diff options
Diffstat (limited to 'src/tools/clippy/src/docs/rc_mutex.txt')
-rw-r--r-- | src/tools/clippy/src/docs/rc_mutex.txt | 26 |
1 files changed, 26 insertions, 0 deletions
diff --git a/src/tools/clippy/src/docs/rc_mutex.txt b/src/tools/clippy/src/docs/rc_mutex.txt new file mode 100644 index 000000000..ed7a1e344 --- /dev/null +++ b/src/tools/clippy/src/docs/rc_mutex.txt @@ -0,0 +1,26 @@ +### What it does +Checks for `Rc<Mutex<T>>`. + +### Why is this bad? +`Rc` is used in single thread and `Mutex` is used in multi thread. +Consider using `Rc<RefCell<T>>` in single thread or `Arc<Mutex<T>>` in multi thread. + +### Known problems +Sometimes combining generic types can lead to the requirement that a +type use Rc in conjunction with Mutex. We must consider those cases false positives, but +alas they are quite hard to rule out. Luckily they are also rare. + +### Example +``` +use std::rc::Rc; +use std::sync::Mutex; +fn foo(interned: Rc<Mutex<i32>>) { ... } +``` + +Better: + +``` +use std::rc::Rc; +use std::cell::RefCell +fn foo(interned: Rc<RefCell<i32>>) { ... } +```
\ No newline at end of file |