diff options
Diffstat (limited to '')
-rw-r--r-- | src/tools/clippy/src/docs/try_err.txt | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/src/tools/clippy/src/docs/try_err.txt b/src/tools/clippy/src/docs/try_err.txt new file mode 100644 index 000000000..e3d4ef3a0 --- /dev/null +++ b/src/tools/clippy/src/docs/try_err.txt @@ -0,0 +1,28 @@ +### What it does +Checks for usages of `Err(x)?`. + +### Why is this bad? +The `?` operator is designed to allow calls that +can fail to be easily chained. For example, `foo()?.bar()` or +`foo(bar()?)`. Because `Err(x)?` can't be used that way (it will +always return), it is more clear to write `return Err(x)`. + +### Example +``` +fn foo(fail: bool) -> Result<i32, String> { + if fail { + Err("failed")?; + } + Ok(0) +} +``` +Could be written: + +``` +fn foo(fail: bool) -> Result<i32, String> { + if fail { + return Err("failed".into()); + } + Ok(0) +} +```
\ No newline at end of file |