diff options
Diffstat (limited to 'src/tools/clippy/tests/ui/for_kv_map.fixed')
-rw-r--r-- | src/tools/clippy/tests/ui/for_kv_map.fixed | 56 |
1 files changed, 56 insertions, 0 deletions
diff --git a/src/tools/clippy/tests/ui/for_kv_map.fixed b/src/tools/clippy/tests/ui/for_kv_map.fixed new file mode 100644 index 000000000..a2112d7b7 --- /dev/null +++ b/src/tools/clippy/tests/ui/for_kv_map.fixed @@ -0,0 +1,56 @@ +#![warn(clippy::for_kv_map)] +#![allow(clippy::used_underscore_binding)] + +use std::collections::*; +use std::rc::Rc; + +fn main() { + let m: HashMap<u64, u64> = HashMap::new(); + for v in m.values() { + //~^ ERROR: you seem to want to iterate on a map's values + //~| NOTE: `-D clippy::for-kv-map` implied by `-D warnings` + let _v = v; + } + + let m: Rc<HashMap<u64, u64>> = Rc::new(HashMap::new()); + for v in (*m).values() { + //~^ ERROR: you seem to want to iterate on a map's values + let _v = v; + // Here the `*` is not actually necessary, but the test tests that we don't + // suggest + // `in *m.values()` as we used to + } + + let mut m: HashMap<u64, u64> = HashMap::new(); + for v in m.values_mut() { + //~^ ERROR: you seem to want to iterate on a map's values + let _v = v; + } + + let m: &mut HashMap<u64, u64> = &mut HashMap::new(); + for v in (*m).values_mut() { + //~^ ERROR: you seem to want to iterate on a map's values + let _v = v; + } + + let m: HashMap<u64, u64> = HashMap::new(); + let rm = &m; + for k in rm.keys() { + //~^ ERROR: you seem to want to iterate on a map's keys + let _k = k; + } + + // The following should not produce warnings. + + let m: HashMap<u64, u64> = HashMap::new(); + // No error, _value is actually used + for (k, _value) in &m { + let _ = _value; + let _k = k; + } + + let m: HashMap<u64, String> = Default::default(); + for (_, v) in m { + let _v = v; + } +} |