diff options
Diffstat (limited to '')
-rw-r--r-- | src/tools/clippy/tests/ui/missing_spin_loop.fixed | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/src/tools/clippy/tests/ui/missing_spin_loop.fixed b/src/tools/clippy/tests/ui/missing_spin_loop.fixed new file mode 100644 index 000000000..aa89e04d2 --- /dev/null +++ b/src/tools/clippy/tests/ui/missing_spin_loop.fixed @@ -0,0 +1,28 @@ +// run-rustfix +#![warn(clippy::missing_spin_loop)] +#![allow(clippy::bool_comparison)] +#![allow(unused_braces)] + +use core::sync::atomic::{AtomicBool, Ordering}; + +fn main() { + let b = AtomicBool::new(true); + // Those should lint + while b.load(Ordering::Acquire) { std::hint::spin_loop() } + + while !b.load(Ordering::SeqCst) { std::hint::spin_loop() } + + while b.load(Ordering::Acquire) == false { std::hint::spin_loop() } + + while { true == b.load(Ordering::Acquire) } { std::hint::spin_loop() } + + while b.compare_exchange(true, false, Ordering::Acquire, Ordering::Relaxed) != Ok(true) { std::hint::spin_loop() } + + while Ok(false) != b.compare_exchange(false, true, Ordering::Acquire, Ordering::Relaxed) { std::hint::spin_loop() } + + // This is OK, as the body is not empty + while b.load(Ordering::Acquire) { + std::hint::spin_loop() + } + // TODO: also match on loop+match or while let +} |