blob: cef5604e01c08b08a2bd2c614bc3dd3e1c63264f (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
|
### What it does
This lint catches reads into a zero-length `Vec`.
Especially in the case of a call to `with_capacity`, this lint warns that read
gets the number of bytes from the `Vec`'s length, not its capacity.
### Why is this bad?
Reading zero bytes is almost certainly not the intended behavior.
### Known problems
In theory, a very unusual read implementation could assign some semantic meaning
to zero-byte reads. But it seems exceptionally unlikely that code intending to do
a zero-byte read would allocate a `Vec` for it.
### Example
```
use std::io;
fn foo<F: io::Read>(mut f: F) {
let mut data = Vec::with_capacity(100);
f.read(&mut data).unwrap();
}
```
Use instead:
```
use std::io;
fn foo<F: io::Read>(mut f: F) {
let mut data = Vec::with_capacity(100);
data.resize(100, 0);
f.read(&mut data).unwrap();
}
```
|
