summaryrefslogtreecommitdiffstats
path: root/src/tools/clippy/src/docs/redundant_slicing.txt
blob: 6798911ed76c08b5da77afdbf12c8c7f809fb5fb (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
### What it does
Checks for redundant slicing expressions which use the full range, and
do not change the type.

### Why is this bad?
It unnecessarily adds complexity to the expression.

### Known problems
If the type being sliced has an implementation of `Index<RangeFull>`
that actually changes anything then it can't be removed. However, this would be surprising
to people reading the code and should have a note with it.

### Example
```
fn get_slice(x: &[u32]) -> &[u32] {
    &x[..]
}
```
Use instead:
```
fn get_slice(x: &[u32]) -> &[u32] {
    x
}
```