blob: a0a90eec681e6dfcb69400b8fa7c9df233d14ab9 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
|
### What it does
Checks for consecutive `if`s with the same function call.
### Why is this bad?
This is probably a copy & paste error.
Despite the fact that function can have side effects and `if` works as
intended, such an approach is implicit and can be considered a "code smell".
### Example
```
if foo() == bar {
…
} else if foo() == bar {
…
}
```
This probably should be:
```
if foo() == bar {
…
} else if foo() == baz {
…
}
```
or if the original code was not a typo and called function mutates a state,
consider move the mutation out of the `if` condition to avoid similarity to
a copy & paste error:
```
let first = foo();
if first == bar {
…
} else {
let second = foo();
if second == bar {
…
}
}
```
|
