blob: bd56aa5b082820168b277d9af2f47916c402c86d (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
|
### What it does
Checks for wildcard imports `use _::*`.
### Why is this bad?
wildcard imports can pollute the namespace. This is especially bad if
you try to import something through a wildcard, that already has been imported by name from
a different source:
```
use crate1::foo; // Imports a function named foo
use crate2::*; // Has a function named foo
foo(); // Calls crate1::foo
```
This can lead to confusing error messages at best and to unexpected behavior at worst.
### Exceptions
Wildcard imports are allowed from modules named `prelude`. Many crates (including the standard library)
provide modules named "prelude" specifically designed for wildcard import.
`use super::*` is allowed in test modules. This is defined as any module with "test" in the name.
These exceptions can be disabled using the `warn-on-all-wildcard-imports` configuration flag.
### Known problems
If macros are imported through the wildcard, this macro is not included
by the suggestion and has to be added by hand.
Applying the suggestion when explicit imports of the things imported with a glob import
exist, may result in `unused_imports` warnings.
### Example
```
use crate1::*;
foo();
```
Use instead:
```
use crate1::foo;
foo();
```
|
