summaryrefslogtreecommitdiffstats
path: root/src/tools/clippy/tests/ui/from_over_into.fixed
blob: 72d635c2ccd65609ada5efc15d5197457ec4b622 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
// run-rustfix

#![feature(type_alias_impl_trait)]
#![warn(clippy::from_over_into)]
#![allow(unused)]

// this should throw an error
struct StringWrapper(String);

impl From<String> for StringWrapper {
    fn from(val: String) -> Self {
        StringWrapper(val)
    }
}

struct SelfType(String);

impl From<String> for SelfType {
    fn from(val: String) -> Self {
        SelfType(String::new())
    }
}

#[derive(Default)]
struct X;

impl X {
    const FOO: &'static str = "a";
}

struct SelfKeywords;

impl From<X> for SelfKeywords {
    fn from(val: X) -> Self {
        let _ = X::default();
        let _ = X::FOO;
        let _: X = val;

        SelfKeywords
    }
}

struct ExplicitPaths(bool);

impl core::convert::From<crate::ExplicitPaths> for bool {
    fn from(mut val: crate::ExplicitPaths) -> Self {
        let in_closure = || val.0;

        val.0 = false;
        val.0
    }
}

// this is fine
struct A(String);

impl From<String> for A {
    fn from(s: String) -> A {
        A(s)
    }
}

#[clippy::msrv = "1.40"]
fn msrv_1_40() {
    struct FromOverInto<T>(Vec<T>);

    impl<T> Into<FromOverInto<T>> for Vec<T> {
        fn into(self) -> FromOverInto<T> {
            FromOverInto(self)
        }
    }
}

#[clippy::msrv = "1.41"]
fn msrv_1_41() {
    struct FromOverInto<T>(Vec<T>);

    impl<T> From<Vec<T>> for FromOverInto<T> {
        fn from(val: Vec<T>) -> Self {
            FromOverInto(val)
        }
    }
}

type Opaque = impl Sized;
struct IntoOpaque;
impl Into<Opaque> for IntoOpaque {
    fn into(self) -> Opaque {}
}

fn main() {}