blob: aeb0a0c1e2e841814d5168ee241db632caae43ef (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
|
#![warn(clippy::inherent_to_string)]
#![deny(clippy::inherent_to_string_shadow_display)]
use std::fmt;
trait FalsePositive {
fn to_string(&self) -> String;
}
struct A;
struct B;
struct C;
struct D;
struct E;
struct F;
struct G;
impl A {
// Should be detected; emit warning
fn to_string(&self) -> String {
"A.to_string()".to_string()
}
// Should not be detected as it does not match the function signature
fn to_str(&self) -> String {
"A.to_str()".to_string()
}
}
// Should not be detected as it is a free function
fn to_string() -> String {
"free to_string()".to_string()
}
impl B {
// Should not be detected, wrong return type
fn to_string(&self) -> i32 {
42
}
}
impl C {
// Should be detected and emit error as C also implements Display
fn to_string(&self) -> String {
"C.to_string()".to_string()
}
}
impl fmt::Display for C {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
write!(f, "impl Display for C")
}
}
impl FalsePositive for D {
// Should not be detected, as it is a trait function
fn to_string(&self) -> String {
"impl FalsePositive for D".to_string()
}
}
impl E {
// Should not be detected, as it is not bound to an instance
fn to_string() -> String {
"E::to_string()".to_string()
}
}
impl F {
// Should not be detected, as it does not match the function signature
fn to_string(&self, _i: i32) -> String {
"F.to_string()".to_string()
}
}
impl G {
// Should not be detected, as it does not match the function signature
fn to_string<const _N: usize>(&self) -> String {
"G.to_string()".to_string()
}
}
fn main() {
let a = A;
a.to_string();
a.to_str();
to_string();
let b = B;
b.to_string();
let c = C;
C.to_string();
let d = D;
d.to_string();
E::to_string();
let f = F;
f.to_string(1);
let g = G;
g.to_string::<1>();
}
|
