summaryrefslogtreecommitdiffstats
path: root/src/tools/clippy/tests/ui/manual_string_new.fixed
blob: a376411bfbc804e3019f409f80c57050ff1fb4f6 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
// run-rustfix

#![warn(clippy::manual_string_new)]

macro_rules! create_strings_from_macro {
    // When inside a macro, nothing should warn to prevent false positives.
    ($some_str:expr) => {
        let _: String = $some_str.into();
        let _ = $some_str.to_string();
    };
}

fn main() {
    // Method calls
    let _ = String::new();
    let _ = "no warning".to_string();

    let _ = String::new();
    let _ = "no warning".to_owned();

    let _: String = String::new();
    let _: String = "no warning".into();

    let _: SomeOtherStruct = "no warning".into();
    let _: SomeOtherStruct = "".into(); // No warning too. We are not converting into String.

    // Calls
    let _ = String::new();
    let _ = String::new();
    let _ = String::from("no warning");
    let _ = SomeOtherStruct::from("no warning");
    let _ = SomeOtherStruct::from(""); // Again: no warning.

    let _ = String::new();
    let _ = String::try_from("no warning").unwrap();
    let _ = String::try_from("no warning").expect("this should not warn");
    let _ = SomeOtherStruct::try_from("no warning").unwrap();
    let _ = SomeOtherStruct::try_from("").unwrap(); // Again: no warning.

    let _: String = String::new();
    let _: String = From::from("no warning");
    let _: SomeOtherStruct = From::from("no warning");
    let _: SomeOtherStruct = From::from(""); // Again: no warning.

    let _: String = String::new();
    let _: String = TryFrom::try_from("no warning").unwrap();
    let _: String = TryFrom::try_from("no warning").expect("this should not warn");
    let _: String = String::new();
    let _: SomeOtherStruct = TryFrom::try_from("no_warning").unwrap();
    let _: SomeOtherStruct = TryFrom::try_from("").unwrap(); // Again: no warning.

    // Macros (never warn)
    create_strings_from_macro!("");
    create_strings_from_macro!("Hey");
}

struct SomeOtherStruct {}

impl From<&str> for SomeOtherStruct {
    fn from(_value: &str) -> Self {
        Self {}
    }
}