1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
|
#![warn(clippy::new_ret_no_self)]
#![allow(dead_code)]
fn main() {}
trait R {
type Item;
}
trait Q {
type Item;
type Item2;
}
struct S;
impl R for S {
type Item = Self;
}
impl S {
// should not trigger the lint
pub fn new() -> impl R<Item = Self> {
S
}
}
struct S2;
impl R for S2 {
type Item = Self;
}
impl S2 {
// should not trigger the lint
pub fn new(_: String) -> impl R<Item = Self> {
S2
}
}
struct S3;
impl R for S3 {
type Item = u32;
}
impl S3 {
// should trigger the lint
pub fn new(_: String) -> impl R<Item = u32> {
S3
}
}
struct S4;
impl Q for S4 {
type Item = u32;
type Item2 = Self;
}
impl S4 {
// should not trigger the lint
pub fn new(_: String) -> impl Q<Item = u32, Item2 = Self> {
S4
}
}
struct T;
impl T {
// should not trigger lint
pub fn new() -> Self {
unimplemented!();
}
}
struct U;
impl U {
// should trigger lint
pub fn new() -> u32 {
unimplemented!();
}
}
struct V;
impl V {
// should trigger lint
pub fn new(_: String) -> u32 {
unimplemented!();
}
}
struct TupleReturnerOk;
impl TupleReturnerOk {
// should not trigger lint
pub fn new() -> (Self, u32) {
unimplemented!();
}
}
struct TupleReturnerOk2;
impl TupleReturnerOk2 {
// should not trigger lint (it doesn't matter which element in the tuple is Self)
pub fn new() -> (u32, Self) {
unimplemented!();
}
}
struct TupleReturnerOk3;
impl TupleReturnerOk3 {
// should not trigger lint (tuple can contain multiple Self)
pub fn new() -> (Self, Self) {
unimplemented!();
}
}
struct TupleReturnerBad;
impl TupleReturnerBad {
// should trigger lint
pub fn new() -> (u32, u32) {
unimplemented!();
}
}
struct MutPointerReturnerOk;
impl MutPointerReturnerOk {
// should not trigger lint
pub fn new() -> *mut Self {
unimplemented!();
}
}
struct ConstPointerReturnerOk2;
impl ConstPointerReturnerOk2 {
// should not trigger lint
pub fn new() -> *const Self {
unimplemented!();
}
}
struct MutPointerReturnerBad;
impl MutPointerReturnerBad {
// should trigger lint
pub fn new() -> *mut V {
unimplemented!();
}
}
struct GenericReturnerOk;
impl GenericReturnerOk {
// should not trigger lint
pub fn new() -> Option<Self> {
unimplemented!();
}
}
struct GenericReturnerBad;
impl GenericReturnerBad {
// should trigger lint
pub fn new() -> Option<u32> {
unimplemented!();
}
}
struct NestedReturnerOk;
impl NestedReturnerOk {
// should not trigger lint
pub fn new() -> (Option<Self>, u32) {
unimplemented!();
}
}
struct NestedReturnerOk2;
impl NestedReturnerOk2 {
// should not trigger lint
pub fn new() -> ((Self, u32), u32) {
unimplemented!();
}
}
struct NestedReturnerOk3;
impl NestedReturnerOk3 {
// should not trigger lint
pub fn new() -> Option<(Self, u32)> {
unimplemented!();
}
}
struct WithLifetime<'a> {
cat: &'a str,
}
impl<'a> WithLifetime<'a> {
// should not trigger the lint, because the lifetimes are different
pub fn new<'b: 'a>(s: &'b str) -> WithLifetime<'b> {
unimplemented!();
}
}
mod issue5435 {
struct V;
pub trait TraitRetSelf {
// should not trigger lint
fn new() -> Self;
}
pub trait TraitRet {
// should trigger lint as we are in trait definition
fn new() -> String;
}
pub struct StructRet;
impl TraitRet for StructRet {
// should not trigger lint as we are in the impl block
fn new() -> String {
unimplemented!();
}
}
pub trait TraitRet2 {
// should trigger lint
fn new(_: String) -> String;
}
trait TupleReturnerOk {
// should not trigger lint
fn new() -> (Self, u32)
where
Self: Sized,
{
unimplemented!();
}
}
trait TupleReturnerOk2 {
// should not trigger lint (it doesn't matter which element in the tuple is Self)
fn new() -> (u32, Self)
where
Self: Sized,
{
unimplemented!();
}
}
trait TupleReturnerOk3 {
// should not trigger lint (tuple can contain multiple Self)
fn new() -> (Self, Self)
where
Self: Sized,
{
unimplemented!();
}
}
trait TupleReturnerBad {
// should trigger lint
fn new() -> (u32, u32) {
unimplemented!();
}
}
trait MutPointerReturnerOk {
// should not trigger lint
fn new() -> *mut Self
where
Self: Sized,
{
unimplemented!();
}
}
trait ConstPointerReturnerOk2 {
// should not trigger lint
fn new() -> *const Self
where
Self: Sized,
{
unimplemented!();
}
}
trait MutPointerReturnerBad {
// should trigger lint
fn new() -> *mut V {
unimplemented!();
}
}
trait GenericReturnerOk {
// should not trigger lint
fn new() -> Option<Self>
where
Self: Sized,
{
unimplemented!();
}
}
trait NestedReturnerOk {
// should not trigger lint
fn new() -> (Option<Self>, u32)
where
Self: Sized,
{
unimplemented!();
}
}
trait NestedReturnerOk2 {
// should not trigger lint
fn new() -> ((Self, u32), u32)
where
Self: Sized,
{
unimplemented!();
}
}
trait NestedReturnerOk3 {
// should not trigger lint
fn new() -> Option<(Self, u32)>
where
Self: Sized,
{
unimplemented!();
}
}
}
// issue #1724
struct RetOtherSelf<T>(T);
struct RetOtherSelfWrapper<T>(T);
impl RetOtherSelf<T> {
fn new(t: T) -> RetOtherSelf<RetOtherSelfWrapper<T>> {
RetOtherSelf(RetOtherSelfWrapper(t))
}
}
|
