blob: 2aa842adc85609690dfbc6f09875fb4b5541f338 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
|
#![warn(clippy::unwrap_in_result)]
struct A;
impl A {
// should not be detected
fn good_divisible_by_3(i_str: String) -> Result<bool, String> {
// checks whether a string represents a number divisible by 3
let i_result = i_str.parse::<i32>();
match i_result {
Err(_e) => Err("Not a number".to_string()),
Ok(i) => {
if i % 3 == 0 {
return Ok(true);
}
Err("Number is not divisible by 3".to_string())
},
}
}
// should be detected
fn bad_divisible_by_3(i_str: String) -> Result<bool, String> {
// checks whether a string represents a number divisible by 3
let i = i_str.parse::<i32>().unwrap();
if i % 3 == 0 {
Ok(true)
} else {
Err("Number is not divisible by 3".to_string())
}
}
fn example_option_expect(i_str: String) -> Option<bool> {
let i = i_str.parse::<i32>().expect("not a number");
if i % 3 == 0 {
return Some(true);
}
None
}
}
fn main() {
A::bad_divisible_by_3("3".to_string());
A::good_divisible_by_3("3".to_string());
}
|
