summaryrefslogtreecommitdiffstats
path: root/ext/recover/dbdata.c
diff options
context:
space:
mode:
Diffstat (limited to 'ext/recover/dbdata.c')
-rw-r--r--ext/recover/dbdata.c24
1 files changed, 19 insertions, 5 deletions
diff --git a/ext/recover/dbdata.c b/ext/recover/dbdata.c
index b6cb26e..ca63710 100644
--- a/ext/recover/dbdata.c
+++ b/ext/recover/dbdata.c
@@ -494,6 +494,15 @@ static void dbdataValue(
}
}
+/* This macro is a copy of the MX_CELL() macro in the SQLite core. Given
+** a page-size, it returns the maximum number of cells that may be present
+** on the page. */
+#define DBDATA_MX_CELL(pgsz) ((pgsz-8)/6)
+
+/* Maximum number of fields that may appear in a single record. This is
+** the "hard-limit", according to comments in sqliteLimit.h. */
+#define DBDATA_MX_FIELD 32676
+
/*
** Move an sqlite_dbdata or sqlite_dbptr cursor to the next entry.
*/
@@ -522,6 +531,9 @@ static int dbdataNext(sqlite3_vtab_cursor *pCursor){
assert( iOff+3+2<=pCsr->nPage );
pCsr->iCell = pTab->bPtr ? -2 : 0;
pCsr->nCell = get_uint16(&pCsr->aPage[iOff+3]);
+ if( pCsr->nCell>DBDATA_MX_CELL(pCsr->nPage) ){
+ pCsr->nCell = DBDATA_MX_CELL(pCsr->nPage);
+ }
}
if( pTab->bPtr ){
@@ -566,19 +578,19 @@ static int dbdataNext(sqlite3_vtab_cursor *pCursor){
if( pCsr->iCell>=pCsr->nCell ){
bNextPage = 1;
}else{
+ int iCellPtr = iOff + 8 + nPointer + pCsr->iCell*2;
- iOff += 8 + nPointer + pCsr->iCell*2;
- if( iOff>pCsr->nPage ){
+ if( iCellPtr>pCsr->nPage ){
bNextPage = 1;
}else{
- iOff = get_uint16(&pCsr->aPage[iOff]);
+ iOff = get_uint16(&pCsr->aPage[iCellPtr]);
}
/* For an interior node cell, skip past the child-page number */
iOff += nPointer;
/* Load the "byte of payload including overflow" field */
- if( bNextPage || iOff>pCsr->nPage ){
+ if( bNextPage || iOff>pCsr->nPage || iOff<=iCellPtr ){
bNextPage = 1;
}else{
iOff += dbdataGetVarintU32(&pCsr->aPage[iOff], &nPayload);
@@ -661,7 +673,9 @@ static int dbdataNext(sqlite3_vtab_cursor *pCursor){
pCsr->iField++;
if( pCsr->iField>0 ){
sqlite3_int64 iType;
- if( pCsr->pHdrPtr>&pCsr->pRec[pCsr->nRec] ){
+ if( pCsr->pHdrPtr>=&pCsr->pRec[pCsr->nRec]
+ || pCsr->iField>=DBDATA_MX_FIELD
+ ){
bNextPage = 1;
}else{
int szField = 0;