1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
|
# Copyright (C) 2017-2022 Open Information Security Foundation
# Copyright (c) 2015-2017 Jason Ish
#
# You can copy, redistribute or modify this Program under the terms of
# the GNU General Public License version 2 as published by the Free
# Software Foundation.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# version 2 along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
# 02110-1301, USA.
from __future__ import print_function
import sys
import re
import os.path
import logging
import argparse
import time
import hashlib
import fnmatch
import subprocess
import shutil
import glob
import io
import tempfile
import signal
import errno
from collections import namedtuple
try:
# Python 3.
from urllib.error import URLError
except ImportError:
# Python 2.7.
from urllib2 import URLError
try:
import yaml
except:
print("error: pyyaml is required")
sys.exit(1)
from suricata.update import (
commands,
config,
configs,
engine,
exceptions,
extract,
loghandler,
net,
notes,
parsers,
rule as rule_mod,
sources,
util,
matchers as matchers_mod
)
from suricata.update.version import version
try:
from suricata.update.revision import revision
except:
revision = None
SourceFile = namedtuple("SourceFile", ["filename", "content"])
if sys.argv[0] == __file__:
sys.path.insert(
0, os.path.abspath(os.path.join(__file__, "..", "..", "..")))
# Initialize logging, use colour if on a tty.
if len(logging.root.handlers) == 0:
logger = logging.getLogger()
loghandler.configure_logging()
logger.setLevel(level=logging.INFO)
else:
logging.basicConfig(
level=logging.INFO,
format="%(asctime)s - <%(levelname)s> - %(message)s")
logger = logging.getLogger()
# If Suricata is not found, default to this version.
DEFAULT_SURICATA_VERSION = "6.0.0"
# The default filename to use for the output rule file. This is a
# single file concatenating all input rule files together.
DEFAULT_OUTPUT_RULE_FILENAME = "suricata.rules"
INDEX_EXPIRATION_TIME = 60 * 60 * 24 * 14
# Rule keywords that come with files
file_kw = ["filemd5", "filesha1", "filesha256", "dataset"]
def strict_error(msg):
logger.error(msg)
if config.args().fail:
sys.exit(1)
class Fetch:
def __init__(self):
self.istty = os.isatty(sys.stdout.fileno())
def check_checksum(self, tmp_filename, url, checksum_url=None):
try:
if not isinstance(checksum_url, str):
checksum_url = url[0] + ".md5"
net_arg=(checksum_url,url[1])
local_checksum = hashlib.md5(
open(tmp_filename, "rb").read()).hexdigest().strip()
remote_checksum_buf = io.BytesIO()
logger.info("Checking %s." % (checksum_url))
net.get(net_arg, remote_checksum_buf)
remote_checksum = remote_checksum_buf.getvalue().decode().strip()
logger.debug("Local checksum=|%s|; remote checksum=|%s|" % (
local_checksum, remote_checksum))
if local_checksum == remote_checksum:
os.utime(tmp_filename, None)
return True
except Exception as err:
logger.warning("Failed to check remote checksum: %s" % err)
return False
def progress_hook(self, content_length, bytes_read):
if config.args().quiet or not self.istty:
return
if not content_length or content_length == 0:
percent = 0
else:
percent = int((bytes_read / float(content_length)) * 100)
buf = " %3d%% - %-30s" % (
percent, "%d/%d" % (bytes_read, content_length))
sys.stdout.write(buf)
sys.stdout.flush()
sys.stdout.write("\b" * 38)
def progress_hook_finish(self):
if config.args().quiet or not self.istty:
return
sys.stdout.write("\n")
sys.stdout.flush()
def url_basename(self, url):
""" Return the base filename of the URL. """
filename = os.path.basename(url).split("?", 1)[0]
return filename
def get_tmp_filename(self, url):
url_hash = hashlib.md5(url.encode("utf-8")).hexdigest()
return os.path.join(
config.get_cache_dir(),
"%s-%s" % (url_hash, self.url_basename(url)))
def fetch(self, url):
net_arg = url
checksum = url[2]
url = url[0]
tmp_filename = self.get_tmp_filename(url)
if config.args().offline:
if config.args().force:
logger.warning("Running offline, skipping download of %s", url)
logger.info("Using latest cached version of rule file: %s", url)
if not os.path.exists(tmp_filename):
logger.error("Can't proceed offline, "
"source {} has not yet been downloaded.".format(url))
sys.exit(1)
return self.extract_files(tmp_filename)
if not config.args().force and os.path.exists(tmp_filename):
if not config.args().now and \
time.time() - os.stat(tmp_filename).st_mtime < (60 * 15):
logger.info(
"Last download less than 15 minutes ago. Not downloading %s.",
url)
return self.extract_files(tmp_filename)
if checksum:
if self.check_checksum(tmp_filename, net_arg, checksum):
logger.info("Remote checksum has not changed. "
"Not fetching.")
return self.extract_files(tmp_filename)
if not os.path.exists(config.get_cache_dir()):
os.makedirs(config.get_cache_dir(), mode=0o770)
logger.info("Fetching %s." % (url))
try:
tmp_fileobj = tempfile.NamedTemporaryFile()
net.get(
net_arg,
tmp_fileobj,
progress_hook=self.progress_hook)
shutil.copyfile(tmp_fileobj.name, tmp_filename)
tmp_fileobj.close()
except URLError as err:
if os.path.exists(tmp_filename):
if config.args().fail:
strict_error("Failed to fetch {}: {}".format(url, err))
else:
logger.error("Failed to fetch {}, will use latest cached version: {}".format(url, err))
return self.extract_files(tmp_filename)
raise err
except IOError as err:
self.progress_hook_finish()
logger.error("Failed to copy file: {}".format(err))
sys.exit(1)
except Exception as err:
raise err
self.progress_hook_finish()
logger.info("Done.")
return self.extract_files(tmp_filename)
def run(self, url=None):
files = {}
if url:
try:
fetched = self.fetch(url)
files.update(fetched)
except URLError as err:
url = url[0] if isinstance(url, tuple) else url
strict_error("Failed to fetch {}: {}".format(url, err))
else:
for url in self.args.url:
files.update(self.fetch(url))
return files
def extract_files(self, filename):
files = extract.try_extract(filename)
if files:
return files
# The file is not an archive, treat it as an individual file.
basename = os.path.basename(filename).split("-", 1)[1]
if not basename.endswith(".rules"):
basename = "{}.rules".format(basename)
files = {}
files[basename] = open(filename, "rb").read()
return files
def load_filters(filename):
filters = []
with open(filename) as fileobj:
for line in fileobj:
line = line.strip()
if not line or line.startswith("#"):
continue
line = line.rsplit(" #")[0].strip()
try:
if line.startswith("metadata-add"):
rule_filter = matchers_mod.AddMetadataFilter.parse(line)
filters.append(rule_filter)
else:
line = re.sub(r'\\\$', '$', line) # needed to escape $ in pp
rule_filter = matchers_mod.ModifyRuleFilter.parse(line)
filters.append(rule_filter)
except Exception as err:
raise exceptions.ApplicationError(
"Failed to parse modify filter: {}".format(line))
return filters
def load_drop_filters(filename):
matchers = load_matchers(filename)
filters = []
for matcher in matchers:
filters.append(matchers_mod.DropRuleFilter(matcher))
return filters
def parse_matchers(fileobj):
matchers = []
for line in fileobj:
line = line.strip()
if not line or line.startswith("#"):
continue
line = line.rsplit(" #")[0]
matcher = matchers_mod.parse_rule_match(line)
if not matcher:
logger.warn("Failed to parse: \"%s\"" % (line))
else:
matchers.append(matcher)
return matchers
def load_matchers(filename):
with open(filename) as fileobj:
return parse_matchers(fileobj)
def load_local(local, files):
"""Load local files into the files dict."""
if os.path.isdir(local):
for dirpath, dirnames, filenames in os.walk(local):
for filename in filenames:
if filename.endswith(".rules"):
path = os.path.join(local, filename)
load_local(path, files)
else:
local_files = glob.glob(local)
if len(local_files) == 0:
local_files.append(local)
for filename in local_files:
filename = os.path.realpath(filename)
logger.info("Loading local file %s" % (filename))
if filename in files:
logger.warn(
"Local file %s overrides existing file of same name." % (
filename))
try:
with open(filename, "rb") as fileobj:
files.append(SourceFile(filename, fileobj.read()))
except Exception as err:
logger.error("Failed to open {}: {}".format(filename, err))
def load_dist_rules(files):
"""Load the rule files provided by the Suricata distribution."""
# In the future hopefully we can just pull in all files from
# /usr/share/suricata/rules, but for now pull in the set of files
# known to have been provided by the Suricata source.
filenames = [
"app-layer-events.rules",
"decoder-events.rules",
"dhcp-events.rules",
"dnp3-events.rules",
"dns-events.rules",
"files.rules",
"http-events.rules",
"ipsec-events.rules",
"kerberos-events.rules",
"modbus-events.rules",
"nfs-events.rules",
"ntp-events.rules",
"smb-events.rules",
"smtp-events.rules",
"stream-events.rules",
"tls-events.rules",
]
dist_rule_path = config.get(config.DIST_RULE_DIRECTORY_KEY)
if not dist_rule_path:
logger.warning("No distribution rule directory found.")
return
if not os.path.exists(dist_rule_path):
logger.warning("Distribution rule directory not found: %s",
dist_rule_path)
return
if os.path.exists(dist_rule_path):
if not os.access(dist_rule_path, os.R_OK):
logger.warning("Distribution rule path not readable: %s",
dist_rule_path)
return
for filename in filenames:
path = os.path.join(dist_rule_path, filename)
if not os.path.exists(path):
continue
if not os.access(path, os.R_OK):
logger.warning("Distribution rule file not readable: %s",
path)
continue
logger.info("Loading distribution rule file %s", path)
try:
with open(path, "rb") as fileobj:
files.append(SourceFile(path, fileobj.read()))
except Exception as err:
logger.error("Failed to open {}: {}".format(path, err))
sys.exit(1)
def load_classification(suriconf, files):
filename = os.path.join("suricata", "classification.config")
dirs = []
classification_dict = {}
if "sysconfdir" in suriconf.build_info:
dirs.append(os.path.join(suriconf.build_info["sysconfdir"], filename))
if "datarootdir" in suriconf.build_info:
dirs.append(os.path.join(suriconf.build_info["datarootdir"], filename))
for path in dirs:
if os.path.exists(path):
logger.debug("Loading {}".format(path))
with open(path) as fp:
for line in fp:
if line.startswith("#") or not line.strip():
continue
config_classification = line.split(":")[1].strip()
key, desc, priority = config_classification.split(",")
if key in classification_dict:
if classification_dict[key][1] >= priority:
continue
classification_dict[key] = [desc, priority, line.strip()]
# Handle files from the sources
for filep in files:
logger.debug("Loading {}".format(filep[0]))
lines = filep[1].decode().split('\n')
for line in lines:
if line.startswith("#") or not line.strip():
continue
config_classification = line.split(":")[1].strip()
key, desc, priority = config_classification.split(",")
if key in classification_dict:
if classification_dict[key][1] >= priority:
if classification_dict[key][1] > priority:
logger.warning("Found classification with same shortname \"{}\","
" keeping the one with higher priority ({})".format(
key, classification_dict[key][1]))
continue
classification_dict[key] = [desc, priority, line.strip()]
return classification_dict
def manage_classification(suriconf, files):
if suriconf is None:
# Can't continue without a valid Suricata configuration
# object.
return
classification_dict = load_classification(suriconf, files)
path = os.path.join(config.get_output_dir(), "classification.config")
try:
logger.info("Writing {}".format(path))
with open(path, "w+") as fp:
fp.writelines("{}\n".format(v[2]) for k, v in classification_dict.items())
except (OSError, IOError) as err:
logger.error(err)
def handle_dataset_files(rule, dep_files):
if not rule.enabled:
return
dataset_load = [el for el in (el.strip() for el in rule.dataset.split(",")) if el.startswith("load")]
if not dataset_load:
# No dataset load found.
return
dataset_filename = dataset_load[0].split(maxsplit=1)[1].strip()
# Get the directory name the rule is from.
prefix = os.path.dirname(rule.group)
# Construct the source filename.
source_filename = os.path.join(prefix, dataset_filename)
# If a source filename starts with a "/", look for it on the filesystem. The archive
# unpackers will take care of removing a leading / so this shouldn't happen for
# downloaded rulesets.
if source_filename.startswith("/"):
if not os.path.exists(source_filename):
logger.warn("Local dataset file '{}' was not found for rule {}, rule will be disabled".format(source_filename, rule.idstr))
rule.enabled = False
return
dataset_contents = open(source_filename, "rb").read()
else:
if not source_filename in dep_files:
logger.warn("Dataset file '{}' was not found for rule {}, rule will be disabled".format(dataset_filename, rule.idstr))
rule.enabled = False
return
dataset_contents = dep_files[source_filename]
source_filename_hash = hashlib.md5(source_filename.encode()).hexdigest()
new_rule = re.sub(r"(dataset.*?load\s+){}".format(dataset_filename), r"\g<1>datasets/{}".format(source_filename_hash), rule.format())
dest_filename = os.path.join(config.get_output_dir(), "datasets", source_filename_hash)
dest_dir = os.path.dirname(dest_filename)
logger.debug("Copying dataset file {} to {}".format(dataset_filename, dest_filename))
try:
os.makedirs(dest_dir, exist_ok=True)
except Exception as err:
logger.error("Failed to create directory {}: {}".format(dest_dir, err))
return
with open(dest_filename, "w") as fp:
fp.write(dataset_contents.decode("utf-8"))
return new_rule
def handle_filehash_files(rule, dep_files, fhash):
if not rule.enabled:
return
filehash_fname = rule.get(fhash)
# Get the directory name the rule is from.
prefix = os.path.dirname(rule.group)
source_filename = os.path.join(prefix, filehash_fname)
dest_filename = source_filename[len(prefix) + len(os.path.sep):]
logger.debug("dest_filename={}".format(dest_filename))
if source_filename not in dep_files:
logger.error("{} file {} was not found".format(fhash, filehash_fname))
else:
logger.debug("Copying %s file %s to output directory" % (fhash, filehash_fname))
filepath = os.path.join(config.get_output_dir(), os.path.dirname(dest_filename))
logger.debug("filepath: %s" % filepath)
try:
os.makedirs(filepath)
except OSError as oserr:
if oserr.errno != errno.EEXIST:
logger.error(oserr)
sys.exit(1)
output_filename = os.path.join(filepath, os.path.basename(filehash_fname))
logger.debug("output fname: %s" % output_filename)
with open(output_filename, "w") as fp:
fp.write(dep_files[source_filename].decode("utf-8"))
def write_merged(filename, rulemap, dep_files):
if not args.quiet:
# List of rule IDs that have been added.
added = []
# List of rule objects that have been removed.
removed = []
# List of rule IDs that have been modified.
modified = []
oldset = {}
if os.path.exists(filename):
for rule in rule_mod.parse_file(filename):
oldset[rule.id] = True
if not rule.id in rulemap:
removed.append(rule)
elif rule.format() != rulemap[rule.id].format():
modified.append(rulemap[rule.id])
for key in rulemap:
if not key in oldset:
added.append(key)
enabled = len([rule for rule in rulemap.values() if rule.enabled])
logger.info("Writing rules to %s: total: %d; enabled: %d; "
"added: %d; removed %d; modified: %d" % (
filename,
len(rulemap),
enabled,
len(added),
len(removed),
len(modified)))
tmp_filename = ".".join([filename, "tmp"])
with io.open(tmp_filename, encoding="utf-8", mode="w") as fileobj:
for sid in rulemap:
rule = rulemap[sid]
reformatted = None
for kw in file_kw:
if kw in rule:
if "dataset" == kw:
reformatted = handle_dataset_files(rule, dep_files)
else:
handle_filehash_files(rule, dep_files, kw)
if reformatted:
print(reformatted, file=fileobj)
else:
print(rule.format(), file=fileobj)
os.rename(tmp_filename, filename)
def write_to_directory(directory, files, rulemap, dep_files):
# List of rule IDs that have been added.
added = []
# List of rule objects that have been removed.
removed = []
# List of rule IDs that have been modified.
modified = []
oldset = {}
if not args.quiet:
for file in files:
outpath = os.path.join(
directory, os.path.basename(file.filename))
if os.path.exists(outpath):
for rule in rule_mod.parse_file(outpath):
oldset[rule.id] = True
if not rule.id in rulemap:
removed.append(rule)
elif rule.format() != rulemap[rule.id].format():
modified.append(rule.id)
for key in rulemap:
if not key in oldset:
added.append(key)
enabled = len([rule for rule in rulemap.values() if rule.enabled])
logger.info("Writing rule files to directory %s: total: %d; "
"enabled: %d; added: %d; removed %d; modified: %d" % (
directory,
len(rulemap),
enabled,
len(added),
len(removed),
len(modified)))
for file in sorted(files):
outpath = os.path.join(
directory, os.path.basename(file.filename))
logger.debug("Writing %s." % outpath)
if not file.filename.endswith(".rules"):
open(outpath, "wb").write(file.content)
else:
content = []
for line in io.StringIO(file.content.decode("utf-8")):
rule = rule_mod.parse(line)
if not rule or rule.id not in rulemap:
content.append(line.strip())
else:
reformatted = None
for kw in file_kw:
if kw in rule:
if "dataset" == kw:
reformatted = handle_dataset_files(rulemap[rule.id], dep_files)
else:
handle_filehash_files(rulemap[rule.id], dep_files, kw)
if reformatted:
content.append(reformatted)
else:
content.append(rulemap[rule.id].format())
tmp_filename = ".".join([outpath, "tmp"])
io.open(tmp_filename, encoding="utf-8", mode="w").write(
u"\n".join(content))
os.rename(tmp_filename, outpath)
def write_yaml_fragment(filename, files):
logger.info(
"Writing YAML configuration fragment: %s" % (filename))
with open(filename, "w") as fileobj:
print("%YAML 1.1", file=fileobj)
print("---", file=fileobj)
print("rule-files:", file=fileobj)
for fn in sorted(files):
if fn.endswith(".rules"):
print(" - %s" % os.path.basename(fn), file=fileobj)
def write_sid_msg_map(filename, rulemap, version=1):
logger.info("Writing %s." % (filename))
with io.open(filename, encoding="utf-8", mode="w") as fileobj:
for key in rulemap:
rule = rulemap[key]
if version == 2:
formatted = rule_mod.format_sidmsgmap_v2(rule)
if formatted:
print(formatted, file=fileobj)
else:
formatted = rule_mod.format_sidmsgmap(rule)
if formatted:
print(formatted, file=fileobj)
def build_rule_map(rules):
"""Turn a list of rules into a mapping of rules.
In case of gid:sid conflict, the rule with the higher revision
number will be used.
"""
rulemap = {}
for rule in rules:
if rule.id not in rulemap:
rulemap[rule.id] = rule
else:
if rule["rev"] == rulemap[rule.id]["rev"]:
logger.warning(
"Found duplicate rule SID {} with same revision, "
"keeping the first rule seen.".format(rule.sid))
if rule["rev"] > rulemap[rule.id]["rev"]:
logger.warning(
"Found duplicate rule SID {}, "
"keeping the rule with greater revision.".format(rule.sid))
rulemap[rule.id] = rule
return rulemap
def dump_sample_configs():
for filename in configs.filenames:
if os.path.exists(filename):
logger.info("File already exists, not dumping %s." % (filename))
else:
logger.info("Creating %s." % (filename))
shutil.copy(os.path.join(configs.directory, filename), filename)
def resolve_flowbits(rulemap, disabled_rules):
flowbit_resolver = rule_mod.FlowbitResolver()
flowbit_enabled = set()
pass_ = 1
while True:
logger.debug("Checking flowbits for pass %d of rules.", pass_)
flowbits = flowbit_resolver.get_required_flowbits(rulemap)
logger.debug("Found %d required flowbits.", len(flowbits))
required_rules = flowbit_resolver.get_required_rules(rulemap, flowbits)
logger.debug(
"Found %d rules to enable for flowbit requirements (pass %d)",
len(required_rules), pass_)
if not required_rules:
logger.debug("All required rules enabled.")
break
for rule in required_rules:
if not rule.enabled and rule in disabled_rules:
logger.debug(
"Enabling previously disabled rule for flowbits: %s" % (
rule.brief()))
rule.enabled = True
rule.noalert = True
flowbit_enabled.add(rule)
pass_ = pass_ + 1
logger.info("Enabled %d rules for flowbit dependencies." % (
len(flowbit_enabled)))
class ThresholdProcessor:
patterns = [
re.compile(r"\s+(re:\"(.*)\")"),
re.compile(r"\s+(re:(.*?)),.*"),
re.compile(r"\s+(re:(.*))"),
]
def extract_regex(self, buf):
for pattern in self.patterns:
m = pattern.search(buf)
if m:
return m.group(2)
def extract_pattern(self, buf):
regex = self.extract_regex(buf)
if regex:
return re.compile(regex, re.I)
def replace(self, threshold, rule):
for pattern in self.patterns:
m = pattern.search(threshold)
if m:
return threshold.replace(
m.group(1), "gen_id %d, sig_id %d" % (rule.gid, rule.sid))
return threshold
def process(self, filein, fileout, rulemap):
count = 0
for line in filein:
line = line.rstrip()
if not line or line.startswith("#"):
print(line, file=fileout)
continue
pattern = self.extract_pattern(line)
if not pattern:
print(line, file=fileout)
else:
for rule in rulemap.values():
if rule.enabled:
if pattern.search(rule.format()):
count += 1
print("# %s" % (rule.brief()), file=fileout)
print(self.replace(line, rule), file=fileout)
print("", file=fileout)
logger.info("Generated %d thresholds to %s." % (count, fileout.name))
class FileTracker:
"""Used to check if files are modified.
Usage: Add files with add(filename) prior to modification. Test
with any_modified() which will return True if any of the checksums
have been modified.
"""
def __init__(self):
self.hashes = {}
def add(self, filename):
checksum = self.md5(filename)
if not checksum:
logger.debug("Recording new file %s" % (filename))
else:
logger.debug("Recording existing file %s with hash '%s'.",
filename, checksum)
self.hashes[filename] = checksum
def md5(self, filename):
if not os.path.exists(filename):
return ""
else:
return hashlib.md5(open(filename, "rb").read()).hexdigest()
def any_modified(self):
for filename in self.hashes:
if self.md5(filename) != self.hashes[filename]:
return True
return False
def ignore_file(ignore_files, filename):
if not ignore_files:
return False
for pattern in ignore_files:
if fnmatch.fnmatch(os.path.basename(filename), pattern):
return True
return False
def check_vars(suriconf, rulemap):
"""Check that all vars referenced by a rule exist. If a var is not
found, disable the rule.
"""
if suriconf is None:
# Can't continue without a valid Suricata configuration
# object.
return
for rule_id in rulemap:
rule = rulemap[rule_id]
disable = False
for var in rule_mod.parse_var_names(rule["source_addr"]):
if not suriconf.has_key("vars.address-groups.%s" % (var)):
logger.warning(
"Rule has unknown source address var and will be disabled: %s: %s" % (
var, rule.brief()))
notes.address_group_vars.add(var)
disable = True
for var in rule_mod.parse_var_names(rule["dest_addr"]):
if not suriconf.has_key("vars.address-groups.%s" % (var)):
logger.warning(
"Rule has unknown dest address var and will be disabled: %s: %s" % (
var, rule.brief()))
notes.address_group_vars.add(var)
disable = True
for var in rule_mod.parse_var_names(rule["source_port"]):
if not suriconf.has_key("vars.port-groups.%s" % (var)):
logger.warning(
"Rule has unknown source port var and will be disabled: %s: %s" % (
var, rule.brief()))
notes.port_group_vars.add(var)
disable = True
for var in rule_mod.parse_var_names(rule["dest_port"]):
if not suriconf.has_key("vars.port-groups.%s" % (var)):
logger.warning(
"Rule has unknown dest port var and will be disabled: %s: %s" % (
var, rule.brief()))
notes.port_group_vars.add(var)
disable = True
if disable:
rule.enabled = False
def test_suricata(suricata_path):
if not suricata_path:
logger.info("No suricata application binary found, skipping test.")
return True
if config.get("no-test"):
logger.info("Skipping test, disabled by configuration.")
return True
if config.get("test-command"):
test_command = config.get("test-command")
logger.info("Testing Suricata configuration with: %s" % (
test_command))
env = {
"SURICATA_PATH": suricata_path,
"OUTPUT_DIR": config.get_output_dir(),
}
if not config.get("no-merge"):
env["OUTPUT_FILENAME"] = os.path.join(
config.get_output_dir(), DEFAULT_OUTPUT_RULE_FILENAME)
rc = subprocess.Popen(test_command, shell=True, env=env).wait()
if rc != 0:
return False
else:
logger.info("Testing with suricata -T.")
suricata_conf = config.get("suricata-conf")
if not config.get("no-merge"):
if not engine.test_configuration(
suricata_path, suricata_conf,
os.path.join(
config.get_output_dir(),
DEFAULT_OUTPUT_RULE_FILENAME)):
return False
else:
if not engine.test_configuration(suricata_path, suricata_conf):
return False
return True
def copytree(src, dst):
"""A shutil.copytree like function that will copy the files from one
tree to another even if the path exists.
"""
for dirpath, dirnames, filenames in os.walk(src):
for filename in filenames:
src_path = os.path.join(dirpath, filename)
dst_path = os.path.join(dst, src_path[len(src) + 1:])
if not os.path.exists(os.path.dirname(dst_path)):
os.makedirs(os.path.dirname(dst_path), mode=0o770)
shutil.copyfile(src_path, dst_path)
# Also attempt to copy the stat bits, but this may fail
# if the owner of the file is not the same as the user
# running the program.
try:
shutil.copystat(src_path, dst_path)
except OSError as err:
logger.debug(
"Failed to copy stat info from %s to %s", src_path,
dst_path)
def load_sources(suricata_version):
urls = []
http_header = None
checksum = True
# Add any URLs added with the --url command line parameter.
if config.args().url:
for url in config.args().url:
urls.append((url, http_header, checksum))
# Get the new style sources.
enabled_sources = sources.get_enabled_sources()
# Convert the Suricata version to a version string.
version_string = "%d.%d.%d" % (
suricata_version.major, suricata_version.minor,
suricata_version.patch)
# Construct the URL replacement parameters that are internal to
# suricata-update.
internal_params = {"__version__": version_string}
# If we have new sources, we also need to load the index.
if enabled_sources:
index_filename = sources.get_index_filename()
if not os.path.exists(index_filename):
logger.warning("No index exists, will use bundled index.")
logger.warning("Please run suricata-update update-sources.")
if os.path.exists(index_filename) and time.time() - \
os.stat(index_filename).st_mtime > INDEX_EXPIRATION_TIME:
logger.warning(
"Source index is older than 2 weeks. "
"Please update with suricata-update update-sources.")
index = sources.Index(index_filename)
for (name, source) in enabled_sources.items():
params = source["params"] if "params" in source else {}
params.update(internal_params)
if "url" in source:
# No need to go off to the index.
http_header = source.get("http-header")
checksum = source.get("checksum")
url = (source["url"] % params, http_header, checksum)
logger.debug("Resolved source %s to URL %s.", name, url[0])
else:
if not index:
raise exceptions.ApplicationError(
"Source index is required for source %s; "
"run suricata-update update-sources" % (source["source"]))
source_config = index.get_source_by_name(name)
if source_config is None:
logger.warn("Source no longer exists in index and will not be fetched: {}".format(name))
continue
try:
checksum = source_config["checksum"]
except:
checksum = True
url = (index.resolve_url(name, params), http_header,
checksum)
if "deprecated" in source_config:
logger.warn("Source has been deprecated: %s: %s" % (
name, source_config["deprecated"]))
if "obsolete" in source_config:
logger.warn("Source is obsolete and will not be fetched: %s: %s" % (
name, source_config["obsolete"]))
continue
logger.debug("Resolved source %s to URL %s.", name, url[0])
urls.append(url)
if config.get("sources"):
for url in config.get("sources"):
if not isinstance(url, str):
raise exceptions.InvalidConfigurationError(
"Invalid datatype for source URL: %s" % (str(url)))
url = (url % internal_params, http_header, checksum)
logger.debug("Adding source %s.", url)
urls.append(url)
# If --etopen is on the command line, make sure its added. Or if
# there are no URLs, default to ET/Open.
if config.get("etopen") or not urls:
if not config.args().offline and not urls:
logger.info("No sources configured, will use Emerging Threats Open")
urls.append((sources.get_etopen_url(internal_params), http_header,
checksum))
# Converting the URLs to a set removed dupes.
urls = set(urls)
# Now download each URL.
files = []
for url in urls:
# To de-duplicate filenames, add a prefix that is a hash of the URL.
prefix = hashlib.md5(url[0].encode()).hexdigest()
source_files = Fetch().run(url)
for key in source_files:
content = source_files[key]
key = os.path.join(prefix, key)
files.append(SourceFile(key, content))
# Now load local rules.
if config.get("local") is not None:
for local in config.get("local"):
load_local(local, files)
return files
def copytree_ignore_backup(src, names):
""" Returns files to ignore when doing a backup of the rules. """
return [".cache"]
def check_output_directory(output_dir):
""" Check that the output directory exists, creating it if it doesn't. """
if not os.path.exists(output_dir):
logger.info("Creating directory %s." % (output_dir))
try:
os.makedirs(output_dir, mode=0o770)
except Exception as err:
raise exceptions.ApplicationError(
"Failed to create directory %s: %s" % (
output_dir, err))
# Check and disable ja3 rules if needed.
#
# Note: This is a bit of a quick fixup job for 5.0, but we should look
# at making feature handling more generic.
def disable_ja3(suriconf, rulemap, disabled_rules):
if suriconf and suriconf.build_info:
enabled = False
reason = None
logged = False
if "HAVE_NSS" not in suriconf.build_info["features"]:
reason = "Disabling ja3 rules as Suricata is built without libnss."
else:
# Check if disabled. Must be explicitly disabled,
# otherwise we'll keep ja3 rules enabled.
val = suriconf.get("app-layer.protocols.tls.ja3-fingerprints")
# Prior to Suricata 5, leaving ja3-fingerprints undefined
# in the configuration disabled the feature. With 5.0,
# having it undefined will enable it as needed.
if not val:
if suriconf.build_info["version"].major < 5:
val = "no"
else:
val = "auto"
if val and val.lower() not in ["1", "yes", "true", "auto"]:
reason = "Disabling ja3 rules as ja3 fingerprints are not enabled."
else:
enabled = True
count = 0
if not enabled:
for key, rule in rulemap.items():
if "ja3" in rule["features"]:
if not logged:
logger.warn(reason)
logged = True
rule.enabled = False
disabled_rules.append(rule)
count += 1
if count:
logger.info("%d ja3_hash rules disabled." % (count))
def _main():
global args
args = parsers.parse_arg()
# Go verbose or quiet sooner than later.
if args.verbose:
logger.setLevel(logging.DEBUG)
if args.quiet:
logger.setLevel(logging.WARNING)
logger.debug("This is suricata-update version %s (rev: %s); Python: %s" % (
version, revision, sys.version.replace("\n", "- ")))
config.init(args)
# Error out if any reserved/unimplemented arguments were set.
unimplemented_args = [
"disable",
"enable",
"modify",
"drop",
]
for arg in unimplemented_args:
if hasattr(args, arg) and getattr(args, arg):
logger.error("--{} not implemented".format(arg))
return 1
suricata_path = config.get("suricata")
# Now parse the Suricata version. If provided on the command line,
# use that, otherwise attempt to get it from Suricata.
if args.suricata_version:
# The Suricata version was passed on the command line, parse it.
suricata_version = engine.parse_version(args.suricata_version)
if not suricata_version:
logger.error("Failed to parse provided Suricata version: {}".format(
args.suricata_version))
return 1
logger.info("Forcing Suricata version to %s." % (suricata_version.full))
elif suricata_path:
suricata_version = engine.get_version(suricata_path)
if suricata_version:
logger.info("Found Suricata version %s at %s." % (
str(suricata_version.full), suricata_path))
else:
logger.error("Failed to get Suricata version.")
return 1
else:
logger.info(
"Using default Suricata version of %s", DEFAULT_SURICATA_VERSION)
suricata_version = engine.parse_version(DEFAULT_SURICATA_VERSION)
# Provide the Suricata version to the net module to add to the
# User-Agent.
net.set_user_agent_suricata_version(suricata_version.full)
if args.subcommand:
if args.subcommand == "check-versions" and hasattr(args, "func"):
return args.func(suricata_version)
elif hasattr(args, "func"):
return args.func()
elif args.subcommand != "update":
logger.error("Unknown command: {}".format(args.subcommand))
return 1
if args.dump_sample_configs:
return dump_sample_configs()
# If --no-ignore was provided, clear any ignores provided in the
# config.
if args.no_ignore:
config.set(config.IGNORE_KEY, [])
file_tracker = FileTracker()
disable_matchers = []
enable_matchers = []
modify_filters = []
drop_filters = []
# Load user provided disable filters.
disable_conf_filename = config.get("disable-conf")
if disable_conf_filename:
if os.path.exists(disable_conf_filename):
logger.info("Loading %s.", disable_conf_filename)
disable_matchers += load_matchers(disable_conf_filename)
else:
logger.warn("disable-conf file does not exist: {}".format(disable_conf_filename))
# Load user provided enable filters.
enable_conf_filename = config.get("enable-conf")
if enable_conf_filename:
if os.path.exists(enable_conf_filename):
logger.info("Loading %s.", enable_conf_filename)
enable_matchers += load_matchers(enable_conf_filename)
else:
logger.warn("enable-conf file does not exist: {}".format(enable_conf_filename))
# Load user provided modify filters.
modify_conf_filename = config.get("modify-conf")
if modify_conf_filename:
if os.path.exists(modify_conf_filename):
logger.info("Loading %s.", modify_conf_filename)
modify_filters += load_filters(modify_conf_filename)
else:
logger.warn("modify-conf file does not exist: {}".format(modify_conf_filename))
# Load user provided drop filters.
drop_conf_filename = config.get("drop-conf")
if drop_conf_filename:
if os.path.exists(drop_conf_filename):
logger.info("Loading %s.", drop_conf_filename)
drop_filters += load_drop_filters(drop_conf_filename)
else:
logger.warn("drop-conf file does not exist: {}".format(drop_conf_filename))
# Load the Suricata configuration if we can.
suriconf = None
if config.get("suricata-conf") and \
os.path.exists(config.get("suricata-conf")) and \
suricata_path and os.path.exists(suricata_path):
logger.info("Loading %s",config.get("suricata-conf"))
try:
suriconf = engine.Configuration.load(
config.get("suricata-conf"), suricata_path=suricata_path)
except subprocess.CalledProcessError:
return 1
# Disable rule that are for app-layers that are not enabled.
if suriconf:
for key in suriconf.keys():
m = re.match(r"app-layer\.protocols\.([^\.]+)\.enabled", key)
if m:
proto = m.group(1)
if not suriconf.is_true(key, ["detection-only"]):
logger.info("Disabling rules for protocol %s", proto)
disable_matchers.append(matchers_mod.ProtoRuleMatcher(proto))
elif proto == "smb" and suriconf.build_info:
# Special case for SMB rules. For versions less
# than 5, disable smb rules if Rust is not
# available.
if suriconf.build_info["version"].major < 5:
if not "RUST" in suriconf.build_info["features"]:
logger.info("Disabling rules for protocol {}".format(proto))
disable_matchers.append(matchers_mod.ProtoRuleMatcher(proto))
# Check that the cache directory exists and is writable.
if not os.path.exists(config.get_cache_dir()):
try:
os.makedirs(config.get_cache_dir(), mode=0o770)
except Exception as err:
logger.warning(
"Cache directory does not exist and could not be created. "
"/var/tmp will be used instead.")
config.set_cache_dir("/var/tmp")
files = load_sources(suricata_version)
load_dist_rules(files)
rules = []
classification_files = []
dep_files = {}
for entry in sorted(files, key = lambda e: e.filename):
if "classification.config" in entry.filename:
classification_files.append((entry.filename, entry.content))
continue
if not entry.filename.endswith(".rules"):
dep_files.update({entry.filename: entry.content})
continue
if ignore_file(config.get("ignore"), entry.filename):
logger.info("Ignoring file {}".format(entry.filename))
continue
logger.debug("Parsing {}".format(entry.filename))
rules += rule_mod.parse_fileobj(io.BytesIO(entry.content), entry.filename)
rulemap = build_rule_map(rules)
logger.info("Loaded %d rules." % (len(rules)))
# Counts of user enabled and modified rules.
enable_count = 0
modify_count = 0
drop_count = 0
# List of rules disabled by user. Used for counting, and to log
# rules that are re-enabled to meet flowbit requirements.
disabled_rules = []
for key, rule in rulemap.items():
# To avoid duplicate counts when a rule has more than one modification
# to it, we track the actions here then update the counts at the end.
enabled = False
modified = False
dropped = False
for matcher in disable_matchers:
if rule.enabled and matcher.match(rule):
logger.debug("Disabling: %s" % (rule.brief()))
rule.enabled = False
disabled_rules.append(rule)
for matcher in enable_matchers:
if not rule.enabled and matcher.match(rule):
logger.debug("Enabling: %s" % (rule.brief()))
rule.enabled = True
enabled = True
for fltr in drop_filters:
if fltr.match(rule):
rule = fltr.run(rule)
dropped = True
for fltr in modify_filters:
if fltr.match(rule):
rule = fltr.run(rule)
modified = True
if enabled:
enable_count += 1
if modified:
modify_count += 1
if dropped:
drop_count += 1
rulemap[key] = rule
# Check if we should disable ja3 rules.
try:
disable_ja3(suriconf, rulemap, disabled_rules)
except Exception as err:
logger.error("Failed to dynamically disable ja3 rules: {}".format(err))
# Check rule vars, disabling rules that use unknown vars.
check_vars(suriconf, rulemap)
logger.info("Disabled %d rules." % (len(disabled_rules)))
logger.info("Enabled %d rules." % (enable_count))
logger.info("Modified %d rules." % (modify_count))
logger.info("Dropped %d rules." % (drop_count))
# Fixup flowbits.
resolve_flowbits(rulemap, disabled_rules)
# Check that output directory exists, creating it if needed.
check_output_directory(config.get_output_dir())
# Check that output directory is writable.
if not os.access(config.get_output_dir(), os.W_OK):
logger.error(
"Output directory is not writable: {}".format(config.get_output_dir()))
return 1
# Backup the output directory.
logger.info("Backing up current rules.")
backup_directory = util.mktempdir()
shutil.copytree(config.get_output_dir(), os.path.join(
backup_directory, "backup"), ignore=copytree_ignore_backup)
if not args.no_merge:
# The default, write out a merged file.
output_filename = os.path.join(
config.get_output_dir(), DEFAULT_OUTPUT_RULE_FILENAME)
file_tracker.add(output_filename)
write_merged(os.path.join(output_filename), rulemap, dep_files)
else:
for file in files:
file_tracker.add(
os.path.join(
config.get_output_dir(), os.path.basename(file.filename)))
write_to_directory(config.get_output_dir(), files, rulemap, dep_files)
manage_classification(suriconf, classification_files)
if args.yaml_fragment:
file_tracker.add(args.yaml_fragment)
write_yaml_fragment(args.yaml_fragment, files)
if args.sid_msg_map:
write_sid_msg_map(args.sid_msg_map, rulemap, version=1)
if args.sid_msg_map_2:
write_sid_msg_map(args.sid_msg_map_2, rulemap, version=2)
if args.threshold_in and args.threshold_out:
file_tracker.add(args.threshold_out)
threshold_processor = ThresholdProcessor()
threshold_processor.process(
open(args.threshold_in), open(args.threshold_out, "w"), rulemap)
if not args.force and not file_tracker.any_modified():
logger.info("No changes detected, exiting.")
notes.dump_notes()
return 0
# Set these containers to None to fee the memory before testing Suricata which
# may consume a lot of memory by itself. Ideally we should refactor this large
# function into multiple methods so these go out of scope and get removed
# automatically.
rulemap = None
rules = None
files = None
if not test_suricata(suricata_path):
logger.error("Suricata test failed, aborting.")
logger.error("Restoring previous rules.")
copytree(
os.path.join(backup_directory, "backup"), config.get_output_dir())
return 1
if not config.args().no_reload and config.get("reload-command"):
logger.info("Running %s." % (config.get("reload-command")))
rc = subprocess.Popen(config.get("reload-command"), shell=True).wait()
if rc != 0:
logger.error("Reload command exited with error: {}".format(rc))
logger.info("Done.")
notes.dump_notes()
return 0
def signal_handler(signal, frame):
print('Program interrupted. Aborting...')
sys.exit(1)
def main():
signal.signal(signal.SIGINT, signal_handler)
try:
sys.exit(_main())
except exceptions.ApplicationError as err:
logger.error(err)
sys.exit(1)
if __name__ == "__main__":
main()
|