1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
|
/* Copyright (C) 2020 Open Information Security Foundation
*
* You can copy, redistribute or modify this Program under the terms of
* the GNU General Public License version 2 as published by the Free
* Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* version 2 along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
* 02110-1301, USA.
*/
/**
* \file
*
* \author Sascha Steinbiss <sascha@steinbiss.name>
*/
#include "suricata-common.h"
#include "conf.h"
#include "detect.h"
#include "detect-parse.h"
#include "detect-engine.h"
#include "detect-engine-content-inspection.h"
#include "detect-mqtt-connect-flags.h"
#include "util-unittest.h"
#include "rust.h"
#define PARSE_REGEX "(?: *,?!?(?:username|password|will|will_retain|clean_session))+"
static DetectParseRegex parse_regex;
static int mqtt_connect_flags_id = 0;
static int DetectMQTTConnectFlagsMatch(DetectEngineThreadCtx *det_ctx,
Flow *f, uint8_t flags, void *state,
void *txv, const Signature *s,
const SigMatchCtx *ctx);
static int DetectMQTTConnectFlagsSetup (DetectEngineCtx *, Signature *, const char *);
void MQTTConnectFlagsRegisterTests(void);
void DetectMQTTConnectFlagsFree(DetectEngineCtx *de_ctx, void *);
typedef struct DetectMQTTConnectFlagsData_ {
MQTTFlagState username,
password,
will,
will_retain,
clean_session;
} DetectMQTTConnectFlagsData;
/**
* \brief Registration function for mqtt.connect.flags: keyword
*/
void DetectMQTTConnectFlagsRegister (void)
{
sigmatch_table[DETECT_AL_MQTT_CONNECT_FLAGS].name = "mqtt.connect.flags";
sigmatch_table[DETECT_AL_MQTT_CONNECT_FLAGS].desc = "match MQTT CONNECT variable header flags";
sigmatch_table[DETECT_AL_MQTT_CONNECT_FLAGS].url = "/rules/mqtt-keywords.html#mqtt-connect-flags";
sigmatch_table[DETECT_AL_MQTT_CONNECT_FLAGS].AppLayerTxMatch = DetectMQTTConnectFlagsMatch;
sigmatch_table[DETECT_AL_MQTT_CONNECT_FLAGS].Setup = DetectMQTTConnectFlagsSetup;
sigmatch_table[DETECT_AL_MQTT_CONNECT_FLAGS].Free = DetectMQTTConnectFlagsFree;
#ifdef UNITTESTS
sigmatch_table[DETECT_AL_MQTT_CONNECT_FLAGS].RegisterTests = MQTTConnectFlagsRegisterTests;
#endif
DetectSetupParseRegexes(PARSE_REGEX, &parse_regex);
DetectAppLayerInspectEngineRegister2("mqtt.connect.flags", ALPROTO_MQTT, SIG_FLAG_TOSERVER, 1,
DetectEngineInspectGenericList, NULL);
mqtt_connect_flags_id = DetectBufferTypeGetByName("mqtt.connect.flags");
}
/**
* \internal
* \brief Function to match variable header flags of an MQTT CONNECT Tx
*
* \param det_ctx Pointer to the pattern matcher thread.
* \param f Pointer to the current flow.
* \param flags Flags.
* \param state App layer state.
* \param txv Pointer to the transaction.
* \param s Pointer to the Signature.
* \param ctx Pointer to the sigmatch that we will cast into DetectMQTTConnectFlagsData.
*
* \retval 0 no match.
* \retval 1 match.
*/
static int DetectMQTTConnectFlagsMatch(DetectEngineThreadCtx *det_ctx,
Flow *f, uint8_t flags, void *state,
void *txv, const Signature *s,
const SigMatchCtx *ctx)
{
const DetectMQTTConnectFlagsData *de = (const DetectMQTTConnectFlagsData *)ctx;
if (!de)
return 0;
return rs_mqtt_tx_has_connect_flags(txv, de->username, de->password, de->will,
de->will_retain, de->clean_session);
}
/**
* \internal
* \brief This function is used to parse options passed via mqtt.connect.flags: keyword
*
* \param rawstr Pointer to the user provided options
*
* \retval de pointer to DetectMQTTConnectFlagsData on success
* \retval NULL on failure
*/
static DetectMQTTConnectFlagsData *DetectMQTTConnectFlagsParse(const char *rawstr)
{
char copy[strlen(rawstr) + 1];
DetectMQTTConnectFlagsData *de = SCCalloc(1, sizeof(DetectMQTTConnectFlagsData));
if (unlikely(de == NULL))
return NULL;
pcre2_match_data *match = NULL;
int ret = DetectParsePcreExec(&parse_regex, &match, rawstr, 0, 0);
if (ret < 1) {
SCLogError("invalid flag definition: %s", rawstr);
goto error;
}
de->username = de->password = de->will = MQTT_DONT_CARE;
de->will_retain = de->clean_session = MQTT_DONT_CARE;
strlcpy(copy, rawstr, sizeof(copy));
char *xsaveptr = NULL;
char *flagv = strtok_r(copy, ",", &xsaveptr);
while (flagv != NULL) {
while (*flagv != '\0' && isblank(*flagv)) {
flagv++;
}
if (strlen(flagv) < 2) {
SCLogError("malformed flag value: %s", flagv);
goto error;
} else {
int offset = 0;
MQTTFlagState fs_to_set = MQTT_MUST_BE_SET;
if (flagv[0] == '!') {
/* negated flag */
offset = 1; /* skip negation operator during comparison */
fs_to_set = MQTT_CANT_BE_SET;
}
if (strcmp(flagv+offset, "username") == 0) {
if (de->username != MQTT_DONT_CARE) {
SCLogError("duplicate flag definition: %s", flagv);
goto error;
}
de->username = fs_to_set;
} else if (strcmp(flagv+offset, "password") == 0) {
if (de->password != MQTT_DONT_CARE) {
SCLogError("duplicate flag definition: %s", flagv);
goto error;
}
de->password = fs_to_set;
} else if (strcmp(flagv+offset, "will") == 0) {
if (de->will != MQTT_DONT_CARE) {
SCLogError("duplicate flag definition: %s", flagv);
goto error;
}
de->will = fs_to_set;
} else if (strcmp(flagv+offset, "will_retain") == 0) {
if (de->will_retain != MQTT_DONT_CARE) {
SCLogError("duplicate flag definition: %s", flagv);
goto error;
}
de->will_retain = fs_to_set;
} else if (strcmp(flagv+offset, "clean_session") == 0) {
if (de->clean_session != MQTT_DONT_CARE) {
SCLogError("duplicate flag definition: %s", flagv);
goto error;
}
de->clean_session = fs_to_set;
} else {
SCLogError("invalid flag definition: %s", flagv);
goto error;
}
}
flagv = strtok_r(NULL, ",", &xsaveptr);
}
pcre2_match_data_free(match);
return de;
error:
if (match) {
pcre2_match_data_free(match);
}
if (de)
SCFree(de);
return NULL;
}
/**
* \internal
* \brief this function is used to add the parsed type query into the current signature
*
* \param de_ctx pointer to the Detection Engine Context
* \param s pointer to the Current Signature
* \param rawstr pointer to the user provided options
*
* \retval 0 on Success
* \retval -1 on Failure
*/
static int DetectMQTTConnectFlagsSetup(DetectEngineCtx *de_ctx, Signature *s, const char *rawstr)
{
DetectMQTTConnectFlagsData *de = NULL;
SigMatch *sm = NULL;
if (DetectSignatureSetAppProto(s, ALPROTO_MQTT) < 0)
return -1;
de = DetectMQTTConnectFlagsParse(rawstr);
if (de == NULL)
goto error;
sm = SigMatchAlloc();
if (sm == NULL)
goto error;
sm->type = DETECT_AL_MQTT_CONNECT_FLAGS;
sm->ctx = (SigMatchCtx *)de;
SigMatchAppendSMToList(s, sm, mqtt_connect_flags_id);
return 0;
error:
if (de != NULL)
SCFree(de);
if (sm != NULL)
SCFree(sm);
return -1;
}
/**
* \internal
* \brief this function will free memory associated with DetectMQTTConnectFlagsData
*
* \param de pointer to DetectMQTTConnectFlagsData
*/
void DetectMQTTConnectFlagsFree(DetectEngineCtx *de_ctx, void *de_ptr)
{
if (de_ptr != NULL)
SCFree(de_ptr);
}
/*
* ONLY TESTS BELOW THIS COMMENT
*/
#ifdef UNITTESTS
/**
* \test MQTTConnectFlagsTestParse01 is a test for a valid value
*
* \retval 1 on success
* \retval 0 on failure
*/
static int MQTTConnectFlagsTestParse01 (void)
{
DetectMQTTConnectFlagsData *de = NULL;
de = DetectMQTTConnectFlagsParse("username");
FAIL_IF_NULL(de);
DetectMQTTConnectFlagsFree(NULL, de);
de = DetectMQTTConnectFlagsParse("username,password,will,will_retain,clean_session");
FAIL_IF_NULL(de);
DetectMQTTConnectFlagsFree(NULL, de);
de = DetectMQTTConnectFlagsParse("!username,!password,!will,!will_retain,!clean_session");
FAIL_IF_NULL(de);
DetectMQTTConnectFlagsFree(NULL, de);
de = DetectMQTTConnectFlagsParse(" username,password");
FAIL_IF_NULL(de);
DetectMQTTConnectFlagsFree(NULL, de);
PASS;
}
/**
* \test MQTTConnectFlagsTestParse02 is a test for an invalid value
*
* \retval 1 on success
* \retval 0 on failure
*/
static int MQTTConnectFlagsTestParse02 (void)
{
DetectMQTTConnectFlagsData *de = NULL;
de = DetectMQTTConnectFlagsParse("foobar");
if (de) {
DetectMQTTConnectFlagsFree(NULL, de);
FAIL;
}
PASS;
}
/**
* \test MQTTConnectFlagsTestParse03 is a test for an invalid value
*
* \retval 1 on success
* \retval 0 on failure
*/
static int MQTTConnectFlagsTestParse03 (void)
{
DetectMQTTConnectFlagsData *de = NULL;
de = DetectMQTTConnectFlagsParse("will,!");
if (de) {
DetectMQTTConnectFlagsFree(NULL, de);
FAIL;
}
PASS;
}
/**
* \test MQTTConnectFlagsTestParse04 is a test for an invalid value
*
* \retval 1 on success
* \retval 0 on failure
*/
static int MQTTConnectFlagsTestParse04 (void)
{
DetectMQTTConnectFlagsData *de = NULL;
de = DetectMQTTConnectFlagsParse("");
if (de) {
DetectMQTTConnectFlagsFree(NULL, de);
FAIL;
}
PASS;
}
/**
* \test MQTTConnectFlagsTestParse05 is a test for an invalid value
*
* \retval 1 on success
* \retval 0 on failure
*/
static int MQTTConnectFlagsTestParse05 (void)
{
DetectMQTTConnectFlagsData *de = NULL;
de = DetectMQTTConnectFlagsParse("username, username");
if (de) {
DetectMQTTConnectFlagsFree(NULL, de);
FAIL;
}
de = DetectMQTTConnectFlagsParse("!username, username");
if (de) {
DetectMQTTConnectFlagsFree(NULL, de);
FAIL;
}
de = DetectMQTTConnectFlagsParse("!username,password,!password");
if (de) {
DetectMQTTConnectFlagsFree(NULL, de);
FAIL;
}
de = DetectMQTTConnectFlagsParse("will, username,password, !will, will");
if (de) {
DetectMQTTConnectFlagsFree(NULL, de);
FAIL;
}
PASS;
}
#endif /* UNITTESTS */
/**
* \brief this function registers unit tests for MQTTConnectFlags
*/
void MQTTConnectFlagsRegisterTests(void)
{
#ifdef UNITTESTS
UtRegisterTest("MQTTConnectFlagsTestParse01", MQTTConnectFlagsTestParse01);
UtRegisterTest("MQTTConnectFlagsTestParse02", MQTTConnectFlagsTestParse02);
UtRegisterTest("MQTTConnectFlagsTestParse03", MQTTConnectFlagsTestParse03);
UtRegisterTest("MQTTConnectFlagsTestParse04", MQTTConnectFlagsTestParse04);
UtRegisterTest("MQTTConnectFlagsTestParse05", MQTTConnectFlagsTestParse05);
#endif /* UNITTESTS */
}
|