1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
|
/* Copyright (C) 2007-2020 Open Information Security Foundation
*
* You can copy, redistribute or modify this Program under the terms of
* the GNU General Public License version 2 as published by the Free
* Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* version 2 along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
* 02110-1301, USA.
*/
/**
* \file
*
* \author Gurvinder Singh <gurvindersighdahiya@gmail.com>
*
* Implements the urilen keyword
*/
#include "suricata-common.h"
#include "app-layer.h"
#include "app-layer-protos.h"
#include "app-layer-htp.h"
#include "util-unittest.h"
#include "util-unittest-helper.h"
#include "detect.h"
#include "detect-parse.h"
#include "detect-engine.h"
#include "detect-engine-state.h"
#include "detect-engine-build.h"
#include "detect-content.h"
#include "detect-engine-uint.h"
#include "detect-urilen.h"
#include "util-debug.h"
#include "util-byte.h"
#include "flow-util.h"
#include "stream-tcp.h"
/*prototypes*/
static int DetectUrilenSetup (DetectEngineCtx *, Signature *, const char *);
static void DetectUrilenFree (DetectEngineCtx *, void *);
#ifdef UNITTESTS
static void DetectUrilenRegisterTests (void);
#endif
static int g_http_uri_buffer_id = 0;
static int g_http_raw_uri_buffer_id = 0;
/**
* \brief Registration function for urilen: keyword
*/
void DetectUrilenRegister(void)
{
sigmatch_table[DETECT_AL_URILEN].name = "urilen";
sigmatch_table[DETECT_AL_URILEN].desc = "match on the length of the HTTP uri";
sigmatch_table[DETECT_AL_URILEN].url = "/rules/http-keywords.html#urilen";
sigmatch_table[DETECT_AL_URILEN].Match = NULL;
sigmatch_table[DETECT_AL_URILEN].Setup = DetectUrilenSetup;
sigmatch_table[DETECT_AL_URILEN].Free = DetectUrilenFree;
#ifdef UNITTESTS
sigmatch_table[DETECT_AL_URILEN].RegisterTests = DetectUrilenRegisterTests;
#endif
g_http_uri_buffer_id = DetectBufferTypeRegister("http_uri");
g_http_raw_uri_buffer_id = DetectBufferTypeRegister("http_raw_uri");
}
/**
* \brief This function is used to parse urilen options passed via urilen: keyword
*
* \param urilenstr Pointer to the user provided urilen options
*
* \retval urilend pointer to DetectUrilenData on success
* \retval NULL on failure
*/
static DetectUrilenData *DetectUrilenParse (const char *urilenstr)
{
return rs_detect_urilen_parse(urilenstr);
}
/**
* \brief this function is used to parse urilen data into the current signature
*
* \param de_ctx pointer to the Detection Engine Context
* \param s pointer to the Current Signature
* \param urilenstr pointer to the user provided urilen options
*
* \retval 0 on Success
* \retval -1 on Failure
*/
static int DetectUrilenSetup (DetectEngineCtx *de_ctx, Signature *s, const char *urilenstr)
{
SCEnter();
DetectUrilenData *urilend = NULL;
SigMatch *sm = NULL;
if (DetectSignatureSetAppProto(s, ALPROTO_HTTP) != 0)
return -1;
urilend = DetectUrilenParse(urilenstr);
if (urilend == NULL)
goto error;
sm = SigMatchAlloc();
if (sm == NULL)
goto error;
sm->type = DETECT_AL_URILEN;
sm->ctx = (void *)urilend;
if (urilend->raw_buffer)
SigMatchAppendSMToList(s, sm, g_http_raw_uri_buffer_id);
else
SigMatchAppendSMToList(s, sm, g_http_uri_buffer_id);
SCReturnInt(0);
error:
DetectUrilenFree(de_ctx, urilend);
SCReturnInt(-1);
}
/**
* \brief this function will free memory associated with DetectUrilenData
*
* \param ptr pointer to DetectUrilenData
*/
static void DetectUrilenFree(DetectEngineCtx *de_ctx, void *ptr)
{
if (ptr == NULL)
return;
DetectUrilenData *urilend = (DetectUrilenData *)ptr;
rs_detect_urilen_free(urilend);
}
/** \brief set prefilter dsize pair
* \param s signature to get dsize value from
*/
void DetectUrilenApplyToContent(Signature *s, int list)
{
for (uint32_t x = 0; x < s->init_data->buffer_index; x++) {
if (s->init_data->buffers[x].id != (uint32_t)list)
continue;
uint16_t high = UINT16_MAX;
bool found = false;
for (SigMatch *sm = s->init_data->buffers[x].head; sm != NULL; sm = sm->next) {
if (sm->type != DETECT_AL_URILEN)
continue;
DetectUrilenData *dd = (DetectUrilenData *)sm->ctx;
switch (dd->du16.mode) {
case DETECT_UINT_LT:
if (dd->du16.arg1 < UINT16_MAX) {
high = dd->du16.arg1 + 1;
}
break;
case DETECT_UINT_LTE:
// fallthrough
case DETECT_UINT_EQ:
high = dd->du16.arg1;
break;
case DETECT_UINT_RA:
if (dd->du16.arg2 < UINT16_MAX) {
high = dd->du16.arg2 + 1;
}
break;
case DETECT_UINT_NE:
// fallthrough
case DETECT_UINT_GTE:
// fallthrough
case DETECT_UINT_GT:
high = UINT16_MAX;
break;
}
found = true;
}
// skip 65535 to avoid mismatch on uri > 64k
if (!found || high == UINT16_MAX)
return;
SCLogDebug("high %u", high);
for (SigMatch *sm = s->init_data->buffers[x].head; sm != NULL; sm = sm->next) {
if (sm->type != DETECT_CONTENT) {
continue;
}
DetectContentData *cd = (DetectContentData *)sm->ctx;
if (cd == NULL) {
continue;
}
if (cd->depth == 0 || cd->depth > high) {
cd->depth = high;
cd->flags |= DETECT_CONTENT_DEPTH;
SCLogDebug("updated %u, content %u to have depth %u "
"because of urilen.",
s->id, cd->id, cd->depth);
}
}
}
}
bool DetectUrilenValidateContent(const Signature *s, int list, const char **sigerror)
{
for (uint32_t x = 0; x < s->init_data->buffer_index; x++) {
if (s->init_data->buffers[x].id != (uint32_t)list)
continue;
for (const SigMatch *sm = s->init_data->buffers[x].head; sm != NULL; sm = sm->next) {
if (sm->type != DETECT_CONTENT) {
continue;
}
DetectContentData *cd = (DetectContentData *)sm->ctx;
if (cd == NULL) {
continue;
}
if (cd->depth && cd->depth < cd->content_len) {
*sigerror = "depth or urilen smaller than content len";
SCLogError("depth or urilen %u smaller "
"than content len %u",
cd->depth, cd->content_len);
return false;
}
}
}
return true;
}
#ifdef UNITTESTS
#include "stream.h"
#include "stream-tcp-private.h"
#include "stream-tcp-reassemble.h"
#include "detect-engine-mpm.h"
#include "app-layer-parser.h"
#include "detect-engine-alert.h"
/** \test Test the Urilen keyword setup */
static int DetectUrilenParseTest01(void)
{
int ret = 0;
DetectUrilenData *urilend = NULL;
urilend = DetectUrilenParse("10");
if (urilend != NULL) {
if (urilend->du16.arg1 == 10 && urilend->du16.mode == DETECT_UINT_EQ &&
!urilend->raw_buffer)
ret = 1;
DetectUrilenFree(NULL, urilend);
}
return ret;
}
/** \test Test the Urilen keyword setup */
static int DetectUrilenParseTest02(void)
{
int ret = 0;
DetectUrilenData *urilend = NULL;
urilend = DetectUrilenParse(" < 10 ");
if (urilend != NULL) {
if (urilend->du16.arg1 == 10 && urilend->du16.mode == DETECT_UINT_LT &&
!urilend->raw_buffer)
ret = 1;
DetectUrilenFree(NULL, urilend);
}
return ret;
}
/** \test Test the Urilen keyword setup */
static int DetectUrilenParseTest03(void)
{
int ret = 0;
DetectUrilenData *urilend = NULL;
urilend = DetectUrilenParse(" > 10 ");
if (urilend != NULL) {
if (urilend->du16.arg1 == 10 && urilend->du16.mode == DETECT_UINT_GT &&
!urilend->raw_buffer)
ret = 1;
DetectUrilenFree(NULL, urilend);
}
return ret;
}
/** \test Test the Urilen keyword setup */
static int DetectUrilenParseTest04(void)
{
int ret = 0;
DetectUrilenData *urilend = NULL;
urilend = DetectUrilenParse(" 5 <> 10 ");
if (urilend != NULL) {
if (urilend->du16.arg1 == 5 && urilend->du16.arg2 == 10 &&
urilend->du16.mode == DETECT_UINT_RA && !urilend->raw_buffer)
ret = 1;
DetectUrilenFree(NULL, urilend);
}
return ret;
}
/** \test Test the Urilen keyword setup */
static int DetectUrilenParseTest05(void)
{
int ret = 0;
DetectUrilenData *urilend = NULL;
urilend = DetectUrilenParse("5<>10,norm");
if (urilend != NULL) {
if (urilend->du16.arg1 == 5 && urilend->du16.arg2 == 10 &&
urilend->du16.mode == DETECT_UINT_RA && !urilend->raw_buffer)
ret = 1;
DetectUrilenFree(NULL, urilend);
}
return ret;
}
/** \test Test the Urilen keyword setup */
static int DetectUrilenParseTest06(void)
{
int ret = 0;
DetectUrilenData *urilend = NULL;
urilend = DetectUrilenParse("5<>10,raw");
if (urilend != NULL) {
if (urilend->du16.arg1 == 5 && urilend->du16.arg2 == 10 &&
urilend->du16.mode == DETECT_UINT_RA && urilend->raw_buffer)
ret = 1;
DetectUrilenFree(NULL, urilend);
}
return ret;
}
/** \test Test the Urilen keyword setup */
static int DetectUrilenParseTest07(void)
{
int ret = 0;
DetectUrilenData *urilend = NULL;
urilend = DetectUrilenParse(">10, norm ");
if (urilend != NULL) {
if (urilend->du16.arg1 == 10 && urilend->du16.mode == DETECT_UINT_GT &&
!urilend->raw_buffer)
ret = 1;
DetectUrilenFree(NULL, urilend);
}
return ret;
}
/** \test Test the Urilen keyword setup */
static int DetectUrilenParseTest08(void)
{
int ret = 0;
DetectUrilenData *urilend = NULL;
urilend = DetectUrilenParse("<10, norm ");
if (urilend != NULL) {
if (urilend->du16.arg1 == 10 && urilend->du16.mode == DETECT_UINT_LT &&
!urilend->raw_buffer)
ret = 1;
DetectUrilenFree(NULL, urilend);
}
return ret;
}
/** \test Test the Urilen keyword setup */
static int DetectUrilenParseTest09(void)
{
int ret = 0;
DetectUrilenData *urilend = NULL;
urilend = DetectUrilenParse(">10, raw ");
if (urilend != NULL) {
if (urilend->du16.arg1 == 10 && urilend->du16.mode == DETECT_UINT_GT && urilend->raw_buffer)
ret = 1;
DetectUrilenFree(NULL, urilend);
}
return ret;
}
/** \test Test the Urilen keyword setup */
static int DetectUrilenParseTest10(void)
{
int ret = 0;
DetectUrilenData *urilend = NULL;
urilend = DetectUrilenParse("<10, raw ");
if (urilend != NULL) {
if (urilend->du16.arg1 == 10 && urilend->du16.mode == DETECT_UINT_LT && urilend->raw_buffer)
ret = 1;
DetectUrilenFree(NULL, urilend);
}
return ret;
}
/**
* \brief this function is used to initialize the detection engine context and
* setup the signature with passed values.
*
*/
static int DetectUrilenInitTest(DetectEngineCtx **de_ctx, Signature **sig,
DetectUrilenData **urilend, const char *str)
{
char fullstr[1024];
int result = 0;
*de_ctx = NULL;
*sig = NULL;
if (snprintf(fullstr, 1024, "alert ip any any -> any any (msg:\"Urilen "
"test\"; urilen:%s; sid:1;)", str) >= 1024) {
goto end;
}
*de_ctx = DetectEngineCtxInit();
if (*de_ctx == NULL) {
goto end;
}
(*de_ctx)->flags |= DE_QUIET;
(*de_ctx)->sig_list = SigInit(*de_ctx, fullstr);
if ((*de_ctx)->sig_list == NULL) {
goto end;
}
*sig = (*de_ctx)->sig_list;
*urilend = DetectUrilenParse(str);
result = 1;
end:
return result;
}
/**
* \test DetectUrilenSetpTest01 is a test for setting up an valid urilen values
* with valid "<>" operator and include spaces arround the given values.
* In the test the values are setup with initializing the detection engine
* context and setting up the signature itself.
*/
static int DetectUrilenSetpTest01(void)
{
DetectUrilenData *urilend = NULL;
uint8_t res = 0;
Signature *sig = NULL;
DetectEngineCtx *de_ctx = NULL;
res = DetectUrilenInitTest(&de_ctx, &sig, &urilend, "1 <> 2 ");
if (res == 0) {
goto end;
}
if(urilend == NULL)
goto cleanup;
if (urilend != NULL) {
if (urilend->du16.arg1 == 1 && urilend->du16.arg2 == 2 &&
urilend->du16.mode == DETECT_UINT_RA)
res = 1;
}
cleanup:
if (urilend)
DetectUrilenFree(NULL, urilend);
SigGroupCleanup(de_ctx);
SigCleanSignatures(de_ctx);
DetectEngineCtxFree(de_ctx);
end:
return res;
}
/** \test Check a signature with given urilen */
static int DetectUrilenSigTest01(void)
{
int result = 0;
Flow f;
uint8_t httpbuf1[] = "POST /suricata HTTP/1.0\r\n"
"Host: foo.bar.tld\r\n"
"\r\n";
uint32_t httplen1 = sizeof(httpbuf1) - 1; /* minus the \0 */
TcpSession ssn;
Packet *p = NULL;
Signature *s = NULL;
ThreadVars th_v;
DetectEngineThreadCtx *det_ctx;
AppLayerParserThreadCtx *alp_tctx = AppLayerParserThreadCtxAlloc();
memset(&th_v, 0, sizeof(th_v));
memset(&f, 0, sizeof(f));
memset(&ssn, 0, sizeof(ssn));
p = UTHBuildPacket(NULL, 0, IPPROTO_TCP);
FLOW_INITIALIZE(&f);
f.protoctx = (void *)&ssn;
f.proto = IPPROTO_TCP;
f.flags |= FLOW_IPV4;
p->flow = &f;
p->flowflags |= FLOW_PKT_TOSERVER;
p->flowflags |= FLOW_PKT_ESTABLISHED;
p->flags |= PKT_HAS_FLOW|PKT_STREAM_EST;
f.alproto = ALPROTO_HTTP1;
StreamTcpInitConfig(true);
DetectEngineCtx *de_ctx = DetectEngineCtxInit();
if (de_ctx == NULL) {
goto end;
}
de_ctx->flags |= DE_QUIET;
s = de_ctx->sig_list = SigInit(de_ctx,
"alert tcp any any -> any any "
"(msg:\"Testing urilen\"; "
"urilen: <5; sid:1;)");
if (s == NULL) {
goto end;
}
s = s->next = SigInit(de_ctx,
"alert tcp any any -> any any "
"(msg:\"Testing http_method\"; "
"urilen: >5; sid:2;)");
if (s == NULL) {
goto end;
}
SigGroupBuild(de_ctx);
DetectEngineThreadCtxInit(&th_v, (void *)de_ctx, (void *)&det_ctx);
int r = AppLayerParserParse(
NULL, alp_tctx, &f, ALPROTO_HTTP1, STREAM_TOSERVER, httpbuf1, httplen1);
if (r != 0) {
SCLogDebug("toserver chunk 1 returned %" PRId32 ", expected 0: ", r);
goto end;
}
HtpState *htp_state = f.alstate;
if (htp_state == NULL) {
SCLogDebug("no http state: ");
goto end;
}
SigMatchSignatures(&th_v, de_ctx, det_ctx, p);
if ((PacketAlertCheck(p, 1))) {
printf("sid 1 alerted, but should not have: \n");
goto end;
}
if (!PacketAlertCheck(p, 2)) {
printf("sid 2 did not alerted, but should have: \n");
goto end;
}
result = 1;
end:
if (alp_tctx != NULL)
AppLayerParserThreadCtxFree(alp_tctx);
if (de_ctx != NULL) SigGroupCleanup(de_ctx);
if (de_ctx != NULL) SigCleanSignatures(de_ctx);
if (de_ctx != NULL) DetectEngineCtxFree(de_ctx);
StreamTcpFreeConfig(true);
FLOW_DESTROY(&f);
UTHFreePackets(&p, 1);
return result;
}
/**
* \brief this function registers unit tests for DetectUrilen
*/
void DetectUrilenRegisterTests(void)
{
UtRegisterTest("DetectUrilenParseTest01", DetectUrilenParseTest01);
UtRegisterTest("DetectUrilenParseTest02", DetectUrilenParseTest02);
UtRegisterTest("DetectUrilenParseTest03", DetectUrilenParseTest03);
UtRegisterTest("DetectUrilenParseTest04", DetectUrilenParseTest04);
UtRegisterTest("DetectUrilenParseTest05", DetectUrilenParseTest05);
UtRegisterTest("DetectUrilenParseTest06", DetectUrilenParseTest06);
UtRegisterTest("DetectUrilenParseTest07", DetectUrilenParseTest07);
UtRegisterTest("DetectUrilenParseTest08", DetectUrilenParseTest08);
UtRegisterTest("DetectUrilenParseTest09", DetectUrilenParseTest09);
UtRegisterTest("DetectUrilenParseTest10", DetectUrilenParseTest10);
UtRegisterTest("DetectUrilenSetpTest01", DetectUrilenSetpTest01);
UtRegisterTest("DetectUrilenSigTest01", DetectUrilenSigTest01);
}
#endif /* UNITTESTS */
|