1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
|
#!/usr/bin/env bash
# SPDX-License-Identifier: LGPL-2.1-or-later
set -eux
set -o pipefail
# shellcheck source=test/units/test-control.sh
. "$(dirname "$0")"/test-control.sh
# shellcheck source=test/units/util.sh
. "$(dirname "$0")"/util.sh
testcase_timedatectl() {
timedatectl --no-pager --help
timedatectl --version
timedatectl
timedatectl --no-ask-password
timedatectl status --machine=testuser@.host
timedatectl status
timedatectl show
timedatectl show --all
timedatectl show -p NTP
timedatectl show -p NTP --value
timedatectl list-timezones
if ! systemd-detect-virt -qc; then
systemctl enable --runtime --now systemd-timesyncd
timedatectl timesync-status
timedatectl show-timesync
fi
}
restore_timezone() {
if [[ -f /tmp/timezone.bak ]]; then
mv /tmp/timezone.bak /etc/timezone
else
rm -f /etc/timezone
fi
}
testcase_timezone() {
local ORIG_TZ=
# Debian/Ubuntu specific file
if [[ -f /etc/timezone ]]; then
mv /etc/timezone /tmp/timezone.bak
fi
trap restore_timezone RETURN
if [[ -L /etc/localtime ]]; then
ORIG_TZ=$(readlink /etc/localtime | sed 's#^.*zoneinfo/##')
echo "original tz: $ORIG_TZ"
fi
echo 'timedatectl works'
assert_in "Local time:" "$(timedatectl --no-pager)"
echo 'change timezone'
assert_eq "$(timedatectl --no-pager set-timezone Europe/Kiev 2>&1)" ""
assert_eq "$(readlink /etc/localtime | sed 's#^.*zoneinfo/##')" "Europe/Kiev"
if [[ -f /etc/timezone ]]; then
assert_eq "$(cat /etc/timezone)" "Europe/Kiev"
fi
assert_in "Time zone: Europe/Kiev \(EES*T, \+0[0-9]00\)" "$(timedatectl)"
if [[ -n "$ORIG_TZ" ]]; then
echo 'reset timezone to original'
assert_eq "$(timedatectl set-timezone "$ORIG_TZ" 2>&1)" ""
assert_eq "$(readlink /etc/localtime | sed 's#^.*zoneinfo/##')" "$ORIG_TZ"
if [[ -f /etc/timezone ]]; then
assert_eq "$(cat /etc/timezone)" "$ORIG_TZ"
fi
fi
}
restore_adjtime() {
if [[ -e /etc/adjtime.bak ]]; then
mv /etc/adjtime.bak /etc/adjtime
else
rm /etc/adjtime
fi
}
check_adjtime_not_exist() {
if [[ -e /etc/adjtime ]]; then
echo "/etc/adjtime unexpectedly exists." >&2
exit 1
fi
}
testcase_adjtime() {
# test setting UTC vs. LOCAL in /etc/adjtime
if [[ -e /etc/adjtime ]]; then
mv /etc/adjtime /etc/adjtime.bak
fi
trap restore_adjtime RETURN
echo 'no adjtime file'
rm -f /etc/adjtime
timedatectl set-local-rtc 0
check_adjtime_not_exist
timedatectl set-local-rtc 1
assert_eq "$(cat /etc/adjtime)" "0.0 0 0
0
LOCAL"
timedatectl set-local-rtc 0
check_adjtime_not_exist
echo 'UTC set in adjtime file'
printf '0.0 0 0\n0\nUTC\n' >/etc/adjtime
timedatectl set-local-rtc 0
assert_eq "$(cat /etc/adjtime)" "0.0 0 0
0
UTC"
timedatectl set-local-rtc 1
assert_eq "$(cat /etc/adjtime)" "0.0 0 0
0
LOCAL"
echo 'non-zero values in adjtime file'
printf '0.1 123 0\n0\nLOCAL\n' >/etc/adjtime
timedatectl set-local-rtc 0
assert_eq "$(cat /etc/adjtime)" "0.1 123 0
0
UTC"
timedatectl set-local-rtc 1
assert_eq "$(cat /etc/adjtime)" "0.1 123 0
0
LOCAL"
echo 'fourth line adjtime file'
printf '0.0 0 0\n0\nLOCAL\nsomethingelse\n' >/etc/adjtime
timedatectl set-local-rtc 0
assert_eq "$(cat /etc/adjtime)" "0.0 0 0
0
UTC
somethingelse"
timedatectl set-local-rtc 1
assert_eq "$(cat /etc/adjtime)" "0.0 0 0
0
LOCAL
somethingelse"
echo 'no final newline in adjtime file'
printf '0.0 0 0\n0\nUTC' >/etc/adjtime
timedatectl set-local-rtc 0
check_adjtime_not_exist
printf '0.0 0 0\n0\nUTC' >/etc/adjtime
timedatectl set-local-rtc 1
assert_eq "$(cat /etc/adjtime)" "0.0 0 0
0
LOCAL"
echo 'only one line in adjtime file'
printf '0.0 0 0\n' >/etc/adjtime
timedatectl set-local-rtc 0
check_adjtime_not_exist
printf '0.0 0 0\n' >/etc/adjtime
timedatectl set-local-rtc 1
assert_eq "$(cat /etc/adjtime)" "0.0 0 0
0
LOCAL"
echo 'only one line in adjtime file, no final newline'
printf '0.0 0 0' >/etc/adjtime
timedatectl set-local-rtc 0
check_adjtime_not_exist
printf '0.0 0 0' >/etc/adjtime
timedatectl set-local-rtc 1
assert_eq "$(cat /etc/adjtime)" "0.0 0 0
0
LOCAL"
echo 'only two lines in adjtime file'
printf '0.0 0 0\n0\n' >/etc/adjtime
timedatectl set-local-rtc 0
check_adjtime_not_exist
printf '0.0 0 0\n0\n' >/etc/adjtime
timedatectl set-local-rtc 1
assert_eq "$(cat /etc/adjtime)" "0.0 0 0
0
LOCAL"
echo 'only two lines in adjtime file, no final newline'
printf '0.0 0 0\n0' >/etc/adjtime
timedatectl set-local-rtc 0
check_adjtime_not_exist
printf '0.0 0 0\n0' >/etc/adjtime
timedatectl set-local-rtc 1
assert_eq "$(cat /etc/adjtime)" "0.0 0 0
0
LOCAL"
echo 'unknown value in 3rd line of adjtime file'
printf '0.0 0 0\n0\nFOO\n' >/etc/adjtime
timedatectl set-local-rtc 0
check_adjtime_not_exist
printf '0.0 0 0\n0\nFOO\n' >/etc/adjtime
timedatectl set-local-rtc 1
assert_eq "$(cat /etc/adjtime)" "0.0 0 0
0
LOCAL"
}
assert_ntp() {
local value="${1:?}"
for _ in {0..9}; do
[[ "$(busctl get-property org.freedesktop.timedate1 /org/freedesktop/timedate1 org.freedesktop.timedate1 NTP)" == "b $value" ]] && return 0
sleep .5
done
return 1
}
assert_timedated_signal() {
local timestamp="${1:?}"
local value="${2:?}"
local args=(-q -n 1 --since="$timestamp" -p info _SYSTEMD_UNIT="busctl-monitor.service")
journalctl --sync
for _ in {0..9}; do
if journalctl "${args[@]}" --grep .; then
[[ "$(journalctl "${args[@]}" -o cat | jq -r '.payload.data[1].NTP.data')" == "$value" ]];
return 0
fi
sleep .5
done
return 1
}
assert_timesyncd_state() {
local state="${1:?}"
for _ in {0..9}; do
[[ "$(systemctl show systemd-timesyncd.service -P ActiveState)" == "$state" ]] && return 0
sleep .5
done
return 1
}
testcase_ntp() {
# This fails due to https://github.com/systemd/systemd/issues/30886
# but it is too complex and risky to backport, so disable the test
return
# timesyncd has ConditionVirtualization=!container by default; drop/mock that for testing
if systemd-detect-virt --container --quiet; then
systemctl disable --quiet --now systemd-timesyncd
mkdir -p /run/systemd/system/systemd-timesyncd.service.d
cat >/run/systemd/system/systemd-timesyncd.service.d/container.conf <<EOF
[Unit]
ConditionVirtualization=
[Service]
Type=simple
AmbientCapabilities=
ExecStart=
ExecStart=/bin/sleep infinity
EOF
systemctl daemon-reload
fi
systemd-run --unit busctl-monitor.service --service-type=notify \
busctl monitor --json=short --match="type=signal,sender=org.freedesktop.timedate1,member=PropertiesChanged,path=/org/freedesktop/timedate1"
: 'Disable NTP'
ts="$(date +"%F %T.%6N")"
timedatectl set-ntp false
assert_timedated_signal "$ts" "false"
assert_timesyncd_state "inactive"
assert_ntp "false"
assert_rc 3 systemctl is-active --quiet systemd-timesyncd
: 'Enable NTP'
ts="$(date +"%F %T.%6N")"
timedatectl set-ntp true
assert_timedated_signal "$ts" "true"
assert_ntp "true"
assert_timesyncd_state "active"
assert_rc 0 systemctl is-active --quiet systemd-timesyncd
: 'Re-disable NTP'
ts="$(date +"%F %T.%6N")"
timedatectl set-ntp false
assert_timedated_signal "$ts" "false"
assert_ntp "false"
assert_rc 3 systemctl is-active --quiet systemd-timesyncd
systemctl stop busctl-monitor.service
rm -rf /run/systemd/system/systemd-timesyncd.service.d/
systemctl daemon-reload
}
assert_timesyncd_signal() {
local timestamp="${1:?}"
local property="${2:?}"
local value="${3:?}"
local args=(-q --since="$timestamp" -p info _SYSTEMD_UNIT="busctl-monitor.service")
journalctl --sync
for _ in {0..9}; do
if journalctl "${args[@]}" --grep .; then
[[ "$(journalctl "${args[@]}" -o cat | jq -r ".payload.data[1].$property.data | join(\" \")")" == "$value" ]];
return 0
fi
sleep .5
done
return 1
}
assert_networkd_ntp() {
local interface="${1:?}"
local value="${2:?}"
# Go through the array of NTP servers and for each entry do:
# - if the entry is an IPv4 address, join the Address array into a dot separated string
# - if the entry is a server address, select it unchanged
# These steps produce an array of strings, that is then joined into a space-separated string
# Note: this doesn't support IPv6 addresses, since converting them to a string is a bit more
# involved than a simple join(), but let's leave that to another time
local expr='[.NTP[] | (select(.Family == 2).Address | join(".")), select(has("Server")).Server] | join(" ")'
[[ "$(networkctl status "$interface" --json=short | jq -r "$expr")" == "$value" ]]
}
testcase_timesyncd() {
if systemd-detect-virt -cq; then
echo "This test case requires a VM, skipping..."
return 0
fi
if ! command -v networkctl >/dev/null; then
echo "This test requires systemd-networkd, skipping..."
return 0
fi
# Create a dummy interface managed by networkd, so we can configure link NTP servers
mkdir -p /run/systemd/network/
cat >/etc/systemd/network/10-ntp99.netdev <<EOF
[NetDev]
Name=ntp99
Kind=dummy
EOF
cat >/etc/systemd/network/10-ntp99.network <<EOF
[Match]
Name=ntp99
[Network]
Address=10.0.0.1/24
EOF
systemctl unmask systemd-timesyncd systemd-networkd
systemctl restart systemd-timesyncd
systemctl restart systemd-networkd
networkctl status ntp99
systemd-run --unit busctl-monitor.service --service-type=notify \
busctl monitor --json=short --match="type=signal,sender=org.freedesktop.timesync1,member=PropertiesChanged,path=/org/freedesktop/timesync1"
# LinkNTPServers
#
# Single IP
ts="$(date +"%F %T.%6N")"
timedatectl ntp-servers ntp99 10.0.0.1
assert_networkd_ntp ntp99 10.0.0.1
assert_timesyncd_signal "$ts" LinkNTPServers 10.0.0.1
# Setting NTP servers to the same value shouldn't emit a PropertiesChanged signal
ts="$(date +"%F %T.%6N")"
timedatectl ntp-servers ntp99 10.0.0.1
assert_networkd_ntp ntp99 10.0.0.1
(! assert_timesyncd_signal "$ts" LinkNTPServers 10.0.0.1)
# Multiple IPs
ts="$(date +"%F %T.%6N")"
timedatectl ntp-servers ntp99 10.0.0.1 192.168.0.99
assert_networkd_ntp ntp99 "10.0.0.1 192.168.0.99"
assert_timesyncd_signal "$ts" LinkNTPServers "10.0.0.1 192.168.0.99"
# Multiple IPs + servers
ts="$(date +"%F %T.%6N")"
timedatectl ntp-servers ntp99 10.0.0.1 192.168.0.99 foo.localhost foo 10.11.12.13
assert_networkd_ntp ntp99 "10.0.0.1 192.168.0.99 foo.localhost foo 10.11.12.13"
assert_timesyncd_signal "$ts" LinkNTPServers "10.0.0.1 192.168.0.99 foo.localhost foo 10.11.12.13"
# RuntimeNTPServers
#
# There's no user-facing API that allows changing this property (afaik), so let's
# call SetRuntimeNTPServers() directly to test things out. The inner workings should
# be exactly the same as in the previous case, so do just one test to make sure
# things work
ts="$(date +"%F %T.%6N")"
busctl call org.freedesktop.timesync1 /org/freedesktop/timesync1 org.freedesktop.timesync1.Manager \
SetRuntimeNTPServers as 4 "10.0.0.1" foo "192.168.99.1" bar
servers="$(busctl get-property org.freedesktop.timesync1 /org/freedesktop/timesync1 org.freedesktop.timesync1.Manager RuntimeNTPServers)"
[[ "$servers" == 'as 4 "10.0.0.1" "foo" "192.168.99.1" "bar"' ]]
assert_timesyncd_signal "$ts" RuntimeNTPServers "10.0.0.1 foo 192.168.99.1 bar"
# Cleanup
systemctl stop systemd-networkd systemd-timesyncd
rm -f /run/systemd/network/ntp99.*
}
run_testcases
touch /testok
|