1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
|
/* $Id: NEMR3.cpp $ */
/** @file
* NEM - Native execution manager.
*/
/*
* Copyright (C) 2018-2023 Oracle and/or its affiliates.
*
* This file is part of VirtualBox base platform packages, as
* available from https://www.virtualbox.org.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation, in version 3 of the
* License.
*
* This program is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <https://www.gnu.org/licenses>.
*
* SPDX-License-Identifier: GPL-3.0-only
*/
/** @page pg_nem NEM - Native Execution Manager.
*
* This is an alternative execution manage to HM and raw-mode. On one host
* (Windows) we're forced to use this, on the others we just do it because we
* can. Since this is host specific in nature, information about an
* implementation is contained in the NEMR3Native-xxxx.cpp files.
*
* @ref pg_nem_win
*/
/*********************************************************************************************************************************
* Header Files *
*********************************************************************************************************************************/
#define LOG_GROUP LOG_GROUP_NEM
#include <VBox/vmm/dbgf.h>
#include <VBox/vmm/nem.h>
#include <VBox/vmm/gim.h>
#include "NEMInternal.h"
#include <VBox/vmm/vm.h>
#include <VBox/vmm/uvm.h>
#include <VBox/err.h>
#include <iprt/asm.h>
#include <iprt/string.h>
/**
* Basic init and configuration reading.
*
* Always call NEMR3Term after calling this.
*
* @returns VBox status code.
* @param pVM The cross context VM structure.
*/
VMMR3_INT_DECL(int) NEMR3InitConfig(PVM pVM)
{
LogFlow(("NEMR3Init\n"));
/*
* Assert alignment and sizes.
*/
AssertCompileMemberAlignment(VM, nem.s, 64);
AssertCompile(sizeof(pVM->nem.s) <= sizeof(pVM->nem.padding));
/*
* Initialize state info so NEMR3Term will always be happy.
* No returning prior to setting magics!
*/
pVM->nem.s.u32Magic = NEM_MAGIC;
for (VMCPUID idCpu = 0; idCpu < pVM->cCpus; idCpu++)
{
PVMCPU pVCpu = pVM->apCpusR3[idCpu];
pVCpu->nem.s.u32Magic = NEMCPU_MAGIC;
}
/*
* Read configuration.
*/
PCFGMNODE pCfgNem = CFGMR3GetChild(CFGMR3GetRoot(pVM), "NEM/");
/*
* Validate the NEM settings.
*/
int rc = CFGMR3ValidateConfig(pCfgNem,
"/NEM/",
"Enabled"
"|Allow64BitGuests"
"|LovelyMesaDrvWorkaround"
#ifdef RT_OS_WINDOWS
"|UseRing0Runloop"
#elif defined(RT_OS_DARWIN)
"|VmxPleGap"
"|VmxPleWindow"
"|VmxLbr"
#endif
,
"" /* pszValidNodes */, "NEM" /* pszWho */, 0 /* uInstance */);
if (RT_FAILURE(rc))
return rc;
/** @cfgm{/NEM/NEMEnabled, bool, true}
* Whether NEM is enabled. */
rc = CFGMR3QueryBoolDef(pCfgNem, "Enabled", &pVM->nem.s.fEnabled, true);
AssertLogRelRCReturn(rc, rc);
#ifdef VBOX_WITH_64_BITS_GUESTS
/** @cfgm{/NEM/Allow64BitGuests, bool, 32-bit:false, 64-bit:true}
* Enables AMD64 CPU features.
* On 32-bit hosts this isn't default and require host CPU support. 64-bit hosts
* already have the support. */
rc = CFGMR3QueryBoolDef(pCfgNem, "Allow64BitGuests", &pVM->nem.s.fAllow64BitGuests, HC_ARCH_BITS == 64);
AssertLogRelRCReturn(rc, rc);
#else
pVM->nem.s.fAllow64BitGuests = false;
#endif
/** @cfgm{/NEM/LovelyMesaDrvWorkaround, bool, false}
* Workaround for mesa vmsvga 3d driver making incorrect assumptions about
* the hypervisor it is running under. */
bool f;
rc = CFGMR3QueryBoolDef(pCfgNem, "LovelyMesaDrvWorkaround", &f, false);
AssertLogRelRCReturn(rc, rc);
for (VMCPUID idCpu = 0; idCpu < pVM->cCpus; idCpu++)
{
PVMCPU pVCpu = pVM->apCpusR3[idCpu];
pVCpu->nem.s.fTrapXcptGpForLovelyMesaDrv = f;
}
return VINF_SUCCESS;
}
/**
* This is called by HMR3Init() when HM cannot be used.
*
* Sets VM::bMainExecutionEngine to VM_EXEC_ENGINE_NATIVE_API if we can use a
* native hypervisor API to execute the VM.
*
* @returns VBox status code.
* @param pVM The cross context VM structure.
* @param fFallback Whether this is a fallback call. Cleared if the VM is
* configured to use NEM instead of HM.
* @param fForced Whether /HM/HMForced was set. If set and we fail to
* enable NEM, we'll return a failure status code.
* Otherwise we'll assume HMR3Init falls back on raw-mode.
*/
VMMR3_INT_DECL(int) NEMR3Init(PVM pVM, bool fFallback, bool fForced)
{
Assert(pVM->bMainExecutionEngine != VM_EXEC_ENGINE_NATIVE_API);
int rc;
if (pVM->nem.s.fEnabled)
{
#ifdef VBOX_WITH_NATIVE_NEM
rc = nemR3NativeInit(pVM, fFallback, fForced);
ASMCompilerBarrier(); /* May have changed bMainExecutionEngine. */
#else
RT_NOREF(fFallback);
rc = VINF_SUCCESS;
#endif
if (RT_SUCCESS(rc))
{
if (pVM->bMainExecutionEngine == VM_EXEC_ENGINE_NATIVE_API)
{
#ifdef RT_OS_WINDOWS /* The WHv* API is extremely slow at handling VM exits. The AppleHv and
KVM APIs are much faster, thus the different mode name. :-) */
LogRel(("NEM:\n"
"NEM: NEMR3Init: Snail execution mode is active!\n"
"NEM: Note! VirtualBox is not able to run at its full potential in this execution mode.\n"
"NEM: To see VirtualBox run at max speed you need to disable all Windows features\n"
"NEM: making use of Hyper-V. That is a moving target, so google how and carefully\n"
"NEM: consider the consequences of disabling these features.\n"
"NEM:\n"));
#else
LogRel(("NEM:\n"
"NEM: NEMR3Init: Turtle execution mode is active!\n"
"NEM: Note! VirtualBox is not able to run at its full potential in this execution mode.\n"
"NEM:\n"));
#endif
}
else
{
LogRel(("NEM: NEMR3Init: Not available.\n"));
if (fForced)
rc = VERR_NEM_NOT_AVAILABLE;
}
}
else
LogRel(("NEM: NEMR3Init: Native init failed: %Rrc.\n", rc));
}
else
{
LogRel(("NEM: NEMR3Init: Disabled.\n"));
rc = fForced ? VERR_NEM_NOT_ENABLED : VINF_SUCCESS;
}
return rc;
}
/**
* Perform initialization that depends on CPUM working.
*
* This is a noop if NEM wasn't activated by a previous NEMR3Init() call.
*
* @returns VBox status code.
* @param pVM The cross context VM structure.
*/
VMMR3_INT_DECL(int) NEMR3InitAfterCPUM(PVM pVM)
{
int rc = VINF_SUCCESS;
if (pVM->bMainExecutionEngine == VM_EXEC_ENGINE_NATIVE_API)
{
/*
* Do native after-CPUM init.
*/
#ifdef VBOX_WITH_NATIVE_NEM
rc = nemR3NativeInitAfterCPUM(pVM);
#else
RT_NOREF(pVM);
#endif
}
return rc;
}
/**
* Called when a init phase has completed.
*
* @returns VBox status code.
* @param pVM The cross context VM structure.
* @param enmWhat The phase that completed.
*/
VMMR3_INT_DECL(int) NEMR3InitCompleted(PVM pVM, VMINITCOMPLETED enmWhat)
{
/*
* Check if GIM needs #UD, since that applies to everyone.
*/
if (enmWhat == VMINITCOMPLETED_RING3)
for (VMCPUID idCpu = 0; idCpu < pVM->cCpus; idCpu++)
{
PVMCPU pVCpu = pVM->apCpusR3[idCpu];
pVCpu->nem.s.fGIMTrapXcptUD = GIMShouldTrapXcptUD(pVCpu);
}
/*
* Call native code.
*/
int rc = VINF_SUCCESS;
#ifdef VBOX_WITH_NATIVE_NEM
if (pVM->bMainExecutionEngine == VM_EXEC_ENGINE_NATIVE_API)
rc = nemR3NativeInitCompleted(pVM, enmWhat);
#else
RT_NOREF(pVM, enmWhat);
#endif
return rc;
}
/**
*
* @returns VBox status code.
* @param pVM The cross context VM structure.
*/
VMMR3_INT_DECL(int) NEMR3Term(PVM pVM)
{
AssertReturn(pVM->nem.s.u32Magic == NEM_MAGIC, VERR_WRONG_ORDER);
for (VMCPUID idCpu = 0; idCpu < pVM->cCpus; idCpu++)
AssertReturn(pVM->apCpusR3[idCpu]->nem.s.u32Magic == NEMCPU_MAGIC, VERR_WRONG_ORDER);
/* Do native termination. */
int rc = VINF_SUCCESS;
#ifdef VBOX_WITH_NATIVE_NEM
if (pVM->bMainExecutionEngine == VM_EXEC_ENGINE_NATIVE_API)
rc = nemR3NativeTerm(pVM);
#endif
/* Mark it as terminated. */
for (VMCPUID idCpu = 0; idCpu < pVM->cCpus; idCpu++)
{
PVMCPU pVCpu = pVM->apCpusR3[idCpu];
pVCpu->nem.s.u32Magic = NEMCPU_MAGIC_DEAD;
}
pVM->nem.s.u32Magic = NEM_MAGIC_DEAD;
return rc;
}
/**
* External interface for querying whether native execution API is used.
*
* @returns true if NEM is being used, otherwise false.
* @param pUVM The user mode VM handle.
* @sa HMR3IsEnabled
*/
VMMR3DECL(bool) NEMR3IsEnabled(PUVM pUVM)
{
UVM_ASSERT_VALID_EXT_RETURN(pUVM, false);
PVM pVM = pUVM->pVM;
VM_ASSERT_VALID_EXT_RETURN(pVM, false);
return VM_IS_NEM_ENABLED(pVM);
}
/**
* The VM is being reset.
*
* @param pVM The cross context VM structure.
*/
VMMR3_INT_DECL(void) NEMR3Reset(PVM pVM)
{
#ifdef VBOX_WITH_NATIVE_NEM
if (pVM->bMainExecutionEngine == VM_EXEC_ENGINE_NATIVE_API)
nemR3NativeReset(pVM);
#else
RT_NOREF(pVM);
#endif
}
/**
* Resets a virtual CPU.
*
* Used to bring up secondary CPUs on SMP as well as CPU hot plugging.
*
* @param pVCpu The cross context virtual CPU structure to reset.
* @param fInitIpi Set if being reset due to INIT IPI.
*/
VMMR3_INT_DECL(void) NEMR3ResetCpu(PVMCPU pVCpu, bool fInitIpi)
{
#ifdef VBOX_WITH_NATIVE_NEM
if (pVCpu->pVMR3->bMainExecutionEngine == VM_EXEC_ENGINE_NATIVE_API)
nemR3NativeResetCpu(pVCpu, fInitIpi);
#else
RT_NOREF(pVCpu, fInitIpi);
#endif
}
/**
* Indicates to TM that TMTSCMODE_NATIVE_API should be used for TSC.
*
* @returns true if TMTSCMODE_NATIVE_API must be used, otherwise @c false.
* @param pVM The cross context VM structure.
*/
VMMR3_INT_DECL(bool) NEMR3NeedSpecialTscMode(PVM pVM)
{
#ifdef VBOX_WITH_NATIVE_NEM
if (VM_IS_NEM_ENABLED(pVM))
return true;
#else
RT_NOREF(pVM);
#endif
return false;
}
/**
* Gets the name of a generic NEM exit code.
*
* @returns Pointer to read only string if @a uExit is known, otherwise NULL.
* @param uExit The NEM exit to name.
*/
VMMR3DECL(const char *) NEMR3GetExitName(uint32_t uExit)
{
switch ((NEMEXITTYPE)uExit)
{
case NEMEXITTYPE_INTTERRUPT_WINDOW: return "NEM interrupt window";
case NEMEXITTYPE_HALT: return "NEM halt";
case NEMEXITTYPE_UNRECOVERABLE_EXCEPTION: return "NEM unrecoverable exception";
case NEMEXITTYPE_INVALID_VP_REGISTER_VALUE: return "NEM invalid vp register value";
case NEMEXITTYPE_XCPT_UD: return "NEM #UD";
case NEMEXITTYPE_XCPT_DB: return "NEM #DB";
case NEMEXITTYPE_XCPT_BP: return "NEM #BP";
case NEMEXITTYPE_CANCELED: return "NEM canceled";
case NEMEXITTYPE_MEMORY_ACCESS: return "NEM memory access";
case NEMEXITTYPE_INTERNAL_ERROR_EMULATION: return "NEM emulation IPE";
case NEMEXITTYPE_INTERNAL_ERROR_FATAL: return "NEM fatal IPE";
case NEMEXITTYPE_INTERRUPTED: return "NEM interrupted";
case NEMEXITTYPE_FAILED_ENTRY: return "NEM failed VT-x/AMD-V entry";
case NEMEXITTYPE_INVALID:
case NEMEXITTYPE_END:
break;
}
return NULL;
}
VMMR3_INT_DECL(VBOXSTRICTRC) NEMR3RunGC(PVM pVM, PVMCPU pVCpu)
{
Assert(VM_IS_NEM_ENABLED(pVM));
#ifdef VBOX_WITH_NATIVE_NEM
return nemR3NativeRunGC(pVM, pVCpu);
#else
NOREF(pVM); NOREF(pVCpu);
return VERR_INTERNAL_ERROR_3;
#endif
}
#ifndef VBOX_WITH_NATIVE_NEM
VMMR3_INT_DECL(bool) NEMR3CanExecuteGuest(PVM pVM, PVMCPU pVCpu)
{
RT_NOREF(pVM, pVCpu);
return false;
}
#endif
VMMR3_INT_DECL(bool) NEMR3SetSingleInstruction(PVM pVM, PVMCPU pVCpu, bool fEnable)
{
Assert(VM_IS_NEM_ENABLED(pVM));
#ifdef VBOX_WITH_NATIVE_NEM
return nemR3NativeSetSingleInstruction(pVM, pVCpu, fEnable);
#else
NOREF(pVM); NOREF(pVCpu); NOREF(fEnable);
return false;
#endif
}
VMMR3_INT_DECL(void) NEMR3NotifyFF(PVM pVM, PVMCPU pVCpu, uint32_t fFlags)
{
AssertLogRelReturnVoid(VM_IS_NEM_ENABLED(pVM));
#ifdef VBOX_WITH_NATIVE_NEM
nemR3NativeNotifyFF(pVM, pVCpu, fFlags);
#else
RT_NOREF(pVM, pVCpu, fFlags);
#endif
}
#ifndef VBOX_WITH_NATIVE_NEM
VMMR3_INT_DECL(void) NEMR3NotifySetA20(PVMCPU pVCpu, bool fEnabled)
{
RT_NOREF(pVCpu, fEnabled);
}
# ifdef VBOX_WITH_PGM_NEM_MODE
VMMR3_INT_DECL(bool) NEMR3IsMmio2DirtyPageTrackingSupported(PVM pVM)
{
RT_NOREF(pVM);
return false;
}
VMMR3_INT_DECL(int) NEMR3PhysMmio2QueryAndResetDirtyBitmap(PVM pVM, RTGCPHYS GCPhys, RTGCPHYS cb, uint32_t uNemRange,
void *pvBitmap, size_t cbBitmap)
{
RT_NOREF(pVM, GCPhys, cb, uNemRange, pvBitmap, cbBitmap);
AssertFailed();
return VERR_INTERNAL_ERROR_2;
}
VMMR3_INT_DECL(int) NEMR3NotifyPhysMmioExMapEarly(PVM pVM, RTGCPHYS GCPhys, RTGCPHYS cb, uint32_t fFlags,
void *pvRam, void *pvMmio2, uint8_t *pu2State, uint32_t *puNemRange)
{
RT_NOREF(pVM, GCPhys, cb, fFlags, pvRam, pvMmio2, pu2State, puNemRange);
AssertFailed();
return VERR_INTERNAL_ERROR_2;
}
# endif /* VBOX_WITH_PGM_NEM_MODE */
#endif /* !VBOX_WITH_NATIVE_NEM */
/**
* Notification callback from DBGF when interrupt breakpoints or generic debug
* event settings changes.
*
* DBGF will call NEMR3NotifyDebugEventChangedPerCpu on each CPU afterwards, this
* function is just updating the VM globals.
*
* @param pVM The VM cross context VM structure.
* @thread EMT(0)
*/
VMMR3_INT_DECL(void) NEMR3NotifyDebugEventChanged(PVM pVM)
{
AssertLogRelReturnVoid(VM_IS_NEM_ENABLED(pVM));
#ifdef VBOX_WITH_NATIVE_NEM
/* Interrupts. */
bool fUseDebugLoop = pVM->dbgf.ro.cSoftIntBreakpoints > 0
|| pVM->dbgf.ro.cHardIntBreakpoints > 0;
/* CPU Exceptions. */
for (DBGFEVENTTYPE enmEvent = DBGFEVENT_XCPT_FIRST;
!fUseDebugLoop && enmEvent <= DBGFEVENT_XCPT_LAST;
enmEvent = (DBGFEVENTTYPE)(enmEvent + 1))
fUseDebugLoop = DBGF_IS_EVENT_ENABLED(pVM, enmEvent);
/* Common VM exits. */
for (DBGFEVENTTYPE enmEvent = DBGFEVENT_EXIT_FIRST;
!fUseDebugLoop && enmEvent <= DBGFEVENT_EXIT_LAST_COMMON;
enmEvent = (DBGFEVENTTYPE)(enmEvent + 1))
fUseDebugLoop = DBGF_IS_EVENT_ENABLED(pVM, enmEvent);
/* Done. */
pVM->nem.s.fUseDebugLoop = nemR3NativeNotifyDebugEventChanged(pVM, fUseDebugLoop);
#else
RT_NOREF(pVM);
#endif
}
/**
* Follow up notification callback to NEMR3NotifyDebugEventChanged for each CPU.
*
* NEM uses this to combine the decision made NEMR3NotifyDebugEventChanged with
* per CPU settings.
*
* @param pVM The VM cross context VM structure.
* @param pVCpu The cross context virtual CPU structure of the calling EMT.
*/
VMMR3_INT_DECL(void) NEMR3NotifyDebugEventChangedPerCpu(PVM pVM, PVMCPU pVCpu)
{
AssertLogRelReturnVoid(VM_IS_NEM_ENABLED(pVM));
#ifdef VBOX_WITH_NATIVE_NEM
pVCpu->nem.s.fUseDebugLoop = nemR3NativeNotifyDebugEventChangedPerCpu(pVM, pVCpu,
pVCpu->nem.s.fSingleInstruction | pVM->nem.s.fUseDebugLoop);
#else
RT_NOREF(pVM, pVCpu);
#endif
}
/**
* Disables a CPU ISA extension, like MONITOR/MWAIT.
*
* @returns VBox status code
* @param pVM The cross context VM structure.
* @param pszIsaExt The ISA extension name in the config tree.
*/
int nemR3DisableCpuIsaExt(PVM pVM, const char *pszIsaExt)
{
/*
* Get IsaExts config node under CPUM.
*/
PCFGMNODE pIsaExts = CFGMR3GetChild(CFGMR3GetRoot(pVM), "/CPUM/IsaExts");
if (!pIsaExts)
{
int rc = CFGMR3InsertNode(CFGMR3GetRoot(pVM), "/CPUM/IsaExts", &pIsaExts);
AssertLogRelMsgReturn(RT_SUCCESS(rc), ("CFGMR3InsertNode: rc=%Rrc pszIsaExt=%s\n", rc, pszIsaExt), rc);
}
/*
* Look for a value by the given name (pszIsaExt).
*/
/* Integer values 1 (CPUMISAEXTCFG_ENABLED_SUPPORTED) and 9 (CPUMISAEXTCFG_ENABLED_PORTABLE) will be replaced. */
uint64_t u64Value;
int rc = CFGMR3QueryInteger(pIsaExts, pszIsaExt, &u64Value);
if (RT_SUCCESS(rc))
{
if (u64Value != 1 && u64Value != 9)
{
LogRel(("NEM: Not disabling IsaExt '%s', already configured with int value %lld\n", pszIsaExt, u64Value));
return VINF_SUCCESS;
}
CFGMR3RemoveValue(pIsaExts, pszIsaExt);
}
/* String value 'default', 'enabled' and 'portable' will be replaced. */
else if (rc == VERR_CFGM_NOT_INTEGER)
{
char szValue[32];
rc = CFGMR3QueryString(pIsaExts, pszIsaExt, szValue, sizeof(szValue));
AssertRCReturn(rc, VINF_SUCCESS);
if ( RTStrICmpAscii(szValue, "default") != 0
&& RTStrICmpAscii(szValue, "def") != 0
&& RTStrICmpAscii(szValue, "enabled") != 0
&& RTStrICmpAscii(szValue, "enable") != 0
&& RTStrICmpAscii(szValue, "on") != 0
&& RTStrICmpAscii(szValue, "yes") != 0
&& RTStrICmpAscii(szValue, "portable") != 0)
{
LogRel(("NEM: Not disabling IsaExt '%s', already configured with string value '%s'\n", pszIsaExt, szValue));
return VINF_SUCCESS;
}
CFGMR3RemoveValue(pIsaExts, pszIsaExt);
}
else
AssertLogRelMsgReturn(rc == VERR_CFGM_VALUE_NOT_FOUND, ("CFGMR3QueryInteger: rc=%Rrc pszIsaExt=%s\n", rc, pszIsaExt),
VERR_NEM_IPE_8);
/*
* Insert the disabling value.
*/
rc = CFGMR3InsertInteger(pIsaExts, pszIsaExt, 0 /* disabled */);
AssertLogRelMsgReturn(RT_SUCCESS(rc), ("CFGMR3InsertInteger: rc=%Rrc pszIsaExt=%s\n", rc, pszIsaExt), rc);
return VINF_SUCCESS;
}
|