Merging upstream version 1:9.18.24.

Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>

3 files changed, 253 insertions, 255 deletions

diff --git a/bin/tests/system/nsec3/ns3/setup.sh b/bin/tests/system/nsec3/ns3/setup.sh
index 68bc2e4..5ddcfc0 100644
--- a/bin/tests/system/nsec3/ns3/setup.sh
+++ b/bin/tests/system/nsec3/ns3/setup.sh
@@ -17,44 +17,44 @@
 echo_i "ns3/setup.sh"
 
 setup() {
-	zone="$1"
-	echo_i "setting up zone: $zone"
-	zonefile="${zone}.db"
-	infile="${zone}.db.infile"
-	cp template.db.in "$zonefile"
+  zone="$1"
+  echo_i "setting up zone: $zone"
+  zonefile="${zone}.db"
+  infile="${zone}.db.infile"
+  cp template.db.in "$zonefile"
 }
 
 for zn in nsec-to-nsec3 nsec3 nsec3-other nsec3-change nsec3-to-nsec \
-	  nsec3-to-optout nsec3-from-optout nsec3-dynamic \
-	  nsec3-dynamic-change nsec3-dynamic-to-inline \
-	  nsec3-inline-to-dynamic nsec3-dynamic-update-inline
-do
-	setup "${zn}.kasp"
+  nsec3-to-optout nsec3-from-optout nsec3-dynamic \
+  nsec3-dynamic-change nsec3-dynamic-to-inline \
+  nsec3-inline-to-dynamic nsec3-dynamic-update-inline; do
+  setup "${zn}.kasp"
 done
 
-if (cd ..; $SHELL ../testcrypto.sh -q RSASHA1)
-then
-	for zn in rsasha1-to-nsec3 rsasha1-to-nsec3-wait nsec3-to-rsasha1 \
-		  nsec3-to-rsasha1-ds
-	do
-		setup "${zn}.kasp"
-	done
-
-	longago="now-1y"
-	keytimes="-P ${longago} -A ${longago}"
-	O="omnipresent"
-
-	zone="rsasha1-to-nsec3-wait.kasp"
-	CSK=$($KEYGEN -k "rsasha1" -l named.conf $keytimes $zone 2> keygen.out.$zone)
-	echo_i "Created key file $CSK"
-	$SETTIME -s -g $O -k $O $longago -r $O $longago -z $O $longago -d $O $longago "$CSK" > settime.out.$zone 2>&1
-
-	zone="nsec3-to-rsasha1-ds.kasp"
-	CSK=$($KEYGEN -k "default" -l named.conf $keytimes $zone 2> keygen.out.$zone)
-	echo_i "Created key file $CSK"
-	$SETTIME -s -g $O -k $O $longago -r $O $longago -z $O $longago -d $O $longago "$CSK" > settime.out.$zone 2>&1
+if (
+  cd ..
+  $SHELL ../testcrypto.sh -q RSASHA1
+); then
+  for zn in rsasha1-to-nsec3 rsasha1-to-nsec3-wait nsec3-to-rsasha1 \
+    nsec3-to-rsasha1-ds; do
+    setup "${zn}.kasp"
+  done
+
+  longago="now-1y"
+  keytimes="-P ${longago} -A ${longago}"
+  O="omnipresent"
+
+  zone="rsasha1-to-nsec3-wait.kasp"
+  CSK=$($KEYGEN -k "rsasha1" -l named.conf $keytimes $zone 2>keygen.out.$zone)
+  echo_i "Created key file $CSK"
+  $SETTIME -s -g $O -k $O $longago -r $O $longago -z $O $longago -d $O $longago "$CSK" >settime.out.$zone 2>&1
+
+  zone="nsec3-to-rsasha1-ds.kasp"
+  CSK=$($KEYGEN -k "default" -l named.conf $keytimes $zone 2>keygen.out.$zone)
+  echo_i "Created key file $CSK"
+  $SETTIME -s -g $O -k $O $longago -r $O $longago -z $O $longago -d $O $longago "$CSK" >settime.out.$zone 2>&1
 else
-	echo_i "skip: skip rsasha1 zones - signing with RSASHA1 not supported"
+  echo_i "skip: skip rsasha1 zones - signing with RSASHA1 not supported"
 fi
 
 cp nsec3-fails-to-load.kasp.db.in nsec3-fails-to-load.kasp.db
diff --git a/bin/tests/system/nsec3/setup.sh b/bin/tests/system/nsec3/setup.sh
index bdd1ae9..3019361 100644
--- a/bin/tests/system/nsec3/setup.sh
+++ b/bin/tests/system/nsec3/setup.sh
@@ -20,11 +20,11 @@ $SHELL clean.sh
 
 copy_setports ns2/named.conf.in ns2/named.conf
 (
-	cd ns2
-	$SHELL setup.sh
+  cd ns2
+  $SHELL setup.sh
 )
 copy_setports ns3/named.conf.in ns3/named.conf
 (
-	cd ns3
-	$SHELL setup.sh
+  cd ns3
+  $SHELL setup.sh
 )
diff --git a/bin/tests/system/nsec3/tests.sh b/bin/tests/system/nsec3/tests.sh
index 117bf63..fc864a4 100644
--- a/bin/tests/system/nsec3/tests.sh
+++ b/bin/tests/system/nsec3/tests.sh
@@ -20,206 +20,206 @@ set -e
 
 # Log errors and increment $ret.
 log_error() {
-	echo_i "error: $1"
-	ret=$((ret+1))
+  echo_i "error: $1"
+  ret=$((ret + 1))
 }
 
 # Call dig with default options.
 dig_with_opts() {
-	$DIG +tcp +noadd +nosea +nostat +nocmd +dnssec -p "$PORT" "$@"
+  $DIG +tcp +noadd +nosea +nostat +nocmd +dnssec -p "$PORT" "$@"
 }
 
 # Call rndc.
 rndccmd() {
-    "$RNDC" -c ../common/rndc.conf -p "$CONTROLPORT" -s "$@"
+  "$RNDC" -c ../_common/rndc.conf -p "$CONTROLPORT" -s "$@"
 }
 
 # Set zone name ($1) and policy ($2) for testing nsec3.
 set_zone_policy() {
-	ZONE=$1
-	POLICY=$2
-	NUM_KEYS=$3
-	DNSKEY_TTL=$4
+  ZONE=$1
+  POLICY=$2
+  NUM_KEYS=$3
+  DNSKEY_TTL=$4
 }
 # Set expected NSEC3 parameters: flags ($1), iterations ($2), and
 # salt length ($3).
 set_nsec3param() {
-	FLAGS=$1
-	ITERATIONS=$2
-	SALTLEN=$3
-	# Reset salt.
-	SALT=""
+  FLAGS=$1
+  ITERATIONS=$2
+  SALTLEN=$3
+  # Reset salt.
+  SALT=""
 }
 
 # Set expected default dnssec-policy keys values.
 set_key_default_values() {
-	key_clear $1
-
-	set_keyrole      $1 "csk"
-	set_keylifetime  $1 "0"
-	set_keyalgorithm $1 "13" "ECDSAP256SHA256" "256"
-	set_keysigning   $1 "yes"
-	set_zonesigning  $1 "yes"
-
-	set_keystate $1 "GOAL"         "omnipresent"
-	set_keystate $1 "STATE_DNSKEY" "rumoured"
-	set_keystate $1 "STATE_KRRSIG" "rumoured"
-	set_keystate $1 "STATE_ZRRSIG" "rumoured"
-	set_keystate $1 "STATE_DS"     "hidden"
+  key_clear $1
+
+  set_keyrole $1 "csk"
+  set_keylifetime $1 "0"
+  set_keyalgorithm $1 "13" "ECDSAP256SHA256" "256"
+  set_keysigning $1 "yes"
+  set_zonesigning $1 "yes"
+
+  set_keystate $1 "GOAL" "omnipresent"
+  set_keystate $1 "STATE_DNSKEY" "rumoured"
+  set_keystate $1 "STATE_KRRSIG" "rumoured"
+  set_keystate $1 "STATE_ZRRSIG" "rumoured"
+  set_keystate $1 "STATE_DS" "hidden"
 }
 
 # Set expected rsasha1 dnssec-policy keys values.
 set_key_rsasha1_values() {
-	key_clear $1
-
-	set_keyrole      $1 "csk"
-	set_keylifetime  $1 "0"
-	set_keyalgorithm $1 "5" "RSASHA1" "2048"
-	set_keysigning   $1 "yes"
-	set_zonesigning  $1 "yes"
-
-	set_keystate $1 "GOAL"         "omnipresent"
-	set_keystate $1 "STATE_DNSKEY" "rumoured"
-	set_keystate $1 "STATE_KRRSIG" "rumoured"
-	set_keystate $1 "STATE_ZRRSIG" "rumoured"
-	set_keystate $1 "STATE_DS"     "hidden"
+  key_clear $1
+
+  set_keyrole $1 "csk"
+  set_keylifetime $1 "0"
+  set_keyalgorithm $1 "5" "RSASHA1" "2048"
+  set_keysigning $1 "yes"
+  set_zonesigning $1 "yes"
+
+  set_keystate $1 "GOAL" "omnipresent"
+  set_keystate $1 "STATE_DNSKEY" "rumoured"
+  set_keystate $1 "STATE_KRRSIG" "rumoured"
+  set_keystate $1 "STATE_ZRRSIG" "rumoured"
+  set_keystate $1 "STATE_DS" "hidden"
 }
 
 # Update the key states.
 set_key_states() {
-	set_keystate $1 "GOAL"         "$2"
-	set_keystate $1 "STATE_DNSKEY" "$3"
-	set_keystate $1 "STATE_KRRSIG" "$4"
-	set_keystate $1 "STATE_ZRRSIG" "$5"
-	set_keystate $1 "STATE_DS"     "$6"
+  set_keystate $1 "GOAL" "$2"
+  set_keystate $1 "STATE_DNSKEY" "$3"
+  set_keystate $1 "STATE_KRRSIG" "$4"
+  set_keystate $1 "STATE_ZRRSIG" "$5"
+  set_keystate $1 "STATE_DS" "$6"
 }
 
 # The apex NSEC3PARAM record indicates that it is signed.
 _wait_for_nsec3param() {
-	dig_with_opts +noquestion "@${SERVER}" "$ZONE" NSEC3PARAM > "dig.out.test$n.wait" || return 1
-	grep "${ZONE}\..*IN.*NSEC3PARAM.*1.*0.*${ITERATIONS}.*${SALT}" "dig.out.test$n.wait" > /dev/null || return 1
-	grep "${ZONE}\..*IN.*RRSIG" "dig.out.test$n.wait" > /dev/null || return 1
-        return 0
+  dig_with_opts +noquestion "@${SERVER}" "$ZONE" NSEC3PARAM >"dig.out.test$n.wait" || return 1
+  grep "${ZONE}\..*IN.*NSEC3PARAM.*1.*0.*${ITERATIONS}.*${SALT}" "dig.out.test$n.wait" >/dev/null || return 1
+  grep "${ZONE}\..*IN.*RRSIG" "dig.out.test$n.wait" >/dev/null || return 1
+  return 0
 }
 # The apex NSEC record indicates that it is signed.
 _wait_for_nsec() {
-	dig_with_opts +noquestion "@${SERVER}" "$ZONE" NSEC > "dig.out.test$n.wait" || return 1
-	grep "NS SOA" "dig.out.test$n.wait" > /dev/null || return 1
-	grep "${ZONE}\..*IN.*RRSIG" "dig.out.test$n.wait" > /dev/null || return 1
-	grep "${ZONE}\..*IN.*NSEC3PARAM" "dig.out.test$n.wait" > /dev/null && return 1
-        return 0
+  dig_with_opts +noquestion "@${SERVER}" "$ZONE" NSEC >"dig.out.test$n.wait" || return 1
+  grep "NS SOA" "dig.out.test$n.wait" >/dev/null || return 1
+  grep "${ZONE}\..*IN.*RRSIG" "dig.out.test$n.wait" >/dev/null || return 1
+  grep "${ZONE}\..*IN.*NSEC3PARAM" "dig.out.test$n.wait" >/dev/null && return 1
+  return 0
 }
 
 # Wait for the zone to be signed.
 wait_for_zone_is_signed() {
-	n=$((n+1))
-	ret=0
-	echo_i "wait for ${ZONE} to be signed with $1 ($n)"
-
-	if [ "$1" = "nsec3" ]; then
-		retry_quiet 10 _wait_for_nsec3param || log_error "wait for ${ZONE} to be signed failed"
-	else
-		retry_quiet 10 _wait_for_nsec || log_error "wait for ${ZONE} to be signed failed"
-	fi
-
-	test "$ret" -eq 0 || echo_i "failed"
-	status=$((status+ret))
+  n=$((n + 1))
+  ret=0
+  echo_i "wait for ${ZONE} to be signed with $1 ($n)"
+
+  if [ "$1" = "nsec3" ]; then
+    retry_quiet 10 _wait_for_nsec3param || log_error "wait for ${ZONE} to be signed failed"
+  else
+    retry_quiet 10 _wait_for_nsec || log_error "wait for ${ZONE} to be signed failed"
+  fi
+
+  test "$ret" -eq 0 || echo_i "failed"
+  status=$((status + ret))
 }
 
 # Test: check DNSSEC verify
 _check_dnssec_verify() {
-        dig_with_opts @$SERVER "${ZONE}" AXFR > "dig.out.test$n.axfr.$ZONE" || return 1
-        $VERIFY -z -o "$ZONE" "dig.out.test$n.axfr.$ZONE" > "verify.out.test$n.$ZONE" 2>&1 || return 1
-	return 0
+  dig_with_opts @$SERVER "${ZONE}" AXFR >"dig.out.test$n.axfr.$ZONE" || return 1
+  $VERIFY -z -o "$ZONE" "dig.out.test$n.axfr.$ZONE" >"verify.out.test$n.$ZONE" 2>&1 || return 1
+  return 0
 }
 
 # Test: check NSEC in answers
 _check_nsec_nsec3param() {
-	dig_with_opts +noquestion @$SERVER "${ZONE}" NSEC3PARAM > "dig.out.test$n.nsec3param.$ZONE" || return 1
-	grep "NSEC3PARAM" "dig.out.test$n.nsec3param.$ZONE" > /dev/null && return 1
-	return 0
+  dig_with_opts +noquestion @$SERVER "${ZONE}" NSEC3PARAM >"dig.out.test$n.nsec3param.$ZONE" || return 1
+  grep "NSEC3PARAM" "dig.out.test$n.nsec3param.$ZONE" >/dev/null && return 1
+  return 0
 }
 
 _check_nsec_nxdomain() {
-	dig_with_opts @$SERVER "nosuchname.${ZONE}" > "dig.out.test$n.nxdomain.$ZONE" || return 1
-	grep "${ZONE}.*IN.*NSEC.*NS.*SOA.*RRSIG.*NSEC.*DNSKEY" "dig.out.test$n.nxdomain.$ZONE" > /dev/null || return 1
-	grep "NSEC3" "dig.out.test$n.nxdomain.$ZONE" > /dev/null && return 1
-	return 0
+  dig_with_opts @$SERVER "nosuchname.${ZONE}" >"dig.out.test$n.nxdomain.$ZONE" || return 1
+  grep "${ZONE}.*IN.*NSEC.*NS.*SOA.*RRSIG.*NSEC.*DNSKEY" "dig.out.test$n.nxdomain.$ZONE" >/dev/null || return 1
+  grep "NSEC3" "dig.out.test$n.nxdomain.$ZONE" >/dev/null && return 1
+  return 0
 }
 
 check_nsec() {
-	wait_for_zone_is_signed "nsec"
-
-	n=$((n+1))
-	echo_i "check DNSKEY rrset is signed correctly for zone ${ZONE} ($n)"
-	ret=0
-	check_keys
-	retry_quiet 10 _check_apex_dnskey || log_error "bad DNSKEY RRset for zone ${ZONE}"
-	test "$ret" -eq 0 || echo_i "failed"
-	status=$((status+ret))
-
-	n=$((n+1))
-	echo_i "verify DNSSEC for zone ${ZONE} ($n)"
-	ret=0
-	retry_quiet 10 _check_dnssec_verify || log_error "DNSSEC verify failed for zone ${ZONE}"
-	test "$ret" -eq 0 || echo_i "failed"
-	status=$((status+ret))
-
-	n=$((n+1))
-	echo_i "check NSEC3PARAM response for zone ${ZONE} ($n)"
-	ret=0
-	retry_quiet 10 _check_nsec_nsec3param || log_error "unexpected NSEC3PARAM in response for zone ${ZONE}"
-	test "$ret" -eq 0 || echo_i "failed"
-	status=$((status+ret))
-
-	n=$((n+1))
-	echo_i "check NXDOMAIN response for zone ${ZONE} ($n)"
-	ret=0
-	retry_quiet 10 _check_nsec_nxdomain || log_error "bad NXDOMAIN response for zone ${ZONE}"
-	test "$ret" -eq 0 || echo_i "failed"
-	status=$((status+ret))
+  wait_for_zone_is_signed "nsec"
+
+  n=$((n + 1))
+  echo_i "check DNSKEY rrset is signed correctly for zone ${ZONE} ($n)"
+  ret=0
+  check_keys
+  retry_quiet 10 _check_apex_dnskey || log_error "bad DNSKEY RRset for zone ${ZONE}"
+  test "$ret" -eq 0 || echo_i "failed"
+  status=$((status + ret))
+
+  n=$((n + 1))
+  echo_i "verify DNSSEC for zone ${ZONE} ($n)"
+  ret=0
+  retry_quiet 10 _check_dnssec_verify || log_error "DNSSEC verify failed for zone ${ZONE}"
+  test "$ret" -eq 0 || echo_i "failed"
+  status=$((status + ret))
+
+  n=$((n + 1))
+  echo_i "check NSEC3PARAM response for zone ${ZONE} ($n)"
+  ret=0
+  retry_quiet 10 _check_nsec_nsec3param || log_error "unexpected NSEC3PARAM in response for zone ${ZONE}"
+  test "$ret" -eq 0 || echo_i "failed"
+  status=$((status + ret))
+
+  n=$((n + 1))
+  echo_i "check NXDOMAIN response for zone ${ZONE} ($n)"
+  ret=0
+  retry_quiet 10 _check_nsec_nxdomain || log_error "bad NXDOMAIN response for zone ${ZONE}"
+  test "$ret" -eq 0 || echo_i "failed"
+  status=$((status + ret))
 }
 
 # Test: check NSEC3 parameters in answers
 _check_nsec3_nsec3param() {
-	dig_with_opts +noquestion @$SERVER "${ZONE}" NSEC3PARAM > "dig.out.test$n.nsec3param.$ZONE" || return 1
-	grep "${ZONE}.*0.*IN.*NSEC3PARAM.*1.*0.*${ITERATIONS}.*${SALT}" "dig.out.test$n.nsec3param.$ZONE" > /dev/null || return 1
+  dig_with_opts +noquestion @$SERVER "${ZONE}" NSEC3PARAM >"dig.out.test$n.nsec3param.$ZONE" || return 1
+  grep "${ZONE}.*0.*IN.*NSEC3PARAM.*1.*0.*${ITERATIONS}.*${SALT}" "dig.out.test$n.nsec3param.$ZONE" >/dev/null || return 1
 
-	if [ -z "$SALT" ]; then
-		SALT=$(awk '$4 == "NSEC3PARAM" { print $8 }' dig.out.test$n.nsec3param.$ZONE)
-	fi
-	return 0
+  if [ -z "$SALT" ]; then
+    SALT=$(awk '$4 == "NSEC3PARAM" { print $8 }' dig.out.test$n.nsec3param.$ZONE)
+  fi
+  return 0
 }
 
 _check_nsec3_nxdomain() {
-	dig_with_opts @$SERVER "nosuchname.${ZONE}" > "dig.out.test$n.nxdomain.$ZONE" || return 1
-	grep ".*\.${ZONE}.*IN.*NSEC3.*1.${FLAGS}.*${ITERATIONS}.*${SALT}" "dig.out.test$n.nxdomain.$ZONE" > /dev/null || return 1
-	return 0
+  dig_with_opts @$SERVER "nosuchname.${ZONE}" >"dig.out.test$n.nxdomain.$ZONE" || return 1
+  grep ".*\.${ZONE}.*IN.*NSEC3.*1.${FLAGS}.*${ITERATIONS}.*${SALT}" "dig.out.test$n.nxdomain.$ZONE" >/dev/null || return 1
+  return 0
 }
 
 check_nsec3() {
-	wait_for_zone_is_signed "nsec3"
-
-	n=$((n+1))
-	echo_i "check that NSEC3PARAM 1 0 ${ITERATIONS} is published zone ${ZONE} ($n)"
-	ret=0
-	retry_quiet 10 _check_nsec3_nsec3param || log_error "bad NSEC3PARAM response for ${ZONE}"
-	test "$ret" -eq 0 || echo_i "failed"
-	status=$((status+ret))
-
-	n=$((n+1))
-	echo_i "check NXDOMAIN response has correct NSEC3 1 ${FLAGS} ${ITERATIONS} ${SALT} for zone ${ZONE} ($n)"
-	ret=0
-	retry_quiet 10 _check_nsec3_nxdomain || log_error "bad NXDOMAIN response for zone ${ZONE}"
-	test "$ret" -eq 0 || echo_i "failed"
-	status=$((status+ret))
-
-	n=$((n+1))
-	echo_i "verify DNSSEC for zone ${ZONE} ($n)"
-	ret=0
-	retry_quiet 10 _check_dnssec_verify || log_error "DNSSEC verify failed for zone ${ZONE}"
-	test "$ret" -eq 0 || echo_i "failed"
-	status=$((status+ret))
+  wait_for_zone_is_signed "nsec3"
+
+  n=$((n + 1))
+  echo_i "check that NSEC3PARAM 1 0 ${ITERATIONS} is published zone ${ZONE} ($n)"
+  ret=0
+  retry_quiet 10 _check_nsec3_nsec3param || log_error "bad NSEC3PARAM response for ${ZONE}"
+  test "$ret" -eq 0 || echo_i "failed"
+  status=$((status + ret))
+
+  n=$((n + 1))
+  echo_i "check NXDOMAIN response has correct NSEC3 1 ${FLAGS} ${ITERATIONS} ${SALT} for zone ${ZONE} ($n)"
+  ret=0
+  retry_quiet 10 _check_nsec3_nxdomain || log_error "bad NXDOMAIN response for zone ${ZONE}"
+  test "$ret" -eq 0 || echo_i "failed"
+  status=$((status + ret))
+
+  n=$((n + 1))
+  echo_i "verify DNSSEC for zone ${ZONE} ($n)"
+  ret=0
+  retry_quiet 10 _check_dnssec_verify || log_error "DNSSEC verify failed for zone ${ZONE}"
+  test "$ret" -eq 0 || echo_i "failed"
+  status=$((status + ret))
 }
 
 start_time="$(TZ=UTC date +%s)"
@@ -238,37 +238,36 @@ set_key_default_values "KEY1"
 echo_i "initial check zone ${ZONE}"
 check_nsec
 
-if ($SHELL ../testcrypto.sh -q RSASHA1)
-then
-	# Zone: rsasha1-to-nsec3.kasp.
-	set_zone_policy "rsasha1-to-nsec3.kasp" "rsasha1" 1 3600
-	set_server "ns3" "10.53.0.3"
-	set_key_rsasha1_values "KEY1"
-	echo_i "initial check zone ${ZONE}"
-	check_nsec
-
-	# Zone: rsasha1-to-nsec3-wait.kasp.
-	set_zone_policy "rsasha1-to-nsec3-wait.kasp" "rsasha1" 1 3600
-	set_server "ns3" "10.53.0.3"
-	set_key_rsasha1_values "KEY1"
-	set_key_states "KEY1" "omnipresent" "omnipresent" "omnipresent" "omnipresent" "omnipresent"
-	echo_i "initial check zone ${ZONE}"
-	check_nsec
-
-	# Zone: nsec3-to-rsasha1.kasp.
-	set_zone_policy "nsec3-to-rsasha1.kasp" "nsec3" 1 3600
-	set_server "ns3" "10.53.0.3"
-	set_key_rsasha1_values "KEY1"
-	echo_i "initial check zone ${ZONE}"
-	check_nsec3
-
-	# Zone: nsec3-to-rsasha1-ds.kasp.
-	set_zone_policy "nsec3-to-rsasha1-ds.kasp" "nsec3" 1 3600
-	set_server "ns3" "10.53.0.3"
-	set_key_rsasha1_values "KEY1"
-	set_key_states "KEY1" "omnipresent" "omnipresent" "omnipresent" "omnipresent" "omnipresent"
-	echo_i "initial check zone ${ZONE}"
-	check_nsec3
+if ($SHELL ../testcrypto.sh -q RSASHA1); then
+  # Zone: rsasha1-to-nsec3.kasp.
+  set_zone_policy "rsasha1-to-nsec3.kasp" "rsasha1" 1 3600
+  set_server "ns3" "10.53.0.3"
+  set_key_rsasha1_values "KEY1"
+  echo_i "initial check zone ${ZONE}"
+  check_nsec
+
+  # Zone: rsasha1-to-nsec3-wait.kasp.
+  set_zone_policy "rsasha1-to-nsec3-wait.kasp" "rsasha1" 1 3600
+  set_server "ns3" "10.53.0.3"
+  set_key_rsasha1_values "KEY1"
+  set_key_states "KEY1" "omnipresent" "omnipresent" "omnipresent" "omnipresent" "omnipresent"
+  echo_i "initial check zone ${ZONE}"
+  check_nsec
+
+  # Zone: nsec3-to-rsasha1.kasp.
+  set_zone_policy "nsec3-to-rsasha1.kasp" "nsec3" 1 3600
+  set_server "ns3" "10.53.0.3"
+  set_key_rsasha1_values "KEY1"
+  echo_i "initial check zone ${ZONE}"
+  check_nsec3
+
+  # Zone: nsec3-to-rsasha1-ds.kasp.
+  set_zone_policy "nsec3-to-rsasha1-ds.kasp" "nsec3" 1 3600
+  set_server "ns3" "10.53.0.3"
+  set_key_rsasha1_values "KEY1"
+  set_key_states "KEY1" "omnipresent" "omnipresent" "omnipresent" "omnipresent" "omnipresent"
+  echo_i "initial check zone ${ZONE}"
+  check_nsec3
 fi
 
 # Zone: nsec3.kasp.
@@ -355,10 +354,10 @@ set_key_default_values "KEY1"
 echo_i "initial check zone ${ZONE}"
 check_nsec
 
-n=$((n+1))
+n=$((n + 1))
 echo_i "dynamic update dnssec-policy zone ${ZONE} with NSEC3 ($n)"
 ret=0
-$NSUPDATE > update.out.$ZONE.test$n 2>&1 << END || ret=1
+$NSUPDATE >update.out.$ZONE.test$n 2>&1 <<END || ret=1
 server 10.53.0.3 ${PORT}
 zone ${ZONE}.
 update add 04O18462RI5903H8RDVL0QDT5B528DUJ.${ZONE}. 3600 NSEC3 0 0 0 408A4B2D412A4E95 1JMDDPMTFF8QQLIOINSIG4CR9OTICAOC A RRSIG
@@ -380,52 +379,51 @@ set_key_default_values "KEY1"
 echo_i "check zone ${ZONE} after reconfig"
 check_nsec3
 
-if ($SHELL ../testcrypto.sh -q RSASHA1)
-then
-	# Zone: rsasha1-to-nsec3.kasp.
-	set_zone_policy "rsasha1-to-nsec3.kasp" "nsec3" 2 3600
-	set_server "ns3" "10.53.0.3"
-	set_key_rsasha1_values "KEY1"
-	set_key_states "KEY1" "hidden" "unretentive" "unretentive" "unretentive" "hidden"
-	set_keysigning  "KEY1" "no"
-	set_zonesigning "KEY1" "no"
-	set_key_default_values "KEY2"
-	echo_i "check zone ${ZONE} after reconfig"
-	check_nsec3
-
-	# Zone: rsasha1-to-nsec3-wait.kasp.
-	set_zone_policy "rsasha1-to-nsec3-wait.kasp" "nsec3" 2 3600
-	set_server "ns3" "10.53.0.3"
-	set_key_rsasha1_values "KEY1"
-	set_key_states "KEY1" "hidden" "omnipresent" "omnipresent" "omnipresent" "omnipresent"
-	set_key_default_values "KEY2"
-	echo_i "check zone ${ZONE} after reconfig"
-	check_nsec
-
-	# Zone: nsec3-to-rsasha1.kasp.
-	set_zone_policy "nsec3-to-rsasha1.kasp" "rsasha1" 2 3600
-	set_nsec3param "1" "0" "0"
-	set_server "ns3" "10.53.0.3"
-	set_key_default_values "KEY1"
-	set_key_states  "KEY1" "hidden" "unretentive" "unretentive" "unretentive" "hidden"
-	set_keysigning  "KEY1" "no"
-	set_zonesigning "KEY1" "no"
-	set_key_rsasha1_values "KEY2"
-	echo_i "check zone ${ZONE} after reconfig"
-	check_nsec
-
-	# Zone: nsec3-to-rsasha1-ds.kasp.
-	set_zone_policy "nsec3-to-rsasha1-ds.kasp" "rsasha1" 2 3600
-	set_nsec3param "1" "0" "0"
-	set_server "ns3" "10.53.0.3"
-	set_key_default_values "KEY1"
-	set_key_states "KEY1" "hidden" "omnipresent" "omnipresent" "omnipresent" "omnipresent"
-	set_key_rsasha1_values "KEY2"
-	echo_i "check zone ${ZONE} after reconfig"
-	check_nsec
-
-	key_clear "KEY1"
-	key_clear "KEY2"
+if ($SHELL ../testcrypto.sh -q RSASHA1); then
+  # Zone: rsasha1-to-nsec3.kasp.
+  set_zone_policy "rsasha1-to-nsec3.kasp" "nsec3" 2 3600
+  set_server "ns3" "10.53.0.3"
+  set_key_rsasha1_values "KEY1"
+  set_key_states "KEY1" "hidden" "unretentive" "unretentive" "unretentive" "hidden"
+  set_keysigning "KEY1" "no"
+  set_zonesigning "KEY1" "no"
+  set_key_default_values "KEY2"
+  echo_i "check zone ${ZONE} after reconfig"
+  check_nsec3
+
+  # Zone: rsasha1-to-nsec3-wait.kasp.
+  set_zone_policy "rsasha1-to-nsec3-wait.kasp" "nsec3" 2 3600
+  set_server "ns3" "10.53.0.3"
+  set_key_rsasha1_values "KEY1"
+  set_key_states "KEY1" "hidden" "omnipresent" "omnipresent" "omnipresent" "omnipresent"
+  set_key_default_values "KEY2"
+  echo_i "check zone ${ZONE} after reconfig"
+  check_nsec
+
+  # Zone: nsec3-to-rsasha1.kasp.
+  set_zone_policy "nsec3-to-rsasha1.kasp" "rsasha1" 2 3600
+  set_nsec3param "1" "0" "0"
+  set_server "ns3" "10.53.0.3"
+  set_key_default_values "KEY1"
+  set_key_states "KEY1" "hidden" "unretentive" "unretentive" "unretentive" "hidden"
+  set_keysigning "KEY1" "no"
+  set_zonesigning "KEY1" "no"
+  set_key_rsasha1_values "KEY2"
+  echo_i "check zone ${ZONE} after reconfig"
+  check_nsec
+
+  # Zone: nsec3-to-rsasha1-ds.kasp.
+  set_zone_policy "nsec3-to-rsasha1-ds.kasp" "rsasha1" 2 3600
+  set_nsec3param "1" "0" "0"
+  set_server "ns3" "10.53.0.3"
+  set_key_default_values "KEY1"
+  set_key_states "KEY1" "hidden" "omnipresent" "omnipresent" "omnipresent" "omnipresent"
+  set_key_rsasha1_values "KEY2"
+  echo_i "check zone ${ZONE} after reconfig"
+  check_nsec
+
+  key_clear "KEY1"
+  key_clear "KEY2"
 fi
 
 # Zone: nsec3.kasp. (same)
@@ -507,8 +505,8 @@ check_nsec3
 # Using rndc signing -nsec3param (should fail)
 set_zone_policy "nsec3-change.kasp" "nsec3-other" 1 3600
 echo_i "use rndc signing -nsec3param ${ZONE} to change NSEC3 settings"
-rndccmd $SERVER signing -nsec3param 1 1 12 ffff $ZONE > rndc.signing.test$n.$ZONE || log_error "failed to call rndc signing -nsec3param $ZONE"
-grep "zone uses dnssec-policy, use rndc dnssec command instead" rndc.signing.test$n.$ZONE > /dev/null || log_error "rndc signing -nsec3param should fail"
+rndccmd $SERVER signing -nsec3param 1 1 12 ffff $ZONE >rndc.signing.test$n.$ZONE || log_error "failed to call rndc signing -nsec3param $ZONE"
+grep "zone uses dnssec-policy, use rndc dnssec command instead" rndc.signing.test$n.$ZONE >/dev/null || log_error "rndc signing -nsec3param should fail"
 check_nsec3
 
 # Test NSEC3 and NSEC3PARAM is the same after restart
@@ -523,13 +521,13 @@ ret=0
 echo "stop ns3"
 stop_server --use-rndc --port ${CONTROLPORT} ${DIR} || ret=1
 test "$ret" -eq 0 || echo_i "failed"
-status=$((status+ret))
+status=$((status + ret))
 
 ret=0
 echo "start ns3"
 start_server --noclean --restart --port ${PORT} ${DIR}
 test "$ret" -eq 0 || echo_i "failed"
-status=$((status+ret))
+status=$((status + ret))
 
 prevsalt="${SALT}"
 set_zone_policy "nsec3.kasp" "nsec3" 1 3600