1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
|
"use strict";
const { Sampling } = ChromeUtils.importESModule(
"resource://gre/modules/components-utils/Sampling.sys.mjs"
);
async function cleanupStore(store) {
Assert.deepEqual(
store.getAllActiveExperiments(),
[],
"There should be no experiments active."
);
Assert.deepEqual(
store.getAllActiveRollouts(),
[],
"There should be no rollouts active"
);
// We need to call finalize first to ensure that any pending saves from
// JSONFile.saveSoon overwrite files on disk.
await store._store.finalize();
await IOUtils.remove(store._store.path);
}
/**
* onStartup()
* - should set call setExperimentActive for each active experiment
*/
add_task(async function test_onStartup_setExperimentActive_called() {
const manager = ExperimentFakes.manager();
const sandbox = sinon.createSandbox();
const experiments = [];
sandbox.stub(manager, "setExperimentActive");
sandbox.stub(manager.store, "init").resolves();
sandbox.stub(manager.store, "getAll").returns(experiments);
sandbox
.stub(manager.store, "get")
.callsFake(slug => experiments.find(expt => expt.slug === slug));
sandbox.stub(manager.store, "set");
const active = ["foo", "bar"].map(ExperimentFakes.experiment);
const inactive = ["baz", "qux"].map(slug =>
ExperimentFakes.experiment(slug, { active: false })
);
[...active, ...inactive].forEach(exp => experiments.push(exp));
await manager.onStartup();
active.forEach(exp =>
Assert.equal(
manager.setExperimentActive.calledWith(exp),
true,
`should call setExperimentActive for active experiment: ${exp.slug}`
)
);
inactive.forEach(exp =>
Assert.equal(
manager.setExperimentActive.calledWith(exp),
false,
`should not call setExperimentActive for inactive experiment: ${exp.slug}`
)
);
sandbox.restore();
await cleanupStore(manager.store);
});
add_task(async function test_onStartup_setRolloutActive_called() {
const manager = ExperimentFakes.manager();
const sandbox = sinon.createSandbox();
sandbox.stub(manager, "setExperimentActive");
sandbox.stub(manager.store, "init").resolves();
const active = ["foo", "bar"].map(ExperimentFakes.rollout);
sandbox.stub(manager.store, "getAll").returns(active);
sandbox
.stub(manager.store, "get")
.callsFake(slug => active.find(e => e.slug === slug));
sandbox.stub(manager.store, "set");
await manager.onStartup();
active.forEach(r =>
Assert.equal(
manager.setExperimentActive.calledWith(r),
true,
`should call setExperimentActive for rollout: ${r.slug}`
)
);
sandbox.restore();
await cleanupStore(manager.store);
});
add_task(async function test_startup_unenroll() {
Services.prefs.setBoolPref("app.shield.optoutstudies.enabled", false);
const store = ExperimentFakes.store();
const sandbox = sinon.createSandbox();
let recipe = ExperimentFakes.experiment("startup_unenroll", {
experimentType: "unittest",
source: "test",
});
// Test initializing ExperimentManager with an active
// recipe in the store. If the user has opted out it should
// unenroll.
await store.init();
let enrollmentPromise = new Promise(resolve =>
store.on(`update:${recipe.slug}`, resolve)
);
store.addEnrollment(recipe);
await enrollmentPromise;
const manager = ExperimentFakes.manager(store);
const unenrollSpy = sandbox.spy(manager, "unenroll");
await manager.onStartup();
Assert.ok(
unenrollSpy.calledOnce,
"Unenrolled from active experiment if user opt out is true"
);
Assert.ok(
unenrollSpy.calledWith("startup_unenroll", "studies-opt-out"),
"Called unenroll for expected recipe"
);
Services.prefs.clearUserPref("app.shield.optoutstudies.enabled");
await cleanupStore(manager.store);
});
/**
* onRecipe()
* - should add recipe slug to .session[source]
* - should call .enroll() if the recipe hasn't been seen before;
* - should call .update() if the Enrollment already exists in the store;
* - should skip enrollment if recipe.isEnrollmentPaused is true
*/
add_task(async function test_onRecipe_track_slug() {
const manager = ExperimentFakes.manager();
const sandbox = sinon.createSandbox();
sandbox.spy(manager, "enroll");
sandbox.spy(manager, "updateEnrollment");
const fooRecipe = ExperimentFakes.recipe("foo");
fooRecipe.bucketConfig.start = 0;
fooRecipe.bucketConfig.count = 0;
await manager.onStartup();
// The first time a recipe has seen;
await manager.onRecipe(fooRecipe, "test");
Assert.equal(
manager.sessions.get("test").has("foo"),
true,
"should add slug to sessions[test]"
);
await cleanupStore(manager.store);
});
add_task(async function test_onRecipe_enroll() {
const manager = ExperimentFakes.manager();
const sandbox = sinon.createSandbox();
sandbox.stub(manager, "isInBucketAllocation").resolves(true);
sandbox.stub(Sampling, "bucketSample").resolves(true);
sandbox.spy(manager, "enroll");
sandbox.spy(manager, "updateEnrollment");
const fooRecipe = ExperimentFakes.recipe("foo");
await manager.onStartup();
Assert.deepEqual(
manager.store.getAllActiveExperiments(),
[],
"There should be no active experiments"
);
await manager.onRecipe(fooRecipe, "test");
Assert.equal(
manager.enroll.calledWith(fooRecipe),
true,
"should call .enroll() the first time a recipe is seen"
);
Assert.equal(
manager.store.has("foo"),
true,
"should add recipe to the store"
);
manager.unenroll(fooRecipe.slug, "test-cleanup");
await cleanupStore(manager.store);
});
add_task(async function test_onRecipe_update() {
const manager = ExperimentFakes.manager();
const sandbox = sinon.createSandbox();
sandbox.spy(manager, "enroll");
sandbox.spy(manager, "updateEnrollment");
sandbox.stub(manager, "isInBucketAllocation").resolves(true);
const fooRecipe = ExperimentFakes.recipe("foo");
const experimentUpdate = new Promise(resolve =>
manager.store.on(`update:${fooRecipe.slug}`, resolve)
);
await manager.onStartup();
await manager.onRecipe(fooRecipe, "test");
// onRecipe calls enroll which saves the experiment in the store
// but none of them wait on disk operations to finish
await experimentUpdate;
// Call again after recipe has already been enrolled
await manager.onRecipe(fooRecipe, "test");
Assert.equal(
manager.updateEnrollment.calledWith(fooRecipe),
true,
"should call .updateEnrollment() if the recipe has already been enrolled"
);
manager.unenroll(fooRecipe.slug, "test-cleanup");
await cleanupStore(manager.store);
});
add_task(async function test_onRecipe_rollout_update() {
const manager = ExperimentFakes.manager();
const sandbox = sinon.createSandbox();
sandbox.spy(manager, "enroll");
sandbox.spy(manager, "unenroll");
sandbox.spy(manager, "updateEnrollment");
sandbox.stub(manager, "isInBucketAllocation").resolves(true);
const fooRecipe = {
...ExperimentFakes.recipe("foo"),
isRollout: true,
};
// Rollouts should only have 1 branch
fooRecipe.branches = fooRecipe.branches.slice(0, 1);
await manager.onStartup();
await manager.onRecipe(fooRecipe, "test");
// onRecipe calls enroll which saves the experiment in the store
// but none of them wait on disk operations to finish
// Call again after recipe has already been enrolled
await manager.onRecipe(fooRecipe, "test");
Assert.equal(
manager.updateEnrollment.calledWith(fooRecipe),
true,
"should call .updateEnrollment() if the recipe has already been enrolled"
);
Assert.ok(
manager.updateEnrollment.alwaysReturned(Promise.resolve(true)),
"updateEnrollment will confirm the enrolled branch still exists in the recipe and exit"
);
Assert.ok(
manager.unenroll.notCalled,
"Should not call if the branches did not change"
);
// We call again but this time we change the branch slug
// Has to be a deep clone otherwise you're changing the
// value found in the experiment store
let recipeClone = Cu.cloneInto(fooRecipe, {});
recipeClone.branches[0].slug = "control-v2";
await manager.onRecipe(recipeClone, "test");
Assert.equal(
manager.updateEnrollment.calledWith(recipeClone),
true,
"should call .updateEnrollment() if the recipe has already been enrolled"
);
Assert.ok(
manager.unenroll.called,
"updateEnrollment will unenroll because the branch slug changed"
);
Assert.ok(
manager.unenroll.calledWith(fooRecipe.slug, "branch-removed"),
"updateEnrollment will unenroll because the branch slug changed"
);
await cleanupStore(manager.store);
});
add_task(async function test_onRecipe_isEnrollmentPaused() {
const manager = ExperimentFakes.manager();
const sandbox = sinon.createSandbox();
sandbox.spy(manager, "enroll");
sandbox.spy(manager, "updateEnrollment");
await manager.onStartup();
const pausedRecipe = ExperimentFakes.recipe("xyz", {
isEnrollmentPaused: true,
});
await manager.onRecipe(pausedRecipe, "test");
Assert.equal(
manager.enroll.calledWith(pausedRecipe),
false,
"should skip enrollment for recipes that are paused"
);
Assert.equal(
manager.store.has("xyz"),
false,
"should not add recipe to the store"
);
const fooRecipe = ExperimentFakes.recipe("foo");
const updatedRecipe = ExperimentFakes.recipe("foo", {
isEnrollmentPaused: true,
});
await manager.enroll(fooRecipe, "test");
await manager.onRecipe(updatedRecipe, "test");
Assert.equal(
manager.updateEnrollment.calledWith(updatedRecipe),
true,
"should still update existing recipes, even if enrollment is paused"
);
manager.unenroll(fooRecipe.slug);
await cleanupStore(manager.store);
});
/**
* onFinalize()
* - should unenroll experiments that weren't seen in the current session
*/
add_task(async function test_onFinalize_unenroll() {
const manager = ExperimentFakes.manager();
const sandbox = sinon.createSandbox();
sandbox.spy(manager, "unenroll");
await manager.onStartup();
// Add an experiment to the store without calling .onRecipe
// This simulates an enrollment having happened in the past.
let recipe0 = ExperimentFakes.experiment("foo", {
experimentType: "unittest",
userFacingName: "foo",
userFacingDescription: "foo",
lastSeen: new Date().toJSON(),
source: "test",
});
await manager.store.addEnrollment(recipe0);
const recipe1 = ExperimentFakes.recipe("bar");
// Unique features to prevent overlap
recipe1.branches[0].features[0].featureId = "red";
recipe1.branches[1].features[0].featureId = "red";
await manager.onRecipe(recipe1, "test");
const recipe2 = ExperimentFakes.recipe("baz");
recipe2.branches[0].features[0].featureId = "green";
recipe2.branches[1].features[0].featureId = "green";
await manager.onRecipe(recipe2, "test");
// Finalize
manager.onFinalize("test");
Assert.equal(
manager.unenroll.callCount,
1,
"should only call unenroll for the unseen recipe"
);
Assert.equal(
manager.unenroll.calledWith("foo", "recipe-not-seen"),
true,
"should unenroll a experiment whose recipe wasn't seen in the current session"
);
Assert.equal(
manager.sessions.has("test"),
false,
"should clear sessions[test]"
);
manager.unenroll(recipe1.slug);
manager.unenroll(recipe2.slug);
await cleanupStore(manager.store);
});
add_task(async function test_onFinalize_unenroll_mismatch() {
const manager = ExperimentFakes.manager();
const sandbox = sinon.createSandbox();
sandbox.spy(manager, "unenroll");
await manager.onStartup();
// Add an experiment to the store without calling .onRecipe
// This simulates an enrollment having happened in the past.
let recipe0 = ExperimentFakes.experiment("foo", {
experimentType: "unittest",
userFacingName: "foo",
userFacingDescription: "foo",
lastSeen: new Date().toJSON(),
source: "test",
});
await manager.store.addEnrollment(recipe0);
const recipe1 = ExperimentFakes.recipe("bar");
// Unique features to prevent overlap
recipe1.branches[0].features[0].featureId = "red";
recipe1.branches[1].features[0].featureId = "red";
await manager.onRecipe(recipe1, "test");
const recipe2 = ExperimentFakes.recipe("baz");
recipe2.branches[0].features[0].featureId = "green";
recipe2.branches[1].features[0].featureId = "green";
await manager.onRecipe(recipe2, "test");
// Finalize
manager.onFinalize("test", { recipeMismatches: [recipe0.slug] });
Assert.equal(
manager.unenroll.callCount,
1,
"should only call unenroll for the unseen recipe"
);
Assert.equal(
manager.unenroll.calledWith("foo", "targeting-mismatch"),
true,
"should unenroll a experiment whose recipe wasn't seen in the current session"
);
Assert.equal(
manager.sessions.has("test"),
false,
"should clear sessions[test]"
);
manager.unenroll(recipe1.slug);
manager.unenroll(recipe2.slug);
await cleanupStore(manager.store);
});
add_task(async function test_onFinalize_rollout_unenroll() {
const manager = ExperimentFakes.manager();
const sandbox = sinon.createSandbox();
sandbox.spy(manager, "unenroll");
await manager.onStartup();
let rollout = ExperimentFakes.rollout("rollout");
await manager.store.addEnrollment(rollout);
manager.onFinalize("NimbusTestUtils");
Assert.equal(
manager.unenroll.callCount,
1,
"should only call unenroll for the unseen recipe"
);
Assert.equal(
manager.unenroll.calledWith("rollout", "recipe-not-seen"),
true,
"should unenroll a experiment whose recipe wasn't seen in the current session"
);
await cleanupStore(manager.store);
});
|