/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ /* * This file is part of the LibreOffice project. * * This Source Code Form is subject to the terms of the Mozilla Public * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include using namespace com::sun::star; namespace { class DrawinglayerBorderTest : public test::BootstrapFixture { }; CPPUNIT_TEST_FIXTURE(DrawinglayerBorderTest, testDoubleDecompositionSolid) { // Create a border line primitive that's similar to the one from the bugdoc: // 1.47 pixels is 0.03cm at 130% zoom and 96 DPI. basegfx::B2DPoint aStart(0, 20); basegfx::B2DPoint aEnd(100, 20); double const fLeftWidth = 1.47; double const fDistance = 1.47; double const fRightWidth = 1.47; double const fExtendLeftStart = 0; double const fExtendLeftEnd = 0; double const fExtendRightStart = 0; double const fExtendRightEnd = 0; basegfx::BColor aColorRight; basegfx::BColor aColorLeft; std::vector aDashing(svtools::GetLineDashing(SvxBorderLineStyle::DOUBLE, 10.0)); const drawinglayer::attribute::StrokeAttribute aStrokeAttribute(std::move(aDashing)); std::vector aBorderlines{ drawinglayer::primitive2d::BorderLine( drawinglayer::attribute::LineAttribute(aColorLeft, fLeftWidth), fExtendLeftStart, fExtendLeftStart, fExtendLeftEnd, fExtendLeftEnd), drawinglayer::primitive2d::BorderLine(fDistance), drawinglayer::primitive2d::BorderLine( drawinglayer::attribute::LineAttribute(aColorRight, fRightWidth), fExtendRightStart, fExtendRightStart, fExtendRightEnd, fExtendRightEnd) }; rtl::Reference aBorder( new drawinglayer::primitive2d::BorderLinePrimitive2D(aStart, aEnd, std::move(aBorderlines), aStrokeAttribute)); // Decompose it into polygons. drawinglayer::geometry::ViewInformation2D aView; drawinglayer::primitive2d::Primitive2DContainer aContainer; aBorder->get2DDecomposition(aContainer, aView); // Make sure it results in two borders as it's a double one. CPPUNIT_ASSERT_EQUAL(static_cast(2), aContainer.size()); // Get the inside line, now a PolygonStrokePrimitive2D auto pInside = dynamic_cast( aContainer[0].get()); CPPUNIT_ASSERT(pInside); // Make sure the inside line's height is fLeftWidth. const double fLineWidthFromDecompose = pInside->getLineAttribute().getWidth(); // This was 2.47, i.e. the width of the inner line was 1 unit (in the bugdoc's case: 1 pixel) wider than expected. CPPUNIT_ASSERT_DOUBLES_EQUAL(fLeftWidth, fLineWidthFromDecompose, basegfx::fTools::getSmallValue()); } CPPUNIT_TEST_FIXTURE(DrawinglayerBorderTest, testDoublePixelProcessing) { // Create a pixel processor. ScopedVclPtrInstance pDev; drawinglayer::geometry::ViewInformation2D aView; std::unique_ptr pProcessor( drawinglayer::processor2d::createBaseProcessor2DFromOutputDevice(*pDev, aView)); CPPUNIT_ASSERT(pProcessor); GDIMetaFile aMetaFile; // Start recording after the processor is created, so we can test the pixel processor. aMetaFile.Record(pDev); // Create a border line primitive that's similar to the one from the bugdoc: // 1.47 pixels is 0.03cm at 130% zoom and 96 DPI. basegfx::B2DPoint aStart(0, 20); basegfx::B2DPoint aEnd(100, 20); double const fLeftWidth = 1.47; double const fDistance = 1.47; double const fRightWidth = 1.47; double const fExtendLeftStart = 0; double const fExtendLeftEnd = 0; double const fExtendRightStart = 0; double const fExtendRightEnd = 0; basegfx::BColor aColorRight; basegfx::BColor aColorLeft; std::vector aDashing(svtools::GetLineDashing(SvxBorderLineStyle::DOUBLE, 10.0)); const drawinglayer::attribute::StrokeAttribute aStrokeAttribute(std::move(aDashing)); std::vector aBorderlines{ drawinglayer::primitive2d::BorderLine( drawinglayer::attribute::LineAttribute(aColorLeft, fLeftWidth), fExtendLeftStart, fExtendLeftStart, fExtendLeftEnd, fExtendLeftEnd), drawinglayer::primitive2d::BorderLine(fDistance), drawinglayer::primitive2d::BorderLine( drawinglayer::attribute::LineAttribute(aColorRight, fRightWidth), fExtendRightStart, fExtendRightStart, fExtendRightEnd, fExtendRightEnd) }; rtl::Reference aBorder( new drawinglayer::primitive2d::BorderLinePrimitive2D(aStart, aEnd, std::move(aBorderlines), aStrokeAttribute)); drawinglayer::primitive2d::Primitive2DContainer aPrimitives; aPrimitives.push_back(drawinglayer::primitive2d::Primitive2DReference(aBorder)); // Process the primitives. pProcessor->process(aPrimitives); // Double line now gets decomposed in Metafile to painting four lines // with width == 0 in a cross pattern due to real line width being between // 1.0 and 2.0. Count created lines aMetaFile.Stop(); aMetaFile.WindStart(); sal_uInt32 nPolyLineActionCount = 0; for (std::size_t nAction = 0; nAction < aMetaFile.GetActionSize(); ++nAction) { MetaAction* pAction = aMetaFile.GetAction(nAction); if (MetaActionType::POLYLINE == pAction->GetType()) { auto pMPLAction = static_cast(pAction); if (0 != pMPLAction->GetLineInfo().GetWidth() && LineStyle::Solid == pMPLAction->GetLineInfo().GetStyle()) { nPolyLineActionCount++; } } } // Check if all eight (2x four) simple lines with width == 0 and // solid were created // // This has changed: Now, just the needed 'real' lines get created // which have a width of 1. This are two lines. The former multiple // lines were a combination of view-dependent force to a single-pixel // line width (0 == lineWidth -> hairline) and vcl rendering this // using a (insane) combination of single non-AAed lines. All the // system-dependent part of the BorderLine stuff is now done in // SdrFrameBorderPrimitive2D and svx. // Adapted this test - still useful, breaking it may be a hint :-) const sal_uInt32 nExpectedNumPolyLineActions = 2; CPPUNIT_ASSERT_EQUAL(nExpectedNumPolyLineActions, nPolyLineActionCount); } } CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */