1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#ifndef LO_CLANG_SHARED_PLUGINS
#include <string>
#include <iostream>
#include <map>
#include <set>
#include "plugin.hxx"
#include "config_clang.h"
#include "clang/AST/CXXInheritance.h"
/**
* Check for data member being shadowed.
*
* @TODO check for any members in superclass hierarchy with duplicate names,
* regardless of their visibility,
* more specific names will make the code easier to read
*/
namespace
{
class DataMemberShadow:
public loplugin::FilteringPlugin<DataMemberShadow>
{
public:
explicit DataMemberShadow(loplugin::InstantiationData const & data):
FilteringPlugin(data) {}
virtual void run() override {
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
bool VisitFieldDecl(FieldDecl const *);
};
bool DataMemberShadow::VisitFieldDecl(FieldDecl const * fieldDecl)
{
if (ignoreLocation(fieldDecl)) {
return true;
}
StringRef aFileName = getFilenameOfLocation(
compiler.getSourceManager().getSpellingLoc(fieldDecl->getBeginLoc()));
// FIXME complex stuff to fix later
if (loplugin::hasPathnamePrefix(aFileName, SRCDIR "/chart2/source/"))
return true;
if (loplugin::isSamePathname(aFileName, SRCDIR "/include/sfx2/recentdocsview.hxx"))
return true;
if (loplugin::isSamePathname(aFileName, SRCDIR "/include/sfx2/templatelocalview.hxx"))
return true;
if (loplugin::isSamePathname(aFileName, SRCDIR "/store/source/stortree.hxx")
|| loplugin::isSamePathname(aFileName, SRCDIR "/store/source/stordata.hxx"))
return true;
if (loplugin::isSamePathname(aFileName, SRCDIR "/sw/source/uibase/inc/dbtree.hxx"))
return true;
const CXXRecordDecl* parentCXXRecordDecl = dyn_cast<CXXRecordDecl>(fieldDecl->getDeclContext());
if (!parentCXXRecordDecl) {
return true;
}
fieldDecl = fieldDecl->getCanonicalDecl();
auto BaseMatchesCallback = [&](const CXXBaseSpecifier *cxxBaseSpecifier, CXXBasePath& Paths)
{
if (!cxxBaseSpecifier->getType().getTypePtr())
return false;
const CXXRecordDecl* baseCXXRecordDecl = cxxBaseSpecifier->getType()->getAsCXXRecordDecl();
if (!baseCXXRecordDecl)
return false;
if (baseCXXRecordDecl->isInvalidDecl())
return false;
for (const FieldDecl* baseFieldDecl : baseCXXRecordDecl->fields())
{
// TODO look for overlaps even with private fields
if (baseFieldDecl->getAccess() == AS_private
|| !baseFieldDecl->getDeclName().isIdentifier()
|| fieldDecl->getName() != baseFieldDecl->getName()) {
continue;
}
std::string sPath;
for (CXXBasePathElement const & pathElement : Paths) {
if (!sPath.empty()) {
sPath += "->";
}
sPath += pathElement.Class->getNameAsString();
}
sPath += "->";
sPath += baseCXXRecordDecl->getNameAsString();
report(DiagnosticsEngine::Warning,
"data member %0 is shadowing member in superclass, through inheritance path %1",
fieldDecl->getBeginLoc())
<< fieldDecl->getName()
<< sPath
<< fieldDecl->getSourceRange();
report(DiagnosticsEngine::Note,
"superclass member here",
baseFieldDecl->getBeginLoc())
<< baseFieldDecl->getSourceRange();
}
return false;
};
CXXBasePaths aPaths;
parentCXXRecordDecl->lookupInBases(BaseMatchesCallback, aPaths);
return true;
}
loplugin::Plugin::Registration< DataMemberShadow > datamembershadow("datamembershadow", true);
}
#endif // LO_CLANG_SHARED_PLUGINS
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
