summaryrefslogtreecommitdiffstats
path: root/src/jaegertracing/thrift/doc/committers.md
diff options
context:
space:
mode:
Diffstat (limited to '')
-rw-r--r--src/jaegertracing/thrift/doc/committers.md53
1 files changed, 53 insertions, 0 deletions
diff --git a/src/jaegertracing/thrift/doc/committers.md b/src/jaegertracing/thrift/doc/committers.md
new file mode 100644
index 000000000..2326711d9
--- /dev/null
+++ b/src/jaegertracing/thrift/doc/committers.md
@@ -0,0 +1,53 @@
+## Process used by committers to review and submit patches
+
+1. Make sure that there is an issue for the patch(s) you are about to commit in our [Jira issue tracker](http://issues.apache.org/jira/browse/THRIFT)
+
+1. Check out the latest version of the source code
+
+ * git clone https://github.com/apache/thrift.git thrift
+
+1. Apply the patch
+
+ * curl https://issues.apache.org/jira/... |git apply --ignore-space-change
+
+ or
+
+ * curl https://github.com/<GitHub User>/thrift/commit/<Commit ID>.patch |git apply --ignore-space-change
+
+
+1. Inspect the applied patch to ensure that all [Legal aspects on Submission of Contributions (Patches)](http://www.apache.org/licenses/LICENSE-2.0.html#contributions) are met
+
+1. Run the necessary unit tests and cross language test cases to verify the patch
+
+1. Commit the patch
+
+ git --config user.name "Your Name"
+ git --config user.email "YourApacheID@apache.org"
+ git add -A
+ git commit
+
+1. The commit message should be in the format:
+
+ THRIFT-####:<Jira description>
+ Client: <component>
+ Patch: <Name of person contributing the patch>
+
+ Description of what was fixed or addressed.
+
+ If this is a github pull request then add below comment to automaticaly close GitHub request,
+ where #NNNN is the PR number:
+
+ This closes #NNNN
+
+
+1. Double check the patch committed and that nothing was missed then push the patch
+
+ git status
+ git show HEAD
+ git push origin master
+
+
+1. Resolve the jira issue and set the following for the changelog
+
+ * Component the patch is for
+ * fixVersion to the current version on master