summaryrefslogtreecommitdiffstats
path: root/build/clang-plugin/ExplicitOperatorBoolChecker.cpp
diff options
context:
space:
mode:
Diffstat (limited to '')
-rw-r--r--build/clang-plugin/ExplicitOperatorBoolChecker.cpp31
1 files changed, 31 insertions, 0 deletions
diff --git a/build/clang-plugin/ExplicitOperatorBoolChecker.cpp b/build/clang-plugin/ExplicitOperatorBoolChecker.cpp
new file mode 100644
index 0000000000..ed97335a00
--- /dev/null
+++ b/build/clang-plugin/ExplicitOperatorBoolChecker.cpp
@@ -0,0 +1,31 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+#include "ExplicitOperatorBoolChecker.h"
+#include "CustomMatchers.h"
+
+void ExplicitOperatorBoolChecker::registerMatchers(MatchFinder *AstMatcher) {
+ AstMatcher->addMatcher(
+ cxxMethodDecl(allOf(isFirstParty(), hasName("operator bool")))
+ .bind("node"),
+ this);
+}
+
+void ExplicitOperatorBoolChecker::check(
+ const MatchFinder::MatchResult &Result) {
+ const CXXConversionDecl *Method =
+ Result.Nodes.getNodeAs<CXXConversionDecl>("node");
+ const CXXRecordDecl *Clazz = Method->getParent();
+
+ if (!Method->isExplicit() && !hasCustomAttribute<moz_implicit>(Method) &&
+ !ASTIsInSystemHeader(Method->getASTContext(), *Method) &&
+ isInterestingDeclForImplicitConversion(Method)) {
+ diag(Method->getBeginLoc(), "bad implicit conversion operator for %0",
+ DiagnosticIDs::Error)
+ << Clazz;
+ diag(Method->getBeginLoc(), "consider adding the explicit keyword to %0",
+ DiagnosticIDs::Note)
+ << "'operator bool'";
+ }
+}