1 files changed, 32 insertions, 0 deletions
diff --git a/build/clang-plugin/NoAddRefReleaseOnReturnChecker.cpp b/build/clang-plugin/NoAddRefReleaseOnReturnChecker.cpp
new file mode 100644
index 0000000000..e1c38fa6b2
--- /dev/null
+++ b/build/clang-plugin/NoAddRefReleaseOnReturnChecker.cpp
@@ -0,0 +1,32 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+#include "NoAddRefReleaseOnReturnChecker.h"
+#include "CustomMatchers.h"
+
+void NoAddRefReleaseOnReturnChecker::registerMatchers(MatchFinder *AstMatcher) {
+  // Look for all of the calls to AddRef() or Release()
+  AstMatcher->addMatcher(
+      memberExpr(isAddRefOrRelease(), hasParent(callExpr())).bind("member"),
+      this);
+}
+
+void NoAddRefReleaseOnReturnChecker::check(
+    const MatchFinder::MatchResult &Result) {
+  const MemberExpr *Member = Result.Nodes.getNodeAs<MemberExpr>("member");
+  const Expr *Base = IgnoreTrivials(Member->getBase());
+
+  // Check if the call to AddRef() or Release() was made on the result of a call
+  // to a MOZ_NO_ADDREF_RELEASE_ON_RETURN function or method.
+  if (auto *Call = dyn_cast<CallExpr>(Base)) {
+    if (auto *Callee = Call->getDirectCallee()) {
+      if (hasCustomAttribute<moz_no_addref_release_on_return>(Callee)) {
+        diag(Call->getBeginLoc(),
+             "%1 must not be called on the return value of '%0' which is marked with MOZ_NO_ADDREF_RELEASE_ON_RETURN",
+             DiagnosticIDs::Error)
+            << Callee->getQualifiedNameAsString() << dyn_cast<CXXMethodDecl>(Member->getMemberDecl());
+      }
+    }
+  }
+}