summaryrefslogtreecommitdiffstats
path: root/python/mozbuild/mozpack/test/test_packager.py
blob: 266902ebb250d2c404b923c64246b058fba24141 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

import os
import unittest

import mozunit
from buildconfig import topobjdir
from mozunit import MockedOpen

import mozpack.path as mozpath
from mozbuild.preprocessor import Preprocessor
from mozpack.chrome.manifest import (
    ManifestBinaryComponent,
    ManifestContent,
    ManifestResource,
)
from mozpack.errors import ErrorMessage, errors
from mozpack.files import GeneratedFile
from mozpack.packager import (
    CallDeque,
    Component,
    SimpleManifestSink,
    SimplePackager,
    preprocess_manifest,
)

MANIFEST = """
bar/*
[foo]
foo/*
-foo/bar
chrome.manifest
[zot destdir="destdir"]
foo/zot
; comment
#ifdef baz
[baz]
baz@SUFFIX@
#endif
"""


class TestPreprocessManifest(unittest.TestCase):
    MANIFEST_PATH = mozpath.join("$OBJDIR", "manifest")

    EXPECTED_LOG = [
        ((MANIFEST_PATH, 2), "add", "", "bar/*"),
        ((MANIFEST_PATH, 4), "add", "foo", "foo/*"),
        ((MANIFEST_PATH, 5), "remove", "foo", "foo/bar"),
        ((MANIFEST_PATH, 6), "add", "foo", "chrome.manifest"),
        ((MANIFEST_PATH, 8), "add", 'zot destdir="destdir"', "foo/zot"),
    ]

    def setUp(self):
        class MockSink(object):
            def __init__(self):
                self.log = []

            def add(self, component, path):
                self._log(errors.get_context(), "add", repr(component), path)

            def remove(self, component, path):
                self._log(errors.get_context(), "remove", repr(component), path)

            def _log(self, *args):
                self.log.append(args)

        self.sink = MockSink()
        self.cwd = os.getcwd()
        os.chdir(topobjdir)

    def tearDown(self):
        os.chdir(self.cwd)

    def test_preprocess_manifest(self):
        with MockedOpen({"manifest": MANIFEST}):
            preprocess_manifest(self.sink, "manifest")
        self.assertEqual(self.sink.log, self.EXPECTED_LOG)

    def test_preprocess_manifest_missing_define(self):
        with MockedOpen({"manifest": MANIFEST}):
            self.assertRaises(
                Preprocessor.Error,
                preprocess_manifest,
                self.sink,
                "manifest",
                {"baz": 1},
            )

    def test_preprocess_manifest_defines(self):
        with MockedOpen({"manifest": MANIFEST}):
            preprocess_manifest(self.sink, "manifest", {"baz": 1, "SUFFIX": ".exe"})
        self.assertEqual(
            self.sink.log,
            self.EXPECTED_LOG + [((self.MANIFEST_PATH, 12), "add", "baz", "baz.exe")],
        )


class MockFinder(object):
    def __init__(self, files):
        self.files = files
        self.log = []

    def find(self, path):
        self.log.append(path)
        for f in sorted(self.files):
            if mozpath.match(f, path):
                yield f, self.files[f]

    def __iter__(self):
        return self.find("")


class MockFormatter(object):
    def __init__(self):
        self.log = []

    def add_base(self, *args):
        self._log(errors.get_context(), "add_base", *args)

    def add_manifest(self, *args):
        self._log(errors.get_context(), "add_manifest", *args)

    def add_interfaces(self, *args):
        self._log(errors.get_context(), "add_interfaces", *args)

    def add(self, *args):
        self._log(errors.get_context(), "add", *args)

    def _log(self, *args):
        self.log.append(args)


class TestSimplePackager(unittest.TestCase):
    def test_simple_packager(self):
        class GeneratedFileWithPath(GeneratedFile):
            def __init__(self, path, content):
                GeneratedFile.__init__(self, content)
                self.path = path

        formatter = MockFormatter()
        packager = SimplePackager(formatter)
        curdir = os.path.abspath(os.curdir)
        file = GeneratedFileWithPath(
            os.path.join(curdir, "foo", "bar.manifest"),
            b"resource bar bar/\ncontent bar bar/",
        )
        with errors.context("manifest", 1):
            packager.add("foo/bar.manifest", file)

        file = GeneratedFileWithPath(
            os.path.join(curdir, "foo", "baz.manifest"), b"resource baz baz/"
        )
        with errors.context("manifest", 2):
            packager.add("bar/baz.manifest", file)

        with errors.context("manifest", 3):
            packager.add(
                "qux/qux.manifest",
                GeneratedFile(
                    b"".join(
                        [
                            b"resource qux qux/\n",
                            b"binary-component qux.so\n",
                        ]
                    )
                ),
            )
        bar_xpt = GeneratedFile(b"bar.xpt")
        qux_xpt = GeneratedFile(b"qux.xpt")
        foo_html = GeneratedFile(b"foo_html")
        bar_html = GeneratedFile(b"bar_html")
        with errors.context("manifest", 4):
            packager.add("foo/bar.xpt", bar_xpt)
        with errors.context("manifest", 5):
            packager.add("foo/bar/foo.html", foo_html)
            packager.add("foo/bar/bar.html", bar_html)

        file = GeneratedFileWithPath(
            os.path.join(curdir, "foo.manifest"),
            b"".join(
                [
                    b"manifest foo/bar.manifest\n",
                    b"manifest bar/baz.manifest\n",
                ]
            ),
        )
        with errors.context("manifest", 6):
            packager.add("foo.manifest", file)
        with errors.context("manifest", 7):
            packager.add("foo/qux.xpt", qux_xpt)

        file = GeneratedFileWithPath(
            os.path.join(curdir, "addon", "chrome.manifest"), b"resource hoge hoge/"
        )
        with errors.context("manifest", 8):
            packager.add("addon/chrome.manifest", file)

        install_rdf = GeneratedFile(b"<RDF></RDF>")
        with errors.context("manifest", 9):
            packager.add("addon/install.rdf", install_rdf)

        with errors.context("manifest", 10):
            packager.add("addon2/install.rdf", install_rdf)
            packager.add(
                "addon2/chrome.manifest", GeneratedFile(b"binary-component addon2.so")
            )

        with errors.context("manifest", 11):
            packager.add("addon3/install.rdf", install_rdf)
            packager.add(
                "addon3/chrome.manifest",
                GeneratedFile(b"manifest components/components.manifest"),
            )
            packager.add(
                "addon3/components/components.manifest",
                GeneratedFile(b"binary-component addon3.so"),
            )

        with errors.context("manifest", 12):
            install_rdf_addon4 = GeneratedFile(
                b"<RDF>\n<...>\n<em:unpack>true</em:unpack>\n<...>\n</RDF>"
            )
            packager.add("addon4/install.rdf", install_rdf_addon4)

        with errors.context("manifest", 13):
            install_rdf_addon5 = GeneratedFile(
                b"<RDF>\n<...>\n<em:unpack>false</em:unpack>\n<...>\n</RDF>"
            )
            packager.add("addon5/install.rdf", install_rdf_addon5)

        with errors.context("manifest", 14):
            install_rdf_addon6 = GeneratedFile(
                b"<RDF>\n<... em:unpack=true>\n<...>\n</RDF>"
            )
            packager.add("addon6/install.rdf", install_rdf_addon6)

        with errors.context("manifest", 15):
            install_rdf_addon7 = GeneratedFile(
                b"<RDF>\n<... em:unpack=false>\n<...>\n</RDF>"
            )
            packager.add("addon7/install.rdf", install_rdf_addon7)

        with errors.context("manifest", 16):
            install_rdf_addon8 = GeneratedFile(
                b'<RDF>\n<... em:unpack="true">\n<...>\n</RDF>'
            )
            packager.add("addon8/install.rdf", install_rdf_addon8)

        with errors.context("manifest", 17):
            install_rdf_addon9 = GeneratedFile(
                b'<RDF>\n<... em:unpack="false">\n<...>\n</RDF>'
            )
            packager.add("addon9/install.rdf", install_rdf_addon9)

        with errors.context("manifest", 18):
            install_rdf_addon10 = GeneratedFile(
                b"<RDF>\n<... em:unpack='true'>\n<...>\n</RDF>"
            )
            packager.add("addon10/install.rdf", install_rdf_addon10)

        with errors.context("manifest", 19):
            install_rdf_addon11 = GeneratedFile(
                b"<RDF>\n<... em:unpack='false'>\n<...>\n</RDF>"
            )
            packager.add("addon11/install.rdf", install_rdf_addon11)

        we_manifest = GeneratedFile(
            b'{"manifest_version": 2, "name": "Test WebExtension", "version": "1.0"}'
        )
        # hybrid and hybrid2 are both bootstrapped extensions with
        # embedded webextensions, they differ in the order in which
        # the manifests are added to the packager.
        with errors.context("manifest", 20):
            packager.add("hybrid/install.rdf", install_rdf)

        with errors.context("manifest", 21):
            packager.add("hybrid/webextension/manifest.json", we_manifest)

        with errors.context("manifest", 22):
            packager.add("hybrid2/webextension/manifest.json", we_manifest)

        with errors.context("manifest", 23):
            packager.add("hybrid2/install.rdf", install_rdf)

        with errors.context("manifest", 24):
            packager.add("webextension/manifest.json", we_manifest)

        non_we_manifest = GeneratedFile(b'{"not a webextension": true}')
        with errors.context("manifest", 25):
            packager.add("nonwebextension/manifest.json", non_we_manifest)

        self.assertEqual(formatter.log, [])

        with errors.context("dummy", 1):
            packager.close()
        self.maxDiff = None
        # The formatter is expected to reorder the manifest entries so that
        # chrome entries appear before the others.
        self.assertEqual(
            formatter.log,
            [
                (("dummy", 1), "add_base", "", False),
                (("dummy", 1), "add_base", "addon", True),
                (("dummy", 1), "add_base", "addon10", "unpacked"),
                (("dummy", 1), "add_base", "addon11", True),
                (("dummy", 1), "add_base", "addon2", "unpacked"),
                (("dummy", 1), "add_base", "addon3", "unpacked"),
                (("dummy", 1), "add_base", "addon4", "unpacked"),
                (("dummy", 1), "add_base", "addon5", True),
                (("dummy", 1), "add_base", "addon6", "unpacked"),
                (("dummy", 1), "add_base", "addon7", True),
                (("dummy", 1), "add_base", "addon8", "unpacked"),
                (("dummy", 1), "add_base", "addon9", True),
                (("dummy", 1), "add_base", "hybrid", True),
                (("dummy", 1), "add_base", "hybrid2", True),
                (("dummy", 1), "add_base", "qux", False),
                (("dummy", 1), "add_base", "webextension", True),
                (
                    (os.path.join(curdir, "foo", "bar.manifest"), 2),
                    "add_manifest",
                    ManifestContent("foo", "bar", "bar/"),
                ),
                (
                    (os.path.join(curdir, "foo", "bar.manifest"), 1),
                    "add_manifest",
                    ManifestResource("foo", "bar", "bar/"),
                ),
                (
                    ("bar/baz.manifest", 1),
                    "add_manifest",
                    ManifestResource("bar", "baz", "baz/"),
                ),
                (
                    ("qux/qux.manifest", 1),
                    "add_manifest",
                    ManifestResource("qux", "qux", "qux/"),
                ),
                (
                    ("qux/qux.manifest", 2),
                    "add_manifest",
                    ManifestBinaryComponent("qux", "qux.so"),
                ),
                (("manifest", 4), "add_interfaces", "foo/bar.xpt", bar_xpt),
                (("manifest", 7), "add_interfaces", "foo/qux.xpt", qux_xpt),
                (
                    (os.path.join(curdir, "addon", "chrome.manifest"), 1),
                    "add_manifest",
                    ManifestResource("addon", "hoge", "hoge/"),
                ),
                (
                    ("addon2/chrome.manifest", 1),
                    "add_manifest",
                    ManifestBinaryComponent("addon2", "addon2.so"),
                ),
                (
                    ("addon3/components/components.manifest", 1),
                    "add_manifest",
                    ManifestBinaryComponent("addon3/components", "addon3.so"),
                ),
                (("manifest", 5), "add", "foo/bar/foo.html", foo_html),
                (("manifest", 5), "add", "foo/bar/bar.html", bar_html),
                (("manifest", 9), "add", "addon/install.rdf", install_rdf),
                (("manifest", 10), "add", "addon2/install.rdf", install_rdf),
                (("manifest", 11), "add", "addon3/install.rdf", install_rdf),
                (("manifest", 12), "add", "addon4/install.rdf", install_rdf_addon4),
                (("manifest", 13), "add", "addon5/install.rdf", install_rdf_addon5),
                (("manifest", 14), "add", "addon6/install.rdf", install_rdf_addon6),
                (("manifest", 15), "add", "addon7/install.rdf", install_rdf_addon7),
                (("manifest", 16), "add", "addon8/install.rdf", install_rdf_addon8),
                (("manifest", 17), "add", "addon9/install.rdf", install_rdf_addon9),
                (("manifest", 18), "add", "addon10/install.rdf", install_rdf_addon10),
                (("manifest", 19), "add", "addon11/install.rdf", install_rdf_addon11),
                (("manifest", 20), "add", "hybrid/install.rdf", install_rdf),
                (
                    ("manifest", 21),
                    "add",
                    "hybrid/webextension/manifest.json",
                    we_manifest,
                ),
                (
                    ("manifest", 22),
                    "add",
                    "hybrid2/webextension/manifest.json",
                    we_manifest,
                ),
                (("manifest", 23), "add", "hybrid2/install.rdf", install_rdf),
                (("manifest", 24), "add", "webextension/manifest.json", we_manifest),
                (
                    ("manifest", 25),
                    "add",
                    "nonwebextension/manifest.json",
                    non_we_manifest,
                ),
            ],
        )

        self.assertEqual(
            packager.get_bases(),
            set(
                [
                    "",
                    "addon",
                    "addon2",
                    "addon3",
                    "addon4",
                    "addon5",
                    "addon6",
                    "addon7",
                    "addon8",
                    "addon9",
                    "addon10",
                    "addon11",
                    "qux",
                    "hybrid",
                    "hybrid2",
                    "webextension",
                ]
            ),
        )
        self.assertEqual(packager.get_bases(addons=False), set(["", "qux"]))

    def test_simple_packager_manifest_consistency(self):
        formatter = MockFormatter()
        # bar/ is detected as an addon because of install.rdf, but top-level
        # includes a manifest inside bar/.
        packager = SimplePackager(formatter)
        packager.add(
            "base.manifest",
            GeneratedFile(
                b"manifest foo/bar.manifest\n" b"manifest bar/baz.manifest\n"
            ),
        )
        packager.add("foo/bar.manifest", GeneratedFile(b"resource bar bar"))
        packager.add("bar/baz.manifest", GeneratedFile(b"resource baz baz"))
        packager.add("bar/install.rdf", GeneratedFile(b""))

        with self.assertRaises(ErrorMessage) as e:
            packager.close()

        self.assertEqual(
            str(e.exception),
            'error: "bar/baz.manifest" is included from "base.manifest", '
            'which is outside "bar"',
        )

        # bar/ is detected as a separate base because of chrome.manifest that
        # is included nowhere, but top-level includes another manifest inside
        # bar/.
        packager = SimplePackager(formatter)
        packager.add(
            "base.manifest",
            GeneratedFile(
                b"manifest foo/bar.manifest\n" b"manifest bar/baz.manifest\n"
            ),
        )
        packager.add("foo/bar.manifest", GeneratedFile(b"resource bar bar"))
        packager.add("bar/baz.manifest", GeneratedFile(b"resource baz baz"))
        packager.add("bar/chrome.manifest", GeneratedFile(b"resource baz baz"))

        with self.assertRaises(ErrorMessage) as e:
            packager.close()

        self.assertEqual(
            str(e.exception),
            'error: "bar/baz.manifest" is included from "base.manifest", '
            'which is outside "bar"',
        )

        # bar/ is detected as a separate base because of chrome.manifest that
        # is included nowhere, but chrome.manifest includes baz.manifest from
        # the same directory. This shouldn't error out.
        packager = SimplePackager(formatter)
        packager.add("base.manifest", GeneratedFile(b"manifest foo/bar.manifest\n"))
        packager.add("foo/bar.manifest", GeneratedFile(b"resource bar bar"))
        packager.add("bar/baz.manifest", GeneratedFile(b"resource baz baz"))
        packager.add("bar/chrome.manifest", GeneratedFile(b"manifest baz.manifest"))
        packager.close()


class TestSimpleManifestSink(unittest.TestCase):
    def test_simple_manifest_parser(self):
        formatter = MockFormatter()
        foobar = GeneratedFile(b"foobar")
        foobaz = GeneratedFile(b"foobaz")
        fooqux = GeneratedFile(b"fooqux")
        foozot = GeneratedFile(b"foozot")
        finder = MockFinder(
            {
                "bin/foo/bar": foobar,
                "bin/foo/baz": foobaz,
                "bin/foo/qux": fooqux,
                "bin/foo/zot": foozot,
                "bin/foo/chrome.manifest": GeneratedFile(b"resource foo foo/"),
                "bin/chrome.manifest": GeneratedFile(b"manifest foo/chrome.manifest"),
            }
        )
        parser = SimpleManifestSink(finder, formatter)
        component0 = Component("component0")
        component1 = Component("component1")
        component2 = Component("component2", destdir="destdir")
        parser.add(component0, "bin/foo/b*")
        parser.add(component1, "bin/foo/qux")
        parser.add(component1, "bin/foo/chrome.manifest")
        parser.add(component2, "bin/foo/zot")
        self.assertRaises(ErrorMessage, parser.add, "component1", "bin/bar")

        self.assertEqual(formatter.log, [])
        parser.close()
        self.assertEqual(
            formatter.log,
            [
                (None, "add_base", "", False),
                (
                    ("foo/chrome.manifest", 1),
                    "add_manifest",
                    ManifestResource("foo", "foo", "foo/"),
                ),
                (None, "add", "foo/bar", foobar),
                (None, "add", "foo/baz", foobaz),
                (None, "add", "foo/qux", fooqux),
                (None, "add", "destdir/foo/zot", foozot),
            ],
        )

        self.assertEqual(
            finder.log,
            [
                "bin/foo/b*",
                "bin/foo/qux",
                "bin/foo/chrome.manifest",
                "bin/foo/zot",
                "bin/bar",
                "bin/chrome.manifest",
            ],
        )


class TestCallDeque(unittest.TestCase):
    def test_call_deque(self):
        class Logger(object):
            def __init__(self):
                self._log = []

            def log(self, str):
                self._log.append(str)

            @staticmethod
            def staticlog(logger, str):
                logger.log(str)

        def do_log(logger, str):
            logger.log(str)

        logger = Logger()
        d = CallDeque()
        d.append(logger.log, "foo")
        d.append(logger.log, "bar")
        d.append(logger.staticlog, logger, "baz")
        d.append(do_log, logger, "qux")
        self.assertEqual(logger._log, [])
        d.execute()
        self.assertEqual(logger._log, ["foo", "bar", "baz", "qux"])


class TestComponent(unittest.TestCase):
    def do_split(self, string, name, options):
        n, o = Component._split_component_and_options(string)
        self.assertEqual(name, n)
        self.assertEqual(options, o)

    def test_component_split_component_and_options(self):
        self.do_split("component", "component", {})
        self.do_split("trailingspace ", "trailingspace", {})
        self.do_split(" leadingspace", "leadingspace", {})
        self.do_split(" trim ", "trim", {})
        self.do_split(' trim key="value"', "trim", {"key": "value"})
        self.do_split(' trim empty=""', "trim", {"empty": ""})
        self.do_split(' trim space=" "', "trim", {"space": " "})
        self.do_split(
            'component key="value"  key2="second" ',
            "component",
            {"key": "value", "key2": "second"},
        )
        self.do_split(
            'trim key="  value with spaces   "  key2="spaces again"',
            "trim",
            {"key": "  value with spaces   ", "key2": "spaces again"},
        )

    def do_split_error(self, string):
        self.assertRaises(ValueError, Component._split_component_and_options, string)

    def test_component_split_component_and_options_errors(self):
        self.do_split_error('"component')
        self.do_split_error('comp"onent')
        self.do_split_error('component"')
        self.do_split_error('"component"')
        self.do_split_error("=component")
        self.do_split_error("comp=onent")
        self.do_split_error("component=")
        self.do_split_error('key="val"')
        self.do_split_error("component key=")
        self.do_split_error('component key="val')
        self.do_split_error('component key=val"')
        self.do_split_error('component key="val" x')
        self.do_split_error('component x key="val"')
        self.do_split_error('component key1="val" x key2="val"')

    def do_from_string(self, string, name, destdir=""):
        component = Component.from_string(string)
        self.assertEqual(name, component.name)
        self.assertEqual(destdir, component.destdir)

    def test_component_from_string(self):
        self.do_from_string("component", "component")
        self.do_from_string("component-with-hyphen", "component-with-hyphen")
        self.do_from_string('component destdir="foo/bar"', "component", "foo/bar")
        self.do_from_string('component destdir="bar spc"', "component", "bar spc")
        self.assertRaises(ErrorMessage, Component.from_string, "")
        self.assertRaises(ErrorMessage, Component.from_string, "component novalue=")
        self.assertRaises(
            ErrorMessage, Component.from_string, "component badoption=badvalue"
        )


if __name__ == "__main__":
    mozunit.main()