1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
|
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "nsEscape.h"
#include "gtest/gtest.h"
#include "mozilla/ArrayUtils.h"
#include "nsNetUtil.h"
using namespace mozilla;
// Testing for failure here would be somewhat hard in automation. Locally you
// could use something like ulimit to create a failure.
TEST(Escape, FallibleNoEscape)
{
// Tests the fallible version of NS_EscapeURL works as expected when no
// escaping is necessary.
nsCString toEscape("data:,Hello%2C%20World!");
nsCString escaped;
nsresult rv = NS_EscapeURL(toEscape, esc_OnlyNonASCII, escaped, fallible);
EXPECT_EQ(rv, NS_OK);
// Nothing should have been escaped, they should be the same string.
EXPECT_STREQ(toEscape.BeginReading(), escaped.BeginReading());
// We expect them to point at the same buffer.
EXPECT_EQ(toEscape.BeginReading(), escaped.BeginReading());
}
TEST(Escape, FallibleEscape)
{
// Tests the fallible version of NS_EscapeURL works as expected when
// escaping is necessary.
nsCString toEscape("data:,Hello%2C%20World!\xC4\x9F");
nsCString escaped;
nsresult rv = NS_EscapeURL(toEscape, esc_OnlyNonASCII, escaped, fallible);
EXPECT_EQ(rv, NS_OK);
EXPECT_STRNE(toEscape.BeginReading(), escaped.BeginReading());
const char* const kExpected = "data:,Hello%2C%20World!%C4%9F";
EXPECT_STREQ(escaped.BeginReading(), kExpected);
}
TEST(Escape, BadEscapeSequences)
{
{
char bad[] = "%s\0fa";
int32_t count = nsUnescapeCount(bad);
EXPECT_EQ(count, 2);
EXPECT_STREQ(bad, "%s");
}
{
char bad[] = "%a";
int32_t count = nsUnescapeCount(bad);
EXPECT_EQ(count, 2);
EXPECT_STREQ(bad, "%a");
}
{
char bad[] = "%";
int32_t count = nsUnescapeCount(bad);
EXPECT_EQ(count, 1);
EXPECT_STREQ(bad, "%");
}
{
char bad[] = "%s/%s";
int32_t count = nsUnescapeCount(bad);
EXPECT_EQ(count, 5);
EXPECT_STREQ(bad, "%s/%s");
}
}
TEST(Escape, nsAppendEscapedHTML)
{
const char* srcs[] = {
"a", "bcdefgh", "<", ">", "&", "\"",
"'", "'bad'", "Foo<T>& foo", "'\"&><abc", "",
};
const char* dsts1[] = {
"a",
"bcdefgh",
"<",
">",
"&",
""",
"'",
"'bad'",
"Foo<T>& foo",
"'"&><abc",
"",
};
const char* dsts2[] = {
"a",
"abcdefgh",
"abcdefgh<",
"abcdefgh<>",
"abcdefgh<>&",
"abcdefgh<>&"",
"abcdefgh<>&"'",
"abcdefgh<>&"''bad'",
"abcdefgh<>&"''bad'Foo<T>& foo",
"abcdefgh<>&"''bad'Foo<T>& "
"foo'"&><abc",
"abcdefgh<>&"''bad'Foo<T>& "
"foo'"&><abc",
};
ASSERT_EQ(ArrayLength(srcs), ArrayLength(dsts1));
ASSERT_EQ(ArrayLength(srcs), ArrayLength(dsts2));
// Test when the destination is empty.
for (size_t i = 0; i < ArrayLength(srcs); i++) {
nsCString src(srcs[i]);
nsCString dst;
nsAppendEscapedHTML(src, dst);
ASSERT_TRUE(dst.Equals(dsts1[i]));
}
// Test when the destination is non-empty.
nsCString dst;
for (size_t i = 0; i < ArrayLength(srcs); i++) {
nsCString src(srcs[i]);
nsAppendEscapedHTML(src, dst);
ASSERT_TRUE(dst.Equals(dsts2[i]));
}
}
TEST(Escape, EscapeSpaces)
{
// Tests the fallible version of NS_EscapeURL works as expected when no
// escaping is necessary.
nsCString toEscape("data:\x0D\x0A spa ces\xC4\x9F");
nsCString escaped;
nsresult rv = NS_EscapeURL(toEscape, esc_OnlyNonASCII, escaped, fallible);
EXPECT_EQ(rv, NS_OK);
// Only non-ASCII and C0
EXPECT_STREQ(escaped.BeginReading(), "data:%0D%0A spa ces%C4%9F");
escaped.Truncate();
rv = NS_EscapeURL(toEscape, esc_OnlyNonASCII | esc_Spaces, escaped, fallible);
EXPECT_EQ(rv, NS_OK);
EXPECT_STREQ(escaped.BeginReading(), "data:%0D%0A%20spa%20ces%C4%9F");
}
TEST(Escape, AppleNSURLEscapeHash)
{
nsCString toEscape("#");
nsCString escaped;
bool isEscapedOK = NS_Escape(toEscape, escaped, url_NSURLRef);
EXPECT_EQ(isEscapedOK, true);
EXPECT_STREQ(escaped.BeginReading(), "%23");
}
TEST(Escape, AppleNSURLEscapeNoDouble)
{
// The '%' in "%23" shouldn't be encoded again.
nsCString toEscape("%23");
nsCString escaped;
bool isEscapedOK = NS_Escape(toEscape, escaped, url_NSURLRef);
EXPECT_EQ(isEscapedOK, true);
EXPECT_STREQ(escaped.BeginReading(), "%23");
}
// Test escaping of URLs that shouldn't be changed by escaping.
TEST(Escape, AppleNSURLEscapeLists)
{
// Pairs of URLs (un-encoded, encoded)
nsTArray<std::pair<nsCString, nsCString>> pairs{
{"https://chat.mozilla.org/#/room/#macdev:mozilla.org"_ns,
"https://chat.mozilla.org/#/room/%23macdev:mozilla.org"_ns},
};
for (std::pair<nsCString, nsCString>& pair : pairs) {
nsCString escaped;
nsresult rv = NS_GetSpecWithNSURLEncoding(escaped, pair.first);
EXPECT_EQ(rv, NS_OK);
EXPECT_STREQ(pair.second.BeginReading(), escaped.BeginReading());
}
// A list of URLs that should not be changed by encoding.
nsTArray<nsCString> unchangedURLs{
// '=' In the query
"https://bugzilla.mozilla.org/show_bug.cgi?id=1737854"_ns,
// Escaped character in the fragment
"https://html.spec.whatwg.org/multipage/dom.html#the-document%27s-address"_ns,
// Misc query
"https://www.google.com/search?q=firefox+web+browser&client=firefox-b-1-d&ei=abc&ved=abc&abc=5&oq=firefox+web+browser&gs_lcp=abc&sclient=gws-wiz"_ns,
// Check for double encoding. % encoded octals should not be re-encoded.
"https://chat.mozilla.org/#/room/%23macdev%3Amozilla.org"_ns,
"https://searchfox.org/mozilla-central/search?q=symbol%3AE_%3CT_mozilla%3A%3AWebGLExtensionID%3E_EXT_color_buffer_half_float&path="_ns,
// Other
"https://site.com/script?foo=bar#this_ref"_ns,
};
for (nsCString& toEscape : unchangedURLs) {
nsCString escaped;
nsresult rv = NS_GetSpecWithNSURLEncoding(escaped, toEscape);
EXPECT_EQ(rv, NS_OK);
EXPECT_STREQ(toEscape.BeginReading(), escaped.BeginReading());
}
}
// Test external handler URLs are properly escaped.
TEST(Escape, EscapeURLExternalHandlerURLs)
{
const nsCString input[] = {
"0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ;/?:@&=+$,!'()*-._~#[]"_ns,
" !\"#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~"_ns,
"custom_proto:Hello World"_ns,
"custom_proto:Hello%20World"_ns,
"myApp://\"foo\" 'bar' `foo`"_ns,
"translator://en-de?view=übersicht"_ns,
"foo:some\\path\\here"_ns,
"web+foo://user:1234@example.com:8080?foo=bar"_ns,
"ext+bar://id='myId'"_ns};
const nsCString expected[] = {
"0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ;/?:@&=+$,!'()*-._~#[]"_ns,
"%20!%22#$%&'()*+,-./0123456789:;%3C=%3E?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[%5C]%5E_%60abcdefghijklmnopqrstuvwxyz%7B%7C%7D~"_ns,
"custom_proto:Hello%20World"_ns,
"custom_proto:Hello%20World"_ns,
"myApp://%22foo%22%20'bar'%20%60foo%60"_ns,
"translator://en-de?view=%C3%BCbersicht"_ns,
"foo:some%5Cpath%5Chere"_ns,
"web+foo://user:1234@example.com:8080?foo=bar"_ns,
"ext+bar://id='myId'"_ns};
for (size_t i = 0; i < ArrayLength(input); i++) {
nsCString src(input[i]);
nsCString dst;
nsresult rv =
NS_EscapeURL(src, esc_ExtHandler | esc_AlwaysCopy, dst, fallible);
EXPECT_EQ(rv, NS_OK);
ASSERT_TRUE(dst.Equals(expected[i]));
}
}
|