1 files changed, 121 insertions, 0 deletions
diff --git a/tools/lint/test/test_clippy.py b/tools/lint/test/test_clippy.py
new file mode 100644
index 0000000000..6a2687d2c3
--- /dev/null
+++ b/tools/lint/test/test_clippy.py
@@ -0,0 +1,121 @@
+import os
+
+import mozunit
+
+LINTER = "clippy"
+
+
+def test_basic(lint, config, paths):
+    results = lint(paths("test1/"))
+    print(results)
+    assert len(results) > 7
+
+    assert (
+        "is never read" in results[0].message or "but never used" in results[0].message
+    )
+    assert results[0].level == "warning"
+    assert results[0].lineno == 7
+    assert results[0].column >= 9
+    assert results[0].rule == "unused_assignments"
+    assert results[0].relpath == "test1/bad.rs"
+    assert "tools/lint/test/files/clippy/test1/bad.rs" in results[0].path
+
+    assert "this looks like you are trying to swap `a` and `b`" in results[1].message
+    assert results[1].level == "error"
+    assert results[1].relpath == "test1/bad.rs"
+    assert results[1].rule == "clippy::almost_swapped"
+    assert "or maybe you should use `std::mem::replace`" in results[1].hint
+
+    assert "value assigned to `b` is never read" in results[2].message
+    assert results[2].level == "warning"
+    assert results[2].relpath == "test1/bad.rs"
+
+    if "variable does not need to be mutable" in results[5].message:
+        n = 5
+    else:
+        n = 6
+
+    assert "variable does not need to be mutable" in results[n].message
+    assert results[n].relpath == "test1/bad2.rs"
+    assert results[n].rule == "unused_mut"
+
+    assert "unused variable: `vec`" in results[n + 1].message
+    assert results[n + 1].level == "warning"
+    assert results[n + 1].relpath == "test1/bad2.rs"
+    assert results[n + 1].rule == "unused_variables"
+
+    assert "this range is empty so" in results[8].message
+    assert results[8].level == "error"
+    assert results[8].relpath == "test1/bad2.rs"
+    assert results[8].rule == "clippy::reversed_empty_ranges"
+
+
+def test_error(lint, config, paths):
+    results = lint(paths("test1/Cargo.toml"))
+    # Should fail. We don't accept Cargo.toml as input
+    assert results == 1
+
+
+def test_file_and_path_provided(lint, config, paths):
+    results = lint(paths("./test2/src/bad_1.rs", "test1/"))
+    # even if clippy analyzed it
+    # we should not have anything from bad_2.rs
+    # as mozlint is filtering out the file
+    print(results)
+    assert len(results) > 12
+    assert "value assigned to `a` is never read" in results[0].message
+    assert results[0].level == "warning"
+    assert results[0].lineno == 7
+    assert results[0].column >= 9
+    assert results[0].rule == "unused_assignments"
+    assert results[0].relpath == "test1/bad.rs"
+    assert "tools/lint/test/files/clippy/test1/bad.rs" in results[0].path
+    assert "value assigned to `a` is never read" in results[0].message
+    assert results[8].level == "error"
+    assert results[8].lineno == 10
+    assert results[8].column == 14
+    assert results[8].rule == "clippy::reversed_empty_ranges"
+    assert results[8].relpath == "test1/bad2.rs"
+    assert "tools/lint/test/files/clippy/test1/bad2.rs" in results[8].path
+
+    assert results[10].level == "warning"
+    assert results[10].lineno == 9
+    assert results[10].column >= 9
+    assert results[10].rule == "unused_assignments"
+    assert results[10].relpath == "test2/src/bad_1.rs"
+    assert "tools/lint/test/files/clippy/test2/src/bad_1.rs" in results[10].path
+    for r in results:
+        assert "bad_2.rs" not in r.relpath
+
+
+def test_file_provided(lint, config, paths):
+    results = lint(paths("./test2/src/bad_1.rs"))
+    # even if clippy analyzed it
+    # we should not have anything from bad_2.rs
+    # as mozlint is filtering out the file
+    print(results)
+    assert len(results) > 2
+    assert results[0].level == "warning"
+    assert results[0].lineno == 9
+    assert results[0].column >= 9
+    assert results[0].rule == "unused_assignments"
+    assert results[0].relpath == "test2/src/bad_1.rs"
+    assert "tools/lint/test/files/clippy/test2/src/bad_1.rs" in results[0].path
+    for r in results:
+        assert "bad_2.rs" not in r.relpath
+
+
+def test_cleanup(lint, paths, root):
+    # If Cargo.lock does not exist before clippy run, delete it
+    lint(paths("test1/"))
+    assert not os.path.exists(os.path.join(root, "test1/target/"))
+    assert not os.path.exists(os.path.join(root, "test1/Cargo.lock"))
+
+    # If Cargo.lock exists before clippy run, keep it after cleanup
+    lint(paths("test2/"))
+    assert not os.path.exists(os.path.join(root, "test2/target/"))
+    assert os.path.exists(os.path.join(root, "test2/Cargo.lock"))
+
+
+if __name__ == "__main__":
+    mozunit.main()