1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
|
/* Any copyright is dedicated to the Public Domain.
http://creativecommons.org/publicdomain/zero/1.0/ */
// Tests results with `suggestedIndex` and `isSuggestedIndexRelativeToGroup`.
"use strict";
const MAX_RESULTS = 10;
const RESULT_GROUPS_PREF = "browser.urlbar.resultGroups";
const MAX_RICH_RESULTS_PREF = "browser.urlbar.maxRichResults";
// Default result groups used in the tests below.
const RESULT_GROUPS = {
children: [
{
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
flexChildren: true,
children: [
{
flex: 1,
group: UrlbarUtils.RESULT_GROUP.FORM_HISTORY,
},
{
flex: 1,
group: UrlbarUtils.RESULT_GROUP.GENERAL,
},
{
flex: 1,
group: UrlbarUtils.RESULT_GROUP.REMOTE_SUGGESTION,
},
],
},
],
};
add_task(async function test() {
// Set a specific maxRichResults for sanity's sake.
Services.prefs.setIntPref(MAX_RICH_RESULTS_PREF, MAX_RESULTS);
// Create the default non-suggestedIndex results we'll use for tests that
// don't specify `otherResults`.
let basicResults = [
...makeHistoryResults(),
...makeFormHistoryResults(),
...makeRemoteSuggestionResults(),
];
// Test cases follow. Each object in `tests` has the following properties:
//
// * {string} desc
// * {object} suggestedIndexResults
// Describes the suggestedIndex results the test provider should return.
// Properties:
// * {number} suggestedIndex
// * {UrlbarUtils.RESULT_GROUP} group
// This will force the result to have the given group.
// * {array} expected
// Describes the expected results the muxer should return, i.e., the search
// results. Each object in the array describes a slice of expected results.
// The size of the slice is defined by the `count` property.
// * {UrlbarUtils.RESULT_GROUP} group
// The expected group of the results in the slice.
// * {number} count
// The number of results in the slice.
// * {number} [offset]
// Can be used to offset the starting index of the slice in the results.
// * {array} [otherResults]
// An array of results besides the group-relative suggestedIndex results
// that the provider should return. If not specified `basicResults` is used.
// * {array} [resultGroups]
// The result groups to use. If not specified `RESULT_GROUPS` is used.
let tests = [
{
desc: "First result in GENERAL",
suggestedIndexResults: [
{
suggestedIndex: 0,
group: UrlbarUtils.RESULT_GROUP.GENERAL,
},
],
expected: [
{
group: UrlbarUtils.RESULT_GROUP.FORM_HISTORY,
count: 4,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL,
suggestedIndex: 0,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL,
count: 2,
},
{
group: UrlbarUtils.RESULT_GROUP.REMOTE_SUGGESTION,
// The muxer will remove the first 4 remote suggestions because they
// dupe the earlier form history.
offset: 4,
count: 3,
},
],
},
{
desc: "Last result in GENERAL",
suggestedIndexResults: [
{
suggestedIndex: -1,
group: UrlbarUtils.RESULT_GROUP.GENERAL,
},
],
expected: [
{
group: UrlbarUtils.RESULT_GROUP.FORM_HISTORY,
count: 4,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL,
count: 2,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL,
suggestedIndex: -1,
},
{
group: UrlbarUtils.RESULT_GROUP.REMOTE_SUGGESTION,
// The muxer will remove the first 4 remote suggestions because they
// dupe the earlier form history.
offset: 4,
count: 3,
},
],
},
{
desc: "First result in GENERAL_PARENT",
suggestedIndexResults: [
{
suggestedIndex: 0,
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
},
],
expected: [
{
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
suggestedIndex: 0,
},
{
group: UrlbarUtils.RESULT_GROUP.FORM_HISTORY,
count: 3,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL,
count: 3,
},
{
group: UrlbarUtils.RESULT_GROUP.REMOTE_SUGGESTION,
// The muxer will remove the first 3 remote suggestions because they
// dupe the earlier form history.
offset: 3,
count: 3,
},
],
},
{
desc: "Last result in GENERAL_PARENT",
suggestedIndexResults: [
{
suggestedIndex: -1,
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
},
],
expected: [
{
group: UrlbarUtils.RESULT_GROUP.FORM_HISTORY,
count: 3,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL,
count: 3,
},
{
group: UrlbarUtils.RESULT_GROUP.REMOTE_SUGGESTION,
// The muxer will remove the first 3 remote suggestions because they
// dupe the earlier form history.
offset: 3,
count: 3,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
suggestedIndex: -1,
},
],
},
{
desc: "First and last results in GENERAL",
suggestedIndexResults: [
{
suggestedIndex: 0,
group: UrlbarUtils.RESULT_GROUP.GENERAL,
},
{
suggestedIndex: -1,
group: UrlbarUtils.RESULT_GROUP.GENERAL,
},
],
expected: [
{
group: UrlbarUtils.RESULT_GROUP.FORM_HISTORY,
count: 4,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL,
suggestedIndex: 0,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL,
count: 1,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL,
suggestedIndex: -1,
},
{
group: UrlbarUtils.RESULT_GROUP.REMOTE_SUGGESTION,
// The muxer will remove the first 4 remote suggestions because they
// dupe the earlier form history.
offset: 4,
count: 3,
},
],
},
{
desc: "First and last results in GENERAL_PARENT",
suggestedIndexResults: [
{
suggestedIndex: 0,
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
},
{
suggestedIndex: -1,
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
},
],
expected: [
{
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
suggestedIndex: 0,
},
{
group: UrlbarUtils.RESULT_GROUP.FORM_HISTORY,
count: 3,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL,
count: 3,
},
{
group: UrlbarUtils.RESULT_GROUP.REMOTE_SUGGESTION,
// The muxer will remove the first 3 remote suggestions because they
// dupe the earlier form history.
offset: 3,
count: 2,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
suggestedIndex: -1,
},
],
},
{
desc: "First result in GENERAL_PARENT, first result in GENERAL",
suggestedIndexResults: [
{
suggestedIndex: 0,
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
},
{
suggestedIndex: 0,
group: UrlbarUtils.RESULT_GROUP.GENERAL,
},
],
expected: [
{
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
suggestedIndex: 0,
},
{
group: UrlbarUtils.RESULT_GROUP.FORM_HISTORY,
count: 3,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL,
suggestedIndex: 0,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL,
count: 2,
},
{
group: UrlbarUtils.RESULT_GROUP.REMOTE_SUGGESTION,
// The muxer will remove the first 3 remote suggestions because they
// dupe the earlier form history.
offset: 3,
count: 3,
},
],
},
{
desc: "Results in sibling group, no other results in same group",
otherResults: makeFormHistoryResults(),
suggestedIndexResults: [
{
suggestedIndex: -1,
group: UrlbarUtils.RESULT_GROUP.GENERAL,
},
],
expected: [
{
group: UrlbarUtils.RESULT_GROUP.FORM_HISTORY,
count: 9,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL,
suggestedIndex: -1,
},
],
},
{
desc:
"Results in sibling group, no other results in same group, has child group",
resultGroups: {
flexChildren: true,
children: [
{
flex: 2,
group: UrlbarUtils.RESULT_GROUP.REMOTE_SUGGESTION,
},
{
flex: 1,
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
children: [{ group: UrlbarUtils.RESULT_GROUP.GENERAL }],
},
],
},
otherResults: makeRemoteSuggestionResults(),
suggestedIndexResults: [
{
suggestedIndex: -1,
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
},
],
expected: [
{
group: UrlbarUtils.RESULT_GROUP.REMOTE_SUGGESTION,
count: 9,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
suggestedIndex: -1,
},
],
},
{
desc: "Complex group nesting with global suggestedIndex with resultSpan",
resultGroups: {
children: [
{
maxResultCount: 1,
children: [{ group: UrlbarUtils.RESULT_GROUP.HEURISTIC_TEST }],
},
{
flexChildren: true,
children: [
{
flex: 2,
group: UrlbarUtils.RESULT_GROUP.REMOTE_SUGGESTION,
},
{
flex: 1,
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
children: [{ group: UrlbarUtils.RESULT_GROUP.GENERAL }],
},
],
},
],
},
otherResults: [
// heuristic
Object.assign(
new UrlbarResult(
UrlbarUtils.RESULT_TYPE.SEARCH,
UrlbarUtils.RESULT_SOURCE.SEARCH,
{
engine: "test",
suggestion: "foo",
lowerCaseSuggestion: "foo",
}
),
{
heuristic: true,
group: UrlbarUtils.RESULT_GROUP.HEURISTIC_TEST,
}
),
// global suggestedIndex with resultSpan = 2
Object.assign(
new UrlbarResult(
UrlbarUtils.RESULT_TYPE.SEARCH,
UrlbarUtils.RESULT_SOURCE.SEARCH,
{
engine: "test",
}
),
{
suggestedIndex: 1,
resultSpan: 2,
}
),
// remote suggestions
...makeRemoteSuggestionResults(),
],
suggestedIndexResults: [
{
suggestedIndex: -1,
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
},
],
expected: [
{
group: UrlbarUtils.RESULT_GROUP.HEURISTIC_TEST,
count: 1,
},
{
group: UrlbarUtils.RESULT_GROUP.SUGGESTED_INDEX,
suggestedIndex: 1,
resultSpan: 2,
count: 1,
},
{
group: UrlbarUtils.RESULT_GROUP.REMOTE_SUGGESTION,
count: 6,
},
{
group: UrlbarUtils.RESULT_GROUP.GENERAL_PARENT,
suggestedIndex: -1,
},
],
},
];
let controller = UrlbarTestUtils.newMockController();
for (let {
desc,
suggestedIndexResults,
expected,
resultGroups,
otherResults,
} of tests) {
info(`Running test: ${desc}`);
setResultGroups(resultGroups || RESULT_GROUPS);
// Make the array of all results and do a search.
let results = (otherResults || basicResults).concat(
makeSuggestedIndexResults(suggestedIndexResults)
);
let provider = registerBasicTestProvider(results);
let context = createContext(undefined, { providers: [provider.name] });
await UrlbarProvidersManager.startQuery(context, controller);
// Make the list of expected results.
let expectedResults = [];
for (let { group, offset, count, suggestedIndex } of expected) {
// Find the index in `results` of the expected result.
let index = results.findIndex(
r =>
UrlbarUtils.getResultGroup(r) == group &&
r.suggestedIndex === suggestedIndex
);
Assert.notEqual(
index,
-1,
"Sanity check: Expected result is in `results`"
);
if (offset) {
index += offset;
}
// Extract the expected number of results from `results` and append them
// to the expected results array.
count = count || 1;
expectedResults.push(...results.slice(index, index + count));
}
Assert.deepEqual(context.results, expectedResults);
UrlbarProvidersManager.unregisterProvider(provider);
}
});
function makeHistoryResults(count = MAX_RESULTS) {
let results = [];
for (let i = 0; i < count; i++) {
results.push(
new UrlbarResult(
UrlbarUtils.RESULT_TYPE.URL,
UrlbarUtils.RESULT_SOURCE.HISTORY,
{ url: "http://example.com/" + i }
)
);
}
return results;
}
function makeRemoteSuggestionResults(count = MAX_RESULTS) {
let results = [];
for (let i = 0; i < count; i++) {
results.push(
new UrlbarResult(
UrlbarUtils.RESULT_TYPE.SEARCH,
UrlbarUtils.RESULT_SOURCE.SEARCH,
{
engine: "test",
query: "test",
suggestion: "test " + i,
lowerCaseSuggestion: "test " + i,
}
)
);
}
return results;
}
function makeFormHistoryResults(count = MAX_RESULTS) {
let results = [];
for (let i = 0; i < count; i++) {
results.push(
new UrlbarResult(
UrlbarUtils.RESULT_TYPE.SEARCH,
UrlbarUtils.RESULT_SOURCE.HISTORY,
{
engine: "test",
suggestion: "test " + i,
lowerCaseSuggestion: "test " + i,
}
)
);
}
return results;
}
function makeSuggestedIndexResults(objects) {
return objects.map(({ suggestedIndex, group }) =>
Object.assign(
new UrlbarResult(
UrlbarUtils.RESULT_TYPE.URL,
UrlbarUtils.RESULT_SOURCE.OTHER_LOCAL,
{
url: "http://example.com/si " + suggestedIndex,
}
),
{
group,
suggestedIndex,
isSuggestedIndexRelativeToGroup: true,
}
)
);
}
function setResultGroups(resultGroups) {
if (resultGroups) {
Services.prefs.setCharPref(
RESULT_GROUPS_PREF,
JSON.stringify(resultGroups)
);
} else {
Services.prefs.clearUserPref(RESULT_GROUPS_PREF);
}
}
|