1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
|
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */
/* -*- indent-tabs-mode: nil; js-indent-level: 4 -*- */
"use strict";
// Ignore calls made through these function pointers
var ignoreIndirectCalls = {
"mallocSizeOf" : true,
"aMallocSizeOf" : true,
"__conv" : true,
"__convf" : true,
"prerrortable.c:callback_newtable" : true,
"mozalloc_oom.cpp:void (* gAbortHandler)(size_t)" : true,
};
// Types that when constructed with no arguments, are "safe" values (they do
// not contain GC pointers, or values with nontrivial destructors.)
var typesWithSafeConstructors = new Set([
"mozilla::Maybe",
"mozilla::dom::Nullable",
"mozilla::dom::Optional",
"mozilla::UniquePtr",
"js::UniquePtr"
]);
var resetterMethods = {
'mozilla::Maybe': new Set(["reset"]),
'mozilla::UniquePtr': new Set(["reset"]),
'js::UniquePtr': new Set(["reset"]),
'mozilla::dom::Nullable': new Set(["SetNull"]),
'mozilla::dom::TypedArray_base': new Set(["Reset"]),
'RefPtr': new Set(["forget"]),
'nsCOMPtr': new Set(["forget"]),
};
function isRefcountedDtor(name) {
return name.includes("::~RefPtr(") || name.includes("::~nsCOMPtr(");
}
function indirectCallCannotGC(fullCaller, fullVariable)
{
var caller = readable(fullCaller);
// This is usually a simple variable name, but sometimes a full name gets
// passed through. And sometimes that name is truncated. Examples:
// _ZL13gAbortHandler$mozalloc_oom.cpp:void (* gAbortHandler)(size_t)
// _ZL14pMutexUnlockFn$umutex.cpp:void (* pMutexUnlockFn)(const void*
var name = readable(fullVariable);
if (name in ignoreIndirectCalls)
return true;
if (name == "mapper" && caller == "ptio.c:pt_MapError")
return true;
if (name == "params" && caller == "PR_ExplodeTime")
return true;
// hook called during script finalization which cannot GC.
if (/CallDestroyScriptHook/.test(caller))
return true;
// Call through a 'callback' function pointer, in a place where we're going
// to be throwing a JS exception.
if (name == "callback" && caller.includes("js::ErrorToException"))
return true;
// The math cache only gets called with non-GC math functions.
if (name == "f" && caller.includes("js::MathCache::lookup"))
return true;
// It would probably be better to somehow rewrite PR_CallOnce(foo) into a
// call of foo, but for now just assume that nobody is crazy enough to use
// PR_CallOnce with a function that can GC.
if (name == "func" && caller == "PR_CallOnce")
return true;
return false;
}
// Ignore calls through functions pointers with these types
var ignoreClasses = {
"JSStringFinalizer" : true,
"SprintfState" : true,
"SprintfStateStr" : true,
"JSLocaleCallbacks" : true,
"JSC::ExecutableAllocator" : true,
"PRIOMethods": true,
"_MD_IOVector" : true,
"malloc_table_t": true, // replace_malloc
"malloc_hook_table_t": true, // replace_malloc
"mozilla::MallocSizeOf": true,
"MozMallocSizeOf": true,
};
// Ignore calls through TYPE.FIELD, where TYPE is the class or struct name containing
// a function pointer field named FIELD.
var ignoreCallees = {
"js::Class.trace" : true,
"js::Class.finalize" : true,
"JSClassOps.trace" : true,
"JSClassOps.finalize" : true,
"JSRuntime.destroyPrincipals" : true,
"icu_50::UObject.__deleting_dtor" : true, // destructors in ICU code can't cause GC
"mozilla::CycleCollectedJSRuntime.DescribeCustomObjects" : true, // During tracing, cannot GC.
"mozilla::CycleCollectedJSRuntime.NoteCustomGCThingXPCOMChildren" : true, // During tracing, cannot GC.
"PLDHashTableOps.hashKey" : true,
"PLDHashTableOps.clearEntry" : true,
"z_stream_s.zfree" : true,
"z_stream_s.zalloc" : true,
"GrGLInterface.fCallback" : true,
"std::strstreambuf._M_alloc_fun" : true,
"std::strstreambuf._M_free_fun" : true,
"struct js::gc::Callback<void (*)(JSContext*, void*)>.op" : true,
"mozilla::ThreadSharedFloatArrayBufferList::Storage.mFree" : true,
"mozilla::SizeOfState.mMallocSizeOf": true,
"mozilla::gfx::SourceSurfaceRawData.mDeallocator": true,
};
function fieldCallCannotGC(csu, fullfield)
{
if (csu in ignoreClasses)
return true;
if (fullfield in ignoreCallees)
return true;
return false;
}
function ignoreEdgeUse(edge, variable, body)
{
// Horrible special case for ignoring a false positive in xptcstubs: there
// is a local variable 'paramBuffer' holding an array of nsXPTCMiniVariant
// on the stack, which appears to be live across a GC call because its
// constructor is called when the array is initialized, even though the
// constructor is a no-op. So we'll do a very narrow exclusion for the use
// that incorrectly started the live range, which was basically "__temp_1 =
// paramBuffer".
//
// By scoping it so narrowly, we can detect most hazards that would be
// caused by modifications in the PrepareAndDispatch code. It just barely
// avoids having a hazard already.
if (('Name' in variable) && (variable.Name[0] == 'paramBuffer')) {
if (body.BlockId.Kind == 'Function' && body.BlockId.Variable.Name[0] == 'PrepareAndDispatch')
if (edge.Kind == 'Assign' && edge.Type.Kind == 'Pointer')
if (edge.Exp[0].Kind == 'Var' && edge.Exp[1].Kind == 'Var')
if (edge.Exp[1].Variable.Kind == 'Local' && edge.Exp[1].Variable.Name[0] == 'paramBuffer')
return true;
}
// Functions which should not be treated as using variable.
if (edge.Kind == "Call") {
var callee = edge.Exp[0];
if (callee.Kind == "Var") {
var name = callee.Variable.Name[0];
if (/~DebugOnly/.test(name))
return true;
if (/~ScopedThreadSafeStringInspector/.test(name))
return true;
}
}
return false;
}
function ignoreEdgeAddressTaken(edge)
{
// Functions which may take indirect pointers to unrooted GC things,
// but will copy them into rooted locations before calling anything
// that can GC. These parameters should usually be replaced with
// handles or mutable handles.
if (edge.Kind == "Call") {
var callee = edge.Exp[0];
if (callee.Kind == "Var") {
var name = callee.Variable.Name[0];
if (/js::Invoke\(/.test(name))
return true;
}
}
return false;
}
// Ignore calls of these functions (so ignore any stack containing these)
var ignoreFunctions = {
"ptio.c:pt_MapError" : true,
"je_malloc_printf" : true,
"malloc_usable_size" : true,
"vprintf_stderr" : true,
"PR_ExplodeTime" : true,
"PR_ErrorInstallTable" : true,
"PR_SetThreadPrivate" : true,
"uint8 NS_IsMainThread()" : true,
// Has an indirect call under it by the name "__f", which seemed too
// generic to ignore by itself.
"void* std::_Locale_impl::~_Locale_impl(int32)" : true,
// Bug 1056410 - devirtualization prevents the standard nsISupports::Release heuristic from working
"uint32 nsXPConnect::Release()" : true,
"uint32 nsAtom::Release()" : true,
// Allocation API
"malloc": true,
"calloc": true,
"realloc": true,
"free": true,
// FIXME!
"NS_LogInit": true,
"NS_LogTerm": true,
"NS_LogAddRef": true,
"NS_LogRelease": true,
"NS_LogCtor": true,
"NS_LogDtor": true,
"NS_LogCOMPtrAddRef": true,
"NS_LogCOMPtrRelease": true,
// FIXME!
"NS_DebugBreak": true,
// Similar to heap snapshot mock classes, and GTests below. This posts a
// synchronous runnable when a GTest fails, and we are pretty sure that the
// particular runnable it posts can't even GC, but the analysis isn't
// currently smart enough to determine that. In either case, this is (a)
// only in GTests, and (b) only when the Gtest has already failed. We have
// static and dynamic checks for no GC in the non-test code, and in the test
// code we fall back to only the dynamic checks.
"void test::RingbufferDumper::OnTestPartResult(testing::TestPartResult*)" : true,
"float64 JS_GetCurrentEmbedderTime()" : true,
// This calls any JSObjectMovedOp for the tenured object via an indirect call.
"JSObject* js::TenuringTracer::moveToTenuredSlow(JSObject*)" : true,
"void js::Nursery::freeMallocedBuffers()" : true,
"void js::AutoEnterOOMUnsafeRegion::crash(uint64, int8*)" : true,
"void mozilla::dom::WorkerPrivate::AssertIsOnWorkerThread() const" : true,
// It would be cool to somehow annotate that nsTHashtable<T> will use
// nsTHashtable<T>::s_MatchEntry for its matchEntry function pointer, but
// there is no mechanism for that. So we will just annotate a particularly
// troublesome logging-related usage.
"EntryType* nsTHashtable<EntryType>::PutEntry(nsTHashtable<EntryType>::KeyType, const fallible_t&) [with EntryType = nsBaseHashtableET<nsCharPtrHashKey, nsAutoPtr<mozilla::LogModule> >; nsTHashtable<EntryType>::KeyType = const char*; nsTHashtable<EntryType>::fallible_t = mozilla::fallible_t]" : true,
"EntryType* nsTHashtable<EntryType>::GetEntry(nsTHashtable<EntryType>::KeyType) const [with EntryType = nsBaseHashtableET<nsCharPtrHashKey, nsAutoPtr<mozilla::LogModule> >; nsTHashtable<EntryType>::KeyType = const char*]" : true,
"EntryType* nsTHashtable<EntryType>::PutEntry(nsTHashtable<EntryType>::KeyType) [with EntryType = nsBaseHashtableET<nsPtrHashKey<const mozilla::BlockingResourceBase>, nsAutoPtr<mozilla::DeadlockDetector<mozilla::BlockingResourceBase>::OrderingEntry> >; nsTHashtable<EntryType>::KeyType = const mozilla::BlockingResourceBase*]" : true,
"EntryType* nsTHashtable<EntryType>::GetEntry(nsTHashtable<EntryType>::KeyType) const [with EntryType = nsBaseHashtableET<nsPtrHashKey<const mozilla::BlockingResourceBase>, nsAutoPtr<mozilla::DeadlockDetector<mozilla::BlockingResourceBase>::OrderingEntry> >; nsTHashtable<EntryType>::KeyType = const mozilla::BlockingResourceBase*]" : true,
// VTune internals that lazy-load a shared library and make IndirectCalls.
"iJIT_IsProfilingActive" : true,
"iJIT_NotifyEvent": true,
// The big hammers.
"PR_GetCurrentThread" : true,
"calloc" : true,
// This will happen early enough in initialization to not matter.
"_PR_UnixInit" : true,
"uint8 nsContentUtils::IsExpandedPrincipal(nsIPrincipal*)" : true,
"void mozilla::AutoProfilerLabel::~AutoProfilerLabel(int32)" : true,
// Stores a function pointer in an AutoProfilerLabelData struct and calls it.
// And it's in mozglue, which doesn't have access to the attributes yet.
"void mozilla::ProfilerLabelEnd(mozilla::Tuple<void*, unsigned int>*)" : true,
// This gets into PLDHashTable function pointer territory, and should get
// set up early enough to not do anything when it matters anyway.
"mozilla::LogModule* mozilla::LogModule::Get(int8*)": true,
// This annotation is correct, but the reasoning is still being hashed out
// in bug 1582326 comment 8 and on.
"nsCycleCollector.cpp:nsISupports* CanonicalizeXPCOMParticipant(nsISupports*)": true,
// PLDHashTable again
"void mozilla::DeadlockDetector<T>::Add(const T*) [with T = mozilla::BlockingResourceBase]": true,
// OOM handling during logging
"void mozilla::detail::log_print(mozilla::LogModule*, int32, int8*)": true,
// This would need to know that the nsCOMPtr refcount will not go to zero.
"uint8 XPCJSRuntime::DescribeCustomObjects(JSObject*, JSClass*, int8[72]*)[72]) const": true,
// As the comment says "Refcount isn't zero, so Suspect won't delete anything."
"uint64 nsCycleCollectingAutoRefCnt::incr(void*, nsCycleCollectionParticipant*) [with void (* suspect)(void*, nsCycleCollectionParticipant*, nsCycleCollectingAutoRefCnt*, bool*) = NS_CycleCollectorSuspect3; uintptr_t = long unsigned int]": true,
// Calls MergeSort
"uint8 v8::internal::RegExpDisjunction::SortConsecutiveAtoms(v8::internal::RegExpCompiler*)": true,
// nsIEventTarget.IsOnCurrentThreadInfallible does not get resolved, and
// this is called on non-JS threads so cannot use AutoSuppressGCAnalysis.
"uint8 nsAutoOwningEventTarget::IsCurrentThread() const": true,
// ~JSStreamConsumer calls 2 ~RefCnt/~nsCOMPtr destructors for its fields,
// but the body of the destructor is written so that all Releases
// are proxied, and the members will all be empty at destruction time.
"void mozilla::dom::JSStreamConsumer::~JSStreamConsumer() [[base_dtor]]": true,
};
function extraGCFunctions(readableNames) {
return ["ffi_call"].filter(f => f in readableNames);
}
function isProtobuf(name)
{
return name.match(/\bgoogle::protobuf\b/) ||
name.match(/\bmozilla::devtools::protobuf\b/);
}
function isHeapSnapshotMockClass(name)
{
return name.match(/\bMockWriter\b/) ||
name.match(/\bMockDeserializedNode\b/);
}
function isGTest(name)
{
return name.match(/\btesting::/);
}
function isICU(name)
{
return name.match(/\bicu_\d+::/) ||
name.match(/u(prv_malloc|prv_realloc|prv_free|case_toFullLower)_\d+/)
}
function ignoreGCFunction(mangled, readableNames)
{
// Field calls will not be in readableNames
if (!(mangled in readableNames))
return false;
const fun = readableNames[mangled][0];
if (fun in ignoreFunctions)
return true;
// The protobuf library, and [de]serialization code generated by the
// protobuf compiler, uses a _ton_ of function pointers but they are all
// internal. The same is true for ICU. Easiest to just ignore that mess
// here.
if (isProtobuf(fun) || isICU(fun))
return true;
// Ignore anything that goes through heap snapshot GTests or mocked classes
// used in heap snapshot GTests. GTest and GMock expose a lot of virtual
// methods and function pointers that could potentially GC after an
// assertion has already failed (depending on user-provided code), but don't
// exhibit that behavior currently. For non-test code, we have dynamic and
// static checks that ensure we don't GC. However, for test code we opt out
// of static checks here, because of the above stated GMock/GTest issues,
// and rely on only the dynamic checks provided by AutoAssertCannotGC.
if (isHeapSnapshotMockClass(fun) || isGTest(fun))
return true;
// Templatized function
if (fun.includes("void nsCOMPtr<T>::Assert_NoQueryNeeded()"))
return true;
// Bug 1577915 - Sixgill is ignoring a template param that makes its CFG
// impossible.
if (fun.includes("UnwrapObjectInternal") && fun.includes("mayBeWrapper = false"))
return true;
// These call through an 'op' function pointer.
if (fun.includes("js::WeakMap<Key, Value, HashPolicy>::getDelegate("))
return true;
// TODO: modify refillFreeList<NoGC> to not need data flow analysis to
// understand it cannot GC. As of gcc 6, the same problem occurs with
// tryNewTenuredThing, tryNewNurseryObject, and others.
if (/refillFreeList|tryNew/.test(fun) && /= js::NoGC/.test(fun))
return true;
return false;
}
function stripUCSAndNamespace(name)
{
name = name.replace(/(struct|class|union|const) /g, "");
name = name.replace(/(js::ctypes::|js::|JS::|mozilla::dom::|mozilla::)/g, "");
return name;
}
function extraRootedGCThings()
{
return [ 'JSAddonId' ];
}
function extraRootedPointers()
{
return [
];
}
function isRootedGCPointerTypeName(name)
{
name = stripUCSAndNamespace(name);
if (name.startsWith('MaybeRooted<'))
return /\(js::AllowGC\)1u>::RootType/.test(name);
return false;
}
function isUnsafeStorage(typeName)
{
typeName = stripUCSAndNamespace(typeName);
return typeName.startsWith('UniquePtr<');
}
// If edgeType is a constructor type, return whatever bits it implies for its
// scope (or zero if not matching).
function isLimitConstructor(typeInfo, edgeType, varName)
{
// Check whether this could be a constructor
if (edgeType.Kind != 'Function')
return 0;
if (!('TypeFunctionCSU' in edgeType))
return 0;
if (edgeType.Type.Kind != 'Void')
return 0;
// Check whether the type is a known suppression type.
var type = edgeType.TypeFunctionCSU.Type.Name;
let attrs = 0;
if (type in typeInfo.GCSuppressors)
attrs = attrs | ATTR_GC_SUPPRESSED;
// And now make sure this is the constructor, not some other method on a
// suppression type. varName[0] contains the qualified name.
var [ mangled, unmangled ] = splitFunction(varName[0]);
if (mangled.search(/C\d[EI]/) == -1)
return 0; // Mangled names of constructors have C<num>E or C<num>I
var m = unmangled.match(/([~\w]+)(?:<.*>)?\(/);
if (!m)
return 0;
var type_stem = type.replace(/\w+::/g, '').replace(/\<.*\>/g, '');
if (m[1] != type_stem)
return 0;
return attrs;
}
// XPIDL-generated methods may invoke JS code, depending on the IDL
// attributes. This is not visible in the static callgraph since it
// goes through generated asm code. We can use the JS_HAZ_CAN_RUN_SCRIPT
// annotation to tell whether this is possible, which is set programmatically
// by the code generator when needed (bug 1347999):
// https://searchfox.org/mozilla-central/rev/81c52abeec336685330af5956c37b4bcf8926476/xpcom/idl-parser/xpidl/header.py#213-219
//
// Note that WebIDL callbacks can also invoke JS code, but our code generator
// produces regular C++ code and so does not need any annotations. (There will
// be a call to JS::Call() or similar.)
function virtualCanRunJS(csu, field)
{
const tags = typeInfo.OtherFieldTags;
const iface = tags[csu]
if (!iface) {
return false;
}
const virtual_method_tags = iface[field];
return virtual_method_tags && virtual_method_tags.includes("Can run script");
}
function listNonGCPointers() {
return [
// Safe only because jsids are currently only made from pinned strings.
'NPIdentifier',
];
}
function isJSNative(mangled)
{
// _Z...E = function
// 9JSContext = JSContext*
// j = uint32
// PN2JS5Value = JS::Value*
// P = pointer
// N2JS = JS::
// 5Value = Value
return mangled.endsWith("P9JSContextjPN2JS5ValueE") && mangled.startsWith("_Z");
}
|