1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
|
/* Any copyright is dedicated to the Public Domain.
* http://creativecommons.org/publicdomain/zero/1.0/ */
"use strict";
const { ON_PROFILE_CHANGE_NOTIFICATION, log } = ChromeUtils.import(
"resource://gre/modules/FxAccountsCommon.js"
);
const { FxAccountsProfileClient } = ChromeUtils.import(
"resource://gre/modules/FxAccountsProfileClient.jsm"
);
const { FxAccountsProfile } = ChromeUtils.import(
"resource://gre/modules/FxAccountsProfile.jsm"
);
const { PromiseUtils } = ChromeUtils.importESModule(
"resource://gre/modules/PromiseUtils.sys.mjs"
);
const { setTimeout } = ChromeUtils.importESModule(
"resource://gre/modules/Timer.sys.mjs"
);
let mockClient = function(fxa) {
let options = {
serverURL: "http://127.0.0.1:1111/v1",
fxa,
};
return new FxAccountsProfileClient(options);
};
const ACCOUNT_UID = "abc123";
const ACCOUNT_EMAIL = "foo@bar.com";
const ACCOUNT_DATA = {
uid: ACCOUNT_UID,
email: ACCOUNT_EMAIL,
};
let mockFxa = function() {
let fxa = {
// helpers to make the tests using this mock less verbose...
set _testProfileCache(profileCache) {
this._internal.currentAccountState._data.profileCache = profileCache;
},
get _testProfileCache() {
return this._internal.currentAccountState._data.profileCache;
},
};
fxa._internal = Object.assign(
{},
{
currentAccountState: Object.assign(
{},
{
_data: Object.assign({}, ACCOUNT_DATA),
get isCurrent() {
return true;
},
async getUserAccountData() {
return this._data;
},
async updateUserAccountData(data) {
this._data = Object.assign(this._data, data);
},
}
),
withCurrentAccountState(cb) {
return cb(this.currentAccountState);
},
async _handleTokenError(err) {
// handleTokenError always rethrows.
throw err;
},
}
);
return fxa;
};
function CreateFxAccountsProfile(fxa = null, client = null) {
if (!fxa) {
fxa = mockFxa();
}
let options = {
fxai: fxa._internal,
profileServerUrl: "http://127.0.0.1:1111/v1",
};
if (client) {
options.profileClient = client;
}
return new FxAccountsProfile(options);
}
add_test(function cacheProfile_change() {
let setProfileCacheCalled = false;
let fxa = mockFxa();
fxa._internal.currentAccountState.updateUserAccountData = data => {
setProfileCacheCalled = true;
Assert.equal(data.profileCache.profile.avatar, "myurl");
Assert.equal(data.profileCache.etag, "bogusetag");
return Promise.resolve();
};
let profile = CreateFxAccountsProfile(fxa);
makeObserver(ON_PROFILE_CHANGE_NOTIFICATION, function(subject, topic, data) {
Assert.equal(data, ACCOUNT_DATA.uid);
Assert.ok(setProfileCacheCalled);
run_next_test();
});
return profile._cacheProfile({
body: { uid: ACCOUNT_UID, email: ACCOUNT_EMAIL, avatar: "myurl" },
etag: "bogusetag",
});
});
add_test(function fetchAndCacheProfile_ok() {
let client = mockClient(mockFxa());
client.fetchProfile = function() {
return Promise.resolve({ body: { uid: ACCOUNT_UID, avatar: "myimg" } });
};
let profile = CreateFxAccountsProfile(null, client);
profile._cachedAt = 12345;
profile._cacheProfile = function(toCache) {
Assert.equal(toCache.body.avatar, "myimg");
return Promise.resolve(toCache.body);
};
return profile._fetchAndCacheProfile().then(result => {
Assert.equal(result.avatar, "myimg");
Assert.notEqual(profile._cachedAt, 12345, "cachedAt has been bumped");
run_next_test();
});
});
add_test(function fetchAndCacheProfile_always_bumps_cachedAt() {
let client = mockClient(mockFxa());
client.fetchProfile = function() {
return Promise.reject(new Error("oops"));
};
let profile = CreateFxAccountsProfile(null, client);
profile._cachedAt = 12345;
return profile._fetchAndCacheProfile().then(
result => {
do_throw("Should not succeed");
},
err => {
Assert.notEqual(profile._cachedAt, 12345, "cachedAt has been bumped");
run_next_test();
}
);
});
add_test(function fetchAndCacheProfile_sendsETag() {
let fxa = mockFxa();
fxa._testProfileCache = { profile: {}, etag: "bogusETag" };
let client = mockClient(fxa);
client.fetchProfile = function(etag) {
Assert.equal(etag, "bogusETag");
return Promise.resolve({
body: { uid: ACCOUNT_UID, email: ACCOUNT_EMAIL, avatar: "myimg" },
});
};
let profile = CreateFxAccountsProfile(fxa, client);
return profile._fetchAndCacheProfile().then(result => {
run_next_test();
});
});
// Check that a second profile request when one is already in-flight reuses
// the in-flight one.
add_task(async function fetchAndCacheProfileOnce() {
// A promise that remains unresolved while we fire off 2 requests for
// a profile.
let resolveProfile;
let promiseProfile = new Promise(resolve => {
resolveProfile = resolve;
});
let numFetches = 0;
let client = mockClient(mockFxa());
client.fetchProfile = function() {
numFetches += 1;
return promiseProfile;
};
let fxa = mockFxa();
let profile = CreateFxAccountsProfile(fxa, client);
let request1 = profile._fetchAndCacheProfile();
profile._fetchAndCacheProfile();
await new Promise(res => setTimeout(res, 0)); // Yield so fetchProfile() is called (promise)
// should be one request made to fetch the profile (but the promise returned
// by it remains unresolved)
Assert.equal(numFetches, 1);
// resolve the promise.
resolveProfile({
body: { uid: ACCOUNT_UID, email: ACCOUNT_EMAIL, avatar: "myimg" },
});
// both requests should complete with the same data.
let got1 = await request1;
Assert.equal(got1.avatar, "myimg");
let got2 = await request1;
Assert.equal(got2.avatar, "myimg");
// and still only 1 request was made.
Assert.equal(numFetches, 1);
});
// Check that sharing a single fetch promise works correctly when the promise
// is rejected.
add_task(async function fetchAndCacheProfileOnce() {
// A promise that remains unresolved while we fire off 2 requests for
// a profile.
let rejectProfile;
let promiseProfile = new Promise((resolve, reject) => {
rejectProfile = reject;
});
let numFetches = 0;
let client = mockClient(mockFxa());
client.fetchProfile = function() {
numFetches += 1;
return promiseProfile;
};
let fxa = mockFxa();
let profile = CreateFxAccountsProfile(fxa, client);
let request1 = profile._fetchAndCacheProfile();
let request2 = profile._fetchAndCacheProfile();
await new Promise(res => setTimeout(res, 0)); // Yield so fetchProfile() is called (promise)
// should be one request made to fetch the profile (but the promise returned
// by it remains unresolved)
Assert.equal(numFetches, 1);
// reject the promise.
rejectProfile("oh noes");
// both requests should reject.
try {
await request1;
throw new Error("should have rejected");
} catch (ex) {
if (ex != "oh noes") {
throw ex;
}
}
try {
await request2;
throw new Error("should have rejected");
} catch (ex) {
if (ex != "oh noes") {
throw ex;
}
}
// but a new request should works.
client.fetchProfile = function() {
return Promise.resolve({
body: { uid: ACCOUNT_UID, email: ACCOUNT_EMAIL, avatar: "myimg" },
});
};
let got = await profile._fetchAndCacheProfile();
Assert.equal(got.avatar, "myimg");
});
add_test(function fetchAndCacheProfile_alreadyCached() {
let cachedUrl = "cachedurl";
let fxa = mockFxa();
fxa._testProfileCache = {
profile: { uid: ACCOUNT_UID, avatar: cachedUrl },
etag: "bogusETag",
};
let client = mockClient(fxa);
client.fetchProfile = function(etag) {
Assert.equal(etag, "bogusETag");
return Promise.resolve(null);
};
let profile = CreateFxAccountsProfile(fxa, client);
profile._cacheProfile = function(toCache) {
do_throw("This method should not be called.");
};
return profile._fetchAndCacheProfile().then(result => {
Assert.equal(result, null);
Assert.equal(fxa._testProfileCache.profile.avatar, cachedUrl);
run_next_test();
});
});
// Check that a new profile request within PROFILE_FRESHNESS_THRESHOLD of the
// last one doesn't kick off a new request to check the cached copy is fresh.
add_task(async function fetchAndCacheProfileAfterThreshold() {
/*
* This test was observed to cause a timeout for... any timer precision reduction.
* Even 1 us. Exact reason is still undiagnosed.
*/
Services.prefs.setBoolPref("privacy.reduceTimerPrecision", false);
registerCleanupFunction(async () => {
Services.prefs.clearUserPref("privacy.reduceTimerPrecision");
});
let numFetches = 0;
let client = mockClient(mockFxa());
client.fetchProfile = async function() {
numFetches += 1;
return {
body: { uid: ACCOUNT_UID, email: ACCOUNT_EMAIL, avatar: "myimg" },
};
};
let profile = CreateFxAccountsProfile(null, client);
profile.PROFILE_FRESHNESS_THRESHOLD = 1000;
// first fetch should return null as we don't have data.
let p = await profile.getProfile();
Assert.equal(p, null);
// ensure we kicked off a fetch.
Assert.notEqual(profile._currentFetchPromise, null);
// wait for that fetch to finish
await profile._currentFetchPromise;
Assert.equal(numFetches, 1);
Assert.equal(profile._currentFetchPromise, null);
await profile.getProfile();
Assert.equal(numFetches, 1);
Assert.equal(profile._currentFetchPromise, null);
await new Promise(resolve => {
do_timeout(1000, resolve);
});
let origFetchAndCatch = profile._fetchAndCacheProfile;
let backgroundFetchDone = PromiseUtils.defer();
profile._fetchAndCacheProfile = async () => {
await origFetchAndCatch.call(profile);
backgroundFetchDone.resolve();
};
await profile.getProfile();
await backgroundFetchDone.promise;
Assert.equal(numFetches, 2);
});
add_task(async function test_ensureProfile() {
let client = new FxAccountsProfileClient({
serverURL: "http://127.0.0.1:1111/v1",
fxa: mockFxa(),
});
let profile = CreateFxAccountsProfile(null, client);
const testCases = [
// profile retrieval when there is no cached profile info
{
threshold: 1000,
expectsCachedProfileReturned: false,
cachedProfile: null,
fetchedProfile: {
uid: ACCOUNT_UID,
email: ACCOUNT_EMAIL,
avatar: "myimg",
},
},
// profile retrieval when the cached profile is recent
{
// Note: The threshold for this test case is being set to an arbitrary value that will
// be greater than Date.now() so the retrieved cached profile will be deemed recent.
threshold: Date.now() + 5000,
expectsCachedProfileReturned: true,
cachedProfile: {
uid: `${ACCOUNT_UID}2`,
email: `${ACCOUNT_EMAIL}2`,
avatar: "myimg2",
},
},
// profile retrieval when the cached profile is old and a new profile is fetched
{
threshold: 1000,
expectsCachedProfileReturned: false,
cachedProfile: {
uid: `${ACCOUNT_UID}3`,
email: `${ACCOUNT_EMAIL}3`,
avatar: "myimg3",
},
fetchAndCacheProfileResolves: true,
fetchedProfile: {
uid: `${ACCOUNT_UID}4`,
email: `${ACCOUNT_EMAIL}4`,
avatar: "myimg4",
},
},
// profile retrieval when the cached profile is old and a null profile is fetched
{
threshold: 1000,
expectsCachedProfileReturned: false,
cachedProfile: {
uid: `${ACCOUNT_UID}5`,
email: `${ACCOUNT_EMAIL}5`,
avatar: "myimg5",
},
fetchAndCacheProfileResolves: true,
fetchedProfile: null,
},
// profile retrieval when the cached profile is old and fetching a new profile errors
{
threshold: 1000,
expectsCachedProfileReturned: false,
cachedProfile: {
uid: `${ACCOUNT_UID}6`,
email: `${ACCOUNT_EMAIL}6`,
avatar: "myimg6",
},
fetchAndCacheProfileResolves: false,
},
// profile retrieval when we've cached a failure to fetch profile data
{
// Note: The threshold for this test case is being set to an arbitrary value that will
// be greater than Date.now() so the retrieved cached profile will be deemed recent.
threshold: Date.now() + 5000,
expectsCachedProfileReturned: false,
cachedProfile: null,
fetchedProfile: {
uid: `${ACCOUNT_UID}7`,
email: `${ACCOUNT_EMAIL}7`,
avatar: "myimg7",
},
fetchAndCacheProfileResolves: true,
},
// profile retrieval when the cached profile is old but staleOk is true.
{
threshold: 1000,
expectsCachedProfileReturned: true,
cachedProfile: {
uid: `${ACCOUNT_UID}8`,
email: `${ACCOUNT_EMAIL}8`,
avatar: "myimg8",
},
fetchAndCacheProfileResolves: false,
options: { staleOk: true },
},
// staleOk but no cached profile
{
threshold: 1000,
expectsCachedProfileReturned: false,
cachedProfile: null,
fetchedProfile: {
uid: `${ACCOUNT_UID}9`,
email: `${ACCOUNT_EMAIL}9`,
avatar: "myimg9",
},
options: { staleOk: true },
},
// fresh profile but forceFresh = true
{
// Note: The threshold for this test case is being set to an arbitrary value that will
// be greater than Date.now() so the retrieved cached profile will be deemed recent.
threshold: Date.now() + 5000,
expectsCachedProfileReturned: false,
fetchedProfile: {
uid: `${ACCOUNT_UID}10`,
email: `${ACCOUNT_EMAIL}10`,
avatar: "myimg10",
},
options: { forceFresh: true },
},
];
for (const tc of testCases) {
print(`test case: ${JSON.stringify(tc)}`);
let mockProfile = sinon.mock(profile);
mockProfile
.expects("_getProfileCache")
.once()
.returns(
tc.cachedProfile
? {
profile: tc.cachedProfile,
}
: null
);
profile.PROFILE_FRESHNESS_THRESHOLD = tc.threshold;
let options = tc.options || {};
if (tc.expectsCachedProfileReturned) {
mockProfile.expects("_fetchAndCacheProfile").never();
let actualProfile = await profile.ensureProfile(options);
mockProfile.verify();
Assert.equal(actualProfile, tc.cachedProfile);
} else if (tc.fetchAndCacheProfileResolves) {
mockProfile
.expects("_fetchAndCacheProfile")
.once()
.resolves(tc.fetchedProfile);
let actualProfile = await profile.ensureProfile(options);
let expectedProfile = tc.fetchedProfile
? tc.fetchedProfile
: tc.cachedProfile;
mockProfile.verify();
Assert.equal(actualProfile, expectedProfile);
} else {
mockProfile
.expects("_fetchAndCacheProfile")
.once()
.rejects();
let actualProfile = await profile.ensureProfile(options);
mockProfile.verify();
Assert.equal(actualProfile, tc.cachedProfile);
}
}
});
// Check that a new profile request within PROFILE_FRESHNESS_THRESHOLD of the
// last one *does* kick off a new request if ON_PROFILE_CHANGE_NOTIFICATION
// is sent.
add_task(async function fetchAndCacheProfileBeforeThresholdOnNotification() {
let numFetches = 0;
let client = mockClient(mockFxa());
client.fetchProfile = async function() {
numFetches += 1;
return {
body: { uid: ACCOUNT_UID, email: ACCOUNT_EMAIL, avatar: "myimg" },
};
};
let profile = CreateFxAccountsProfile(null, client);
profile.PROFILE_FRESHNESS_THRESHOLD = 1000;
// first fetch should return null as we don't have data.
let p = await profile.getProfile();
Assert.equal(p, null);
// ensure we kicked off a fetch.
Assert.notEqual(profile._currentFetchPromise, null);
// wait for that fetch to finish
await profile._currentFetchPromise;
Assert.equal(numFetches, 1);
Assert.equal(profile._currentFetchPromise, null);
Services.obs.notifyObservers(null, ON_PROFILE_CHANGE_NOTIFICATION);
let origFetchAndCatch = profile._fetchAndCacheProfile;
let backgroundFetchDone = PromiseUtils.defer();
profile._fetchAndCacheProfile = async () => {
await origFetchAndCatch.call(profile);
backgroundFetchDone.resolve();
};
await profile.getProfile();
await backgroundFetchDone.promise;
Assert.equal(numFetches, 2);
});
add_test(function tearDown_ok() {
let profile = CreateFxAccountsProfile();
Assert.ok(!!profile.client);
Assert.ok(!!profile.fxai);
profile.tearDown();
Assert.equal(null, profile.fxai);
Assert.equal(null, profile.client);
run_next_test();
});
add_task(async function getProfile_ok() {
let cachedUrl = "myurl";
let didFetch = false;
let fxa = mockFxa();
fxa._testProfileCache = { profile: { uid: ACCOUNT_UID, avatar: cachedUrl } };
let profile = CreateFxAccountsProfile(fxa);
profile._fetchAndCacheProfile = function() {
didFetch = true;
return Promise.resolve();
};
let result = await profile.getProfile();
Assert.equal(result.avatar, cachedUrl);
Assert.ok(didFetch);
});
add_task(async function getProfile_no_cache() {
let fetchedUrl = "newUrl";
let fxa = mockFxa();
let profile = CreateFxAccountsProfile(fxa);
profile._fetchAndCacheProfileInternal = function() {
return Promise.resolve({ uid: ACCOUNT_UID, avatar: fetchedUrl });
};
await profile.getProfile(); // returns null.
let result = await profile._currentFetchPromise;
Assert.equal(result.avatar, fetchedUrl);
});
add_test(function getProfile_has_cached_fetch_deleted() {
let cachedUrl = "myurl";
let fxa = mockFxa();
let client = mockClient(fxa);
client.fetchProfile = function() {
return Promise.resolve({
body: { uid: ACCOUNT_UID, email: ACCOUNT_EMAIL, avatar: null },
});
};
let profile = CreateFxAccountsProfile(fxa, client);
fxa._testProfileCache = {
profile: { uid: ACCOUNT_UID, email: ACCOUNT_EMAIL, avatar: cachedUrl },
};
// instead of checking this in a mocked "save" function, just check after the
// observer
makeObserver(ON_PROFILE_CHANGE_NOTIFICATION, function(subject, topic, data) {
profile.getProfile().then(profileData => {
Assert.equal(null, profileData.avatar);
run_next_test();
});
});
return profile.getProfile().then(result => {
Assert.equal(result.avatar, "myurl");
});
});
add_test(function getProfile_fetchAndCacheProfile_throws() {
let fxa = mockFxa();
fxa._testProfileCache = {
profile: { uid: ACCOUNT_UID, email: ACCOUNT_EMAIL, avatar: "myimg" },
};
let profile = CreateFxAccountsProfile(fxa);
profile._fetchAndCacheProfile = () => Promise.reject(new Error());
return profile.getProfile().then(result => {
Assert.equal(result.avatar, "myimg");
run_next_test();
});
});
add_test(function getProfile_email_changed() {
let fxa = mockFxa();
let client = mockClient(fxa);
client.fetchProfile = function() {
return Promise.resolve({
body: { uid: ACCOUNT_UID, email: "newemail@bar.com" },
});
};
fxa._internal._handleEmailUpdated = email => {
Assert.equal(email, "newemail@bar.com");
run_next_test();
};
let profile = CreateFxAccountsProfile(fxa, client);
return profile._fetchAndCacheProfile();
});
function makeObserver(aObserveTopic, aObserveFunc) {
let callback = function(aSubject, aTopic, aData) {
log.debug("observed " + aTopic + " " + aData);
if (aTopic == aObserveTopic) {
removeMe();
aObserveFunc(aSubject, aTopic, aData);
}
};
function removeMe() {
log.debug("removing observer for " + aObserveTopic);
Services.obs.removeObserver(callback, aObserveTopic);
}
Services.obs.addObserver(callback, aObserveTopic);
return removeMe;
}
|