1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
|
/* Any copyright is dedicated to the Public Domain.
* http://creativecommons.org/publicdomain/zero/1.0/ */
"use strict";
// ------------------------------------------------------------------------------
// Requirements
// ------------------------------------------------------------------------------
var rule = require("../lib/rules/reject-globalThis-modification");
var RuleTester = require("eslint").RuleTester;
const ruleTester = new RuleTester();
// ------------------------------------------------------------------------------
// Tests
// ------------------------------------------------------------------------------
function invalidCall(code) {
return {
code,
errors: [
{
message:
"`globalThis` shouldn't be passed to function that can modify it. `globalThis` is the shared global inside the system module, and properties defined on it is visible from all modules.",
type: "CallExpression",
},
],
};
}
function invalidAssignment(code) {
return {
code,
errors: [
{
message:
"`globalThis` shouldn't be modified. `globalThis` is the shared global inside the system module, and properties defined on it is visible from all modules.",
type: "AssignmentExpression",
},
],
};
}
ruleTester.run("reject-globalThis-modification", rule, {
valid: [
`var x = globalThis.Array;`,
`Array in globalThis;`,
`result.deserialize(globalThis)`,
],
invalid: [
invalidAssignment(`
globalThis.foo = 10;
`),
invalidCall(`
Object.defineProperty(globalThis, "foo", { value: 10 });
`),
invalidCall(`
Object.defineProperties(globalThis, {
foo: { value: 10 },
});
`),
invalidCall(`
Object.assign(globalThis, { foo: 10 });
`),
invalidCall(`
ChromeUtils.defineModuleGetter(
globalThis, "AppConstants", "resource://gre/modules/AppConstants.jsm"
);
`),
invalidCall(`
ChromeUtils.defineESMGetters(globalThis, {
AppConstants: "resource://gre/modules/AppConstants.sys.mjs",
});
`),
invalidCall(`
XPCOMUtils.defineLazyModuleGetter(
globalThis, "AppConstants", "resource://gre/modules/AppConstants.jsm"
);
`),
invalidCall(`
XPCOMUtils.defineLazyModuleGetters(globalThis, {
AppConstants: "resource://gre/modules/AppConstants.jsm",
});
`),
invalidCall(`
someFunction(1, globalThis);
`),
],
});
|
