Adding upstream version 4:7.4.7.upstream/4%7.4.7upstream

Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>

1 files changed, 191 insertions, 0 deletions

diff --git a/compilerplugins/clang/test/flatten.cxx b/compilerplugins/clang/test/flatten.cxx
new file mode 100644
index 000000000..300067b9b
--- /dev/null
+++ b/compilerplugins/clang/test/flatten.cxx
@@ -0,0 +1,191 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include <exception>
+
+extern int foo();
+extern int bar(int = 0);
+class Class {};
+
+void top1() {
+    if (foo() == 1) { // expected-note {{if condition here [loplugin:flatten]}}
+        foo();
+    } else {
+        throw std::exception(); // expected-error {{unconditional throw in else branch, rather invert the condition, throw early, and flatten the normal case [loplugin:flatten]}}
+    }
+    if (foo() == 1) {
+        Class aClass;
+        (void)aClass;
+    } else {
+        throw std::exception(); // no warning expected
+    }
+    if (foo() == 1) { // expected-note {{if condition here [loplugin:flatten]}}
+        Class aClass;
+        (void)aClass;
+    } else {
+        throw std::exception(); // expected-error {{unconditional throw in else branch, rather invert the condition, throw early, and flatten the normal case [loplugin:flatten]}}
+    }
+}
+
+void top2() {
+    if (foo() == 2) {
+        throw std::exception(); // expected-error {{unconditional throw in then branch, just flatten the else [loplugin:flatten]}}
+    } else {
+        foo();
+    }
+    if (foo() == 2) {
+        throw std::exception(); // no warning expected
+    } else {
+        Class aClass;
+        (void)aClass;
+    }
+    if (foo() == 2) {
+        throw std::exception(); // expected-error {{unconditional throw in then branch, just flatten the else [loplugin:flatten]}}
+    } else {
+        Class aClass;
+        (void)aClass;
+    }
+}
+
+void top3() {
+    // no warning expected
+    if (foo() == 2) {
+        throw std::exception();
+    } else {
+        Class aClass;
+        (void)aClass;
+    }
+    int x = 1;
+    (void)x;
+}
+
+void top4() {
+    // no warning expected
+    if (foo() == 2) {
+        Class aClass;
+        (void)aClass;
+    } else {
+        throw std::exception();
+    }
+    int x = 1;
+    (void)x;
+}
+
+void top5() {
+#if 1
+    if (foo() == 2) {
+        if (foo() == 3) { // expected-note {{if condition here [loplugin:flatten]}}
+            bar();
+        } else {
+            throw std::exception(); // expected-error {{unconditional throw in else branch, rather invert the condition, throw early, and flatten the normal case [loplugin:flatten]}}
+        }
+    } else
+#endif
+        throw std::exception(); // no warning expected
+}
+
+int main() {
+    // no warning expected
+    if (bar() == 3) {
+        throw std::exception();
+    } else {
+        throw std::exception();
+    }
+}
+
+void top6() {
+    // no warning expected
+    if (foo() == 2) {
+        Class aClass;
+        (void)aClass;
+    } else if (foo() == 2) {
+        Class aClass;
+        (void)aClass;
+    } else {
+        throw std::exception();
+    }
+    int x = 1;
+    (void)x;
+}
+
+void top7() {
+    // no warning expected
+    if (foo() == 1) {
+        throw std::exception();
+    } else if (foo() == 2) {
+        throw std::exception();
+    } else {
+        throw std::exception();
+    }
+}
+
+void top8() {
+    if (foo() == 1) {
+        if (foo() == 2) {
+            throw std::exception(); // expected-error {{unconditional throw in then branch, just flatten the else [loplugin:flatten]}}
+        } else {
+            bar();
+        }
+    } else if (foo() == 2) {
+        bar(1);
+    } else {
+        bar(2);
+    }
+}
+
+void top9() {
+    if (foo() == 1) { // expected-error {{large if statement at end of function, rather invert the condition and exit early, and flatten the function [loplugin:flatten]}}
+        Class aClass1;
+        (void)aClass1;
+        Class aClass2;
+        (void)aClass2;
+        Class aClass3;
+        (void)aClass3;
+        Class aClass4;
+        (void)aClass4;
+        Class aClass5;
+        (void)aClass5;
+        Class aClass6;
+        (void)aClass6;
+    }
+}
+
+void top10() {
+    // no warning expected
+    if (foo() == 2) {
+        if (foo() == 1) {
+            Class aClass1;
+            (void)aClass1;
+            Class aClass2;
+            (void)aClass2;
+            Class aClass3;
+            (void)aClass3;
+        }
+    }
+}
+
+int top11() {
+    // no warning expected
+    if (foo() == 1) {
+        Class aClass1;
+        (void)aClass1;
+        Class aClass2;
+        (void)aClass2;
+        Class aClass3;
+        (void)aClass3;
+        Class aClass4;
+        (void)aClass4;
+        Class aClass5;
+        (void)aClass5;
+        Class aClass6;
+        (void)aClass6;
+    }
+    return 1;
+}
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */