diff options
author | Daniel Baumann <daniel.baumann@progress-linux.org> | 2024-04-07 09:06:44 +0000 |
---|---|---|
committer | Daniel Baumann <daniel.baumann@progress-linux.org> | 2024-04-07 09:06:44 +0000 |
commit | ed5640d8b587fbcfed7dd7967f3de04b37a76f26 (patch) | |
tree | 7a5f7c6c9d02226d7471cb3cc8fbbf631b415303 /compilerplugins/clang/typeidcomparison.cxx | |
parent | Initial commit. (diff) | |
download | libreoffice-upstream.tar.xz libreoffice-upstream.zip |
Adding upstream version 4:7.4.7.upstream/4%7.4.7upstream
Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>
Diffstat (limited to '')
-rw-r--r-- | compilerplugins/clang/typeidcomparison.cxx | 90 |
1 files changed, 90 insertions, 0 deletions
diff --git a/compilerplugins/clang/typeidcomparison.cxx b/compilerplugins/clang/typeidcomparison.cxx new file mode 100644 index 000000000..359231f26 --- /dev/null +++ b/compilerplugins/clang/typeidcomparison.cxx @@ -0,0 +1,90 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +// Find (in-)equality comparisons between typeid expressions that can never succeed. For now, just +// detects cases where the two involved types are structurally different, one a pointer type and the +// other a non-pointer type. + +#ifndef LO_CLANG_SHARED_PLUGINS + +#include "plugin.hxx" + +namespace +{ +class TypeidComparison final : public loplugin::FilteringPlugin<TypeidComparison> +{ +public: + explicit TypeidComparison(loplugin::InstantiationData const& data) + : FilteringPlugin(data) + { + } + + // For CXXRewrittenBinaryOperator `typeid(...) != typeid(...)`: + bool shouldVisitImplicitCode() const { return true; } + + bool preRun() override { return compiler.getLangOpts().CPlusPlus; } + + void run() override + { + if (preRun()) + { + TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); + } + } + + bool VisitCXXOperatorCallExpr(CXXOperatorCallExpr const* expr) + { + if (ignoreLocation(expr)) + { + return true; + } + auto const op = expr->getOperator(); + if (op != OO_EqualEqual && op != OO_ExclaimEqual) + { + return true; + } + assert(expr->getNumArgs() == 2); + auto const e1 = dyn_cast<CXXTypeidExpr>(expr->getArg(0)->IgnoreParenImpCasts()); + if (e1 == nullptr) + { + return true; + } + auto const e2 = dyn_cast<CXXTypeidExpr>(expr->getArg(1)->IgnoreParenImpCasts()); + if (e2 == nullptr) + { + return true; + } + auto const t1 = getOperandType(e1); + auto const t2 = getOperandType(e2); + if (t1->isPointerType() == t2->isPointerType()) + { + return true; + } + report(DiagnosticsEngine::Warning, + "comparison of type info of mixed pointer and non-pointer types %0 and %1 can never " + "succeed", + expr->getExprLoc()) + << t1 << t2 << expr->getSourceRange(); + return true; + } + +private: + QualType getOperandType(CXXTypeidExpr const* expr) + { + return expr->isTypeOperand() ? expr->getTypeOperand(compiler.getASTContext()) + : expr->getExprOperand()->getType(); + } +}; + +static loplugin::Plugin::Registration<TypeidComparison> typeidcomparison("typeidcomparison"); +} + +#endif + +/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ |