/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ /* * This file is part of the LibreOffice project. * * This Source Code Form is subject to the terms of the Mozilla Public * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include // defines of slot-IDs using namespace css; namespace sc_apitest { class ScShapeTest : public CalcUnoApiTest { public: ScShapeTest(); void saveAndReload(css::uno::Reference& xComponent, const OUString& rFilter); void testTdf143619_validation_circle_pos(); void testTdf140252_DragCreateFormControl(); void testTdf134355_DragCreateCustomShape(); void testTdf140252_LayerOfControl(); void testTdf137082_LTR_to_RTL(); void testTdf137082_RTL_cell_anchored(); void testTdf137081_RTL_page_anchored(); void testTdf139583_Rotate180deg(); void testTdf137033_FlipHori_Resize(); void testTdf137033_RotShear_ResizeHide(); void testTdf137033_RotShear_Hide(); void testTdf137576_LogicRectInDefaultMeasureline(); void testTdf137576_LogicRectInNewMeasureline(); void testMeasurelineHideColSave(); void testHideColsShow(); void testTdf138138_MoveCellWithRotatedShape(); void testLoadVerticalFlip(); void testTdf117948_CollapseBeforeShape(); void testTdf137355_UndoHideRows(); void testTdf152081_UndoHideColsWithNotes(); void testTdf115655_HideDetail(); void testFitToCellSize(); void testCustomShapeCellAnchoredRotatedShape(); void testTdf144242_Line_noSwapWH(); void testTdf144242_OpenBezier_noSwapWH(); void testLargeAnchorOffset(); CPPUNIT_TEST_SUITE(ScShapeTest); CPPUNIT_TEST(testTdf143619_validation_circle_pos); CPPUNIT_TEST(testTdf140252_DragCreateFormControl); CPPUNIT_TEST(testTdf134355_DragCreateCustomShape); CPPUNIT_TEST(testTdf140252_LayerOfControl); CPPUNIT_TEST(testTdf137082_LTR_to_RTL); CPPUNIT_TEST(testTdf137082_RTL_cell_anchored); CPPUNIT_TEST(testTdf137081_RTL_page_anchored); CPPUNIT_TEST(testTdf139583_Rotate180deg); CPPUNIT_TEST(testTdf137033_FlipHori_Resize); CPPUNIT_TEST(testTdf137033_RotShear_ResizeHide); CPPUNIT_TEST(testTdf137033_RotShear_Hide); CPPUNIT_TEST(testTdf137576_LogicRectInDefaultMeasureline); CPPUNIT_TEST(testTdf137576_LogicRectInNewMeasureline); CPPUNIT_TEST(testMeasurelineHideColSave); CPPUNIT_TEST(testHideColsShow); CPPUNIT_TEST(testTdf138138_MoveCellWithRotatedShape); CPPUNIT_TEST(testLoadVerticalFlip); CPPUNIT_TEST(testTdf117948_CollapseBeforeShape); CPPUNIT_TEST(testTdf137355_UndoHideRows); CPPUNIT_TEST(testTdf152081_UndoHideColsWithNotes); CPPUNIT_TEST(testTdf115655_HideDetail); CPPUNIT_TEST(testFitToCellSize); CPPUNIT_TEST(testCustomShapeCellAnchoredRotatedShape); CPPUNIT_TEST(testTdf144242_Line_noSwapWH); CPPUNIT_TEST(testTdf144242_OpenBezier_noSwapWH); CPPUNIT_TEST(testLargeAnchorOffset); CPPUNIT_TEST_SUITE_END(); }; ScShapeTest::ScShapeTest() : CalcUnoApiTest("sc/qa/unit/data/ods") { } void ScShapeTest::saveAndReload(css::uno::Reference& xComponent, const OUString& rFilter) { utl::TempFile aTempFile; aTempFile.EnableKillingFile(); css::uno::Sequence aArgs{ comphelper::makePropertyValue("FilterName", rFilter) }; // e.g. "calc8" css::uno::Reference xStorable(xComponent, css::uno::UNO_QUERY_THROW); xStorable->storeAsURL(aTempFile.GetURL(), aArgs); css::uno::Reference xCloseable(xComponent, css::uno::UNO_QUERY_THROW); xCloseable->close(true); xComponent = loadFromDesktop(aTempFile.GetURL(), "com.sun.star.sheet.SpreadsheetDocument"); } static void lcl_AssertRectEqualWithTolerance(std::string_view sInfo, const tools::Rectangle& rExpected, const tools::Rectangle& rActual, const sal_Int32 nTolerance) { // Left OString sMsg = OString::Concat(sInfo) + " Left expected " + OString::number(rExpected.Left()) + " actual " + OString::number(rActual.Left()) + " Tolerance " + OString::number(nTolerance); CPPUNIT_ASSERT_MESSAGE(sMsg.getStr(), std::abs(rExpected.Left() - rActual.Left()) <= nTolerance); // Top sMsg = OString::Concat(sInfo) + " Top expected " + OString::number(rExpected.Top()) + " actual " + OString::number(rActual.Top()) + " Tolerance " + OString::number(nTolerance); CPPUNIT_ASSERT_MESSAGE(sMsg.getStr(), std::abs(rExpected.Top() - rActual.Top()) <= nTolerance); // Width sMsg = OString::Concat(sInfo) + " Width expected " + OString::number(rExpected.GetWidth()) + " actual " + OString::number(rActual.GetWidth()) + " Tolerance " + OString::number(nTolerance); CPPUNIT_ASSERT_MESSAGE(sMsg.getStr(), std::abs(rExpected.GetWidth() - rActual.GetWidth()) <= nTolerance); // Height sMsg = OString::Concat(sInfo) + " Height expected " + OString::number(rExpected.GetHeight()) + " actual " + OString::number(rActual.GetHeight()) + " Tolerance " + OString::number(nTolerance); CPPUNIT_ASSERT_MESSAGE(sMsg.getStr(), std::abs(rExpected.GetHeight() - rActual.GetHeight()) <= nTolerance); } static void lcl_AssertPointEqualWithTolerance(std::string_view sInfo, const Point rExpected, const Point rActual, const sal_Int32 nTolerance) { // X OString sMsg = OString::Concat(sInfo) + " X expected " + OString::number(rExpected.X()) + " actual " + OString::number(rActual.X()) + " Tolerance " + OString::number(nTolerance); CPPUNIT_ASSERT_MESSAGE(sMsg.getStr(), std::abs(rExpected.X() - rActual.X()) <= nTolerance); // Y sMsg = OString::Concat(sInfo) + " Y expected " + OString::number(rExpected.Y()) + " actual " + OString::number(rActual.Y()) + " Tolerance " + OString::number(nTolerance); CPPUNIT_ASSERT_MESSAGE(sMsg.getStr(), std::abs(rExpected.Y() - rActual.Y()) <= nTolerance); } static ScDocShell* lcl_getScDocShellWithAssert(css::uno::Reference& xComponent) { SfxObjectShell* pFoundShell = SfxObjectShell::GetShellFromComponent(xComponent); CPPUNIT_ASSERT_MESSAGE("Failed to access document shell", pFoundShell); ScDocShell* pDocSh = dynamic_cast(pFoundShell); CPPUNIT_ASSERT(pDocSh); return pDocSh; } static ScTabViewShell* lcl_getScTabViewShellWithAssert(ScDocShell* pDocSh) { ScTabViewShell* pTabViewShell = pDocSh->GetBestViewShell(false); CPPUNIT_ASSERT_MESSAGE("No ScTabViewShell", pTabViewShell); return pTabViewShell; } static SdrPage* lcl_getSdrPageWithAssert(ScDocument& rDoc) { ScDrawLayer* pDrawLayer = rDoc.GetDrawLayer(); CPPUNIT_ASSERT_MESSAGE("No ScDrawLayer", pDrawLayer); SdrPage* pPage = pDrawLayer->GetPage(0); CPPUNIT_ASSERT_MESSAGE("No draw page", pPage); return pPage; } static SdrObject* lcl_getSdrObjectWithAssert(ScDocument& rDoc, sal_uInt16 nObjNumber) { ScDrawLayer* pDrawLayer = rDoc.GetDrawLayer(); CPPUNIT_ASSERT_MESSAGE("No ScDrawLayer", pDrawLayer); const SdrPage* pPage = pDrawLayer->GetPage(0); CPPUNIT_ASSERT_MESSAGE("No draw page", pPage); SdrObject* pObj = pPage->GetObj(nObjNumber); OString sMsg = "no Object " + OString::number(nObjNumber); CPPUNIT_ASSERT_MESSAGE(sMsg.getStr(), pObj); return pObj; } void ScShapeTest::testTdf144242_OpenBezier_noSwapWH() { // Shapes, which have rotation incorporated in their points, got erroneously width-height // swapped, because they report a rotation. (Rotation was introduced to align text with curve.) // Create a spreadsheet document with default row height and col width uno::Reference xComponent = loadFromDesktop("private:factory/scalc", "com.sun.star.sheet.SpreadsheetDocument"); // Get ScDocShell ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); // Insert default open Bezier curve ScTabViewShell* pTabViewShell = lcl_getScTabViewShellWithAssert(pDocSh); SfxRequest aReq(pTabViewShell->GetViewFrame(), SID_DRAW_BEZIER_NOFILL); aReq.SetModifier(KEY_MOD1); // Ctrl pTabViewShell->ExecDraw(aReq); pTabViewShell->SetDrawShell(false); // Get document and newly created object ScDocument& rDoc = pDocSh->GetDocument(); SdrObject* pObj = lcl_getSdrObjectWithAssert(rDoc, 0); // Rotate object by 300deg pObj->Rotate(pObj->GetSnapRect().Center(), 30000_deg100, sin(toRadians(30000_deg100)), cos(toRadians(30000_deg100))); tools::Rectangle aExpectRect(pObj->GetSnapRect()); // Save, reload and compare saveAndReload(xComponent, "Calc Office Open XML"); pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc2 = pDocSh->GetDocument(); pObj = lcl_getSdrObjectWithAssert(rDoc2, 0); tools::Rectangle aSnapRect(pObj->GetSnapRect()); // Without fix in place width and height were swapped lcl_AssertRectEqualWithTolerance("Reload: wrong pos and size", aExpectRect, aSnapRect, 40); pDocSh->DoClose(); } void ScShapeTest::testTdf144242_Line_noSwapWH() { // Shapes, which have rotation incorporated in their points, got erroneously width-height // swapped, because they report a rotation. (Rotation was introduced to align text with line.) // Create a spreadsheet document with default row height and col width uno::Reference xComponent = loadFromDesktop("private:factory/scalc", "com.sun.star.sheet.SpreadsheetDocument"); // Get ScDocShell ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); // Insert default line ScTabViewShell* pTabViewShell = lcl_getScTabViewShellWithAssert(pDocSh); SfxRequest aReq(pTabViewShell->GetViewFrame(), SID_DRAW_LINE); aReq.SetModifier(KEY_MOD1); // Ctrl pTabViewShell->ExecDraw(aReq); pTabViewShell->SetDrawShell(false); // Get document and newly created object ScDocument& rDoc = pDocSh->GetDocument(); SdrObject* pObj = lcl_getSdrObjectWithAssert(rDoc, 0); // Rotate object by 300deg pObj->Rotate(pObj->GetSnapRect().Center(), 30000_deg100, sin(toRadians(30000_deg100)), cos(toRadians(30000_deg100))); tools::Rectangle aExpectRect(pObj->GetSnapRect()); // Save, reload and compare saveAndReload(xComponent, "Calc Office Open XML"); pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc2 = pDocSh->GetDocument(); pObj = lcl_getSdrObjectWithAssert(rDoc2, 0); tools::Rectangle aSnapRect(pObj->GetSnapRect()); // Without fix in place width and height were swapped lcl_AssertRectEqualWithTolerance("Reload: wrong pos and size", aExpectRect, aSnapRect, 40); pDocSh->DoClose(); } void ScShapeTest::testTdf143619_validation_circle_pos() { // Load a document, which has validation circle around cell E6. OUString aFileURL; createFileURL(u"tdf143619_validationCirclePos.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); // Get shape. That is the validation circle. SdrObject* pObj = lcl_getSdrObjectWithAssert(rDoc, 0); // Error was, that deleting row and col before E6 does not move circle to D5, but to B3. // Delete first row and first column. uno::Sequence aPropertyValues = { comphelper::makePropertyValue("ToPoint", OUString("$A$1")), }; dispatchCommand(xComponent, ".uno:GoToCell", aPropertyValues); dispatchCommand(xComponent, ".uno:DeleteRows", {}); dispatchCommand(xComponent, ".uno:GoToCell", aPropertyValues); dispatchCommand(xComponent, ".uno:DeleteColumns", {}); // Without fix in place the position was (2007, 833) Point aPos = pObj->GetSnapRect().TopLeft(); lcl_AssertPointEqualWithTolerance("after row and col delete", Point(6523, 1736), aPos, 1); pDocSh->DoClose(); } void ScShapeTest::testTdf140252_DragCreateFormControl() { // Error was, that drag-created form controls were initially not on layer 'controls' and thus // other shapes could be placed in front of form controls. // Load an empty document. OUString aFileURL; createFileURL(u"ManualColWidthRowHeight.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get ScTabViewShell ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScTabViewShell* pTabViewShell = lcl_getScTabViewShellWithAssert(pDocSh); // drag-create a push button as example of form control SfxUInt16Item aIdentifierItem(SID_FM_CONTROL_IDENTIFIER, static_cast(SdrObjKind::FormButton)); SfxUInt32Item aInventorItem(SID_FM_CONTROL_INVENTOR, sal_uInt32(SdrInventor::FmForm)); const SfxPoolItem* pArgs[] = { &aIdentifierItem, &aInventorItem, nullptr }; pTabViewShell->GetViewData().GetDispatcher().Execute(SID_FM_CREATE_CONTROL, SfxCallMode::SYNCHRON, pArgs); // above includes creation of FuConstUnoControl and call of its Activate() method // get FuConstUnoControl ScTabView* pTabView = pTabViewShell->GetViewData().GetView(); CPPUNIT_ASSERT(pTabView); FuConstUnoControl* pFuConstUC = static_cast(pTabView->GetDrawFuncPtr()); CPPUNIT_ASSERT(pFuConstUC); // drag-create shape, points are in pixel MouseEvent aMouseEvent(Point(50, 100), 1, MouseEventModifiers::NONE, MOUSE_LEFT, 0); pFuConstUC->MouseButtonDown(aMouseEvent); aMouseEvent = MouseEvent(Point(200, 250), 1, MouseEventModifiers::DRAGMOVE, MOUSE_LEFT, 0); pFuConstUC->MouseMove(aMouseEvent); aMouseEvent = MouseEvent(Point(200, 250), 1, MouseEventModifiers::NONE, MOUSE_LEFT, 0); pFuConstUC->MouseButtonUp(aMouseEvent); pFuConstUC->Deactivate(); pTabViewShell->SetDrawShell(false); // Get document and newly created push button. ScDocument& rDoc = pDocSh->GetDocument(); SdrUnoObj* pObj = static_cast(lcl_getSdrObjectWithAssert(rDoc, 0)); // Without the fix in place, the shape would be on layer SC_LAYER_FRONT (0) sal_Int16 nExpectedID = SC_LAYER_CONTROLS.get(); sal_Int16 nActualID = pObj->GetLayer().get(); CPPUNIT_ASSERT_EQUAL(nExpectedID, nActualID); pDocSh->DoClose(); } void ScShapeTest::testTdf134355_DragCreateCustomShape() { // Error was, that drag-created custom shapes were initially on layer "controls", although that // layer is exclusively for form controls. Effect was, that other shapes could not be brought in // front of custom shapes. // Load an empty document. OUString aFileURL; createFileURL(u"ManualColWidthRowHeight.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get ScTabView ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScTabViewShell* pTabViewShell = lcl_getScTabViewShellWithAssert(pDocSh); ScTabView* pTabView = pTabViewShell->GetViewData().GetView(); // drag-create custom shape uno::Sequence aPropertyValues = { comphelper::makePropertyValue("SymbolShapes", OUString("smiley")), }; dispatchCommand(xComponent, ".uno:SymbolShapes", aPropertyValues); // above includes creation of FuConstCustomShape and call of its Activate() method FuConstCustomShape* pFuConstCS = static_cast(pTabView->GetDrawFuncPtr()); CPPUNIT_ASSERT(pFuConstCS); // points are in pixel MouseEvent aMouseEvent(Point(50, 100), 1, MouseEventModifiers::NONE, MOUSE_LEFT, 0); pFuConstCS->MouseButtonDown(aMouseEvent); aMouseEvent = MouseEvent(Point(200, 250), 1, MouseEventModifiers::DRAGMOVE, MOUSE_LEFT, 0); pFuConstCS->MouseMove(aMouseEvent); aMouseEvent = MouseEvent(Point(200, 250), 1, MouseEventModifiers::NONE, MOUSE_LEFT, 0); pFuConstCS->MouseButtonUp(aMouseEvent); pFuConstCS->Deactivate(); pTabViewShell->SetDrawShell(false); // Get document and newly created custom shape. ScDocument& rDoc = pDocSh->GetDocument(); SdrObjCustomShape* pObj = static_cast(lcl_getSdrObjectWithAssert(rDoc, 0)); // Without the fix in place, the shape would be on layer SC_LAYER_CONTROLS (3) sal_Int16 nExpectedID = SC_LAYER_FRONT.get(); sal_Int16 nActualID = pObj->GetLayer().get(); CPPUNIT_ASSERT_EQUAL(nExpectedID, nActualID); pDocSh->DoClose(); } void ScShapeTest::testTdf140252_LayerOfControl() { // Error was, that a newly inserted control shape was put on layer // "vorne" instead of layer "control". // Load an empty document. OUString aFileURL; createFileURL(u"ManualColWidthRowHeight.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get ScDocShell ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); // Create default push button SfxUInt16Item aIdentifierItem(SID_FM_CONTROL_IDENTIFIER, static_cast(SdrObjKind::FormButton)); SfxUInt32Item aInventorItem(SID_FM_CONTROL_INVENTOR, sal_uInt32(SdrInventor::FmForm)); const SfxPoolItem* pArgs[] = { &aIdentifierItem, &aInventorItem, nullptr }; const SfxPoolItem* pInternalArgs[] = { nullptr }; ScTabViewShell* pTabViewShell = lcl_getScTabViewShellWithAssert(pDocSh); pTabViewShell->GetViewData().GetDispatcher().Execute( SID_FM_CREATE_CONTROL, SfxCallMode::SYNCHRON, pArgs, KEY_MOD1, pInternalArgs); // Get document and newly created push button. ScDocument& rDoc = pDocSh->GetDocument(); SdrObject* pObj = lcl_getSdrObjectWithAssert(rDoc, 0); // Check LayerID of object. Without the fix in place it was 0. sal_Int16 nExpectedID = SC_LAYER_CONTROLS.get(); sal_Int16 nActualID = pObj->GetLayer().get(); CPPUNIT_ASSERT_EQUAL(nExpectedID, nActualID); pDocSh->DoClose(); } void ScShapeTest::testTdf137082_LTR_to_RTL() { // Before the fix for tdf137081 and tdf137082, when flipping sheet from LTR to RTL, page anchored // shapes were mirrored, but cell anchored shapes not. This was changed so, that shapes are always // mirrored. Graphics are still not mirrored but shifted. This test makes sure a shape is mirrored // and an image is not mirrored. OUString aFileURL; createFileURL(u"tdf137082_LTR_arrow_image.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); // Get objects and their transformation angles SdrObject* pObjCS = lcl_getSdrObjectWithAssert(rDoc, 0); const Degree100 nRotateLTR = pObjCS->GetRotateAngle(); SdrObject* pObjImage = lcl_getSdrObjectWithAssert(rDoc, 1); const Degree100 nShearLTR = pObjImage->GetShearAngle(); // Switch to RTL ScTabViewShell* pViewShell = lcl_getScTabViewShellWithAssert(pDocSh); pViewShell->GetViewData().GetDispatcher().Execute(FID_TAB_RTL); // Check custom shape is mirrored, image not. const Degree100 nShearRTLActual = pObjImage->GetShearAngle(); CPPUNIT_ASSERT_EQUAL_MESSAGE("image should not be mirrored", nShearLTR.get(), nShearRTLActual.get()); const Degree100 nRotateRTLExpected = 36000_deg100 - nRotateLTR; const Degree100 nRotateRTLActual = pObjCS->GetRotateAngle(); CPPUNIT_ASSERT_EQUAL_MESSAGE("custom shape should be mirrored", nRotateRTLExpected.get(), nRotateRTLActual.get()); pDocSh->DoClose(); } void ScShapeTest::testTdf137082_RTL_cell_anchored() { // Error was, that cell anchored custom shapes wrote wrong offsets to file and thus were wrong on // reloading. The file contains one custom shape with "resize" and another one without. OUString aFileURL; createFileURL(u"tdf137082_RTL_cell_anchored.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); // Expected values. const Point aTopLeftA(-20500, 3500); // shape A without "resize" const Point aTopLeftB(-9500, 3500); // shape B with "resize" const Size aSize(2278, 5545); // both const tools::Rectangle aSnapRectA(aTopLeftA, aSize); const tools::Rectangle aSnapRectB(aTopLeftB, aSize); // Test reading was correct SdrObject* pObj = lcl_getSdrObjectWithAssert(rDoc, 0); lcl_AssertRectEqualWithTolerance("load shape A: ", aSnapRectA, pObj->GetSnapRect(), 1); pObj = lcl_getSdrObjectWithAssert(rDoc, 1); lcl_AssertRectEqualWithTolerance("load shape B: ", aSnapRectB, pObj->GetSnapRect(), 1); // Save and reload. saveAndReload(xComponent, "calc8"); CPPUNIT_ASSERT(xComponent); // Get document pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc2 = pDocSh->GetDocument(); // And test again pObj = lcl_getSdrObjectWithAssert(rDoc2, 0); lcl_AssertRectEqualWithTolerance("reload shape A: ", aSnapRectA, pObj->GetSnapRect(), 1); pObj = lcl_getSdrObjectWithAssert(rDoc2, 1); lcl_AssertRectEqualWithTolerance("reload shape B: ", aSnapRectB, pObj->GetSnapRect(), 1); pDocSh->DoClose(); } void ScShapeTest::testTdf137081_RTL_page_anchored() { // Error was, that page anchored lines and custom shapes were mirrored on opening. The document // contains measure line, polyline and transformed custom shape. OUString aFileURL; createFileURL(u"tdf137081_RTL_page_anchored.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); // Expected values. // Measure line const Point aStart(-3998, 2490); const Point aEnd(-8488, 5490); // Polyline const Point aFirst(-10010, 2500); const Point aSecond(-14032, 5543); const Point aThird(-14500, 3500); // Custom shape const Point aTopLeft(-20500, 4583); // Test reading was correct SdrObject* pObj = lcl_getSdrObjectWithAssert(rDoc, 0); // Measure line lcl_AssertPointEqualWithTolerance("measure line start", aStart, pObj->GetPoint(0), 1); lcl_AssertPointEqualWithTolerance("measure line end", aEnd, pObj->GetPoint(1), 1); // Polyline pObj = lcl_getSdrObjectWithAssert(rDoc, 1); lcl_AssertPointEqualWithTolerance("polyline 1: ", aFirst, pObj->GetPoint(0), 1); lcl_AssertPointEqualWithTolerance("polyline 2: ", aSecond, pObj->GetPoint(1), 1); lcl_AssertPointEqualWithTolerance("polyline 3: ", aThird, pObj->GetPoint(2), 1); //Custom shape SdrObjCustomShape* pObjCS = static_cast(lcl_getSdrObjectWithAssert(rDoc, 2)); CPPUNIT_ASSERT(!pObjCS->IsMirroredX()); lcl_AssertPointEqualWithTolerance("custom shape top left: ", aTopLeft, pObjCS->GetLogicRect().TopLeft(), 1); // Save and reload. saveAndReload(xComponent, "calc8"); CPPUNIT_ASSERT(xComponent); // Get document pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc2 = pDocSh->GetDocument(); // And test again pObj = lcl_getSdrObjectWithAssert(rDoc2, 0); // Measure line lcl_AssertPointEqualWithTolerance("measure line start", aStart, pObj->GetPoint(0), 1); lcl_AssertPointEqualWithTolerance("measure line end", aEnd, pObj->GetPoint(1), 1); // Polyline pObj = lcl_getSdrObjectWithAssert(rDoc2, 1); lcl_AssertPointEqualWithTolerance("polyline 1: ", aFirst, pObj->GetPoint(0), 1); lcl_AssertPointEqualWithTolerance("polyline 2: ", aSecond, pObj->GetPoint(1), 1); lcl_AssertPointEqualWithTolerance("polyline 3: ", aThird, pObj->GetPoint(2), 1); //Custom shape pObjCS = static_cast(lcl_getSdrObjectWithAssert(rDoc2, 2)); CPPUNIT_ASSERT(!pObjCS->IsMirroredX()); lcl_AssertPointEqualWithTolerance("custom shape top left: ", aTopLeft, pObjCS->GetLogicRect().TopLeft(), 1); pDocSh->DoClose(); } void ScShapeTest::testTdf139583_Rotate180deg() { // Load an empty document. OUString aFileURL; createFileURL(u"ManualColWidthRowHeight.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document and draw page ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); SdrPage* pPage = lcl_getSdrPageWithAssert(rDoc); // Insert Shape const tools::Rectangle aRect(Point(3000, 4000), Size(5000, 2000)); ScDrawLayer* pDrawLayer = rDoc.GetDrawLayer(); CPPUNIT_ASSERT_MESSAGE("No ScDrawLayer", pDrawLayer); SdrRectObj* pObj = new SdrRectObj(*pDrawLayer, aRect); CPPUNIT_ASSERT_MESSAGE("Could not create rectangle", pObj); pPage->InsertObject(pObj); // Anchor "to cell (resize with cell)" and then rotate it by 180deg around center // The order is important here. ScDrawLayer::SetCellAnchoredFromPosition(*pObj, rDoc, 0 /*SCTAB*/, true /*bResizeWithCell*/); pObj->Rotate(aRect.Center(), Degree100(18000), 0.0, -1.0); // Save and reload. saveAndReload(xComponent, "calc8"); CPPUNIT_ASSERT(xComponent); // Get document and object pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc2 = pDocSh->GetDocument(); pObj = static_cast(lcl_getSdrObjectWithAssert(rDoc2, 0)); // Without the fix in place, the shape would have nearly zero size. lcl_AssertRectEqualWithTolerance("Show: Object geometry should not change", aRect, pObj->GetSnapRect(), 1); } void ScShapeTest::testTdf137033_FlipHori_Resize() { // Load a document, which has a rotated custom shape, which is horizontal flipped. Error was, that // if such shape was anchored "resize with cell", then after save and reload it was distorted. OUString aFileURL; createFileURL(u"tdf137033_FlipHoriRotCustomShape.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document and shape ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); SdrObjCustomShape* pObj = static_cast(lcl_getSdrObjectWithAssert(rDoc, 0)); // Verify shape is correctly loaded. Then set shape to "resize with cell". tools::Rectangle aSnapRect(pObj->GetSnapRect()); const tools::Rectangle aExpectRect(Point(4998, 7000), Size(9644, 6723)); lcl_AssertRectEqualWithTolerance("Load, wrong pos or size: ", aExpectRect, aSnapRect, 1); ScDrawLayer::SetCellAnchoredFromPosition(*pObj, rDoc, 0 /*SCTAB*/, true /*bResizeWithCell*/); // Save and reload. saveAndReload(xComponent, "calc8"); CPPUNIT_ASSERT(xComponent); // Get document and shape pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc2 = pDocSh->GetDocument(); pObj = static_cast(lcl_getSdrObjectWithAssert(rDoc2, 0)); // Check shape has the original geometry, besides rounding and unit conversion errors aSnapRect = pObj->GetSnapRect(); lcl_AssertRectEqualWithTolerance("Reload, wrong pos or size: ", aExpectRect, aSnapRect, 1); pDocSh->DoClose(); } void ScShapeTest::testTdf137033_RotShear_ResizeHide() { // For rotated or sheared shapes anchored "To Cell (resize with cell) hiding rows or columns will // not only change size but rotation and shear angle too. Error was, that not the original angles // of the full sized shape were written to file but the changed one. // Load a document, which has a rotated and sheared shape, anchored to cell with resize. OUString aFileURL; createFileURL(u"tdf137033_RotShearResizeAnchor.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); // Hide rows 4 and 5 (UI number), which are inside the shape and thus change shape geometry rDoc.SetRowHidden(3, 4, 0, true); rDoc.SetDrawPageSize(0); // trigger recalcpos, otherwise shapes are not changed // Get shape SdrObject* pObj = lcl_getSdrObjectWithAssert(rDoc, 0); // Verify hiding has changed shape geometry as expected tools::Rectangle aSnapRect(pObj->GetSnapRect()); Degree100 aRotateAngle(pObj->GetRotateAngle()); Degree100 aShearAngle(pObj->GetShearAngle()); // mathematical exact would be Point(3868, 4795), Size(9763, 1909) // current values as of LO 7.2 const tools::Rectangle aExpectRect(Point(3875, 4796), Size(9760, 1911)); const Degree100 aExpectRotateAngle(20925_deg100); const Degree100 aExpectShearAngle(-6570_deg100); CPPUNIT_ASSERT_MESSAGE("Hide rows, shear angle: ", abs(aShearAngle - aExpectShearAngle) <= 1_deg100); CPPUNIT_ASSERT_MESSAGE("Hide rows, rotate angle: ", abs(aRotateAngle - aExpectRotateAngle) <= 1_deg100); lcl_AssertRectEqualWithTolerance("Load: wrong pos or size", aExpectRect, aSnapRect, 1); // Save and reload. saveAndReload(xComponent, "calc8"); CPPUNIT_ASSERT(xComponent); // Get document and shape pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc2 = pDocSh->GetDocument(); pObj = lcl_getSdrObjectWithAssert(rDoc2, 0); // Check shape has the original geometry, besides heavy rounding and unit conversion errors aSnapRect = pObj->GetSnapRect(); aRotateAngle = pObj->GetRotateAngle(); aShearAngle = pObj->GetShearAngle(); CPPUNIT_ASSERT_MESSAGE("Reload, shear angle: ", abs(aShearAngle - aExpectShearAngle) <= 3_deg100); CPPUNIT_ASSERT_MESSAGE("Reload, rotate angle: ", abs(aRotateAngle - aExpectRotateAngle) <= 3_deg100); lcl_AssertRectEqualWithTolerance("Reload: wrong pos or size", aExpectRect, aSnapRect, 7); pDocSh->DoClose(); } void ScShapeTest::testTdf137033_RotShear_Hide() { // Hiding row or columns affect cell anchored shape based on their snap rectangle. The first // attempt to fix lost position has used the logic rect instead. For rotated or sheared shape it // makes a difference. // Load a document, which has a rotated and sheared shape, anchored to cell, without resize. OUString aFileURL; createFileURL(u"tdf137033_RotShearCellAnchor.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); // Hide column C, which is left from logic rect, but right from left edge of snap rect rDoc.SetColHidden(2, 2, 0, true); rDoc.SetDrawPageSize(0); // trigger recalcpos, otherwise shapes are not changed // Save and reload. saveAndReload(xComponent, "calc8"); CPPUNIT_ASSERT(xComponent); // Get document and shape pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc2 = pDocSh->GetDocument(); SdrObject* pObj = lcl_getSdrObjectWithAssert(rDoc2, 0); // Check shape is visible. With the old version, the shape was moved to column C and // thus hidden on reload. CPPUNIT_ASSERT_MESSAGE("Reload: Shape has to be visible", pObj->IsVisible()); // Verify position and size are unchanged besides rounding and unit conversion errors // Values are manually taken from shape before hiding column C. const tools::Rectangle aExpectRect(Point(4500, 3500), Size(15143, 5187)); const tools::Rectangle aSnapRect = pObj->GetSnapRect(); lcl_AssertRectEqualWithTolerance("Reload: wrong pos and size", aExpectRect, aSnapRect, 1); pDocSh->DoClose(); } void ScShapeTest::testTdf137576_LogicRectInDefaultMeasureline() { // Error was, that the empty logical rectangle of a default measure line (Ctrl+Click) // resulted in zeros in NonRotatedAnchor and a wrong position when reloading. // Load an empty document. OUString aFileURL; createFileURL(u"ManualColWidthRowHeight.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get ScDocShell ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); // Create default measureline by SfxRequest that corresponds to Ctrl+Click ScTabViewShell* pTabViewShell = lcl_getScTabViewShellWithAssert(pDocSh); SfxRequest aReq(pTabViewShell->GetViewFrame(), SID_DRAW_MEASURELINE); aReq.SetModifier(KEY_MOD1); // Ctrl pTabViewShell->ExecDraw(aReq); // Get document and newly created measure line. ScDocument& rDoc = pDocSh->GetDocument(); SdrObject* pObj = lcl_getSdrObjectWithAssert(rDoc, 0); // Anchor "to Cell (resize with cell)" ScDrawLayer::SetCellAnchoredFromPosition(*pObj, rDoc, 0 /*SCTAB*/, true /*bResizeWithCell*/); // Deselect shape and switch to object selection type "Cell". pTabViewShell->SetDrawShell(false); // Hide column A. uno::Sequence aPropertyValues = { comphelper::makePropertyValue("ToPoint", OUString("$A$1")), }; dispatchCommand(xComponent, ".uno:GoToCell", aPropertyValues); dispatchCommand(xComponent, ".uno:HideColumn", {}); // Get current position. I will not use absolute values for comparison, because document is loaded // in full screen mode of unknown size and default object is placed in center of window. Point aOldPos = pObj->GetRelativePos(); // Save and reload, get ScDocShell saveAndReload(xComponent, "calc8"); CPPUNIT_ASSERT(xComponent); pDocSh = lcl_getScDocShellWithAssert(xComponent); // Get document and object ScDocument& rDoc2 = pDocSh->GetDocument(); pObj = lcl_getSdrObjectWithAssert(rDoc2, 0); // Assert object position is unchanged, besides Twips<->Hmm inaccuracy. Point aNewPos = pObj->GetRelativePos(); lcl_AssertPointEqualWithTolerance("after reload", aOldPos, aNewPos, 1); pDocSh->DoClose(); } void ScShapeTest::testTdf137576_LogicRectInNewMeasureline() { // Error was, that a new measure line had no logical rectangle. This resulted in zeros in // NonRotatedAnchor. As a result the position was wrong when reloading. // Load an empty document OUString aFileURL; createFileURL(u"ManualColWidthRowHeight.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document and draw page ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); SdrPage* pPage = lcl_getSdrPageWithAssert(rDoc); // Create a new measure line and insert it Point aStartPoint(5000, 5500); Point aEndPoint(13000, 8000); ScDrawLayer* pDrawLayer = rDoc.GetDrawLayer(); CPPUNIT_ASSERT_MESSAGE("No ScDrawLayer", pDrawLayer); SdrMeasureObj* pObj = new SdrMeasureObj(*pDrawLayer, aStartPoint, aEndPoint); CPPUNIT_ASSERT_MESSAGE("Could not create measure line", pObj); pPage->InsertObject(pObj); // Anchor "to cell (resize with cell)" and examine NonRotatedAnchor ScDrawLayer::SetCellAnchoredFromPosition(*pObj, rDoc, 0 /*SCTAB*/, true /*bResizeWithCell*/); ScDrawObjData* pNData = ScDrawLayer::GetNonRotatedObjData(pObj); CPPUNIT_ASSERT_MESSAGE("Failed to get NonRotatedAnchor", pNData); // Without the fix all four values would be zero. CPPUNIT_ASSERT_EQUAL(SCCOL(1), pNData->maStart.Col()); CPPUNIT_ASSERT_EQUAL(SCROW(2), pNData->maStart.Row()); CPPUNIT_ASSERT_EQUAL(SCCOL(7), pNData->maEnd.Col()); CPPUNIT_ASSERT_EQUAL(SCROW(2), pNData->maEnd.Row()); pDocSh->DoClose(); } void ScShapeTest::testMeasurelineHideColSave() { // The document contains a SdrMeasureObj anchored "To Cell (resize with cell)" with start in cell // D11 and end in cell I5. Error was, that after hiding col A and saving, start and end point // position were lost. OUString aFileURL; createFileURL(u"measurelineHideColSave.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document and shape ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); SdrObject* pObj = lcl_getSdrObjectWithAssert(rDoc, 0); // Make sure loading is correct Point aStartPoint(7500, 15000); // according UI Point aEndPoint(17500, 8000); lcl_AssertPointEqualWithTolerance("Load start: ", aStartPoint, pObj->GetPoint(0), 1); lcl_AssertPointEqualWithTolerance("Load end: ", aEndPoint, pObj->GetPoint(1), 1); // Hide column A rDoc.SetColHidden(0, 0, 0, true); rDoc.SetDrawPageSize(0); // trigger recalcpos, otherwise shapes are not changed // Shape should move by column width, here 3000 aStartPoint.Move(-3000, 0); aEndPoint.Move(-3000, 0); lcl_AssertPointEqualWithTolerance("Hide col A: ", aStartPoint, pObj->GetPoint(0), 1); lcl_AssertPointEqualWithTolerance("Hide col A: ", aEndPoint, pObj->GetPoint(1), 1); // save and reload saveAndReload(xComponent, "calc8"); CPPUNIT_ASSERT(xComponent); // Get document and shape pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc2 = pDocSh->GetDocument(); pObj = lcl_getSdrObjectWithAssert(rDoc2, 0); // Check that start and end point are unchanged besides rounding and unit conversion errors lcl_AssertPointEqualWithTolerance("Reload start: ", aStartPoint, pObj->GetPoint(0), 2); lcl_AssertPointEqualWithTolerance("Reload end: ", aEndPoint, pObj->GetPoint(1), 2); pDocSh->DoClose(); } void ScShapeTest::testHideColsShow() { // The document contains a shape anchored "To Cell (resize with cell)" with starts in cell C3 and //ends in cell D5. Error was, that hiding cols C and D and then show them again extends the shape // to column E OUString aFileURL; createFileURL(u"hideColsShow.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document and shape ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); SdrObjCustomShape* pObj = static_cast(lcl_getSdrObjectWithAssert(rDoc, 0)); CPPUNIT_ASSERT_MESSAGE("Load: Object should be visible", pObj->IsVisible()); tools::Rectangle aSnapRectOrig(pObj->GetSnapRect()); // Hide cols C and D. uno::Sequence aPropertyValues = { comphelper::makePropertyValue("ToPoint", OUString("$C$1:$D$1")), }; dispatchCommand(xComponent, ".uno:GoToCell", aPropertyValues); ScTabViewShell* pViewShell = lcl_getScTabViewShellWithAssert(pDocSh); pViewShell->GetViewData().GetDispatcher().Execute(FID_COL_HIDE); // Check object is invisible CPPUNIT_ASSERT_MESSAGE("Hide: Object should be invisible", !pObj->IsVisible()); // Show cols C and D aPropertyValues = { comphelper::makePropertyValue("ToPoint", OUString("$C$1:$D$1")), }; dispatchCommand(xComponent, ".uno:GoToCell", aPropertyValues); pViewShell->GetViewData().GetDispatcher().Execute(FID_COL_SHOW); // Check object is visible and has old size CPPUNIT_ASSERT_MESSAGE("Show: Object should be visible", pObj->IsVisible()); tools::Rectangle aSnapRectShow(pObj->GetSnapRect()); lcl_AssertRectEqualWithTolerance("Show: Object geometry should not change", aSnapRectOrig, aSnapRectShow, 1); pDocSh->DoClose(); } void ScShapeTest::testTdf138138_MoveCellWithRotatedShape() { // The document contains a 90deg rotated, cell-anchored rectangle in column D. Insert 2 columns // after column B, save and reload. The shape was not correctly moved to column F. OUString aFileURL; createFileURL(u"tdf138138_MoveCellWithRotatedShape.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document and shape ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); SdrObject* pObj = lcl_getSdrObjectWithAssert(rDoc, 0); // Check anchor and position of shape. The expected values are taken from UI. tools::Rectangle aSnapRect = pObj->GetSnapRect(); tools::Rectangle aExpectedRect(Point(10000, 3000), Size(1000, 7500)); lcl_AssertRectEqualWithTolerance("Load original: ", aExpectedRect, aSnapRect, 1); // Insert two columns after column B uno::Sequence aPropertyValues = { comphelper::makePropertyValue("ToPoint", OUString("$A$1:$B$1")), }; dispatchCommand(xComponent, ".uno:GoToCell", aPropertyValues); ScTabViewShell* pViewShell = lcl_getScTabViewShellWithAssert(pDocSh); pViewShell->GetViewData().GetDispatcher().Execute(FID_INS_COLUMNS_AFTER); aExpectedRect = tools::Rectangle(Point(16000, 3000), Size(1000, 7500)); // col width 3000 aSnapRect = pObj->GetSnapRect(); lcl_AssertRectEqualWithTolerance("Shift: Wrong after insert of columns ", aExpectedRect, aSnapRect, 1); // Save and reload saveAndReload(xComponent, "calc8"); CPPUNIT_ASSERT(xComponent); // Get document and shape pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc2 = pDocSh->GetDocument(); pObj = lcl_getSdrObjectWithAssert(rDoc2, 0); // Assert objects size is unchanged, position is shifted. aSnapRect = pObj->GetSnapRect(); lcl_AssertRectEqualWithTolerance("Reload: Shape geometry has changed.", aExpectedRect, aSnapRect, 1); pDocSh->DoClose(); } void ScShapeTest::testLoadVerticalFlip() { // The document has a cell anchored custom shape with vertical flip. Error was, that the // flip was lost on loading. OUString aFileURL; createFileURL(u"loadVerticalFlip.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document and shape ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); SdrObjCustomShape* pObj = static_cast(lcl_getSdrObjectWithAssert(rDoc, 0)); // Check that shape is flipped CPPUNIT_ASSERT_MESSAGE("Load: Object should be vertically flipped", pObj->IsMirroredY()); pDocSh->DoClose(); } void ScShapeTest::testTdf117948_CollapseBeforeShape() { // The document contains a column group left from the image. The group is expanded. Collapse the // group, save and reload. The original error was, that the line was on wrong position after reload. // After the fix for 'resize with cell', the custom shape had wrong position and size too. OUString aFileURL; createFileURL(u"tdf117948_CollapseBeforeShape.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document and objects ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); SdrObject* pObj0 = lcl_getSdrObjectWithAssert(rDoc, 0); SdrObject* pObj1 = lcl_getSdrObjectWithAssert(rDoc, 1); // Collapse the group ScTabViewShell* pViewShell = lcl_getScTabViewShellWithAssert(pDocSh); pViewShell->GetViewData().SetCurX(1); pViewShell->GetViewData().SetCurY(0); pViewShell->GetViewData().GetDispatcher().Execute(SID_OUTLINE_HIDE); // Check anchor and position of shape. The expected values are taken from UI before saving. tools::Rectangle aSnapRect0Collapse = pObj0->GetSnapRect(); tools::Rectangle aExpectedRect0(Point(4672, 1334), Size(1787, 1723)); lcl_AssertRectEqualWithTolerance("Collapse: Custom shape", aExpectedRect0, aSnapRect0Collapse, 1); tools::Rectangle aSnapRect1Collapse = pObj1->GetSnapRect(); tools::Rectangle aExpectedRect1(Point(5647, 4172), Size(21, 3441)); lcl_AssertRectEqualWithTolerance("Collapse: Line", aExpectedRect1, aSnapRect1Collapse, 1); // Save and reload saveAndReload(xComponent, "calc8"); CPPUNIT_ASSERT(xComponent); // Get document and objects pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc2 = pDocSh->GetDocument(); pObj0 = lcl_getSdrObjectWithAssert(rDoc2, 0); pObj1 = lcl_getSdrObjectWithAssert(rDoc2, 1); // Assert objects size and position are not changed. Actual values differ a little bit // because of cumulated Twips-Hmm conversion errors. tools::Rectangle aSnapRect0Reload = pObj0->GetSnapRect(); lcl_AssertRectEqualWithTolerance("Reload: Custom shape geometry has changed.", aExpectedRect0, aSnapRect0Reload, 2); tools::Rectangle aSnapRect1Reload = pObj1->GetSnapRect(); lcl_AssertRectEqualWithTolerance("Reload: Line geometry has changed.", aExpectedRect1, aSnapRect1Reload, 2); pDocSh->DoClose(); } void ScShapeTest::testTdf137355_UndoHideRows() { // The document contains a shape anchored "To Cell" with start in cell C3 and end in cell D6. // Error was, that hiding rows 3 to 6 and undo that action "lost" the shape. // Actually it was not lost but hidden. OUString aFileURL; createFileURL(u"tdf137355_UndoHideRows.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document and shape ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); SdrObject* pObj = lcl_getSdrObjectWithAssert(rDoc, 0); CPPUNIT_ASSERT_MESSAGE("Load: Object should be visible", pObj->IsVisible()); tools::Rectangle aSnapRectOrig(pObj->GetSnapRect()); // Hide rows 3 to 6 in UI. [Note: Simple rDoc.SetRowHidden(2,5,0,true) does not work, because it // does not produce the needed undo items.] uno::Sequence aPropertyValues = { comphelper::makePropertyValue("ToPoint", OUString("$A$3:$A$6")), }; dispatchCommand(xComponent, ".uno:GoToCell", aPropertyValues); ScTabViewShell* pViewShell = lcl_getScTabViewShellWithAssert(pDocSh); pViewShell->GetViewData().GetDispatcher().Execute(FID_ROW_HIDE); // Check object is invisible CPPUNIT_ASSERT_MESSAGE("Hide: Object should be invisible", !pObj->IsVisible()); // Undo pViewShell->GetViewData().GetDispatcher().Execute(SID_UNDO); // Check object is visible and has old size CPPUNIT_ASSERT_MESSAGE("Undo: Object should exist", pObj); CPPUNIT_ASSERT_MESSAGE("Undo: Object should be visible", pObj->IsVisible()); tools::Rectangle aSnapRectUndo(pObj->GetSnapRect()); lcl_AssertRectEqualWithTolerance("Undo: Object geometry should not change", aSnapRectOrig, aSnapRectUndo, 1); pDocSh->DoClose(); } void ScShapeTest::testTdf152081_UndoHideColsWithNotes() { OUString aFileURL; createFileURL(u"tdf152081_UndoHideColsWithNotes.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document and shape ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); SdrObject* pObj = lcl_getSdrObjectWithAssert(rDoc, 0); CPPUNIT_ASSERT_MESSAGE("Load: Note object should be visible", pObj->IsVisible()); // Hide column B uno::Sequence aPropertyValues = { comphelper::makePropertyValue("ToPoint", OUString("$B$2:$B$2")), }; dispatchCommand(xComponent, ".uno:GoToCell", aPropertyValues); ScTabViewShell* pViewShell = lcl_getScTabViewShellWithAssert(pDocSh); pViewShell->GetViewData().GetDispatcher().Execute(FID_COL_HIDE); // Check object is invisible CPPUNIT_ASSERT_MESSAGE("Hide: Note object should be invisible", !pObj->IsVisible()); // Undo pViewShell->GetViewData().GetDispatcher().Execute(SID_UNDO); // Check object is visible CPPUNIT_ASSERT_MESSAGE("Undo: Note object should exist", pObj); CPPUNIT_ASSERT_MESSAGE("Undo: Note object should be visible", pObj->IsVisible()); pDocSh->DoClose(); } void ScShapeTest::testTdf115655_HideDetail() { // The document contains an image inside a cell anchored "To Cell (resize with cell)". The cell // belongs to a group. On loading the group is expanded. // Error was, that after collapsing the group, save and reload, and expanding the group, the image // was "lost". Actually is was resized to zero height. OUString aFileURL; createFileURL(u"tdf115655_HideDetail.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document and image ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); SdrObject* pObj = lcl_getSdrObjectWithAssert(rDoc, 0); // Get image size tools::Rectangle aSnapRectOrig = pObj->GetSnapRect(); // Collapse the group ScTabViewShell* pViewShell = lcl_getScTabViewShellWithAssert(pDocSh); pViewShell->GetViewData().SetCurX(0); pViewShell->GetViewData().SetCurY(1); pViewShell->GetViewData().GetDispatcher().Execute(SID_OUTLINE_HIDE); CPPUNIT_ASSERT_MESSAGE("Collapse: Image should not be visible", !pObj->IsVisible()); // Save and reload saveAndReload(xComponent, "calc8"); CPPUNIT_ASSERT(xComponent); // Get document and image pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc2 = pDocSh->GetDocument(); pObj = lcl_getSdrObjectWithAssert(rDoc2, 0); // Expand the group pViewShell = pDocSh->GetBestViewShell(false); CPPUNIT_ASSERT_MESSAGE("Reload: No ScTabViewShell", pViewShell); pViewShell->GetViewData().SetCurX(0); pViewShell->GetViewData().SetCurY(1); pViewShell->GetViewData().GetDispatcher().Execute(SID_OUTLINE_SHOW); CPPUNIT_ASSERT_MESSAGE("Expand: Image should be visible", pObj->IsVisible()); // Assert image size is not changed tools::Rectangle aSnapRectReload = pObj->GetSnapRect(); lcl_AssertRectEqualWithTolerance("Reload: Object geometry has changed.", aSnapRectOrig, aSnapRectReload, 1); pDocSh->DoClose(); } void ScShapeTest::testFitToCellSize() { // The document has a cell anchored custom shape. Applying // FitToCellSize should resize and position the shape so, // that it fits into its anchor cell. That did not happened. OUString aFileURL; createFileURL(u"tdf119191_FitToCellSize.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document and shape ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); SdrObjCustomShape* pObj = dynamic_cast(lcl_getSdrObjectWithAssert(rDoc, 0)); // Get the draw view of the document ScTabViewShell* pViewShell = lcl_getScTabViewShellWithAssert(pDocSh); ScDrawView* pDrawView = pViewShell->GetViewData().GetScDrawView(); CPPUNIT_ASSERT(pDrawView); // Select the shape pDrawView->MarkNextObj(); CPPUNIT_ASSERT(pDrawView->AreObjectsMarked()); // Fit selected shape into cell pViewShell->GetViewData().GetDispatcher().Execute(SID_FITCELLSIZE); const tools::Rectangle& rShapeRect(pObj->GetSnapRect()); const tools::Rectangle aCellRect = rDoc.GetMMRect(1, 1, 1, 1, 0); lcl_AssertRectEqualWithTolerance("Cell and SnapRect should be equal", aCellRect, rShapeRect, 2); pDocSh->DoClose(); } void ScShapeTest::testCustomShapeCellAnchoredRotatedShape() { // The example doc contains a cell anchored custom shape that is rotated // and sheared. Error was, that the shape lost position and size on // loading. OUString aFileURL; createFileURL(u"tdf119191_transformedShape.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); // Get document and shape ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); ScDocument& rDoc = pDocSh->GetDocument(); SdrObjCustomShape* pObj = dynamic_cast(lcl_getSdrObjectWithAssert(rDoc, 0)); // Check Position and Size rDoc.SetDrawPageSize(0); // trigger recalcpos tools::Rectangle aRect(2400, 751, 5772, 3694); // expected snap rect from values in file const tools::Rectangle& rShapeRect(pObj->GetSnapRect()); lcl_AssertRectEqualWithTolerance("Load: wrong pos and size", aRect, rShapeRect, 1); // Check anchor ScDrawObjData* pData = ScDrawLayer::GetObjData(pObj); CPPUNIT_ASSERT_MESSAGE("expected object meta data", pData); const OUString sActual("start col " + OUString::number(pData->maStart.Col()) + " row " + OUString::number(pData->maStart.Row()) + " end col " + OUString::number(pData->maEnd.Col()) + " row " + OUString::number(pData->maEnd.Row())); CPPUNIT_ASSERT_EQUAL(OUString("start col 1 row 1 end col 2 row 8"), sActual); pDocSh->DoClose(); } void ScShapeTest::testLargeAnchorOffset() { // The example doc contains a resize-with-cell-anchored measure line // with a large vertical offset that shifts the start point onto the // next cell below. OUString aFileURL; createFileURL(u"LargeAnchorOffset.ods", aFileURL); uno::Reference xComponent = loadFromDesktop(aFileURL); ScDocShell* pDocSh = lcl_getScDocShellWithAssert(xComponent); SdrObject* pObj = lcl_getSdrObjectWithAssert(pDocSh->GetDocument(), 0); const Point aOldPos = pObj->GetRelativePos(); // Just to check that it imports correctly lcl_AssertPointEqualWithTolerance("before reload", { 9504, 9089 }, aOldPos, 1); saveAndReload(xComponent, "calc8"); pDocSh = lcl_getScDocShellWithAssert(xComponent); pObj = lcl_getSdrObjectWithAssert(pDocSh->GetDocument(), 0); // Without the fix, this would fail: // Test name: sc_apitest::ScShapeTest::testLargeAnchorOffset // assertion failed // - Expression: std::abs(rExpected.Y() - rActual.Y()) <= nTolerance // - after reload Y expected 9089 actual 9643 Tolerance 1 const Point aNewPos = pObj->GetRelativePos(); lcl_AssertPointEqualWithTolerance("after reload", aOldPos, aNewPos, 1); pDocSh->DoClose(); } CPPUNIT_TEST_SUITE_REGISTRATION(ScShapeTest); } CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */