1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#ifndef LO_CLANG_SHARED_PLUGINS
#include <cassert>
#include "check.hxx"
#include "plugin.hxx"
// Find uses of OUString in conditional expressions that could be rewritten as std::u16string_view,
// as in
//
// s += (b ? OUString("xy") : OUString(z");
namespace
{
// Like Expr::IgnoreImplicit, but for an ImplicitCastExpr skips to getSubExprAsWritten (so skips a
// CXXConstructExpr where Expr::IgnoreImplicit would stop):
Expr const* ignoreImplicit(Expr const* expr)
{
for (auto e = expr;;)
{
if (auto const e1 = dyn_cast<ImplicitCastExpr>(e))
{
e = e1->getSubExprAsWritten();
}
else if (auto const e2 = dyn_cast<FullExpr>(e))
{
e = e2->getSubExpr();
}
else if (auto const e3 = dyn_cast<MaterializeTemporaryExpr>(e))
{
e = e3->getSubExpr();
}
else if (auto const e4 = dyn_cast<CXXBindTemporaryExpr>(e))
{
e = e4->getSubExpr();
}
else
{
return e;
}
}
}
class ConditionalString final : public loplugin::FilteringPlugin<ConditionalString>
{
public:
explicit ConditionalString(loplugin::InstantiationData const& data)
: FilteringPlugin(data)
{
}
bool VisitCallExpr(CallExpr const* expr)
{
if (ignoreLocation(expr))
{
return true;
}
auto const fn = expr->getDirectCallee();
if (fn == nullptr)
{
return true;
}
//TODO: Instead of a hardcoded list of functions, check that `fn` has overloads taking
// OUString and std::u16string_view, respectively (and operator + is even more complicated
// than that, going via ToStringHelper<std::u16string_view> specialization; the getNumArgs
// checks for the various functions are meant to guard against the unlikely case that the
// affected parameters get defaulted in the future; overloaded operators cannot generally
// have defaulted parameters):
loplugin::DeclCheck const dc(fn);
if (dc.Operator(OO_Equal).Class("OUString").Namespace("rtl").GlobalNamespace())
{
assert(fn->getNumParams() == 1);
if (isa<CXXOperatorCallExpr>(expr))
{
assert(expr->getNumArgs() == 2);
check(expr->getArg(1));
}
else
{
assert(expr->getNumArgs() == 1);
check(expr->getArg(0));
}
return true;
}
if (dc.Operator(OO_PlusEqual).Class("OUString").Namespace("rtl").GlobalNamespace())
{
assert(fn->getNumParams() == 1);
if (isa<CXXOperatorCallExpr>(expr))
{
assert(expr->getNumArgs() == 2);
check(expr->getArg(1));
}
else
{
assert(expr->getNumArgs() == 1);
check(expr->getArg(0));
}
return true;
}
if (dc.Function("reverseCompareTo").Class("OUString").Namespace("rtl").GlobalNamespace()
&& fn->getNumParams() == 1)
{
if (expr->getNumArgs() >= 1)
{
check(expr->getArg(0));
}
return true;
}
if (dc.Function("equalsIgnoreAsciiCase")
.Class("OUString")
.Namespace("rtl")
.GlobalNamespace()
&& fn->getNumParams() == 1)
{
if (expr->getNumArgs() >= 1)
{
check(expr->getArg(0));
}
return true;
}
if (dc.Function("match").Class("OUString").Namespace("rtl").GlobalNamespace()
&& fn->getNumParams() == 2)
{
if (expr->getNumArgs() >= 1)
{
check(expr->getArg(0));
}
return true;
}
if (dc.Function("matchIgnoreAsciiCase").Class("OUString").Namespace("rtl").GlobalNamespace()
&& fn->getNumParams() == 2)
{
if (expr->getNumArgs() >= 1)
{
check(expr->getArg(0));
}
return true;
}
if (dc.Function("startsWith").Class("OUString").Namespace("rtl").GlobalNamespace()
&& fn->getNumParams() == 2)
{
if (expr->getNumArgs() >= 1)
{
check(expr->getArg(0));
}
return true;
}
if (dc.Function("startsWithIgnoreAsciiCase")
.Class("OUString")
.Namespace("rtl")
.GlobalNamespace()
&& fn->getNumParams() == 2)
{
if (expr->getNumArgs() >= 1)
{
check(expr->getArg(0));
}
return true;
}
if (dc.Function("endsWith").Class("OUString").Namespace("rtl").GlobalNamespace()
&& fn->getNumParams() == 2)
{
if (expr->getNumArgs() >= 1)
{
check(expr->getArg(0));
}
return true;
}
if (dc.Function("endsWithIgnoreAsciiCase")
.Class("OUString")
.Namespace("rtl")
.GlobalNamespace()
&& fn->getNumParams() == 2)
{
if (expr->getNumArgs() >= 1)
{
check(expr->getArg(0));
}
return true;
}
if (dc.Operator(OO_EqualEqual)
.Namespace("rtl")
.GlobalNamespace()) //TODO: more precicse check
{
assert(fn->getNumParams() == 2);
assert(expr->getNumArgs() == 2);
check(expr->getArg(0));
check(expr->getArg(1));
return true;
}
if (dc.Operator(OO_ExclaimEqual)
.Namespace("rtl")
.GlobalNamespace()) //TODO: more precicse check
{
assert(fn->getNumParams() == 2);
assert(expr->getNumArgs() == 2);
check(expr->getArg(0));
check(expr->getArg(1));
return true;
}
if (dc.Operator(OO_Less).Namespace("rtl").GlobalNamespace()) //TODO: more precicse check
{
assert(fn->getNumParams() == 2);
assert(expr->getNumArgs() == 2);
check(expr->getArg(0));
check(expr->getArg(1));
return true;
}
if (dc.Operator(OO_LessEqual)
.Namespace("rtl")
.GlobalNamespace()) //TODO: more precicse check
{
assert(fn->getNumParams() == 2);
assert(expr->getNumArgs() == 2);
check(expr->getArg(0));
check(expr->getArg(1));
return true;
}
if (dc.Operator(OO_Greater).Namespace("rtl").GlobalNamespace()) //TODO: more precicse check
{
assert(fn->getNumParams() == 2);
assert(expr->getNumArgs() == 2);
check(expr->getArg(0));
check(expr->getArg(1));
return true;
}
if (dc.Operator(OO_GreaterEqual)
.Namespace("rtl")
.GlobalNamespace()) //TODO: more precicse check
{
assert(fn->getNumParams() == 2);
assert(expr->getNumArgs() == 2);
check(expr->getArg(0));
check(expr->getArg(1));
return true;
}
if (dc.Function("indexOf").Class("OUString").Namespace("rtl").GlobalNamespace()
&& fn->getNumParams() == 2)
{
if (expr->getNumArgs() >= 1)
{
check(expr->getArg(0));
}
return true;
}
if (dc.Function("lastIndexOf").Class("OUString").Namespace("rtl").GlobalNamespace()
&& fn->getNumParams() == 1)
{
if (expr->getNumArgs() >= 1)
{
check(expr->getArg(0));
}
return true;
}
if (dc.Function("replaceFirst").Class("OUString").Namespace("rtl").GlobalNamespace()
&& fn->getNumParams() == 3)
{
if (expr->getNumArgs() >= 1)
{
check(expr->getArg(0));
}
if (expr->getNumArgs() >= 2)
{
check(expr->getArg(1));
}
return true;
}
if (dc.Function("replaceAll").Class("OUString").Namespace("rtl").GlobalNamespace()
&& fn->getNumParams() == 2)
{
if (expr->getNumArgs() >= 1)
{
check(expr->getArg(0));
}
if (expr->getNumArgs() >= 2)
{
check(expr->getArg(1));
}
return true;
}
if (dc.Operator(OO_Plus).Namespace("rtl").GlobalNamespace()
&& fn->getNumParams() == 2) //TODO: more precicse check
{
assert(expr->getNumArgs() == 2);
check(expr->getArg(0));
check(expr->getArg(1));
return true;
}
if (dc.Operator(OO_Equal).Class("OUStringBuffer").Namespace("rtl").GlobalNamespace())
{
assert(fn->getNumParams() == 1);
if (isa<CXXOperatorCallExpr>(expr))
{
assert(expr->getNumArgs() == 2);
check(expr->getArg(1));
}
else
{
assert(expr->getNumArgs() == 1);
check(expr->getArg(0));
}
return true;
}
if (dc.Function("append").Class("OUStringBuffer").Namespace("rtl").GlobalNamespace()
&& fn->getNumParams() == 1)
{
if (expr->getNumArgs() >= 1)
{
check(expr->getArg(0));
}
return true;
}
if (dc.Function("insert").Class("OUStringBuffer").Namespace("rtl").GlobalNamespace()
&& fn->getNumParams() == 2)
{
if (expr->getNumArgs() >= 2)
{
check(expr->getArg(1));
}
return true;
}
if (dc.Function("indexOf").Class("OUStringBuffer").Namespace("rtl").GlobalNamespace()
&& fn->getNumParams() == 2)
{
if (expr->getNumArgs() >= 1)
{
check(expr->getArg(0));
}
return true;
}
if (dc.Function("lastIndexOf").Class("OUStringBuffer").Namespace("rtl").GlobalNamespace()
&& fn->getNumParams() == 1)
{
if (expr->getNumArgs() >= 1)
{
check(expr->getArg(0));
}
return true;
}
return true;
}
bool preRun() override { return compiler.getLangOpts().CPlusPlus; }
private:
enum class Kind
{
OUStringFromLiteral,
StringViewOrVoid,
Other
};
void run() override
{
if (preRun())
{
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
}
Kind getKind(Expr const* expr)
{
auto const tc = loplugin::TypeCheck(ignoreImplicit(expr)->getType());
if (tc.ClassOrStruct("basic_string_view").StdNamespace() //TODO: check explicitly for
// std::basic_string_view<char16_t>
|| tc.Void())
{
return Kind::StringViewOrVoid;
}
if (loplugin::TypeCheck(expr->getType())
.Class("OUString")
.Namespace("rtl")
.GlobalNamespace())
{
// Check for both explicit
//
// OUString("...")
//
// and implicit
//
// "..."
//
// expressions:
auto e = expr->IgnoreParens();
if (auto const e1 = dyn_cast<CXXFunctionalCastExpr>(e))
{
e = e1->getSubExpr();
}
if (auto const e1 = dyn_cast<CXXConstructExpr>(e->IgnoreImplicit()->IgnoreParens()))
{
if (e1->getNumArgs() != 0 //TODO
&& isa<clang::StringLiteral>(e1->getArg(0)->IgnoreParenImpCasts()))
{
return Kind::OUStringFromLiteral;
}
}
}
return Kind::Other;
}
void check(Expr const* expr)
{
//TODO: skip `,`; handle ?: chains
auto const cond = dyn_cast<ConditionalOperator>(expr->IgnoreParenImpCasts());
if (cond == nullptr)
{
return;
}
auto const k1 = getKind(cond->getTrueExpr());
if (k1 == Kind::Other)
{
return;
}
auto const k2 = getKind(cond->getFalseExpr());
if (k2 == Kind::Other || (k1 == Kind::StringViewOrVoid && k2 == Kind::StringViewOrVoid))
{
return;
}
if (k1 == Kind::OUStringFromLiteral && k2 == Kind::OUStringFromLiteral)
{
report(DiagnosticsEngine::Warning,
("replace both 2nd and 3rd operands of conditional expression with"
" `std::u16string_view`"),
cond->getExprLoc())
<< cond->getSourceRange();
}
else
{
assert((k1 == Kind::OUStringFromLiteral && k2 == Kind::StringViewOrVoid)
|| (k1 == Kind::StringViewOrVoid && k2 == Kind::OUStringFromLiteral));
auto const second = k1 == Kind::OUStringFromLiteral;
auto const sub
= (second ? cond->getTrueExpr() : cond->getFalseExpr())->IgnoreParenImpCasts();
report(DiagnosticsEngine::Warning,
("replace %select{2nd|3rd}0 operand of conditional expression with"
" `std::u16string_view`"),
sub->getExprLoc())
<< (second ? 0 : 1) << sub->getSourceRange();
report(DiagnosticsEngine::Note, "conditional expression is here", cond->getExprLoc())
<< cond->getSourceRange();
}
}
};
loplugin::Plugin::Registration<ConditionalString> conditionalstring("conditionalstring");
}
#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
