1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <exception>
extern int foo();
extern int bar(int = 0);
class Class {};
void top1() {
if (foo() == 1) { // expected-note {{if condition here [loplugin:flatten]}}
foo();
} else {
throw std::exception(); // expected-error {{unconditional throw in else branch, rather invert the condition, throw early, and flatten the normal case [loplugin:flatten]}}
}
if (foo() == 1) {
Class aClass;
(void)aClass;
} else {
throw std::exception(); // no warning expected
}
if (foo() == 1) { // expected-note {{if condition here [loplugin:flatten]}}
Class aClass;
(void)aClass;
} else {
throw std::exception(); // expected-error {{unconditional throw in else branch, rather invert the condition, throw early, and flatten the normal case [loplugin:flatten]}}
}
}
void top2() {
if (foo() == 2) {
throw std::exception(); // expected-error {{unconditional throw in then branch, just flatten the else [loplugin:flatten]}}
} else {
foo();
}
if (foo() == 2) {
throw std::exception(); // no warning expected
} else {
Class aClass;
(void)aClass;
}
if (foo() == 2) {
throw std::exception(); // expected-error {{unconditional throw in then branch, just flatten the else [loplugin:flatten]}}
} else {
Class aClass;
(void)aClass;
}
}
void top3() {
// no warning expected
if (foo() == 2) {
throw std::exception();
} else {
Class aClass;
(void)aClass;
}
int x = 1;
(void)x;
}
void top4() {
// no warning expected
if (foo() == 2) {
Class aClass;
(void)aClass;
} else {
throw std::exception();
}
int x = 1;
(void)x;
}
void top5() {
#if 1
if (foo() == 2) {
if (foo() == 3) { // expected-note {{if condition here [loplugin:flatten]}}
bar();
} else {
throw std::exception(); // expected-error {{unconditional throw in else branch, rather invert the condition, throw early, and flatten the normal case [loplugin:flatten]}}
}
} else
#endif
throw std::exception(); // no warning expected
}
int main() {
// no warning expected
if (bar() == 3) {
throw std::exception();
} else {
throw std::exception();
}
}
void top6() {
// no warning expected
if (foo() == 2) {
Class aClass;
(void)aClass;
} else if (foo() == 2) {
Class aClass;
(void)aClass;
} else {
throw std::exception();
}
int x = 1;
(void)x;
}
void top7() {
// no warning expected
if (foo() == 1) {
throw std::exception();
} else if (foo() == 2) {
throw std::exception();
} else {
throw std::exception();
}
}
void top8() {
if (foo() == 1) {
if (foo() == 2) {
throw std::exception(); // expected-error {{unconditional throw in then branch, just flatten the else [loplugin:flatten]}}
} else {
bar();
}
} else if (foo() == 2) {
bar(1);
} else {
bar(2);
}
}
void top9() {
if (foo() == 1) { // expected-error {{large if statement at end of function, rather invert the condition and exit early, and flatten the function [loplugin:flatten]}}
Class aClass1;
(void)aClass1;
Class aClass2;
(void)aClass2;
Class aClass3;
(void)aClass3;
Class aClass4;
(void)aClass4;
Class aClass5;
(void)aClass5;
Class aClass6;
(void)aClass6;
}
}
void top10() {
// no warning expected
if (foo() == 2) {
if (foo() == 1) {
Class aClass1;
(void)aClass1;
Class aClass2;
(void)aClass2;
Class aClass3;
(void)aClass3;
}
}
}
int top11() {
// no warning expected
if (foo() == 1) {
Class aClass1;
(void)aClass1;
Class aClass2;
(void)aClass2;
Class aClass3;
(void)aClass3;
Class aClass4;
(void)aClass4;
Class aClass5;
(void)aClass5;
Class aClass6;
(void)aClass6;
}
return 1;
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
