1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
|
/*
* SPDX-License-Identifier: ISC
*
* Copyright (c) 2021-2022 Todd C. Miller <Todd.Miller@sudo.ws>
*
* Permission to use, copy, modify, and distribute this software for any
* purpose with or without fee is hereby granted, provided that the above
* copyright notice and this permission notice appear in all copies.
*
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
#include <config.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#define SUDO_ERROR_WRAP 0
#include "sudoers.h"
struct test_data {
const char *input;
const char *result;
size_t result_len;
size_t bufsize;
};
/* strlcpy_unescape() does not unescape whitespace */
static struct test_data strlcpy_unescape_test_data[] = {
{ "\\\0ABC", "\\", 1, 2 }, /* 1 */
{ "\\ \\;", "\\ ;", 3, 4 }, /* 2 */
{ "\\\t\\;", "\\\t;", 3, 4 }, /* 3 */
{ "\\foo", "foo", 3, 4 }, /* 4 */
{ "foo\\ bar", "foo\\ bar", 8, 9 }, /* 5 */
{ "foo bar", "f", 7, 2 }, /* 6 */
{ "foo bar", "", 7, 1 }, /* 7 */
{ "foo bar", NULL, 7, 0 }, /* 8 */
{ NULL }
};
/* unescape_string() _does_ unescape whitespace */
static struct test_data unescape_string_test_data[] = {
{ "foo\\ bar", "foo bar", 7, 8 }, /* 1 */
{ "foo\\,bar", "foo,bar", 7, 8 }, /* 2 */
{ "baz \\", "baz \\", 5, 5 }, /* 3 */
{ "\\foo", "foo", 3, 4 }, /* 4 */
{ "var=aaa,b\\,b", "var=aaa,b,b", 11, 12 }, /* 5 */
{ "\\a\\ b\\ c\\\\", "a b c\\", 6, 10 }, /* 6 */
{ "\\", "\\", 1, 1 }, /* 7 */
{ "foo", "foo", 3, 3 }, /* 8 */
{ "", "", 0, 0 }, /* 9 */
{ NULL }
};
sudo_dso_public int main(int argc, char *argv[]);
static void
test_strlcpy_unescape(int *ntests_out, int *errors_out)
{
int ntests = *ntests_out;
int errors = *errors_out;
struct test_data *td;
char buf[1024];
size_t len;
for (td = strlcpy_unescape_test_data; td->input != NULL; td++) {
ntests++;
memset(buf, 'A', sizeof(buf));
len = strlcpy_unescape(buf, td->input, td->bufsize);
if (len != td->result_len) {
sudo_warnx("%d: \"%s\": bad return %zu, expected %zu",
ntests, td->input, len, td->result_len);
errors++;
}
len = td->result ? strlen(td->result) : 0;
if ((len != 0 || td->bufsize != 0) && len >= td->bufsize) {
sudo_warnx("%d: \"%s\": bad length %zu >= %zu",
ntests, td->input, len, td->bufsize);
errors++;
}
if (td->result != NULL && strcmp(td->result, buf) != 0) {
sudo_warnx("%d: \"%s\": got \"%s\", expected \"%s\"",
ntests, td->input, buf, td->result);
errors++;
}
if (buf[td->bufsize] != 'A') {
sudo_warnx("%d: \"%s\": wrote past end of buffer at %zu (0x%x)",
ntests, td->input, td->bufsize, buf[td->bufsize]);
errors++;
}
}
*ntests_out = ntests;
*errors_out = errors;
}
static void
test_unescape_string(int *ntests_out, int *errors_out)
{
int ntests = *ntests_out;
int errors = *errors_out;
struct test_data *td;
char buf[1024];
for (td = unescape_string_test_data; td->input != NULL; td++) {
ntests++;
memset(buf, 'A', sizeof(buf));
memcpy(buf, td->input, td->bufsize);
buf[td->bufsize] = '\0';
unescape_string(buf);
if (strcmp(td->result, buf) != 0) {
sudo_warnx("%d: \"%s\": got \"%s\", expected \"%s\"",
ntests, td->input, buf, td->result);
errors++;
}
}
*ntests_out = ntests;
*errors_out = errors;
}
static void
test_strvec_join(char sep, int *ntests_out, int *errors_out)
{
int ntests = *ntests_out;
int errors = *errors_out;
char buf[64*1024 + 1], expected[64*1024 + 3];
char *argv[3], *result;
/* Test joining an argument vector while unescaping. */
/* Simulate: sudoedit -s '\' `perl -e 'print "A" x 65536'` */
memset(buf, 'A', sizeof(buf));
buf[sizeof(buf) - 1] = '\0';
argv[0] = (char *)"\\";
argv[1] = buf;
argv[2] = NULL;
memset(expected, 'A', sizeof(expected));
expected[0] = '\\';
expected[1] = sep;
expected[sizeof(expected) - 1] = '\0';
ntests++;
result = strvec_join(argv, sep, strlcpy_unescape);
if (result == NULL) {
sudo_warnx("%d: failed to join argument vector", ntests);
errors++;
} else if (strcmp(result, expected) != 0) {
sudo_warnx("%d: got \"%s\", expected \"%s\"", ntests,
result, expected);
errors++;
}
free(result);
*ntests_out = ntests;
*errors_out = errors;
}
int
main(int argc, char *argv[])
{
int ntests = 0, errors = 0;
initprogname(argc > 0 ? argv[0] : "check_unesc");
/* strlcpy_unescape tests */
test_strlcpy_unescape(&ntests, &errors);
/* unescape_string test */
test_unescape_string(&ntests, &errors);
/* strvec_join test */
test_strvec_join(' ', &ntests, &errors);
test_strvec_join('\n', &ntests, &errors);
if (ntests != 0) {
printf("%s: %d tests run, %d errors, %d%% success rate\n",
getprogname(), ntests, errors, (ntests - errors) * 100 / ntests);
}
exit(errors);
}
|
