1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
|
/* Any copyright is dedicated to the Public Domain.
http://creativecommons.org/publicdomain/zero/1.0/ */
"use strict";
add_setup(async () => {
await SpecialPowers.pushPrefEnv({
set: [["extensions.manifestV3.enabled", true]],
});
});
add_task(async function test_actions_setPopup_allowed_urls() {
const otherExtension = ExtensionTestUtils.loadExtension({});
const extensionDefinition = {
background() {
browser.test.onMessage.addListener(async (msg, ...args) => {
if (msg === "set-popup") {
const apiNs = args[0];
const popupOptions = args[1];
if (apiNs === "pageAction") {
popupOptions.tabId = (
await browser.tabs.query({ active: true })
)[0].id;
}
let error;
try {
await browser[apiNs].setPopup(popupOptions);
} catch (err) {
error = err;
}
browser.test.sendMessage("set-popup:done", {
error: error && String(error),
});
return;
}
browser.test.fail(`Unexpected test message: ${msg}`);
});
},
};
await otherExtension.startup();
const testCases = [
// https urls are disallowed on mv3 but currently allowed on mv2.
[
"action",
"https://example.com",
{
manifest_version: 3,
action: {},
},
{
disallowed: true,
errorMessage: "Access denied for URL https://example.com",
},
],
[
"pageAction",
"https://example.com",
{
manifest_version: 3,
page_action: {},
},
{
disallowed: true,
errorMessage: "Access denied for URL https://example.com",
},
],
[
"browserAction",
"https://example.com",
{
manifest_version: 2,
browser_action: {},
},
{
disallowed: false,
},
],
[
"pageAction",
"https://example.com",
{
manifest_version: 2,
page_action: {},
},
{
disallowed: false,
},
],
// absolute moz-extension url from same extension expected to be allowed in MV3 and MV2.
[
"action",
extension => `moz-extension://${extension.uuid}/page.html`,
{
manifest_version: 3,
action: {},
},
{
disallowed: false,
},
],
[
"browserAction",
extension => `moz-extension://${extension.uuid}/page.html`,
{
manifest_version: 2,
browser_action: { default_popup: "popup.html" },
},
{
disallowed: false,
},
],
[
"pageAction",
extension => `moz-extension://${extension.uuid}/page.html`,
{
manifest_version: 3,
page_action: {},
},
{
disallowed: false,
},
],
[
"pageAction",
extension => `moz-extension://${extension.uuid}/page.html`,
{
manifest_version: 2,
page_action: {},
},
{
disallowed: false,
},
],
// absolute moz-extension url from other extensions expected to be disallowed in MV3 and MV2.
[
"action",
`moz-extension://${otherExtension.uuid}/page.html`,
{
manifest_version: 3,
action: {},
},
{
disallowed: true,
errorMessage: `Access denied for URL moz-extension://${otherExtension.uuid}/page.html`,
},
],
[
"browserAction",
`moz-extension://${otherExtension.uuid}/page.html`,
{
manifest_version: 2,
browser_action: {},
},
{
disallowed: true,
errorMessage: `Access denied for URL moz-extension://${otherExtension.uuid}/page.html`,
},
],
[
"pageAction",
`moz-extension://${otherExtension.uuid}/page.html`,
{
manifest_version: 3,
page_action: {},
},
{
disallowed: true,
errorMessage: `Access denied for URL moz-extension://${otherExtension.uuid}/page.html`,
},
],
[
"pageAction",
`moz-extension://${otherExtension.uuid}/page.html`,
{
manifest_version: 2,
page_action: {},
},
{
disallowed: true,
errorMessage: `Access denied for URL moz-extension://${otherExtension.uuid}/page.html`,
},
],
// Empty url should also be allowed (as it resets the popup url currently set).
[
"action",
null,
{
manifest_version: 3,
action: {},
},
{
disallowed: false,
},
],
[
"browserAction",
null,
{
manifest_version: 2,
browser_action: {},
},
{
disallowed: false,
},
],
[
"pageAction",
null,
{
manifest_version: 3,
page_action: {},
},
{
disallowed: false,
},
],
[
"pageAction",
null,
{
manifest_version: 2,
page_action: {},
},
{
disallowed: false,
},
],
];
for (const [apiNs, popupUrl, manifest, expects] of testCases) {
const extension = ExtensionTestUtils.loadExtension({
...extensionDefinition,
manifest,
});
await extension.startup();
const popup =
typeof popupUrl === "function" ? popupUrl(extension) : popupUrl;
info(
`Testing ${apiNs}.setPopup({ popup: ${popup} }) on manifest_version ${
manifest.manifest_version ?? 2
}`
);
const popupOptions = { popup };
extension.sendMessage("set-popup", apiNs, popupOptions);
const { error } = await extension.awaitMessage("set-popup:done");
if (expects.disallowed) {
ok(
error?.includes(expects.errorMessage),
`Got expected error on url ${popup}: ${error}`
);
} else {
is(error, undefined, `Expected url ${popup} to be allowed`);
}
await extension.unload();
}
await otherExtension.unload();
});
|
