1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
|
"use strict";
const { ExtensionPermissions } = ChromeUtils.importESModule(
"resource://gre/modules/ExtensionPermissions.sys.mjs"
);
loadTestSubscript("head_unified_extensions.js");
async function makeExtension({
useAddonManager = "temporary",
manifest_version = 3,
id,
permissions,
host_permissions,
content_scripts,
granted,
}) {
info(
`Loading extension ` +
JSON.stringify({ id, permissions, host_permissions, granted })
);
let manifest = {
manifest_version,
browser_specific_settings: { gecko: { id } },
permissions,
host_permissions,
content_scripts,
action: {
default_popup: "popup.html",
default_area: "navbar",
},
};
if (manifest_version < 3) {
manifest.browser_action = manifest.action;
delete manifest.action;
}
let ext = ExtensionTestUtils.loadExtension({
manifest,
useAddonManager,
background() {
browser.permissions.onAdded.addListener(({ origins }) => {
browser.test.sendMessage("granted", origins.join());
});
browser.permissions.onRemoved.addListener(({ origins }) => {
browser.test.sendMessage("revoked", origins.join());
});
if (browser.menus) {
let submenu = browser.menus.create({
id: "parent",
title: "submenu",
contexts: ["action"],
});
browser.menus.create({
id: "child1",
title: "child1",
parentId: submenu,
});
browser.menus.create({
id: "child2",
title: "child2",
parentId: submenu,
});
}
},
files: {
"popup.html": `<!DOCTYPE html><meta charset=utf-8>Test Popup`,
},
});
if (granted) {
info("Granting initial permissions.");
await ExtensionPermissions.add(id, { permissions: [], origins: granted });
}
await ext.startup();
return ext;
}
async function testOriginControls(
extension,
{ contextMenuId },
{ items, selected, click, granted, revoked, attention }
) {
info(
`Testing ${extension.id} on ${gBrowser.currentURI.spec} with contextMenuId=${contextMenuId}.`
);
let buttonOrWidget;
let menu;
let nextMenuItemClassName;
switch (contextMenuId) {
case "toolbar-context-menu":
let target = `#${CSS.escape(makeWidgetId(extension.id))}-BAP`;
buttonOrWidget = document.querySelector(target).parentElement;
menu = await openChromeContextMenu(contextMenuId, target);
nextMenuItemClassName = "customize-context-manageExtension";
break;
case "unified-extensions-context-menu":
await openExtensionsPanel();
buttonOrWidget = getUnifiedExtensionsItem(extension.id);
menu = await openUnifiedExtensionsContextMenu(extension.id);
nextMenuItemClassName = "unified-extensions-context-menu-pin-to-toolbar";
break;
default:
throw new Error(`unexpected context menu "${contextMenuId}"`);
}
let doc = menu.ownerDocument;
let visibleOriginItems = menu.querySelectorAll(
":is(menuitem, menuseparator):not([hidden])"
);
info("Check expected menu items.");
for (let i = 0; i < items.length; i++) {
let l10n = doc.l10n.getAttributes(visibleOriginItems[i]);
Assert.deepEqual(
l10n,
items[i],
`Visible menu item ${i} has correct l10n attrs.`
);
let checked = visibleOriginItems[i].getAttribute("checked") === "true";
is(i === selected, checked, `Expected checked value for item ${i}.`);
}
if (items.length) {
is(
visibleOriginItems[items.length].nodeName,
"menuseparator",
"Found separator."
);
is(
visibleOriginItems[items.length + 1].className,
nextMenuItemClassName,
"All items accounted for."
);
}
is(
buttonOrWidget.hasAttribute("attention"),
!!attention,
"Expected attention badge before clicking."
);
Assert.deepEqual(
document.l10n.getAttributes(
buttonOrWidget.querySelector(".unified-extensions-item-action-button")
),
{
id: attention
? "origin-controls-toolbar-button-permission-needed"
: "origin-controls-toolbar-button",
args: {
extensionTitle: "Generated extension",
},
},
"Correct l10n message."
);
let itemToClick;
if (click) {
itemToClick = visibleOriginItems[click];
}
// Clicking a menu item of the unified extensions context menu should close
// the unified extensions panel automatically.
let panelHidden =
itemToClick && contextMenuId === "unified-extensions-context-menu"
? BrowserTestUtils.waitForEvent(document, "popuphidden", true)
: Promise.resolve();
await closeChromeContextMenu(contextMenuId, itemToClick);
await panelHidden;
// When there is no menu item to close, we should manually close the unified
// extensions panel because simply closing the context menu will not close
// it.
if (!itemToClick && contextMenuId === "unified-extensions-context-menu") {
await closeExtensionsPanel();
}
if (granted) {
info("Waiting for the permissions.onAdded event.");
let host = await extension.awaitMessage("granted");
is(host, granted.join(), "Expected host permission granted.");
}
if (revoked) {
info("Waiting for the permissions.onRemoved event.");
let host = await extension.awaitMessage("revoked");
is(host, revoked.join(), "Expected host permission revoked.");
}
}
// Move the widget to the toolbar or the addons panel (if Unified Extensions
// is enabled) or the overflow panel otherwise.
function moveWidget(ext, pinToToolbar = false) {
let area = pinToToolbar
? CustomizableUI.AREA_NAVBAR
: CustomizableUI.AREA_ADDONS;
let widgetId = `${makeWidgetId(ext.id)}-browser-action`;
CustomizableUI.addWidgetToArea(widgetId, area);
}
const originControlsInContextMenu = async options => {
// Has no permissions.
let ext1 = await makeExtension({ id: "ext1@test" });
// Has activeTab and (ungranted) example.com permissions.
let ext2 = await makeExtension({
id: "ext2@test",
permissions: ["activeTab"],
host_permissions: ["*://example.com/*"],
useAddonManager: "permanent",
});
// Has ungranted <all_urls>, and granted example.com.
let ext3 = await makeExtension({
id: "ext3@test",
host_permissions: ["<all_urls>"],
granted: ["*://example.com/*"],
useAddonManager: "permanent",
});
// Has granted <all_urls>.
let ext4 = await makeExtension({
id: "ext4@test",
host_permissions: ["<all_urls>"],
granted: ["<all_urls>"],
useAddonManager: "permanent",
});
// MV2 extension with an <all_urls> content script and activeTab.
let ext5 = await makeExtension({
manifest_version: 2,
id: "ext5@test",
permissions: ["activeTab"],
content_scripts: [
{
matches: ["<all_urls>"],
css: [],
},
],
useAddonManager: "permanent",
});
let extensions = [ext1, ext2, ext3, ext4, ext5];
let unifiedButton;
if (options.contextMenuId === "unified-extensions-context-menu") {
// Unified button should only show a notification indicator when extensions
// asking for attention are not already visible in the toolbar.
moveWidget(ext1, false);
moveWidget(ext2, false);
moveWidget(ext3, false);
moveWidget(ext4, false);
moveWidget(ext5, false);
unifiedButton = document.querySelector("#unified-extensions-button");
} else {
// TestVerify runs this again in the same Firefox instance, so move the
// widgets back to the toolbar for testing outside the unified extensions
// panel.
moveWidget(ext1, true);
moveWidget(ext2, true);
moveWidget(ext3, true);
moveWidget(ext4, true);
moveWidget(ext5, true);
}
const NO_ACCESS = { id: "origin-controls-no-access", args: null };
const QUARANTINED = { id: "origin-controls-quarantined", args: null };
const ACCESS_OPTIONS = { id: "origin-controls-options", args: null };
const ALL_SITES = { id: "origin-controls-option-all-domains", args: null };
const WHEN_CLICKED = {
id: "origin-controls-option-when-clicked",
args: null,
};
const UNIFIED_NO_ATTENTION = { id: "unified-extensions-button", args: null };
const UNIFIED_ATTENTION = {
id: "unified-extensions-button-permissions-needed",
args: null,
};
await BrowserTestUtils.withNewTab("about:blank", async () => {
await testOriginControls(ext1, options, { items: [NO_ACCESS] });
await testOriginControls(ext2, options, { items: [NO_ACCESS] });
await testOriginControls(ext3, options, { items: [NO_ACCESS] });
await testOriginControls(ext4, options, { items: [NO_ACCESS] });
await testOriginControls(ext5, options, { items: [] });
if (unifiedButton) {
ok(
!unifiedButton.hasAttribute("attention"),
"No extension will have attention indicator on about:blank."
);
Assert.deepEqual(
document.l10n.getAttributes(unifiedButton),
UNIFIED_NO_ATTENTION,
"Unified button has no permissions needed tooltip."
);
}
});
await BrowserTestUtils.withNewTab("http://mochi.test:8888/", async () => {
const ALWAYS_ON = {
id: "origin-controls-option-always-on",
args: { domain: "mochi.test" },
};
await testOriginControls(ext1, options, { items: [NO_ACCESS] });
// Has activeTab.
await testOriginControls(ext2, options, {
items: [ACCESS_OPTIONS, WHEN_CLICKED],
selected: 1,
attention: true,
});
// Could access mochi.test when clicked.
await testOriginControls(ext3, options, {
items: [ACCESS_OPTIONS, WHEN_CLICKED, ALWAYS_ON],
selected: 1,
attention: true,
});
// Has <all_urls> granted.
await testOriginControls(ext4, options, {
items: [ACCESS_OPTIONS, ALL_SITES],
selected: 1,
attention: false,
});
// MV2 extension, has no origin controls, and never flags for attention.
await testOriginControls(ext5, options, { items: [], attention: false });
if (unifiedButton) {
ok(
unifiedButton.hasAttribute("attention"),
"Both ext2 and ext3 are WHEN_CLICKED for example.com, so show attention indicator."
);
Assert.deepEqual(
document.l10n.getAttributes(unifiedButton),
UNIFIED_ATTENTION,
"UEB has permissions needed tooltip."
);
}
});
info("Testing again with mochi.test now quarantined.");
await SpecialPowers.pushPrefEnv({
set: [
["extensions.quarantinedDomains.enabled", true],
["extensions.quarantinedDomains.list", "mochi.test"],
],
});
await BrowserTestUtils.withNewTab("http://mochi.test:8888/", async () => {
await testOriginControls(ext1, options, { items: [NO_ACCESS] });
await testOriginControls(ext2, options, { items: [QUARANTINED] });
await testOriginControls(ext3, options, { items: [QUARANTINED] });
await testOriginControls(ext4, options, { items: [QUARANTINED] });
// MV2 normally don't have controls, but we show the quarantined status.
await testOriginControls(ext5, options, { items: [QUARANTINED] });
});
await SpecialPowers.popPrefEnv();
await BrowserTestUtils.withNewTab("http://example.com/", async () => {
const ALWAYS_ON = {
id: "origin-controls-option-always-on",
args: { domain: "example.com" },
};
await testOriginControls(ext1, options, { items: [NO_ACCESS] });
// Click alraedy selected options, expect no permission changes.
await testOriginControls(ext2, options, {
items: [ACCESS_OPTIONS, WHEN_CLICKED, ALWAYS_ON],
selected: 1,
click: 1,
attention: true,
});
await testOriginControls(ext3, options, {
items: [ACCESS_OPTIONS, WHEN_CLICKED, ALWAYS_ON],
selected: 2,
click: 2,
attention: false,
});
await testOriginControls(ext4, options, {
items: [ACCESS_OPTIONS, ALL_SITES],
selected: 1,
click: 1,
attention: false,
});
await testOriginControls(ext5, options, { items: [], attention: false });
if (unifiedButton) {
ok(
unifiedButton.hasAttribute("attention"),
"ext2 is WHEN_CLICKED for example.com, show attention indicator."
);
Assert.deepEqual(
document.l10n.getAttributes(unifiedButton),
UNIFIED_ATTENTION,
"UEB attention for only one extension."
);
}
// Click the other option, expect example.com permission granted/revoked.
await testOriginControls(ext2, options, {
items: [ACCESS_OPTIONS, WHEN_CLICKED, ALWAYS_ON],
selected: 1,
click: 2,
granted: ["*://example.com/*"],
attention: true,
});
if (unifiedButton) {
ok(
!unifiedButton.hasAttribute("attention"),
"Bot ext2 and ext3 are ALWAYS_ON for example.com, so no attention indicator."
);
Assert.deepEqual(
document.l10n.getAttributes(unifiedButton),
UNIFIED_NO_ATTENTION,
"Unified button has no permissions needed tooltip."
);
}
await testOriginControls(ext3, options, {
items: [ACCESS_OPTIONS, WHEN_CLICKED, ALWAYS_ON],
selected: 2,
click: 1,
revoked: ["*://example.com/*"],
attention: false,
});
if (unifiedButton) {
ok(
unifiedButton.hasAttribute("attention"),
"ext3 is now WHEN_CLICKED for example.com, show attention indicator."
);
Assert.deepEqual(
document.l10n.getAttributes(unifiedButton),
UNIFIED_ATTENTION,
"UEB attention for only one extension."
);
}
// Other option is now selected.
await testOriginControls(ext2, options, {
items: [ACCESS_OPTIONS, WHEN_CLICKED, ALWAYS_ON],
selected: 2,
attention: false,
});
await testOriginControls(ext3, options, {
items: [ACCESS_OPTIONS, WHEN_CLICKED, ALWAYS_ON],
selected: 1,
attention: true,
});
if (unifiedButton) {
ok(
unifiedButton.hasAttribute("attention"),
"Still showing the attention indicator."
);
Assert.deepEqual(
document.l10n.getAttributes(unifiedButton),
UNIFIED_ATTENTION,
"UEB attention for only one extension."
);
}
});
await Promise.all(extensions.map(e => e.unload()));
};
add_task(async function originControls_in_browserAction_contextMenu() {
await originControlsInContextMenu({ contextMenuId: "toolbar-context-menu" });
});
add_task(async function originControls_in_unifiedExtensions_contextMenu() {
await originControlsInContextMenu({
contextMenuId: "unified-extensions-context-menu",
});
});
add_task(async function test_attention_dot_when_pinning_extension() {
const extension = await makeExtension({ permissions: ["activeTab"] });
await extension.startup();
const unifiedButton = document.querySelector("#unified-extensions-button");
const extensionWidgetID = AppUiTestInternals.getBrowserActionWidgetId(
extension.id
);
const extensionWidget =
CustomizableUI.getWidget(extensionWidgetID).forWindow(window).node;
await BrowserTestUtils.withNewTab("http://mochi.test:8888/", async () => {
// The extensions should be placed in the navbar by default so we do not
// expect an attention dot on the Unifed Extensions Button (UEB), only on
// the extension (widget) itself.
ok(
!unifiedButton.hasAttribute("attention"),
"expected no attention attribute on the UEB"
);
ok(
extensionWidget.hasAttribute("attention"),
"expected attention attribute on the extension widget"
);
// Open the context menu of the extension and unpin the extension.
let contextMenu = await openChromeContextMenu(
"toolbar-context-menu",
`#${CSS.escape(extensionWidgetID)}`
);
let pinToToolbar = contextMenu.querySelector(
".customize-context-pinToToolbar"
);
ok(pinToToolbar, "expected a 'Pin to Toolbar' menu item");
// Passing the `pinToToolbar` item to `closeChromeContextMenu()` will
// activate it before closing the context menu.
await closeChromeContextMenu(contextMenu.id, pinToToolbar);
ok(
unifiedButton.hasAttribute("attention"),
"expected attention attribute on the UEB"
);
// We still expect the attention dot on the extension.
ok(
extensionWidget.hasAttribute("attention"),
"expected attention attribute on the extension widget"
);
// Now let's open the unified extensions panel, and pin the same extension
// to the toolbar, which should hide the attention dot on the UEB again.
await openExtensionsPanel();
contextMenu = await openUnifiedExtensionsContextMenu(extension.id);
pinToToolbar = contextMenu.querySelector(
".unified-extensions-context-menu-pin-to-toolbar"
);
ok(pinToToolbar, "expected a 'Pin to Toolbar' menu item");
const hidden = BrowserTestUtils.waitForEvent(
gUnifiedExtensions.panel,
"popuphidden",
true
);
contextMenu.activateItem(pinToToolbar);
await hidden;
ok(
!unifiedButton.hasAttribute("attention"),
"expected no attention attribute on the UEB"
);
// We still expect the attention dot on the extension.
ok(
extensionWidget.hasAttribute("attention"),
"expected attention attribute on the extension widget"
);
});
await extension.unload();
});
async function testWithSubmenu(menu, nextItemClassName) {
function expectMenuItems() {
info("Checking expected menu items.");
let [submenu, sep1, ocMessage, sep2, next] = menu.children;
is(submenu.tagName, "menu", "First item is a submenu.");
is(submenu.label, "submenu", "Submenu has the expected label.");
is(sep1.tagName, "menuseparator", "Second item is a separator.");
let l10n = menu.ownerDocument.l10n.getAttributes(ocMessage);
is(ocMessage.tagName, "menuitem", "Third is origin controls message.");
is(l10n.id, "origin-controls-no-access", "Expected l10n id.");
is(sep2.tagName, "menuseparator", "Fourth item is a separator.");
is(next.className, nextItemClassName, "All items accounted for.");
}
// Repeat a few times.
for (let i = 0; i < 3; i++) {
expectMenuItems();
let shown = BrowserTestUtils.waitForEvent(menu, "popupshown");
menu.children[0].click();
let popup = (await shown).target;
expectMenuItems();
let closed = promiseContextMenuClosed(popup);
popup.hidePopup();
await closed;
}
menu.hidePopup();
}
add_task(async function test_originControls_with_submenus() {
if (AppConstants.platform === "macosx") {
ok(true, "Probably some context menus quirks on macOS.");
return;
}
let extension = await makeExtension({
id: "submenus@test",
permissions: ["menus"],
});
await BrowserTestUtils.withNewTab("about:blank", async () => {
info(`Testing with submenus.`);
moveWidget(extension, true);
let target = `#${CSS.escape(makeWidgetId(extension.id))}-BAP`;
await testWithSubmenu(
await openChromeContextMenu("toolbar-context-menu", target),
"customize-context-manageExtension"
);
info(`Testing with submenus inside extensions panel.`);
moveWidget(extension, false);
await openExtensionsPanel();
await testWithSubmenu(
await openUnifiedExtensionsContextMenu(extension.id),
"unified-extensions-context-menu-pin-to-toolbar"
);
});
await extension.unload();
});
|
