1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
|
/* -*- Mode: indent-tabs-mode: nil; js-indent-level: 2 -*- */
/* vim: set sts=2 sw=2 et tw=80: */
"use strict";
Services.prefs.setBoolPref("extensions.manifestV3.enabled", true);
async function testManifest(manifest, expectedError) {
ExtensionTestUtils.failOnSchemaWarnings(false);
let normalized = await ExtensionTestUtils.normalizeManifest(manifest);
ExtensionTestUtils.failOnSchemaWarnings(true);
if (expectedError) {
ok(
expectedError.test(normalized.error),
`Should have an error for ${JSON.stringify(manifest)}, got ${
normalized.error
}`
);
} else {
ok(
!normalized.error,
`Should not have an error ${JSON.stringify(manifest)}, ${
normalized.error
}`
);
}
return normalized.errors;
}
const all_actions = [
"action",
"browser_action",
"page_action",
"sidebar_action",
];
add_task(async function test_manifest() {
let badpaths = ["", " ", "\t", "http://foo.com/icon.png"];
for (let path of badpaths) {
for (let action of all_actions) {
let manifest_version = action == "action" ? 3 : 2;
let manifest = { manifest_version };
manifest[action] = { default_icon: path };
let error = new RegExp(`Error processing ${action}.default_icon`);
await testManifest(manifest, error);
manifest[action] = { default_icon: { 16: path } };
await testManifest(manifest, error);
}
}
let paths = [
"icon.png",
"/icon.png",
"./icon.png",
"path to an icon.png",
" icon.png",
];
for (let path of paths) {
for (let action of all_actions) {
let manifest_version = action == "action" ? 3 : 2;
let manifest = { manifest_version };
manifest[action] = { default_icon: path };
if (action == "sidebar_action") {
// Sidebar requires panel.
manifest[action].default_panel = "foo.html";
}
await testManifest(manifest);
manifest[action] = { default_icon: { 16: path } };
if (action == "sidebar_action") {
manifest[action].default_panel = "foo.html";
}
await testManifest(manifest);
}
}
});
add_task(async function test_action_version() {
let warnings = await testManifest({
manifest_version: 3,
browser_action: {
default_panel: "foo.html",
},
});
Assert.deepEqual(
warnings,
[`Property "browser_action" is unsupported in Manifest Version 3`],
`Manifest v3 with "browser_action" key logs an error.`
);
warnings = await testManifest({
manifest_version: 2,
action: {
default_icon: "",
default_panel: "foo.html",
},
});
Assert.deepEqual(
warnings,
[`Property "action" is unsupported in Manifest Version 2`],
`Manifest v2 with "action" key first warning is clear.`
);
});
|
