1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
|
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
import json
import logging
import re
from taskgraph.util.parameterization import resolve_task_references
from taskgraph.util.taskcluster import get_artifact, get_task_definition, list_artifacts
from gecko_taskgraph.util.copy_task import copy_task
from .registry import register_callback_action
from .util import add_args_to_command, create_task_from_def, fetch_graph_and_labels
logger = logging.getLogger(__name__)
def get_failures(task_id):
"""Returns a dict containing properties containing a list of
directories containing test failures and a separate list of
individual test failures from the errorsummary.log artifact for
the task.
Calls the helper function munge_test_path to attempt to find an
appropriate test path to pass to the task in
MOZHARNESS_TEST_PATHS. If no appropriate test path can be
determined, nothing is returned.
"""
def re_compile_list(*lst):
# Ideally we'd just use rb"" literals and avoid the encode, but
# this file needs to be importable in python2 for now.
return [re.compile(s.encode("utf-8")) for s in lst]
re_bad_tests = re_compile_list(
r"Last test finished",
r"LeakSanitizer",
r"Main app process exited normally",
r"ShutdownLeaks",
r"[(]SimpleTest/TestRunner.js[)]",
r"automation.py",
r"https?://localhost:\d+/\d+/\d+/.*[.]html",
r"jsreftest",
r"leakcheck",
r"mozrunner-startup",
r"pid: ",
r"RemoteProcessMonitor",
r"unknown test url",
)
re_extract_tests = re_compile_list(
r'"test": "(?:[^:]+:)?(?:https?|file):[^ ]+/reftest/tests/([^ "]+)',
r'"test": "(?:[^:]+:)?(?:https?|file):[^:]+:[0-9]+/tests/([^ "]+)',
r'xpcshell-?[^ "]*\.ini:([^ "]+)',
r'/tests/([^ "]+) - finished .*',
r'"test": "([^ "]+)"',
r'"message": "Error running command run_test with arguments '
r"[(]<wptrunner[.]wpttest[.]TestharnessTest ([^>]+)>",
r'"message": "TEST-[^ ]+ [|] ([^ "]+)[^|]*[|]',
)
def munge_test_path(line):
test_path = None
for r in re_bad_tests:
if r.search(line):
return None
for r in re_extract_tests:
m = r.search(line)
if m:
test_path = m.group(1)
break
return test_path
# collect dirs that don't have a specific manifest
dirs = set()
tests = set()
artifacts = list_artifacts(task_id)
for artifact in artifacts:
if "name" not in artifact or not artifact["name"].endswith("errorsummary.log"):
continue
stream = get_artifact(task_id, artifact["name"])
if not stream:
continue
# We handle the stream as raw bytes because it may contain invalid
# UTF-8 characters in portions other than those containing the error
# messages we're looking for.
for line in stream.read().split(b"\n"):
if not line.strip():
continue
l = json.loads(line)
if "group_results" in l.keys() and l["status"] != "OK":
dirs.add(l["group_results"].group())
elif "test" in l.keys():
test_path = munge_test_path(line.strip())
tests.add(test_path.decode("utf-8"))
# only run the failing test not both test + dir
if l["group"] in dirs:
dirs.remove(l["group"])
if len(tests) > 4:
break
# turn group into dir by stripping off leafname
dirs = set([d.split("/")[0:-1] for d in dirs])
return {"dirs": sorted(dirs), "tests": sorted(tests)}
def create_confirm_failure_tasks(task_definition, failures, level):
"""
Create tasks to re-run the original task plus tasks to test
each failing test directory and individual path.
"""
logger.info(f"Confirm Failures task:\n{json.dumps(task_definition, indent=2)}")
# Operate on a copy of the original task_definition
task_definition = copy_task(task_definition)
task_name = task_definition["metadata"]["name"]
repeatable_task = False
if (
"crashtest" in task_name
or "mochitest" in task_name
or "reftest" in task_name
or "xpcshell" in task_name
and "jsreftest" not in task_name
):
repeatable_task = True
th_dict = task_definition["extra"]["treeherder"]
symbol = th_dict["symbol"]
is_windows = "windows" in th_dict["machine"]["platform"]
suite = task_definition["extra"]["suite"]
if "-coverage" in suite:
suite = suite[: suite.index("-coverage")]
is_wpt = "web-platform-tests" in suite
# command is a copy of task_definition['payload']['command'] from the original task.
# It is used to create the new version containing the
# task_definition['payload']['command'] with repeat_args which is updated every time
# through the failure_group loop.
command = copy_task(task_definition["payload"]["command"])
th_dict["groupSymbol"] = th_dict["groupSymbol"] + "-cf"
th_dict["tier"] = 3
if repeatable_task:
task_definition["payload"]["maxRunTime"] = 3600 * 3
for failure_group in failures:
if len(failures[failure_group]) == 0:
continue
if failure_group == "dirs":
failure_group_suffix = "-d"
# execute 5 total loops
repeat_args = ["--repeat=4"] if repeatable_task else []
elif failure_group == "tests":
failure_group_suffix = "-t"
# execute 10 total loops
repeat_args = ["--repeat=9"] if repeatable_task else []
else:
logger.error(
"create_confirm_failure_tasks: Unknown failure_group {}".format(
failure_group
)
)
continue
if repeat_args:
task_definition["payload"]["command"] = add_args_to_command(
command, extra_args=repeat_args
)
else:
task_definition["payload"]["command"] = command
for failure_path in failures[failure_group]:
th_dict["symbol"] = symbol + failure_group_suffix
if is_wpt:
failure_path = "testing/web-platform/tests" + failure_path
if is_windows:
failure_path = "\\".join(failure_path.split("/"))
task_definition["payload"]["env"]["MOZHARNESS_TEST_PATHS"] = json.dumps(
{suite: [failure_path]}, sort_keys=True
)
logger.info(
"Creating task for path {} with command {}".format(
failure_path, task_definition["payload"]["command"]
)
)
create_task_from_def(task_definition, level)
@register_callback_action(
name="confirm-failures",
title="Confirm failures in job",
symbol="cf",
description="Re-run Tests for original manifest, directories or tests for failing tests.",
order=150,
context=[{"kind": "test"}],
schema={
"type": "object",
"properties": {},
"additionalProperties": False,
},
)
def confirm_failures(parameters, graph_config, input, task_group_id, task_id):
task = get_task_definition(task_id)
decision_task_id, full_task_graph, label_to_taskid = fetch_graph_and_labels(
parameters, graph_config
)
pre_task = full_task_graph.tasks[task["metadata"]["name"]]
# fix up the task's dependencies, similar to how optimization would
# have done in the decision
dependencies = {
name: label_to_taskid[label] for name, label in pre_task.dependencies.items()
}
task_definition = resolve_task_references(
pre_task.label, pre_task.task, task_id, decision_task_id, dependencies
)
task_definition.setdefault("dependencies", []).extend(dependencies.values())
failures = get_failures(task_id)
logger.info("confirm_failures: %s" % failures)
create_confirm_failure_tasks(task_definition, failures, parameters["level"])
|
