1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
|
/**
* @fileoverview Reject use of Cu.importGlobalProperties
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
"use strict";
const path = require("path");
const privilegedGlobals = Object.keys(
require("../environments/privileged.js").globals
);
module.exports = {
meta: {
docs: {
url: "https://firefox-source-docs.mozilla.org/code-quality/lint/linters/eslint-plugin-mozilla/reject-importGlobalProperties.html",
},
messages: {
unexpectedCall: "Unexpected call to Cu.importGlobalProperties",
unexpectedCallCuWebIdl:
"Unnecessary call to Cu.importGlobalProperties for {{name}} (webidl names are automatically imported)",
unexpectedCallXPCOMWebIdl:
"Unnecessary call to XPCOMUtils.defineLazyGlobalGetters for {{name}} (webidl names are automatically imported)",
},
schema: [
{
enum: ["everything", "allownonwebidl"],
},
],
type: "problem",
},
create(context) {
return {
CallExpression(node) {
if (
node.callee.type !== "MemberExpression" ||
// TODO Bug 1501127: sjs files have their own sandbox, and do not inherit
// the Window backstage pass directly.
path.extname(context.getFilename()) == ".sjs"
) {
return;
}
let memexp = node.callee;
if (
memexp.object.type === "Identifier" &&
// Only Cu, not Components.utils as `use-cc-etc` handles this for us.
memexp.object.name === "Cu" &&
memexp.property.type === "Identifier" &&
memexp.property.name === "importGlobalProperties"
) {
if (context.options.includes("allownonwebidl")) {
for (let element of node.arguments[0].elements) {
if (privilegedGlobals.includes(element.value)) {
context.report({
node,
messageId: "unexpectedCallCuWebIdl",
data: { name: element.value },
});
}
}
} else {
context.report({ node, messageId: "unexpectedCall" });
}
}
if (
memexp.object.type === "Identifier" &&
memexp.object.name === "XPCOMUtils" &&
memexp.property.type === "Identifier" &&
memexp.property.name === "defineLazyGlobalGetters" &&
node.arguments.length >= 2
) {
if (context.options.includes("allownonwebidl")) {
for (let element of node.arguments[1].elements) {
if (privilegedGlobals.includes(element.value)) {
context.report({
node,
messageId: "unexpectedCallXPCOMWebIdl",
data: { name: element.value },
});
}
}
} else {
context.report({ node, messageId: "unexpectedCall" });
}
}
},
};
},
};
|
