1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
|
/* Any copyright is dedicated to the Public Domain.
* http://creativecommons.org/publicdomain/zero/1.0/ */
"use strict";
// ------------------------------------------------------------------------------
// Requirements
// ------------------------------------------------------------------------------
var rule = require("../lib/rules/no-useless-removeEventListener");
var RuleTester = require("eslint").RuleTester;
const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: "latest" } });
// ------------------------------------------------------------------------------
// Tests
// ------------------------------------------------------------------------------
function invalidCode(code) {
return { code, errors: [{ messageId: "useOnce", type: "CallExpression" }] };
}
ruleTester.run("no-useless-removeEventListener", rule, {
valid: [
// Listeners that aren't a function are always valid.
"elt.addEventListener('click', handler);",
"elt.addEventListener('click', handler, true);",
"elt.addEventListener('click', handler, {once: true});",
// Should not fail on empty functions.
"elt.addEventListener('click', function() {});",
// Should not reject when removing a listener for another event.
"elt.addEventListener('click', function listener() {" +
" elt.removeEventListener('keypress', listener);" +
"});",
// Should not reject when there's another instruction before
// removeEventListener.
"elt.addEventListener('click', function listener() {" +
" elt.focus();" +
" elt.removeEventListener('click', listener);" +
"});",
// Should not reject when wantsUntrusted is true.
"elt.addEventListener('click', function listener() {" +
" elt.removeEventListener('click', listener);" +
"}, false, true);",
// Should not reject when there's a literal and a variable
"elt.addEventListener('click', function listener() {" +
" elt.removeEventListener(eventName, listener);" +
"});",
// Should not reject when there's 2 different variables
"elt.addEventListener(event1, function listener() {" +
" elt.removeEventListener(event2, listener);" +
"});",
// Should not fail if this is a different type of event listener function.
"myfunc.addEventListener(listener);",
],
invalid: [
invalidCode(
"elt.addEventListener('click', function listener() {" +
" elt.removeEventListener('click', listener);" +
"});"
),
invalidCode(
"elt.addEventListener('click', function listener() {" +
" elt.removeEventListener('click', listener, true);" +
"}, true);"
),
invalidCode(
"elt.addEventListener('click', function listener() {" +
" elt.removeEventListener('click', listener);" +
"}, {once: true});"
),
invalidCode(
"elt.addEventListener('click', function listener() {" +
" /* Comment */" +
" elt.removeEventListener('click', listener);" +
"});"
),
invalidCode(
"elt.addEventListener('click', function() {" +
" elt.removeEventListener('click', arguments.callee);" +
"});"
),
invalidCode(
"elt.addEventListener(eventName, function listener() {" +
" elt.removeEventListener(eventName, listener);" +
"});"
),
],
});
|
