Adding upstream version 1.47.0.upstream/1.47.0

Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>

12 files changed, 47 insertions, 12 deletions

diff --git a/src/go/collectors/go.d.plugin/modules/ping/README.md b/src/go/plugin/go.d/modules/ping/README.md
index a1381e57b..a1381e57b 120000
--- a/src/go/collectors/go.d.plugin/modules/ping/README.md
+++ b/src/go/plugin/go.d/modules/ping/README.md
diff --git a/src/go/collectors/go.d.plugin/modules/ping/charts.go b/src/go/plugin/go.d/modules/ping/charts.go
index e117a18d5..04dfc17d5 100644
--- a/src/go/collectors/go.d.plugin/modules/ping/charts.go
+++ b/src/go/plugin/go.d/modules/ping/charts.go
@@ -6,7 +6,7 @@ import (
 	"fmt"
 	"strings"
 
-	"github.com/netdata/netdata/go/go.d.plugin/agent/module"
+	"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
 )
 
 const (
diff --git a/src/go/collectors/go.d.plugin/modules/ping/collect.go b/src/go/plugin/go.d/modules/ping/collect.go
index c162a2b15..c162a2b15 100644
--- a/src/go/collectors/go.d.plugin/modules/ping/collect.go
+++ b/src/go/plugin/go.d/modules/ping/collect.go
diff --git a/src/go/collectors/go.d.plugin/modules/ping/config_schema.json b/src/go/plugin/go.d/modules/ping/config_schema.json
index 007dd45b0..1168e3388 100644
--- a/src/go/collectors/go.d.plugin/modules/ping/config_schema.json
+++ b/src/go/plugin/go.d/modules/ping/config_schema.json
@@ -13,7 +13,7 @@
       },
       "privileged": {
         "title": "Privileged mode",
-        "description": "If unset, sends unprivileged UDP ping packets (require [additional configuration](https://github.com/netdata/netdata/tree/master/src/go/collectors/go.d.plugin/modules/ping#overview)); otherwise, sends raw ICMP ping packets ([not recommended](https://github.com/netdata/netdata/issues/15410)).",
+        "description": "If unset, sends unprivileged UDP ping packets (require [additional configuration](https://github.com/netdata/netdata/tree/master/src/go/plugin/go.d/modules/ping#overview)); otherwise, sends raw ICMP ping packets ([not recommended](https://github.com/netdata/netdata/issues/15410)).",
         "type": "boolean",
         "default": false
       },
diff --git a/src/go/collectors/go.d.plugin/modules/ping/init.go b/src/go/plugin/go.d/modules/ping/init.go
index 62d78c8e6..62d78c8e6 100644
--- a/src/go/collectors/go.d.plugin/modules/ping/init.go
+++ b/src/go/plugin/go.d/modules/ping/init.go
diff --git a/src/go/collectors/go.d.plugin/modules/ping/integrations/ping.md b/src/go/plugin/go.d/modules/ping/integrations/ping.md
index 4b073050d..db97288b0 100644
--- a/src/go/collectors/go.d.plugin/modules/ping/integrations/ping.md
+++ b/src/go/plugin/go.d/modules/ping/integrations/ping.md
@@ -1,6 +1,6 @@
 <!--startmeta
-custom_edit_url: "https://github.com/netdata/netdata/edit/master/src/go/collectors/go.d.plugin/modules/ping/README.md"
-meta_yaml: "https://github.com/netdata/netdata/edit/master/src/go/collectors/go.d.plugin/modules/ping/metadata.yaml"
+custom_edit_url: "https://github.com/netdata/netdata/edit/master/src/go/plugin/go.d/modules/ping/README.md"
+meta_yaml: "https://github.com/netdata/netdata/edit/master/src/go/plugin/go.d/modules/ping/metadata.yaml"
 sidebar_label: "Ping"
 learn_status: "Published"
 learn_rel_path: "Collecting Metrics/Synthetic Checks"
@@ -39,7 +39,7 @@ There are two operational modes:
   ```bash
   sudo sysctl -w net.ipv4.ping_group_range="0 2147483647"
   ```
-  To persist the change add `net.ipv4.ping_group_range="0 2147483647"` to `/etc/sysctl.conf` and
+  To persist the change add `net.ipv4.ping_group_range=0 2147483647` to `/etc/sysctl.conf` and
   execute `sudo sysctl -p`.
 
 
@@ -211,6 +211,8 @@ jobs:
 
 ### Debug Mode
 
+**Important**: Debug mode is not supported for data collection jobs created via the UI using the Dyncfg feature.
+
 To troubleshoot issues with the `ping` collector, run the `go.d.plugin` with the debug option enabled. The output
 should give you clues as to why the collector isn't working.
 
@@ -233,4 +235,37 @@ should give you clues as to why the collector isn't working.
   ./go.d.plugin -d -m ping
   ```
 
+### Getting Logs
+
+If you're encountering problems with the `ping` collector, follow these steps to retrieve logs and identify potential issues:
+
+- **Run the command** specific to your system (systemd, non-systemd, or Docker container).
+- **Examine the output** for any warnings or error messages that might indicate issues.  These messages should provide clues about the root cause of the problem.
+
+#### System with systemd
+
+Use the following command to view logs generated since the last Netdata service restart:
+
+```bash
+journalctl _SYSTEMD_INVOCATION_ID="$(systemctl show --value --property=InvocationID netdata)" --namespace=netdata --grep ping
+```
+
+#### System without systemd
+
+Locate the collector log file, typically at `/var/log/netdata/collector.log`, and use `grep` to filter for collector's name:
+
+```bash
+grep ping /var/log/netdata/collector.log
+```
+
+**Note**: This method shows logs from all restarts. Focus on the **latest entries** for troubleshooting current issues.
+
+#### Docker Container
+
+If your Netdata runs in a Docker container named "netdata" (replace if different), use this command:
+
+```bash
+docker logs netdata 2>&1 | grep ping
+```
+
 
diff --git a/src/go/collectors/go.d.plugin/modules/ping/metadata.yaml b/src/go/plugin/go.d/modules/ping/metadata.yaml
index d70c8a3f4..8686d103b 100644
--- a/src/go/collectors/go.d.plugin/modules/ping/metadata.yaml
+++ b/src/go/plugin/go.d/modules/ping/metadata.yaml
@@ -39,7 +39,7 @@ modules:
             ```bash
             sudo sysctl -w net.ipv4.ping_group_range="0 2147483647"
             ```
-            To persist the change add `net.ipv4.ping_group_range="0 2147483647"` to `/etc/sysctl.conf` and
+            To persist the change add `net.ipv4.ping_group_range=0 2147483647` to `/etc/sysctl.conf` and
             execute `sudo sysctl -p`.
         method_description: ""
       supported_platforms:
diff --git a/src/go/collectors/go.d.plugin/modules/ping/ping.go b/src/go/plugin/go.d/modules/ping/ping.go
index 5171afc04..9d1ef929f 100644
--- a/src/go/collectors/go.d.plugin/modules/ping/ping.go
+++ b/src/go/plugin/go.d/modules/ping/ping.go
@@ -7,9 +7,9 @@ import (
 	"errors"
 	"time"
 
-	"github.com/netdata/netdata/go/go.d.plugin/agent/module"
-	"github.com/netdata/netdata/go/go.d.plugin/logger"
-	"github.com/netdata/netdata/go/go.d.plugin/pkg/web"
+	"github.com/netdata/netdata/go/plugins/logger"
+	"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
+	"github.com/netdata/netdata/go/plugins/plugin/go.d/pkg/web"
 
 	probing "github.com/prometheus-community/pro-bing"
 )
diff --git a/src/go/collectors/go.d.plugin/modules/ping/ping_test.go b/src/go/plugin/go.d/modules/ping/ping_test.go
index 856449d33..52d16dd3e 100644
--- a/src/go/collectors/go.d.plugin/modules/ping/ping_test.go
+++ b/src/go/plugin/go.d/modules/ping/ping_test.go
@@ -8,8 +8,8 @@ import (
 	"testing"
 	"time"
 
-	"github.com/netdata/netdata/go/go.d.plugin/agent/module"
-	"github.com/netdata/netdata/go/go.d.plugin/logger"
+	"github.com/netdata/netdata/go/plugins/logger"
+	"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
 
 	probing "github.com/prometheus-community/pro-bing"
 	"github.com/stretchr/testify/assert"
diff --git a/src/go/collectors/go.d.plugin/modules/ping/prober.go b/src/go/plugin/go.d/modules/ping/prober.go
index e0d9925b4..70c31dcde 100644
--- a/src/go/collectors/go.d.plugin/modules/ping/prober.go
+++ b/src/go/plugin/go.d/modules/ping/prober.go
@@ -8,7 +8,7 @@ import (
 	"net"
 	"time"
 
-	"github.com/netdata/netdata/go/go.d.plugin/logger"
+	"github.com/netdata/netdata/go/plugins/logger"
 
 	probing "github.com/prometheus-community/pro-bing"
 )
diff --git a/src/go/collectors/go.d.plugin/modules/ping/testdata/config.json b/src/go/plugin/go.d/modules/ping/testdata/config.json
index 18df64529..18df64529 100644
--- a/src/go/collectors/go.d.plugin/modules/ping/testdata/config.json
+++ b/src/go/plugin/go.d/modules/ping/testdata/config.json
diff --git a/src/go/collectors/go.d.plugin/modules/ping/testdata/config.yaml b/src/go/plugin/go.d/modules/ping/testdata/config.yaml
index 5eacb9413..5eacb9413 100644
--- a/src/go/collectors/go.d.plugin/modules/ping/testdata/config.yaml
+++ b/src/go/plugin/go.d/modules/ping/testdata/config.yaml