1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
|
// SPDX-License-Identifier: GPL-3.0-or-later
package lvm
import (
"errors"
"os"
"testing"
"github.com/netdata/netdata/go/plugins/plugin/go.d/agent/module"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
var (
dataConfigJSON, _ = os.ReadFile("testdata/config.json")
dataConfigYAML, _ = os.ReadFile("testdata/config.yaml")
dataLvsReportJson, _ = os.ReadFile("testdata/lvs-report.json")
dataLvsReportNoThinJson, _ = os.ReadFile("testdata/lvs-report-no-thin.json")
)
func Test_testDataIsValid(t *testing.T) {
for name, data := range map[string][]byte{
"dataConfigJSON": dataConfigJSON,
"dataConfigYAML": dataConfigYAML,
"dataLvsReportJson": dataLvsReportJson,
"dataLvsReportNoThinJson": dataLvsReportNoThinJson,
} {
require.NotNil(t, data, name)
}
}
func TestLVM_Configuration(t *testing.T) {
module.TestConfigurationSerialize(t, &LVM{}, dataConfigJSON, dataConfigYAML)
}
func TestLVM_Init(t *testing.T) {
tests := map[string]struct {
config Config
wantFail bool
}{
"fails if failed to locate ndsudo": {
wantFail: true,
config: New().Config,
},
}
for name, test := range tests {
t.Run(name, func(t *testing.T) {
lvm := New()
lvm.Config = test.config
if test.wantFail {
assert.Error(t, lvm.Init())
} else {
assert.NoError(t, lvm.Init())
}
})
}
}
func TestLVM_Cleanup(t *testing.T) {
tests := map[string]struct {
prepare func() *LVM
}{
"not initialized exec": {
prepare: func() *LVM {
return New()
},
},
"after check": {
prepare: func() *LVM {
lvm := New()
lvm.exec = prepareMockOK()
_ = lvm.Check()
return lvm
},
},
"after collect": {
prepare: func() *LVM {
lvm := New()
lvm.exec = prepareMockOK()
_ = lvm.Collect()
return lvm
},
},
}
for name, test := range tests {
t.Run(name, func(t *testing.T) {
lvm := test.prepare()
assert.NotPanics(t, lvm.Cleanup)
})
}
}
func TestLVM_Charts(t *testing.T) {
assert.NotNil(t, New().Charts())
}
func TestLVM_Check(t *testing.T) {
tests := map[string]struct {
prepareMock func() *mockLvmCliExec
wantFail bool
}{
"success case": {
prepareMock: prepareMockOK,
wantFail: false,
},
"no thin volumes": {
prepareMock: prepareMockNoThinVolumes,
wantFail: true,
},
"error on lvs report call": {
prepareMock: prepareMockErrOnLvsReportJson,
wantFail: true,
},
"empty response": {
prepareMock: prepareMockEmptyResponse,
wantFail: true,
},
"unexpected response": {
prepareMock: prepareMockUnexpectedResponse,
wantFail: true,
},
}
for name, test := range tests {
t.Run(name, func(t *testing.T) {
lvm := New()
mock := test.prepareMock()
lvm.exec = mock
if test.wantFail {
assert.Error(t, lvm.Check())
} else {
assert.NoError(t, lvm.Check())
}
})
}
}
func TestLVM_Collect(t *testing.T) {
tests := map[string]struct {
prepareMock func() *mockLvmCliExec
wantMetrics map[string]int64
}{
"success case": {
prepareMock: prepareMockOK,
wantMetrics: map[string]int64{
"lv_root_vg_cm-vg_data_percent": 7889,
"lv_root_vg_cm-vg_metadata_percent": 1925,
},
},
"no thin volumes": {
prepareMock: prepareMockNoThinVolumes,
wantMetrics: nil,
},
"error on lvs report call": {
prepareMock: prepareMockErrOnLvsReportJson,
wantMetrics: nil,
},
"empty response": {
prepareMock: prepareMockEmptyResponse,
wantMetrics: nil,
},
"unexpected response": {
prepareMock: prepareMockUnexpectedResponse,
wantMetrics: nil,
},
}
for name, test := range tests {
t.Run(name, func(t *testing.T) {
lvm := New()
mock := test.prepareMock()
lvm.exec = mock
mx := lvm.Collect()
assert.Equal(t, test.wantMetrics, mx)
if len(test.wantMetrics) > 0 {
assert.Len(t, *lvm.Charts(), len(lvThinPoolChartsTmpl)*len(lvm.lvmThinPools))
}
})
}
}
func prepareMockOK() *mockLvmCliExec {
return &mockLvmCliExec{
lvsReportJsonData: dataLvsReportJson,
}
}
func prepareMockNoThinVolumes() *mockLvmCliExec {
return &mockLvmCliExec{
lvsReportJsonData: dataLvsReportNoThinJson,
}
}
func prepareMockErrOnLvsReportJson() *mockLvmCliExec {
return &mockLvmCliExec{
errOnLvsReportJson: true,
}
}
func prepareMockEmptyResponse() *mockLvmCliExec {
return &mockLvmCliExec{}
}
func prepareMockUnexpectedResponse() *mockLvmCliExec {
return &mockLvmCliExec{
lvsReportJsonData: []byte(`
Lorem ipsum dolor sit amet, consectetur adipiscing elit.
Nulla malesuada erat id magna mattis, eu viverra tellus rhoncus.
Fusce et felis pulvinar, posuere sem non, porttitor eros.
`),
}
}
type mockLvmCliExec struct {
errOnLvsReportJson bool
lvsReportJsonData []byte
}
func (m *mockLvmCliExec) lvsReportJson() ([]byte, error) {
if m.errOnLvsReportJson {
return nil, errors.New("mock.lvsReportJson() error")
}
return m.lvsReportJsonData, nil
}
|
