1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
|
#!/usr/bin/python3
import os
import unittest
from staslib import conf
class StasProcessConfUnitTest(unittest.TestCase):
'''Process config unit tests'''
FNAME = '/tmp/stas-process-config-test'
@classmethod
def setUpClass(cls):
'''Create a temporary configuration file'''
data = [
'[Global]\n',
'tron=true\n',
'kato=200\n',
'ip-family=ipv6\n',
'\n',
'[I/O controller connection management]\n',
'disconnect-scope = joe\n',
'disconnect-trtypes = bob\n',
'connect-attempts-on-ncc = 1\n',
'\n',
'[Controllers]\n',
'controller=transport=tcp;traddr=100.100.100.100;host-iface=enp0s8\n',
'controller=transport=tcp;traddr=100.100.100.200;host-iface=enp0s7;dhchap-ctrl-secret=super-secret;hdr-digest=true;data-digest=true;nr-io-queues=8;nr-write-queues=6;nr-poll-queues=4;queue-size=400;kato=71;reconnect-delay=13;ctrl-loss-tmo=666;disable-sqflow=true\n',
'exclude=transport=tcp;traddr=10.10.10.10\n',
]
with open(StasProcessConfUnitTest.FNAME, 'w') as f: # # pylint: disable=unspecified-encoding
f.writelines(data)
@classmethod
def tearDownClass(cls):
'''Delete the temporary configuration file'''
if os.path.exists(StasProcessConfUnitTest.FNAME):
os.remove(StasProcessConfUnitTest.FNAME)
def test_config(self):
'''Check we can read the temporary configuration file'''
default_conf = {
('Global', 'tron'): False,
('Global', 'hdr-digest'): False,
('Global', 'data-digest'): False,
('Global', 'kato'): None, # None to let the driver decide the default
('Global', 'nr-io-queues'): None, # None to let the driver decide the default
('Global', 'nr-write-queues'): None, # None to let the driver decide the default
('Global', 'nr-poll-queues'): None, # None to let the driver decide the default
('Global', 'queue-size'): None, # None to let the driver decide the default
('Global', 'reconnect-delay'): None, # None to let the driver decide the default
('Global', 'ctrl-loss-tmo'): None, # None to let the driver decide the default
('Global', 'disable-sqflow'): None, # None to let the driver decide the default
('Global', 'ignore-iface'): False,
('Global', 'ip-family'): (4, 6),
('Global', 'persistent-connections'): False, # Deprecated
('Discovery controller connection management', 'persistent-connections'): True,
('Global', 'pleo'): True,
('Service Discovery', 'zeroconf'): True,
('Controllers', 'controller'): list(),
('Controllers', 'exclude'): list(),
('I/O controller connection management', 'disconnect-scope'): 'only-stas-connections',
('I/O controller connection management', 'disconnect-trtypes'): ['tcp'],
('I/O controller connection management', 'connect-attempts-on-ncc'): 0,
}
service_conf = conf.SvcConf(default_conf=default_conf)
service_conf.set_conf_file(StasProcessConfUnitTest.FNAME)
self.assertEqual(service_conf.conf_file, StasProcessConfUnitTest.FNAME)
self.assertTrue(service_conf.tron)
self.assertTrue(getattr(service_conf, 'tron'))
self.assertFalse(service_conf.hdr_digest)
self.assertFalse(service_conf.data_digest)
self.assertTrue(service_conf.persistent_connections)
self.assertTrue(service_conf.pleo_enabled)
self.assertEqual(service_conf.disconnect_scope, 'only-stas-connections')
self.assertEqual(service_conf.disconnect_trtypes, ['tcp'])
self.assertFalse(service_conf.ignore_iface)
self.assertIn(6, service_conf.ip_family)
self.assertNotIn(4, service_conf.ip_family)
self.assertEqual(service_conf.kato, 200)
self.assertEqual(
service_conf.get_controllers(),
[
{
'transport': 'tcp',
'traddr': '100.100.100.100',
'host-iface': 'enp0s8',
},
{
'transport': 'tcp',
'traddr': '100.100.100.200',
'host-iface': 'enp0s7',
'dhchap-ctrl-secret': 'super-secret',
'hdr-digest': True,
'data-digest': True,
'nr-io-queues': 8,
'nr-write-queues': 6,
'nr-poll-queues': 4,
'queue-size': 400,
'kato': 71,
'reconnect-delay': 13,
'ctrl-loss-tmo': 666,
'disable-sqflow': True,
},
],
)
self.assertEqual(service_conf.get_excluded(), [{'transport': 'tcp', 'traddr': '10.10.10.10'}])
stypes = service_conf.stypes
self.assertIn('_nvme-disc._tcp', stypes)
self.assertTrue(service_conf.zeroconf_enabled)
self.assertEqual(service_conf.connect_attempts_on_ncc, 2)
data = [
'[I/O controller connection management]\n',
'disconnect-trtypes = tcp+rdma+fc\n',
'connect-attempts-on-ncc = hello\n',
]
with open(StasProcessConfUnitTest.FNAME, 'w') as f: # pylint: disable=unspecified-encoding
f.writelines(data)
service_conf.reload()
self.assertEqual(service_conf.connect_attempts_on_ncc, 0)
self.assertEqual(set(service_conf.disconnect_trtypes), set(['fc', 'tcp', 'rdma']))
data = [
'[Global]\n',
'ip-family=ipv4\n',
]
with open(StasProcessConfUnitTest.FNAME, 'w') as f: # pylint: disable=unspecified-encoding
f.writelines(data)
service_conf.reload()
self.assertIn(4, service_conf.ip_family)
self.assertNotIn(6, service_conf.ip_family)
data = [
'[Global]\n',
'ip-family=ipv4+ipv6\n',
]
with open(StasProcessConfUnitTest.FNAME, 'w') as f: # pylint: disable=unspecified-encoding
f.writelines(data)
service_conf.reload()
self.assertIn(4, service_conf.ip_family)
self.assertIn(6, service_conf.ip_family)
data = [
'[Global]\n',
'ip-family=ipv6+ipv4\n',
]
with open(StasProcessConfUnitTest.FNAME, 'w') as f: # pylint: disable=unspecified-encoding
f.writelines(data)
service_conf.reload()
self.assertIn(4, service_conf.ip_family)
self.assertIn(6, service_conf.ip_family)
self.assertRaises(KeyError, service_conf.get_option, 'Babylon', 5)
def test__parse_single_val(self):
self.assertEqual(conf._parse_single_val('hello'), 'hello')
self.assertIsNone(conf._parse_single_val(None))
self.assertEqual(conf._parse_single_val(['hello', 'goodbye']), 'goodbye')
class StasSysConfUnitTest(unittest.TestCase):
'''Sys config unit tests'''
FNAME_1 = '/tmp/stas-sys-config-test-1'
FNAME_2 = '/tmp/stas-sys-config-test-2'
FNAME_3 = '/tmp/stas-sys-config-test-3'
FNAME_4 = '/tmp/stas-sys-config-test-4'
NQN = 'nqn.2014-08.org.nvmexpress:uuid:9aae2691-b275-4b64-8bfe-5da429a2bab9'
ID = '56529e15-0f3e-4ede-87e2-63932a4adb99'
KEY = 'DHHC-1:03:qwertyuioplkjhgfdsazxcvbnm0123456789QWERTYUIOPLKJHGFDSAZXCVBNM010101010101010101010101010101:'
SYMNAME = 'Bart-Simpson'
DATA = {
FNAME_1: [
'[Host]\n',
f'nqn={NQN}\n',
f'id={ID}\n',
f'key={KEY}\n',
f'symname={SYMNAME}\n',
],
FNAME_2: [
'[Host]\n',
'nqn=file:///dev/null\n',
],
FNAME_3: [
'[Host]\n',
'nqn=qnq.2014-08.org.nvmexpress:uuid:9aae2691-b275-4b64-8bfe-5da429a2bab9\n',
f'id={ID}\n',
],
FNAME_4: [
'[Host]\n',
'nqn=file:///some/non/exisiting/file/!@#\n',
'id=file:///some/non/exisiting/file/!@#\n',
'symname=file:///some/non/exisiting/file/!@#\n',
],
}
@classmethod
def setUpClass(cls):
'''Create a temporary configuration file'''
for file, data in StasSysConfUnitTest.DATA.items():
with open(file, 'w') as f: # pylint: disable=unspecified-encoding
f.writelines(data)
@classmethod
def tearDownClass(cls):
'''Delete the temporary configuration file'''
for file in StasSysConfUnitTest.DATA.keys():
if os.path.exists(file):
os.remove(file)
def test_config_1(self):
'''Check we can read the temporary configuration file'''
system_conf = conf.SysConf()
system_conf.set_conf_file(StasSysConfUnitTest.FNAME_1)
self.assertEqual(system_conf.conf_file, StasSysConfUnitTest.FNAME_1)
self.assertEqual(system_conf.hostnqn, StasSysConfUnitTest.NQN)
self.assertEqual(system_conf.hostid, StasSysConfUnitTest.ID)
self.assertEqual(system_conf.hostsymname, StasSysConfUnitTest.SYMNAME)
self.assertEqual(
system_conf.as_dict(),
{
'hostnqn': StasSysConfUnitTest.NQN,
'hostid': StasSysConfUnitTest.ID,
'hostkey': StasSysConfUnitTest.KEY,
'symname': StasSysConfUnitTest.SYMNAME,
},
)
def test_config_2(self):
'''Check we can read from /dev/null or missing 'id' definition'''
system_conf = conf.SysConf()
system_conf.set_conf_file(StasSysConfUnitTest.FNAME_2)
self.assertEqual(system_conf.conf_file, StasSysConfUnitTest.FNAME_2)
self.assertIsNone(system_conf.hostnqn)
self.assertIsNone(system_conf.hostsymname)
def test_config_3(self):
'''Check we can read an invalid NQN string'''
system_conf = conf.SysConf()
system_conf.set_conf_file(StasSysConfUnitTest.FNAME_3)
self.assertEqual(system_conf.conf_file, StasSysConfUnitTest.FNAME_3)
self.assertRaises(SystemExit, lambda: system_conf.hostnqn)
self.assertEqual(system_conf.hostid, StasSysConfUnitTest.ID)
self.assertIsNone(system_conf.hostsymname)
def test_config_4(self):
'''Check we can read the temporary configuration file'''
system_conf = conf.SysConf()
system_conf.set_conf_file(StasSysConfUnitTest.FNAME_4)
self.assertEqual(system_conf.conf_file, StasSysConfUnitTest.FNAME_4)
self.assertRaises(SystemExit, lambda: system_conf.hostnqn)
self.assertRaises(SystemExit, lambda: system_conf.hostid)
self.assertIsNone(system_conf.hostsymname)
def test_config_missing_file(self):
'''Check what happens when conf file is missing'''
system_conf = conf.SysConf()
system_conf.set_conf_file('/just/some/ramdom/file/name')
self.assertIsNone(system_conf.hostsymname)
if __name__ == '__main__':
unittest.main()
|
