diff options
author | Daniel Baumann <daniel.baumann@progress-linux.org> | 2024-04-28 09:51:25 +0000 |
---|---|---|
committer | Daniel Baumann <daniel.baumann@progress-linux.org> | 2024-04-28 09:51:25 +0000 |
commit | 4a31b814a318a37fe8b58d42f2025e49072971e4 (patch) | |
tree | 5ba51f467804ef2f6fea80a7ea2682cbdec1ff8f /debian/patches/Fix-uninitialized-read-in-doveadm-oldstats.patch | |
parent | Adding upstream version 1:2.3.19.1+dfsg1. (diff) | |
download | dovecot-4a31b814a318a37fe8b58d42f2025e49072971e4.tar.xz dovecot-4a31b814a318a37fe8b58d42f2025e49072971e4.zip |
Adding debian version 1:2.3.19.1+dfsg1-2.1.debian/1%2.3.19.1+dfsg1-2.1debian
Signed-off-by: Daniel Baumann <daniel.baumann@progress-linux.org>
Diffstat (limited to 'debian/patches/Fix-uninitialized-read-in-doveadm-oldstats.patch')
-rw-r--r-- | debian/patches/Fix-uninitialized-read-in-doveadm-oldstats.patch | 33 |
1 files changed, 33 insertions, 0 deletions
diff --git a/debian/patches/Fix-uninitialized-read-in-doveadm-oldstats.patch b/debian/patches/Fix-uninitialized-read-in-doveadm-oldstats.patch new file mode 100644 index 0000000..ff85b51 --- /dev/null +++ b/debian/patches/Fix-uninitialized-read-in-doveadm-oldstats.patch @@ -0,0 +1,33 @@ +From: =?utf-8?q?Christian_G=C3=B6ttsche?= <cgzones@googlemail.com> +Date: Sat, 23 Jul 2022 16:38:23 +0200 +Subject: Fix uninitialized read in doveadm-oldstats + +The third argument to doveadm_cmd_param_bool() is only set on a return +value of TRUE. +Since disk_input_field and disk_output_field should be set if the value +of show-disk-io is specified and specified to true, fix the condition. + + doveadm-oldstats.c: In function 'cmd_stats_top': + doveadm-oldstats.c:551:63: warning: 'b' may be used uninitialized [-Wmaybe-uninitialized] + 551 | if (!doveadm_cmd_param_bool(cctx, "show-disk-io", &b) && b) { + | ^ + doveadm-oldstats.c:545:14: note: 'b' was declared here + 545 | bool b; + | ^ +--- + src/doveadm/doveadm-oldstats.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/doveadm/doveadm-oldstats.c b/src/doveadm/doveadm-oldstats.c +index 4be575e..ff6dcf5 100644 +--- a/src/doveadm/doveadm-oldstats.c ++++ b/src/doveadm/doveadm-oldstats.c +@@ -548,7 +548,7 @@ static void cmd_stats_top(struct doveadm_cmd_context *cctx) + path = t_strconcat(doveadm_settings->base_dir, + "/old-stats", NULL); + } +- if (!doveadm_cmd_param_bool(cctx, "show-disk-io", &b) && b) { ++ if (doveadm_cmd_param_bool(cctx, "show-disk-io", &b) && b) { + disk_input_field = "read_bytes"; + disk_output_field = "write_bytes"; + } |