blob: 7f14d6c4d951d28a5418e3c2325a5fdc1c62626d (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#ifndef LO_CLANG_SHARED_PLUGINS
#include <cassert>
#include <string>
#include <iostream>
#include <fstream>
#include <set>
#include <clang/AST/CXXInheritance.h>
#include "plugin.hxx"
#include "check.hxx"
/**
When used in "for" loops, css::uno::Sequence objects tend to end up calling the non-const begin()/end(),
which is considerably more expensive than the const variants because it forces a local copy
of the internal ref-counted impl object.
*/
namespace
{
class SequenceLoop : public loplugin::FilteringPlugin<SequenceLoop>
{
public:
explicit SequenceLoop(loplugin::InstantiationData const& data)
: FilteringPlugin(data)
{
}
virtual void run() override
{
if (preRun())
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
}
bool VisitCXXForRangeStmt(CXXForRangeStmt const*);
};
bool SequenceLoop::VisitCXXForRangeStmt(CXXForRangeStmt const* forStmt)
{
if (ignoreLocation(forStmt))
return true;
auto tc = loplugin::TypeCheck(forStmt->getRangeInit()->getType());
if (tc.Const())
return true;
if (!tc.Class("Sequence")
.Namespace("uno")
.Namespace("star")
.Namespace("sun")
.Namespace("com")
.GlobalNamespace())
return true;
const VarDecl* varDecl = forStmt->getLoopVariable();
auto tc2 = loplugin::TypeCheck(varDecl->getType());
if (!tc2.LvalueReference().Const())
return true;
report(DiagnosticsEngine::Warning,
("use std::as_const, or otherwise make the for-range-initializer expression const, to"
" avoid creating a copy of the Sequence"),
compat::getBeginLoc(forStmt->getRangeInit()))
<< forStmt->getSourceRange();
return true;
}
loplugin::Plugin::Registration<SequenceLoop> sequenceloop("sequenceloop");
} // namespace
#endif // LO_CLANG_SHARED_PLUGINS
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
